Skip to contentSkip to conversation

drm/msm/adreno: Fix snapshot BINDLESS_DATA size

PATCH In review Rob Clark 3 participants 3 messages Jul 11, 2023 – Jul 13, 2023

Subsystems (4)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/msm/adreno: Fix snapshot BINDLESS_DATA size

From: Rob Clark <[email protected]>

The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1 -1
index 790f55e24533..e788ed72eb0d 100644
@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {
 	SHADER(A6XX_SP_LB_3_DATA, 0x800),
 	SHADER(A6XX_SP_LB_4_DATA, 0x800),
 	SHADER(A6XX_SP_LB_5_DATA, 0x200),
-	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x2000),
+	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x800),
 	SHADER(A6XX_SP_CB_LEGACY_DATA, 0x280),
 	SHADER(A6XX_SP_UAV_DATA, 0x80),
 	SHADER(A6XX_SP_INST_TAG, 0x80),
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Rob Clark

From: Rob Clark <[email protected]>

The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1 -1
index 790f55e24533..e788ed72eb0d 100644
@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {
 	SHADER(A6XX_SP_LB_3_DATA, 0x800),
 	SHADER(A6XX_SP_LB_4_DATA, 0x800),
 	SHADER(A6XX_SP_LB_5_DATA, 0x200),
-	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x2000),
+	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x800),
 	SHADER(A6XX_SP_CB_LEGACY_DATA, 0x280),
 	SHADER(A6XX_SP_UAV_DATA, 0x80),
 	SHADER(A6XX_SP_INST_TAG, 0x80),
Signature · 1 line
2.41.0

-Akhil

#2 lore raw
In reply to Rob Clark
Quoted 7 lines · Rob Clark

From: Rob Clark <[email protected]>

The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).

What about:

Fixes 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state")

?

Quoted 17 lines
---
  drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1 -1
index 790f55e24533..e788ed72eb0d 100644
@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {
  	SHADER(A6XX_SP_LB_3_DATA, 0x800),
  	SHADER(A6XX_SP_LB_4_DATA, 0x800),
  	SHADER(A6XX_SP_LB_5_DATA, 0x200),
-	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x2000),
+	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x800),
  	SHADER(A6XX_SP_CB_LEGACY_DATA, 0x280),
  	SHADER(A6XX_SP_UAV_DATA, 0x80),
  	SHADER(A6XX_SP_INST_TAG, 0x80),
Signature · 2 lines
With best wishes
Dmitry