Skip to contentSkip to conversation

drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

PATCH Superseded Zhanjun Dong 4 participants 9 messages Jul 27, 2023 – Aug 8, 2023

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

        lock_acquire+0xd8/0x2d0
        i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
        intel_gt_init_reset+0x65/0x80 [i915]
        intel_gt_common_init_early+0xe1/0x170 [i915]
        intel_root_gt_init_early+0x48/0x60 [i915]
        i915_driver_probe+0x671/0xcb0 [i915]
        i915_pci_probe+0xdc/0x210 [i915]
        pci_device_probe+0x95/0x120
        really_probe+0x164/0x3c0
        __driver_probe_device+0x73/0x160
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        __pfx_vgem_open+0x3/0x10 [vgem]
        do_one_initcall+0x57/0x270
        do_init_module+0x5f/0x220
        load_module+0x1ca4/0x1f00
        __do_sys_finit_module+0xb4/0x130
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

        lock_acquire+0xd8/0x2d0
        fs_reclaim_acquire+0xac/0xe0
        kmem_cache_alloc+0x32/0x260
        i915_vma_instance+0xb2/0xc60 [i915]
        i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
        vm_fault_gtt+0x22d/0xf60 [i915]
        __do_fault+0x2f/0x1d0
        do_pte_missing+0x4a/0xd20
        __handle_mm_fault+0x5b0/0x790
        handle_mm_fault+0xa2/0x230
        do_user_addr_fault+0x3ea/0xa10
        exc_page_fault+0x68/0x1a0
        asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

        lock_acquire+0xd8/0x2d0
        _intel_gt_reset_lock+0x57/0x330 [i915]
        guc_timestamp_ping+0x35/0x130 [i915]
        process_one_work+0x250/0x510
        worker_thread+0x4f/0x3a0
        kthread+0xff/0x130
        ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

        check_prev_add+0x90/0xc60
        __lock_acquire+0x1998/0x2590
        lock_acquire+0xd8/0x2d0
        __flush_work+0x74/0x530
        __cancel_work_timer+0x14f/0x1f0
        intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
        intel_uc_reset_prepare+0x9c/0x120 [i915]
        reset_prepare+0x21/0x60 [i915]
        intel_gt_reset+0x1dd/0x470 [i915]
        intel_gt_reset_global+0xfb/0x170 [i915]
        intel_gt_handle_error+0x368/0x420 [i915]
        intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
        i915_wedged_set+0x29/0x40 [i915]
        simple_attr_write_xsigned.constprop.0+0xb4/0x110
        full_proxy_write+0x52/0x80
        vfs_write+0xc5/0x4f0
        ksys_write+0x64/0xe0
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Chain exists of:
  (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&gt->reset.mutex);
                                lock(fs_reclaim);
                                lock(&gt->reset.mutex);
   lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:
#0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
#1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110 #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.
v4: Set to always sync from __uc_fini_hw path.

Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -7
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
 	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
 }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
 {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);
 }
 
 static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
 	unsigned long flags;
 	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
 	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
 static void guc_fini_engine_stats(struct intel_guc *guc)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 }
 
 void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
 	 * and causes an unclaimed register access warning. Cancel the worker
 	 * synchronously here.
 	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
 	/*
 	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
 }
 
 /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
 	/* Semaphore interrupt disable and route to host */
 	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
 void intel_guc_submission_init_early(struct intel_guc *guc);
 int intel_guc_submission_init(struct intel_guc *guc);
 int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..5b76f0d4d2a6 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
 	 * We've failed to load the firmware :(
 	 */
 err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
 err_log_capture:
 	__uc_capture_load_err_log(uc);
 err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
 		return;
 
 	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, true);
 
 	__uc_sanitize(uc);
 }
Signature · 1 line
2.34.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)

== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)
URL : https://patchwork.freedesktop.org/series/118898/
State : warning

== Summary ==

Error: dim checkpatch failed
bf7983c87486 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.

total: 0 errors, 1 warnings, 0 checks, 73 lines checked

#2 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)
URL : https://patchwork.freedesktop.org/series/118898/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

#3 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)
URL : https://patchwork.freedesktop.org/series/118898/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13434 -> Patchwork_118898v4
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/index.html

Participating hosts (43 -> 42)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_118898v4 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_auth@basic-auth:
- bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#8011])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-11/igt@[email protected]

* igt@dmabuf@all-tests@dma_fence:
- fi-tgl-1115g4: [PASS][2] -> [DMESG-FAIL][3] ([i915#8189])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-tgl-1115g4/igt@dmabuf@all-tests@dma_fence.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-tgl-1115g4/igt@dmabuf@all-tests@dma_fence.html

* igt@dmabuf@all-tests@sanitycheck:
- fi-tgl-1115g4: [PASS][4] -> [ABORT][5] ([i915#8144])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-tgl-1115g4/igt@dmabuf@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-tgl-1115g4/igt@dmabuf@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-9: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][8] ([i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- bat-adlp-6: NOTRUN -> [SKIP][9] ([i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-cfl-8700k: [PASS][10] -> [FAIL][11] ([i915#7940])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-cfl-8700k/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-cfl-8700k/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-7567u: [PASS][12] -> [FAIL][13] ([i915#7940])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-kbl-7567u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-kbl-7567u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- bat-adlp-9: NOTRUN -> [FAIL][14] ([i915#7940])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-adlp-6: NOTRUN -> [SKIP][15] ([i915#6621])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@[email protected]
- bat-adlp-9: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][17] ([i915#6621])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][18] ([i915#6621])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@[email protected]

* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [PASS][19] -> [DMESG-FAIL][20] ([i915#7059])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][21] -> [DMESG-FAIL][22] ([i915#8497])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-mtlp-8/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-mtlp-8/igt@i915_selftest@[email protected]
- bat-rpls-2: [PASS][23] -> [ABORT][24] ([i915#7913] / [i915#7982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-rpls-2/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][25] -> [ABORT][26] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-rpls-1/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-mtlp-8: [PASS][27] -> [DMESG-WARN][28] ([i915#6367])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-mtlp-8/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-mtlp-8/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-adlm-1: [PASS][29] -> [DMESG-FAIL][30] ([i915#7904])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adlm-1/igt@i915_selftest@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlm-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-8809g: [PASS][31] -> [INCOMPLETE][32] ([i915#4817])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-kbl-8809g/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-kbl-8809g/igt@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-adlp-9: NOTRUN -> [SKIP][33] ([i915#7828])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][34] ([i915#7828])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][35] ([i915#7828])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][36] ([i915#7828])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- fi-bsw-nick: NOTRUN -> [SKIP][37] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-bsw-nick/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: NOTRUN -> [SKIP][38] ([i915#1072]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [SKIP][39] ([i915#3555])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][40] ([i915#3555])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][41] ([i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-9: NOTRUN -> [SKIP][42] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]

* igt@prime_vgem@basic-read:
- bat-rplp-1: NOTRUN -> [SKIP][43] ([i915#3708]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-adln-1: NOTRUN -> [SKIP][44] ([fdo#109295] / [i915#3291]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][45] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- bat-adlp-9: [FAIL][46] ([i915#7940]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adlp-9/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][48] ([i915#7940]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-rkl-11600/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-rkl-11600/igt@[email protected]
- fi-kbl-7567u: [FAIL][50] ([i915#7940]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-kbl-7567u/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-kbl-7567u/igt@[email protected]
- fi-tgl-1115g4: [FAIL][52] ([i915#7940]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-tgl-1115g4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-tgl-1115g4/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [ABORT][54] ([i915#7913]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-bsw-nick/igt@i915_selftest@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][56] ([i915#5334] / [i915#7872]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@requests:
- bat-mtlp-6: [DMESG-FAIL][58] ([i915#8497]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-mtlp-6/igt@i915_selftest@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-mtlp-6/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1:
- bat-adlp-6: [ABORT][60] ([i915#7977] / [i915#8434] / [i915#8668]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- bat-adln-1: [ABORT][62] ([i915#8442] / [i915#8668]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html

#### Warnings ####

* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][64] ([i915#4423]) -> [DMESG-WARN][65] ([i915#4423])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adlp-11/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-11/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][66] ([i915#7940]) -> [FAIL][67] ([i915#8843])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/fi-kbl-guc/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/fi-kbl-guc/igt@[email protected]
- bat-adlp-9: [ABORT][68] ([i915#7977] / [i915#8668]) -> [FAIL][69] ([i915#7940])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-adlp-9/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-adlp-9/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- bat-rplp-1: [ABORT][70] ([i915#8434] / [i915#8668]) -> [SKIP][71] ([i915#1072])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/bat-rplp-1/igt@kms_psr@cursor_plane_move.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/bat-rplp-1/igt@kms_psr@cursor_plane_move.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7904]: https://gitlab.freedesktop.org/drm/intel/issues/7904
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8144]: https://gitlab.freedesktop.org/drm/intel/issues/8144
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843

Build changes
-------------

* Linux: CI_DRM_13434 -> Patchwork_118898v4

CI-20190529: 20190529
CI_DRM_13434: 918975ceb3c3df43381c188394360b665ebd9263 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7408: 93482edd02839f9eb6ceffca9418d03f570f34f3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118898v4: 918975ceb3c3df43381c188394360b665ebd9263 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

8e6e3b3ddfa9 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/index.html

#4 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev4)
URL : https://patchwork.freedesktop.org/series/118898/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13434_full -> Patchwork_118898v4_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_118898v4_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][1] ([i915#8411])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][2] ([i915#8411])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][3] ([i915#8411])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@debugfs_test@basic-hwmon:
- shard-mtlp: NOTRUN -> [SKIP][4] ([i915#7456])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@drm_fdinfo@busy-check-all@bcs0:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#8414]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@busy-hang@rcs0:
- shard-mtlp: NOTRUN -> [SKIP][6] ([i915#8414]) +6 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][7] -> [FAIL][8] ([i915#7742]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-6/igt@drm_fdinfo@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-6/igt@drm_fdinfo@[email protected]

* igt@feature_discovery@chamelium:
- shard-dg2: NOTRUN -> [SKIP][9] ([i915#4854])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@[email protected]

* igt@gem_busy@close-race:
- shard-tglu: [PASS][10] -> [ABORT][11] ([i915#6016])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-5/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-4/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy:
- shard-dg1: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#5325])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy-new-ctx:
- shard-mtlp: NOTRUN -> [SKIP][13] ([i915#5325])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#8555])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1099]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb1/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-mtlp: [PASS][16] -> [ABORT][17] ([i915#8503])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][18] ([i915#8898])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb4/igt@[email protected]

* igt@gem_exec_await@wide-contexts:
- shard-dg2: [PASS][19] -> [FAIL][20] ([i915#5892])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-1/igt@[email protected]

* igt@gem_exec_balancer@invalid-bonds:
- shard-dg2: NOTRUN -> [SKIP][21] ([i915#4036])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][22] ([i915#4036])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][23] ([i915#4036])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_exec_balancer@sliced:
- shard-dg1: NOTRUN -> [SKIP][24] ([i915#4812])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_exec_endless@dispatch@vcs1:
- shard-mtlp: [PASS][25] -> [TIMEOUT][26] ([i915#3778])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-8/igt@gem_exec_endless@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-7/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-rkl: [PASS][27] -> [FAIL][28] ([i915#2846])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-rkl: [PASS][29] -> [FAIL][30] ([i915#2842]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-7/igt@gem_exec_fair@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@gem_exec_fair@[email protected]
- shard-tglu: [PASS][31] -> [FAIL][32] ([i915#2842])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-2/igt@gem_exec_fair@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fence@submit67:
- shard-mtlp: NOTRUN -> [SKIP][33] ([i915#4812]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@[email protected]

* igt@gem_exec_flush@basic-uc-ro-default:
- shard-dg1: NOTRUN -> [SKIP][34] ([i915#3539] / [i915#4852]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_exec_flush@basic-wb-ro-default:
- shard-dg2: NOTRUN -> [SKIP][35] ([i915#3539] / [i915#4852])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@gem_exec_reloc@basic-gtt-wc-active:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#3281]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][37] ([i915#3281]) +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_exec_reloc@basic-write-cpu-active:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#3281]) +7 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-mtlp: [PASS][39] -> [TIMEOUT][40] ([i915#7392])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-3/igt@[email protected]

* igt@gem_fence_thrash@bo-write-verify-none:
- shard-dg1: NOTRUN -> [SKIP][41] ([i915#4860])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_fence_thrash@bo-write-verify-threaded-none:
- shard-mtlp: NOTRUN -> [SKIP][42] ([i915#4860])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0:
- shard-dg1: NOTRUN -> [SKIP][43] ([i915#4423] / [i915#4565])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-mtlp: NOTRUN -> [SKIP][44] ([i915#4613])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_mmap_gtt@big-bo:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#4077]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#4077])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_mmap_wc@bad-size:
- shard-mtlp: NOTRUN -> [SKIP][47] ([i915#4083])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-3/igt@[email protected]

* igt@gem_mmap_wc@write-read:
- shard-dg1: NOTRUN -> [SKIP][48] ([i915#4083]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_mmap_wc@write-wc-read-gtt:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#4083])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-dg1: NOTRUN -> [SKIP][50] ([i915#3282]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-tglu: NOTRUN -> [SKIP][51] ([i915#4270])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]

* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#4270])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][53] ([i915#4270]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][54] ([i915#4270]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_readwrite@beyond-eob:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#3282])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][56] ([i915#3282]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_render_copy@yf-tiled-ccs-to-yf-tiled:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#8428]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-mtlp: NOTRUN -> [SKIP][58] ([i915#4079])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-dg1: NOTRUN -> [SKIP][59] ([i915#4077]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@gem_userptr_blits@invalid-mmap-offset-unsync:
- shard-mtlp: NOTRUN -> [SKIP][60] ([i915#3297])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#3297] / [i915#4880])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@[email protected]

* igt@gen7_exec_parse@load-register-reg:
- shard-mtlp: NOTRUN -> [SKIP][62] ([fdo#109289]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- shard-mtlp: NOTRUN -> [SKIP][63] ([i915#2856]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@i915_hwmon@hwmon-read:
- shard-mtlp: NOTRUN -> [SKIP][64] ([i915#7707])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [PASS][65] -> [DMESG-WARN][66] ([i915#7061] / [i915#8617])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-11/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-10/igt@[email protected]
- shard-mtlp: [PASS][67] -> [ABORT][68] ([i915#8489] / [i915#8668])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-7/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [PASS][69] -> [SKIP][70] ([i915#4281])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-3/igt@[email protected]

* igt@i915_pm_lpsp@screens-disabled:
- shard-dg2: NOTRUN -> [SKIP][71] ([i915#1902])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][72] ([i915#1902])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][73] ([i915#8430])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@i915_pm_rpm@cursor-dpms:
- shard-dg1: [PASS][74] -> [FAIL][75] ([i915#7940])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-15/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-17/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg1: [PASS][76] -> [SKIP][77] ([i915#1397]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-18/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-dg2: NOTRUN -> [FAIL][78] ([i915#8717])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-rkl: [PASS][79] -> [SKIP][80] ([i915#1397])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg2: [PASS][81] -> [SKIP][82] ([i915#1397])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-3/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-10/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- shard-mtlp: NOTRUN -> [SKIP][83] ([i915#6621])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@i915_query@query-topology-unsupported:
- shard-dg2: NOTRUN -> [SKIP][84] ([fdo#109302])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][85] ([fdo#109302])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][86] ([fdo#109302])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@i915_selftest@live@slpc:
- shard-mtlp: NOTRUN -> [DMESG-WARN][87] ([i915#6367])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- shard-dg1: NOTRUN -> [DMESG-WARN][88] ([i915#4391] / [i915#4423]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-snb: NOTRUN -> [DMESG-WARN][89] ([i915#8841]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb1/igt@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#5190]) +4 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][91] ([i915#5190])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_addfb_basic@bo-too-small-due-to-tiling:
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#4212])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][93] ([i915#4212])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][94] ([i915#4212])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@kms_async_flips@crc@pipe-c-hdmi-a-1:
- shard-dg1: NOTRUN -> [FAIL][95] ([i915#8247]) +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@4-tiled-32bpp-rotate-180:
- shard-tglu: NOTRUN -> [SKIP][96] ([fdo#111615] / [i915#5286])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]

* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [PASS][97] -> [FAIL][98] ([i915#5138])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-3/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-dg1: NOTRUN -> [SKIP][99] ([i915#4538] / [i915#5286]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: [PASS][100] -> [FAIL][101] ([i915#3743])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][102] ([i915#3638])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][103] ([fdo#111614])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][104] ([fdo#111614])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-dg2: NOTRUN -> [SKIP][105] ([i915#4538] / [i915#5190])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#4538]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb:
- shard-dg1: NOTRUN -> [SKIP][107] ([fdo#111615])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][108] ([i915#6187])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0:
- shard-mtlp: NOTRUN -> [SKIP][109] ([fdo#111615]) +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-dg2: NOTRUN -> [SKIP][110] ([i915#2705])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][111] ([i915#2705])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][112] ([i915#2705])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-aux-stride-yf_tiled_ccs:
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#3689] / [i915#5354] / [i915#6095]) +7 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_ccs@pipe-b-bad-aux-stride-yf_tiled_ccs.html
- shard-tglu: NOTRUN -> [SKIP][114] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@kms_ccs@pipe-b-bad-aux-stride-yf_tiled_ccs.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][115] ([i915#6095]) +13 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#3689] / [i915#3886] / [i915#5354])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-dg1: NOTRUN -> [SKIP][117] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#3886] / [i915#6095])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#3689] / [i915#4423] / [i915#5354] / [i915#6095])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-d-ccs-on-another-bo-4_tiled_mtl_rc_ccs:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#5354]) +16 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_ccs@pipe-d-ccs-on-another-bo-4_tiled_mtl_rc_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][121] ([i915#3689] / [i915#5354]) +7 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs.html

* igt@kms_ccs@pipe-d-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc:
- shard-dg1: NOTRUN -> [SKIP][122] ([i915#5354] / [i915#6095]) +10 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_ccs@pipe-d-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc.html

* igt@kms_chamelium_color@gamma:
- shard-dg2: NOTRUN -> [SKIP][123] ([fdo#111827])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][124] ([fdo#111827])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][125] ([fdo#111827])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-after-suspend:
- shard-dg2: NOTRUN -> [SKIP][126] ([i915#7828]) +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][127] ([i915#7828])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-dg1: NOTRUN -> [SKIP][128] ([i915#7828]) +3 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_color@deep-color:
- shard-dg2: NOTRUN -> [SKIP][129] ([i915#3555])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-10/igt@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-dg2: NOTRUN -> [SKIP][130] ([i915#7118])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_content_protection@mei_interface.html
- shard-dg1: NOTRUN -> [SKIP][131] ([i915#7116])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@kms_content_protection@mei_interface.html
- shard-mtlp: NOTRUN -> [SKIP][132] ([i915#8063])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_content_protection@mei_interface.html

* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-dg1: NOTRUN -> [SKIP][133] ([i915#3555])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-tglu: NOTRUN -> [SKIP][134] ([i915#3359])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][135] ([i915#3359])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][136] ([i915#3359])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-mtlp: NOTRUN -> [SKIP][137] ([i915#3546]) +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
- shard-dg2: NOTRUN -> [SKIP][138] ([fdo#109274] / [i915#5354])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@kms_draw_crc@draw-method-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][139] ([i915#8812])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-dg2: NOTRUN -> [SKIP][140] ([fdo#109274]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][141] ([i915#3637])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-snb: NOTRUN -> [SKIP][142] ([fdo#109271] / [fdo#111767])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb4/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-dg1: NOTRUN -> [SKIP][143] ([fdo#111825]) +19 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_flip@flip-vs-fences:
- shard-mtlp: NOTRUN -> [SKIP][144] ([i915#8381])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][145] ([i915#8810])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][146] ([i915#2672]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][147] ([i915#2672])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#2587] / [i915#2672])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-blt:
- shard-mtlp: NOTRUN -> [SKIP][149] ([i915#1825]) +16 similar issues
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
- shard-tglu: NOTRUN -> [SKIP][150] ([fdo#109280])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- shard-dg2: [PASS][151] -> [FAIL][152] ([i915#6880])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-3/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-10/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][153] ([i915#8708]) +5 similar issues
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][154] ([i915#8708]) +2 similar issues
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][155] ([i915#8708]) +2 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt:
- shard-snb: NOTRUN -> [SKIP][156] ([fdo#109271]) +270 similar issues
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-dg1: NOTRUN -> [SKIP][157] ([i915#3458]) +8 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][158] ([i915#3458]) +2 similar issues
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#3555] / [i915#8228])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-6/igt@[email protected]

* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-dg1: NOTRUN -> [SKIP][160] ([fdo#109289])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][161] ([fdo#109289])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@kms_plane_lowres@tiling-none@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][162] ([i915#3582]) +7 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-dg2: NOTRUN -> [SKIP][163] ([i915#3555] / [i915#8806])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-dg1: NOTRUN -> [FAIL][164] ([i915#8292])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][165] ([i915#5176]) +3 similar issues
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-8/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3.html

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#5176]) +15 similar issues
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][167] ([i915#5176]) +3 similar issues
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][168] ([i915#5235]) +3 similar issues
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][169] ([i915#5235]) +7 similar issues
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-11/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][170] ([i915#5235]) +3 similar issues
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#5235]) +11 similar issues
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@kms_plane_scaling@[email protected]

* igt@kms_prime@basic-crc-hybrid:
- shard-dg1: NOTRUN -> [SKIP][172] ([i915#6524])
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-dg1: NOTRUN -> [SKIP][173] ([i915#658])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#658])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-mtlp: NOTRUN -> [SKIP][175] ([i915#4348])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-dg1: NOTRUN -> [SKIP][176] ([fdo#111068] / [i915#658])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@psr2_sprite_blt:
- shard-dg2: NOTRUN -> [SKIP][177] ([i915#1072]) +1 similar issue
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@kms_psr@psr2_sprite_blt.html
- shard-dg1: NOTRUN -> [SKIP][178] ([i915#1072]) +2 similar issues
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-mtlp: NOTRUN -> [SKIP][179] ([i915#4235])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-8/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-dg1: NOTRUN -> [SKIP][180] ([i915#8623])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][181] ([i915#8623])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][182] ([i915#8623])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]

* igt@perf_pmu@event-wait@rcs0:
- shard-mtlp: NOTRUN -> [SKIP][183] ([i915#8807])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@perf_pmu@[email protected]

* igt@perf_pmu@frequency@gt0:
- shard-dg1: NOTRUN -> [FAIL][184] ([i915#6806])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@perf_pmu@[email protected]

* igt@prime_vgem@basic-fence-blt:
- shard-mtlp: NOTRUN -> [FAIL][185] ([i915#8445])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- shard-dg2: NOTRUN -> [SKIP][186] ([i915#3291] / [i915#3708])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][187] ([i915#3708]) +1 similar issue
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][188] ([i915#3708])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@[email protected]

* igt@sysfs_heartbeat_interval@nopreempt@vcs0:
- shard-mtlp: [PASS][189] -> [FAIL][190] ([i915#6015]) +1 similar issue
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-4/igt@sysfs_heartbeat_interval@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@sysfs_heartbeat_interval@[email protected]

* igt@v3d/v3d_get_param@get-bad-param:
- shard-dg1: NOTRUN -> [SKIP][191] ([i915#2575]) +3 similar issues
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@v3d/[email protected]

* igt@v3d/v3d_submit_csd@bad-bo:
- shard-mtlp: NOTRUN -> [SKIP][192] ([i915#2575]) +2 similar issues
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@v3d/[email protected]

* igt@v3d/v3d_wait_bo@unused-bo-0ns:
- shard-dg2: NOTRUN -> [SKIP][193] ([i915#2575]) +3 similar issues
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-6/igt@v3d/[email protected]

* igt@vc4/vc4_label_bo@set-bad-name:
- shard-dg1: NOTRUN -> [SKIP][194] ([i915#7711]) +4 similar issues
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@vc4/[email protected]

* igt@vc4/vc4_wait_bo@used-bo-1ns:
- shard-dg2: NOTRUN -> [SKIP][195] ([i915#7711]) +2 similar issues
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@vc4/[email protected]
- shard-mtlp: NOTRUN -> [SKIP][196] ([i915#7711]) +1 similar issue
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@vc4/[email protected]

#### Possible fixes ####

* igt@gem_barrier_race@remote-request@rcs0:
- shard-dg2: [ABORT][197] ([i915#7461] / [i915#8211] / [i915#8234]) -> [PASS][198]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-1/igt@gem_barrier_race@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-2/igt@gem_barrier_race@[email protected]
- shard-dg1: [ABORT][199] ([i915#7461] / [i915#8234]) -> [PASS][200]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-16/igt@gem_barrier_race@[email protected]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-14/igt@gem_barrier_race@[email protected]
- shard-mtlp: [ABORT][201] ([i915#6333] / [i915#8234]) -> [PASS][202]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-5/igt@gem_barrier_race@[email protected]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@gem_barrier_race@[email protected]

* {igt@gem_ctx_freq@sysfs@gt0}:
- shard-mtlp: [FAIL][203] ([i915#6786]) -> [PASS][204]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-4/igt@gem_ctx_freq@[email protected]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@gem_ctx_freq@[email protected]

* igt@gem_eio@hibernate:
- shard-tglu: [ABORT][205] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][206]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-10/igt@[email protected]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][207] ([i915#2846]) -> [PASS][208]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-glk6/igt@[email protected]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-glk3/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-rkl: [FAIL][209] ([i915#2842]) -> [PASS][210]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-1/igt@gem_exec_fair@[email protected]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][211] ([i915#2842]) -> [PASS][212]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-glk8/igt@gem_exec_fair@[email protected]
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [ABORT][213] -> [PASS][214]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-snb2/igt@[email protected]
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb4/igt@[email protected]

* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-mtlp: [FAIL][215] ([i915#8691]) -> [PASS][216]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-2/igt@[email protected]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-tglu: [FAIL][217] ([i915#3989] / [i915#454]) -> [PASS][218]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-8/igt@[email protected]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-dg1: [FAIL][219] ([i915#3591]) -> [PASS][220]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-18/igt@i915_pm_rc6_residency@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [FAIL][221] ([i915#7940]) -> [PASS][222]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-6/igt@i915_pm_rpm@[email protected]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-8/igt@i915_pm_rpm@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- shard-dg1: [FAIL][223] ([i915#7940]) -> [PASS][224]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-18/igt@i915_pm_rpm@[email protected]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@i915_pm_rpm@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- shard-dg2: [SKIP][225] ([i915#1397]) -> [PASS][226]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-11/igt@[email protected]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-10/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg1: [SKIP][227] ([i915#1397]) -> [PASS][228]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-17/igt@[email protected]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-19/igt@[email protected]

* igt@i915_selftest@live@gem_contexts:
- shard-mtlp: [ABORT][229] ([i915#8630]) -> [PASS][230]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-6/igt@i915_selftest@live@gem_contexts.html
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@i915_selftest@live@gem_contexts.html

* igt@i915_selftest@live@gt_mocs:
- shard-mtlp: [DMESG-FAIL][231] ([i915#7059]) -> [PASS][232]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@requests:
- shard-mtlp: [DMESG-FAIL][233] ([i915#7269]) -> [PASS][234]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-6/igt@i915_selftest@[email protected]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-6/igt@i915_selftest@[email protected]

* igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_mc_ccs:
- shard-dg2: [FAIL][235] ([i915#8221]) -> [PASS][236]
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-11/igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_mc_ccs.html
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-11/igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_mc_ccs.html

* igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-3:
- shard-dg2: [FAIL][237] ([fdo#103375]) -> [PASS][238]
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-5/igt@kms_cursor_crc@[email protected]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-3/igt@kms_cursor_crc@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-mtlp: [FAIL][239] ([i915#8248]) -> [PASS][240]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-3/igt@[email protected]
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-dg2: [FAIL][241] ([i915#6880]) -> [PASS][242] +1 similar issue
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- shard-mtlp: [FAIL][243] ([i915#1623]) -> [PASS][244]
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-2/igt@kms_plane@[email protected]
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@kms_plane@[email protected]

* igt@sysfs_heartbeat_interval@nopreempt@ccs0:
- shard-mtlp: [FAIL][245] ([i915#6015]) -> [PASS][246]
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-mtlp-4/igt@sysfs_heartbeat_interval@[email protected]
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-mtlp-4/igt@sysfs_heartbeat_interval@[email protected]

#### Warnings ####

* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][247] ([i915#5493]) -> [DMESG-WARN][248] ([i915#4936] / [i915#5493])
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg2-11/igt@gem_lmem_swapping@[email protected]
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg2-11/igt@gem_lmem_swapping@[email protected]
- shard-dg1: [DMESG-WARN][249] ([i915#4936] / [i915#5493]) -> [TIMEOUT][250] ([i915#5493])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-18/igt@gem_lmem_swapping@[email protected]
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@gem_lmem_swapping@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-tglu: [FAIL][251] ([i915#2681] / [i915#3591]) -> [WARN][252] ([i915#2681])
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-tglu-4/igt@i915_pm_rc6_residency@[email protected]
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-tglu-9/igt@i915_pm_rc6_residency@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-snb: [DMESG-FAIL][253] ([fdo#103375]) -> [DMESG-WARN][254] ([i915#8841])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-snb7/igt@[email protected]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-snb2/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][255] ([fdo#110189] / [i915#3955]) -> [SKIP][256] ([i915#3955])
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-rkl-2/igt@[email protected]
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-rkl-4/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- shard-dg1: [SKIP][257] ([i915#1072] / [i915#4078]) -> [SKIP][258] ([i915#1072]) +1 similar issue
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-18/igt@kms_psr@cursor_plane_move.html
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-15/igt@kms_psr@cursor_plane_move.html

* igt@kms_psr@primary_page_flip:
- shard-dg1: [SKIP][259] ([i915#1072]) -> [SKIP][260] ([i915#1072] / [i915#4078])
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13434/shard-dg1-17/igt@kms_psr@primary_page_flip.html
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/shard-dg1-16/igt@kms_psr@primary_page_flip.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3582]: https://gitlab.freedesktop.org/drm/intel/issues/3582
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4348]: https://gitlab.freedesktop.org/drm/intel/issues/4348
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6015]: https://gitlab.freedesktop.org/drm/intel/issues/6015
[i915#6016]: https://gitlab.freedesktop.org/drm/intel/issues/6016
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6187]: https://gitlab.freedesktop.org/drm/intel/issues/6187
[i915#6333]: https://gitlab.freedesktop.org/drm/intel/issues/6333
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8063]: https://gitlab.freedesktop.org/drm/intel/issues/8063
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8221]: https://gitlab.freedesktop.org/drm/intel/issues/8221
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/intel/issues/8430
[i915#8445]: https://gitlab.freedesktop.org/drm/intel/issues/8445
[i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
[i915#8503]: https://gitlab.freedesktop.org/drm/intel/issues/8503
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8617]: https://gitlab.freedesktop.org/drm/intel/issues/8617
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
[i915#8630]: https://gitlab.freedesktop.org/drm/intel/issues/8630
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8717]: https://gitlab.freedesktop.org/drm/intel/issues/8717
[i915#8806]: https://gitlab.freedesktop.org/drm/intel/issues/8806
[i915#8807]: https://gitlab.freedesktop.org/drm/intel/issues/8807
[i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810
[i915#8812]: https://gitlab.freedesktop.org/drm/intel/issues/8812
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8898]: https://gitlab.freedesktop.org/drm/intel/issues/8898
[i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925

Build changes
-------------

* Linux: CI_DRM_13434 -> Patchwork_118898v4

CI-20190529: 20190529
CI_DRM_13434: 918975ceb3c3df43381c188394360b665ebd9263 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7408: 93482edd02839f9eb6ceffca9418d03f570f34f3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118898v4: 918975ceb3c3df43381c188394360b665ebd9263 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v4/index.html

#5 lore raw
In reply to Zhanjun Dong

Hi Zhanjun,

Quoted 2 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

Next time, please wrap the sentences to 65 characters (standing to the e-mail netiquette, RFC1855[1]) or 70-75 characters (standing to the kernel guidelines[2]).

[1] https://www.ietf.org/rfc/rfc1855.txt

    chapter "2.1.1 For mail", page 3

[2] https://docs.kernel.org/process/submitting-patches.html
chapter "The canonical patch format"

Quoted 99 lines

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

        lock_acquire+0xd8/0x2d0
        i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
        intel_gt_init_reset+0x65/0x80 [i915]
        intel_gt_common_init_early+0xe1/0x170 [i915]
        intel_root_gt_init_early+0x48/0x60 [i915]
        i915_driver_probe+0x671/0xcb0 [i915]
        i915_pci_probe+0xdc/0x210 [i915]
        pci_device_probe+0x95/0x120
        really_probe+0x164/0x3c0
        __driver_probe_device+0x73/0x160
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        __pfx_vgem_open+0x3/0x10 [vgem]
        do_one_initcall+0x57/0x270
        do_init_module+0x5f/0x220
        load_module+0x1ca4/0x1f00
        __do_sys_finit_module+0xb4/0x130
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

        lock_acquire+0xd8/0x2d0
        fs_reclaim_acquire+0xac/0xe0
        kmem_cache_alloc+0x32/0x260
        i915_vma_instance+0xb2/0xc60 [i915]
        i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
        vm_fault_gtt+0x22d/0xf60 [i915]
        __do_fault+0x2f/0x1d0
        do_pte_missing+0x4a/0xd20
        __handle_mm_fault+0x5b0/0x790
        handle_mm_fault+0xa2/0x230
        do_user_addr_fault+0x3ea/0xa10
        exc_page_fault+0x68/0x1a0
        asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

        lock_acquire+0xd8/0x2d0
        _intel_gt_reset_lock+0x57/0x330 [i915]
        guc_timestamp_ping+0x35/0x130 [i915]
        process_one_work+0x250/0x510
        worker_thread+0x4f/0x3a0
        kthread+0xff/0x130
        ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

        check_prev_add+0x90/0xc60
        __lock_acquire+0x1998/0x2590
        lock_acquire+0xd8/0x2d0
        __flush_work+0x74/0x530
        __cancel_work_timer+0x14f/0x1f0
        intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
        intel_uc_reset_prepare+0x9c/0x120 [i915]
        reset_prepare+0x21/0x60 [i915]
        intel_gt_reset+0x1dd/0x470 [i915]
        intel_gt_reset_global+0xfb/0x170 [i915]
        intel_gt_handle_error+0x368/0x420 [i915]
        intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
        i915_wedged_set+0x29/0x40 [i915]
        simple_attr_write_xsigned.constprop.0+0xb4/0x110
        full_proxy_write+0x52/0x80
        vfs_write+0xc5/0x4f0
        ksys_write+0x64/0xe0
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Chain exists of:
  (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&gt->reset.mutex);
                                lock(fs_reclaim);
                                lock(&gt->reset.mutex);
   lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:
#0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
#1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110 #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

Quoted 3 lines

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.
v4: Set to always sync from __uc_fini_hw path.

Thanks for taking care of this, there was a period we could see this splatter everywhere :)

Quoted 15 lines
Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0 -0
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
 	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_enable_busyness_worker(struct intel_guc *guc) · line 1365

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -2
 }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
 {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);

The guc_cancel_busyness_worker() wrapper is made to make life simpler, in oder not to force the caller to find guc->timestamp.work. But if we add a true/false value, then we make it again difficult because we need to go and check what they mean, so that we decrease readability.

I would rather prefer something like:

	static void guc_cancel_busyness_worker_sync(struct intel_guc *guc)
	{
		cancel_delayed_work_sync(&guc->timestamp.work);
	}

	static void guc_cancel_busyness_worker(struct intel_guc *guc)
	{
		cancel_delayed_work(&guc->timestamp.work);
	}

We could perhaps improve this with defines or inlines, but I like this way more.

What do you think?

Andi

Quoted 79 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -5
 }
 
 static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
 	unsigned long flags;
 	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
 	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
 static void guc_fini_engine_stats(struct intel_guc *guc)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 }
 
 void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
 	 * and causes an unclaimed register access warning. Cancel the worker
 	 * synchronously here.
 	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
 	/*
 	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
 }
 
 /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
 	/* Semaphore interrupt disable and route to host */
 	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
 void intel_guc_submission_init_early(struct intel_guc *guc);
 int intel_guc_submission_init(struct intel_guc *guc);
 int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..5b76f0d4d2a6 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
 	 * We've failed to load the firmware :(
 	 */
 err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
 err_log_capture:
 	__uc_capture_load_err_log(uc);
 err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
 		return;
 
 	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, true);
 
 	__uc_sanitize(uc);
 }
Signature · 1 line
2.34.1
#7 lore raw
In reply to Zhanjun Dong
Quoted 136 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

        lock_acquire+0xd8/0x2d0
        i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
        intel_gt_init_reset+0x65/0x80 [i915]
        intel_gt_common_init_early+0xe1/0x170 [i915]
        intel_root_gt_init_early+0x48/0x60 [i915]
        i915_driver_probe+0x671/0xcb0 [i915]
        i915_pci_probe+0xdc/0x210 [i915]
        pci_device_probe+0x95/0x120
        really_probe+0x164/0x3c0
        __driver_probe_device+0x73/0x160
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        __pfx_vgem_open+0x3/0x10 [vgem]
        do_one_initcall+0x57/0x270
        do_init_module+0x5f/0x220
        load_module+0x1ca4/0x1f00
        __do_sys_finit_module+0xb4/0x130
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

        lock_acquire+0xd8/0x2d0
        fs_reclaim_acquire+0xac/0xe0
        kmem_cache_alloc+0x32/0x260
        i915_vma_instance+0xb2/0xc60 [i915]
        i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
        vm_fault_gtt+0x22d/0xf60 [i915]
        __do_fault+0x2f/0x1d0
        do_pte_missing+0x4a/0xd20
        __handle_mm_fault+0x5b0/0x790
        handle_mm_fault+0xa2/0x230
        do_user_addr_fault+0x3ea/0xa10
        exc_page_fault+0x68/0x1a0
        asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

        lock_acquire+0xd8/0x2d0
        _intel_gt_reset_lock+0x57/0x330 [i915]
        guc_timestamp_ping+0x35/0x130 [i915]
        process_one_work+0x250/0x510
        worker_thread+0x4f/0x3a0
        kthread+0xff/0x130
        ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

        check_prev_add+0x90/0xc60
        __lock_acquire+0x1998/0x2590
        lock_acquire+0xd8/0x2d0
        __flush_work+0x74/0x530
        __cancel_work_timer+0x14f/0x1f0
        intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
        intel_uc_reset_prepare+0x9c/0x120 [i915]
        reset_prepare+0x21/0x60 [i915]
        intel_gt_reset+0x1dd/0x470 [i915]
        intel_gt_reset_global+0xfb/0x170 [i915]
        intel_gt_handle_error+0x368/0x420 [i915]
        intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
        i915_wedged_set+0x29/0x40 [i915]
        simple_attr_write_xsigned.constprop.0+0xb4/0x110
        full_proxy_write+0x52/0x80
        vfs_write+0xc5/0x4f0
        ksys_write+0x64/0xe0
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Chain exists of:
  (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&gt->reset.mutex);
                                lock(fs_reclaim);
                                lock(&gt->reset.mutex);
   lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:
#0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
#1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110 #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.
v4: Set to always sync from __uc_fini_hw path.

Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -2
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
        mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
 }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
 {
-       cancel_delayed_work_sync(&guc->timestamp.work);
+       if (sync)
+               cancel_delayed_work_sync(&guc->timestamp.work);
+       else
+               cancel_delayed_work(&guc->timestamp.work);
 }
 
 static void __reset_guc_busyness_stats(struct intel_guc *guc)

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void __reset_guc_busyness_stats(struct intel_guc *guc) · line 1376

Quoted 5 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -1
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
        unsigned long flags;
        ktime_t unused;
 
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, false);

This needs an absolutely giantic explainer of why this is correct, and why it's needed. I suspect this one of these "shut up lockdep, break the code" kind of patches.
-Daniel

Quoted 71 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +4 -4
        spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
 static void guc_fini_engine_stats(struct intel_guc *guc)
 {
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, true);
 }
 
 void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
         * and causes an unclaimed register access warning. Cancel the worker
         * synchronously here.
         */
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, true);
 
        /*
         * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
 }
 
 /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
 {
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, sync);
 
        /* Semaphore interrupt disable and route to host */
        guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
 void intel_guc_submission_init_early(struct intel_guc *guc);
 int intel_guc_submission_init(struct intel_guc *guc);
 int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -3
index 18250fb64bd8..5b76f0d4d2a6 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
         * We've failed to load the firmware :(
         */
 err_submission:
-       intel_guc_submission_disable(guc);
+       intel_guc_submission_disable(guc, true);
 err_log_capture:
        __uc_capture_load_err_log(uc);
 err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
                return;
 
        if (intel_uc_uses_guc_submission(uc))
-               intel_guc_submission_disable(guc);
+               intel_guc_submission_disable(guc, true);
 
        __uc_sanitize(uc);
 }
--

2.34.1

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#6 lore raw
In reply to Andi Shyti

Hi Andi,

Quoted 6 lines · Andi Shyti

Hi Zhanjun,

Quoted 2 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

Quoted 9 lines

Next time, please wrap the sentences to 65 characters (standing to the e-mail netiquette, RFC1855[1]) or 70-75 characters (standing to the kernel guidelines[2]).

[1] https://www.ietf.org/rfc/rfc1855.txt

     chapter "2.1.1 For mail", page 3

[2] https://docs.kernel.org/process/submitting-patches.html
chapter "The canonical patch format"

Thanks, will be fixed in next revision.

Quoted 150 lines
Quoted 95 lines

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

         lock_acquire+0xd8/0x2d0
         i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
         intel_gt_init_reset+0x65/0x80 [i915]
         intel_gt_common_init_early+0xe1/0x170 [i915]
         intel_root_gt_init_early+0x48/0x60 [i915]
         i915_driver_probe+0x671/0xcb0 [i915]
         i915_pci_probe+0xdc/0x210 [i915]
         pci_device_probe+0x95/0x120
         really_probe+0x164/0x3c0
         __driver_probe_device+0x73/0x160
         driver_probe_device+0x19/0xa0
         __driver_attach+0xb6/0x180
         bus_for_each_dev+0x77/0xd0
         bus_add_driver+0x114/0x210
         driver_register+0x5b/0x110
         __pfx_vgem_open+0x3/0x10 [vgem]
         do_one_initcall+0x57/0x270
         do_init_module+0x5f/0x220
         load_module+0x1ca4/0x1f00
         __do_sys_finit_module+0xb4/0x130
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

         lock_acquire+0xd8/0x2d0
         fs_reclaim_acquire+0xac/0xe0
         kmem_cache_alloc+0x32/0x260
         i915_vma_instance+0xb2/0xc60 [i915]
         i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
         vm_fault_gtt+0x22d/0xf60 [i915]
         __do_fault+0x2f/0x1d0
         do_pte_missing+0x4a/0xd20
         __handle_mm_fault+0x5b0/0x790
         handle_mm_fault+0xa2/0x230
         do_user_addr_fault+0x3ea/0xa10
         exc_page_fault+0x68/0x1a0
         asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

         lock_acquire+0xd8/0x2d0
         _intel_gt_reset_lock+0x57/0x330 [i915]
         guc_timestamp_ping+0x35/0x130 [i915]
         process_one_work+0x250/0x510
         worker_thread+0x4f/0x3a0
         kthread+0xff/0x130
         ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

         check_prev_add+0x90/0xc60
         __lock_acquire+0x1998/0x2590
         lock_acquire+0xd8/0x2d0
         __flush_work+0x74/0x530
         __cancel_work_timer+0x14f/0x1f0
         intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
         intel_uc_reset_prepare+0x9c/0x120 [i915]
         reset_prepare+0x21/0x60 [i915]
         intel_gt_reset+0x1dd/0x470 [i915]
         intel_gt_reset_global+0xfb/0x170 [i915]
         intel_gt_handle_error+0x368/0x420 [i915]
         intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
         i915_wedged_set+0x29/0x40 [i915]
         simple_attr_write_xsigned.constprop.0+0xb4/0x110
         full_proxy_write+0x52/0x80
         vfs_write+0xc5/0x4f0
         ksys_write+0x64/0xe0
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

  Chain exists of:
   (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
   Possible unsafe locking scenario:
         CPU0                    CPU1
         ----                    ----
    lock(&gt->reset.mutex);
                                 lock(fs_reclaim);
                                 lock(&gt->reset.mutex);
    lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:

Quoted 7 lines
   #0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
   #1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110
   #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.
v4: Set to always sync from __uc_fini_hw path.

Thanks for taking care of this, there was a period we could see this splatter everywhere :)

Quoted 15 lines
Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
  .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
  drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
  3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0 -0
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
  	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_enable_busyness_worker(struct intel_guc *guc) · line 1365

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -2
  }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
  {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);

The guc_cancel_busyness_worker() wrapper is made to make life simpler, in oder not to force the caller to find guc->timestamp.work. But if we add a true/false value, then we make it again difficult because we need to go and check what they mean, so that we decrease readability.

I would rather prefer something like:

	static void guc_cancel_busyness_worker_sync(struct intel_guc *guc)
	{
		cancel_delayed_work_sync(&guc->timestamp.work);
	}

	static void guc_cancel_busyness_worker(struct intel_guc *guc)
	{
		cancel_delayed_work(&guc->timestamp.work);
	}
Quoted 6 lines

We could perhaps improve this with defines or inlines, but I like this way more.

What do you think?

Andi

I like this idea, will change it that way in next revision.

Regards,
Zhanjun

Quoted 80 lines
Quoted 80 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -5
  }
 
  static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
  	unsigned long flags;
  	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
  	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
  static void guc_fini_engine_stats(struct intel_guc *guc)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
  }
 
  void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
  	 * and causes an unclaimed register access warning. Cancel the worker
  	 * synchronously here.
  	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
  	/*
  	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
  }
 
  /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
  	/* Semaphore interrupt disable and route to host */
  	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
  void intel_guc_submission_init_early(struct intel_guc *guc);
  int intel_guc_submission_init(struct intel_guc *guc);
  int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
  void intel_guc_submission_fini(struct intel_guc *guc);
  int intel_guc_preempt_work_create(struct intel_guc *guc);
  void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..5b76f0d4d2a6 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
  	 * We've failed to load the firmware :(
  	 */
  err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
  err_log_capture:
  	__uc_capture_load_err_log(uc);
  err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
  		return;
 
  	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, true);
 
  	__uc_sanitize(uc);
  }
Signature · 1 line
2.34.1
#8 lore raw
In reply to Daniel Vetter

Hi Daniel,

Quoted 140 lines · Daniel Vetter
Quoted 139 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

         lock_acquire+0xd8/0x2d0
         i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
         intel_gt_init_reset+0x65/0x80 [i915]
         intel_gt_common_init_early+0xe1/0x170 [i915]
         intel_root_gt_init_early+0x48/0x60 [i915]
         i915_driver_probe+0x671/0xcb0 [i915]
         i915_pci_probe+0xdc/0x210 [i915]
         pci_device_probe+0x95/0x120
         really_probe+0x164/0x3c0
         __driver_probe_device+0x73/0x160
         driver_probe_device+0x19/0xa0
         __driver_attach+0xb6/0x180
         bus_for_each_dev+0x77/0xd0
         bus_add_driver+0x114/0x210
         driver_register+0x5b/0x110
         __pfx_vgem_open+0x3/0x10 [vgem]
         do_one_initcall+0x57/0x270
         do_init_module+0x5f/0x220
         load_module+0x1ca4/0x1f00
         __do_sys_finit_module+0xb4/0x130
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

         lock_acquire+0xd8/0x2d0
         fs_reclaim_acquire+0xac/0xe0
         kmem_cache_alloc+0x32/0x260
         i915_vma_instance+0xb2/0xc60 [i915]
         i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
         vm_fault_gtt+0x22d/0xf60 [i915]
         __do_fault+0x2f/0x1d0
         do_pte_missing+0x4a/0xd20
         __handle_mm_fault+0x5b0/0x790
         handle_mm_fault+0xa2/0x230
         do_user_addr_fault+0x3ea/0xa10
         exc_page_fault+0x68/0x1a0
         asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

         lock_acquire+0xd8/0x2d0
         _intel_gt_reset_lock+0x57/0x330 [i915]
         guc_timestamp_ping+0x35/0x130 [i915]
         process_one_work+0x250/0x510
         worker_thread+0x4f/0x3a0
         kthread+0xff/0x130
         ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

         check_prev_add+0x90/0xc60
         __lock_acquire+0x1998/0x2590
         lock_acquire+0xd8/0x2d0
         __flush_work+0x74/0x530
         __cancel_work_timer+0x14f/0x1f0
         intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
         intel_uc_reset_prepare+0x9c/0x120 [i915]
         reset_prepare+0x21/0x60 [i915]
         intel_gt_reset+0x1dd/0x470 [i915]
         intel_gt_reset_global+0xfb/0x170 [i915]
         intel_gt_handle_error+0x368/0x420 [i915]
         intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
         i915_wedged_set+0x29/0x40 [i915]
         simple_attr_write_xsigned.constprop.0+0xb4/0x110
         full_proxy_write+0x52/0x80
         vfs_write+0xc5/0x4f0
         ksys_write+0x64/0xe0
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

  Chain exists of:
   (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
   Possible unsafe locking scenario:
         CPU0                    CPU1
         ----                    ----
    lock(&gt->reset.mutex);
                                 lock(fs_reclaim);
                                 lock(&gt->reset.mutex);
    lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:

   #0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
   #1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110
   #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.
v4: Set to always sync from __uc_fini_hw path.

Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
  .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
  drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
  3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +5 -2
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
         mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
  }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
  {
-       cancel_delayed_work_sync(&guc->timestamp.work);
+       if (sync)
+               cancel_delayed_work_sync(&guc->timestamp.work);
+       else
+               cancel_delayed_work(&guc->timestamp.work);
  }
 
  static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
         unsigned long flags;
         ktime_t unused;
 
Quoted 7 lines

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void __reset_guc_busyness_stats(struct intel_guc *guc) · line 1376

Quoted 2 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 -1
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, false);

This needs an absolutely giantic explainer of why this is correct, and why it's needed. I suspect this one of these "shut up lockdep, break the code" kind of patches.
-Daniel

Thanks for comments. Will add more code comments in next revision.

Regards,
Zhanjun

Quoted 74 lines
Quoted 72 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +4 -4
         spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
  static void guc_fini_engine_stats(struct intel_guc *guc)
  {
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, true);
  }
 
  void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
          * and causes an unclaimed register access warning. Cancel the worker
          * synchronously here.
          */
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, true);
 
         /*
          * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
  }
 
  /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
  {
-       guc_cancel_busyness_worker(guc);
+       guc_cancel_busyness_worker(guc, sync);
 
         /* Semaphore interrupt disable and route to host */
         guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
  void intel_guc_submission_init_early(struct intel_guc *guc);
  int intel_guc_submission_init(struct intel_guc *guc);
  int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
  void intel_guc_submission_fini(struct intel_guc *guc);
  int intel_guc_preempt_work_create(struct intel_guc *guc);
  void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -3
index 18250fb64bd8..5b76f0d4d2a6 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
          * We've failed to load the firmware :(
          */
  err_submission:
-       intel_guc_submission_disable(guc);
+       intel_guc_submission_disable(guc, true);
  err_log_capture:
         __uc_capture_load_err_log(uc);
  err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
                 return;
 
         if (intel_uc_uses_guc_submission(uc))
-               intel_guc_submission_disable(guc);
+               intel_guc_submission_disable(guc, true);
 
         __uc_sanitize(uc);
  }
--

2.34.1