clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
Subsystems (3)
PATCH 1/1 clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error.
--- drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-sm8250.c +1 -0
@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };
Signature · 1 line
2.25.1
Quoted 6 lines · Patrick Whewell
Set .flags =
CLK_OPS_PARENT_ENABLEto fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error.Signed-off-by Patrick Whewell <[email protected]>Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")---
You could also mention that the error is caused by GPLL9 (the one providing the highest frequency in the freq table) not being on by default.
And ultra nit: your s-o-b should go last
Konrad
Quoted 15 lines
drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/qcom/gcc-sm8250.c +1
-0@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };
Quoted 9 lines · Konrad Dybcio
Quoted 8 lines · Patrick Whewell
Set .flags =
CLK_OPS_PARENT_ENABLEto fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error.Signed-off-by: Patrick Whewell
<[email protected]>Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controllerdriver for SM8250")
---
Quoted 6 lines
Reviewed-by Konrad Dybcio <[email protected]>You could also mention that the error is caused by GPLL9 (the one providing the highest frequency in the freq table) not being on by default.
And ultra nit: your s-o-b should go last
I will be sending over v2 shortly with both comments addressed.
Quoted 18 lines
Konrad
Quoted 16 lines
drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/clk/qcom/gcc-sm8250.cindexb6cf4bc88d4d..d3c75bb55946100644drivers/clk/qcom/gcc-sm8250.c +1
-0@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };
Quoted 14 lines · Patrick Whewell
Set .flags =
CLK_OPS_PARENT_ENABLEto fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error.Signed-off-by Patrick Whewell <[email protected]>Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")--- drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/qcom/gcc-sm8250.c +0
-0
drivers/clk/qcom/gcc-sm8250.c static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { · line 727
Quoted 7 lines
drivers/clk/qcom/gcc-sm8250.c +1
-0@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };
Quoted 5 lines · Patrick Whewell
Set .flags =
CLK_OPS_PARENT_ENABLEto fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error.Signed-off-by Patrick Whewell <[email protected]>Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
The error appears resolved when tested on my Open-Q 865 SOM.
Quoted 19 lines
--- drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/qcom/gcc-sm8250.c +1
-0@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };Signature · 1 line
2.25.1