Skip to contentSkip to conversation

clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src

PATCH RESEND Applied Patrick Whewell 3 participants 3 messages Aug 2, 2023 – Aug 3, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src

GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error when booting. Set .flags = CLK_OPS_PARENT_ENABLE to fix the error.

Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")

---
Changes in v2:
- Updated commit messaage to mention GPLL9 not being on by default being the cause of error
- Moved Signed-off-by line to the bottom.

 drivers/clk/qcom/gcc-sm8250.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-sm8250.c +1 -0
index b6cf4bc88d4d..d3c75bb55946 100644
@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
 		.name = "gcc_sdcc2_apps_clk_src",
 		.parent_data = gcc_parent_data_4,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_4),
+		.flags = CLK_OPS_PARENT_ENABLE,
 		.ops = &clk_rcg2_floor_ops,
 	},
 };
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 3 lines · Patrick Whewell

GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error when booting. Set .flags = CLK_OPS_PARENT_ENABLE to fix the error.

Quoted 28 lines
Fixes 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")

---
Changes in v2:
- Updated commit messaage to mention GPLL9 not being on by default being the cause of error
- Moved Signed-off-by line to the bottom.

 drivers/clk/qcom/gcc-sm8250.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-sm8250.c +1 -0
index b6cf4bc88d4d..d3c75bb55946 100644
@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
 		.name = "gcc_sdcc2_apps_clk_src",
 		.parent_data = gcc_parent_data_4,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_4),
+		.flags = CLK_OPS_PARENT_ENABLE,
 		.ops = &clk_rcg2_floor_ops,
 	},
 };
Signature · 1 line
2.25.1
Signature · 1 line
~Vinod
maintainer Applied
#2 lore raw
In reply to Patrick Whewell
Quoted 5 lines · Patrick Whewell

GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error when booting. Set .flags = CLK_OPS_PARENT_ENABLE to fix the error.

Applied, thanks!

[1/1] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src

      commit: 783cb693828ce487cf0bc6ad16cbcf2caae6f8d9

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>