scsi: lpfc: Do not abuse UUID APIs
Subsystems (2)
PATCH v2 1/1 scsi: lpfc: Do not abuse UUID APIs
The lpfc_vmid_host_uuid is not defined as uuid_t and its usage is not the same as for uuid_t operations (like exporting or importing). Hence replace call to uuid_is_null() by respective memchr_inv() without abusing casting.
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: fixed the logic: memchr_inv() returns "true" when uuid_is_null() returns false.
drivers/scsi/lpfc/lpfc_els.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +2 -2
@@ -1332,7 +1332,7 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,if (phba->cfg_vmid_priority_tagging) { sp->cmn.priority_tagging =1 ;/* lpfc_vmid_host_uuid is combination of wwpn and wwnn */ -if (uuid_is_null ((uuid_t *)vport->lpfc_vmid_host_uuid)) { +if (!memchr_inv (vport->lpfc_vmid_host_uuid,0 ,LPFC_COMPRESS_VMID_SIZE )) {memcpy (vport->lpfc_vmid_host_uuid, phba->wwpn,sizeof (phba->wwpn)); memcpy(&vport->lpfc_vmid_host_uuid[8], phba->wwnn,
@@ -12331,7 +12331,7 @@ lpfc_vmid_uvem(struct lpfc_vport *vport, elsiocb->vmid_tag.vmid_context = vmid_context; pcmd = (u8 *)elsiocb->cmd_dmabuf->virt; -if (uuid_is_null ((uuid_t *)vport->lpfc_vmid_host_uuid)) +if (!memchr_inv (vport->lpfc_vmid_host_uuid,0 ,LPFC_COMPRESS_VMID_SIZE ))memcpy (vport->lpfc_vmid_host_uuid, vmid->host_vmid,LPFC_COMPRESS_VMID_SIZE );
Signature · 1 line
2.40.0.1.gaa8946217a0b