Skip to contentSkip to conversation

doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

PATCH In review Fabio Estevam 2 participants 4 messages Aug 7, 2023 – Aug 9, 2023 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

From: Fabio Estevam <[email protected]>

Originally, exporting the ATF_LOAD_ADDR was required, but since binman has been used to generate the flash.bin, it is no longer needed to do such manual export.

The ATF address is now passed via binman in imx8mp-u-boot.dtsi:

	atf {
		description = "ARM Trusted Firmware";
		type = "firmware";
		arch = "arm64";
		compression = "none";
		load = <0x970000>;
		entry = <0x970000>;

		atf_blob: atf-blob {
			filename = "bl31.bin";
			type = "atf-bl31";
		};
	};

Remove the unneeded export ATF_LOAD_ADDR line.

---
 doc/board/nxp/imx8mp_evk.rst | 1 -
 1 file changed, 1 deletion(-)
doc/board/nxp/imx8mp_evk.rst +0 -1
index e7cc7b396b57..e106c3c71872 100644
@@ -44,7 +44,6 @@ Build U-Boot
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin ./build/
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin ./build/
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin ./build/
-   $ export ATF_LOAD_ADDR=0x970000
    $ make O=build
 
 Burn the flash.bin to the MicroSD card at offset 32KB:
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH 2/2 doc: imx8mp_evk: Use in-tree build in the example

From: Fabio Estevam <[email protected]>

To make it consistent with the instructions from other NXP imx8m boards, such as imx8mm-evk and imx8mn-evk, use U-Boot in-tree build in the examples.

---
 doc/board/nxp/imx8mp_evk.rst | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
doc/board/nxp/imx8mp_evk.rst +9 -7
index e106c3c71872..0297cc8ffc16 100644
@@ -37,20 +37,22 @@ Build U-Boot
 
 .. code-block:: bash
 
+Note: builddir is U-Boot build directory (source directory for in-tree builds).
+
    $ export CROSS_COMPILE=aarch64-poky-linux-
    $ make O=build imx8mp_evk_defconfig
-   $ cp ../imx-atf/build/imx8mp/release/bl31.bin ./build/bl31.bin
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin ./build/
-   $ make O=build
+   $ cp ../imx-atf/build/imx8mp/release/bl31.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin $(builddir)
+   $ make
 
 Burn the flash.bin to the MicroSD card at offset 32KB:
 
 .. code-block:: bash
 
-   $sudo dd if=build/flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync
+   $ sudo dd if=flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync
 
 Boot
 ----
Signature · 1 line
2.34.1
Reviewed-by on v1 1/2
#3 lore raw
In reply to Fabio Estevam
Quoted 22 lines · Fabio Estevam

From: Fabio Estevam<[email protected]>

Originally, exporting the ATF_LOAD_ADDR was required, but since binman has been used to generate the flash.bin, it is no longer needed to do such manual export.

The ATF address is now passed via binman in imx8mp-u-boot.dtsi:

	atf {
		description = "ARM Trusted Firmware";
		type = "firmware";
		arch = "arm64";
		compression = "none";
		load = <0x970000>;
		entry = <0x970000>;

		atf_blob: atf-blob {
			filename = "bl31.bin";
			type = "atf-bl31";
		};
	};
Quoted 3 lines

Remove the unneeded export ATF_LOAD_ADDR line.