Skip to contentSkip to conversation

dt-bindings: stm32: document MYD-YA15XC-T development board

PATCH Superseded Alexander Shiyan 2 participants 3 messages Sep 1, 2023

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: stm32: document MYD-YA15XC-T development board

Add new entry for MYD-YA15XC-T development board.

---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +7 -0
index 4466b455bffa..1bde704bcd65 100644
@@ -140,6 +140,13 @@ properties:
           - const: engicam,microgea-stm32mp1
           - const: st,stm32mp157
 
+      - description: MyirTech STM32MP15x SoM based Boards
+        items:
+          - const: myir,myd-ya15xc-t   # MYIR MYD-YA15XC-T STM32MP151C
+          - const: myir,myc-ya15xc-t   # MYIR MYC-YA15XC-T STM32MP15X SoM
+          - enum:
+              - st,stm32mp151
+
       - description: Octavo OSD32MP15x System-in-Package based boards
         items:
           - enum:
Signature · 1 line
2.39.1
#1 lore raw

PATCH v2 2/2 ARM: dts: stm32: Add MyirTech MYD-YA15XC-T development board support

Add support for the MyirTech MYD-YA15XC-T development board.

General features:
- STM32MP151C
- 256MB RAM
- 2xUSB HOST
- USB-C OTG
- Gigabit ethernet
- UART
- Boot from NAND, eMMC, SD

---
 arch/arm/boot/dts/st/Makefile                 |   1 +
 .../dts/st/stm32mp151c-myir-myd-ya15xc-t.dts  | 460 ++++++++++++++++++
 .../dts/st/stm32mp15xc-myir-myc-ya15xc-t.dtsi | 349 +++++++++++++
 3 files changed, 810 insertions(+)
 create mode 100644 arch/arm/boot/dts/st/stm32mp151c-myir-myd-ya15xc-t.dts
 create mode 100644 arch/arm/boot/dts/st/stm32mp15xc-myir-myc-ya15xc-t.dtsi
arch/arm/boot/dts/st/Makefile +1 -0
index b3e9d29390e3..ddbca3f124dd 100644
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
 	stm32mp151a-prtt1c.dtb \
 	stm32mp151a-prtt1s.dtb \
 	stm32mp151a-dhcor-testbench.dtb \
+	stm32mp151c-myir-myd-ya15xc-t.dtb \
 	stm32mp153c-dhcom-drc02.dtb \
 	stm32mp153c-dhcor-drc-compact.dtb \
 	stm32mp157a-avenger96.dtb \
arch/arm/boot/dts/st/stm32mp151c-myir-myd-ya15xc-t.dts new file +460 -0

460 lines not on this page · raw message

arch/arm/boot/dts/st/stm32mp15xc-myir-myc-ya15xc-t.dtsi new file +349 -0

349 lines not on this page · raw message

Signature · 1 line
2.39.1
#2 lore raw
In reply to Alexander Shiyan
Quoted 12 lines · Alexander Shiyan

Add new entry for MYD-YA15XC-T development board.

---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +0 -0
index 4466b455bffa..1bde704bcd65 100644

Documentation/devicetree/bindings/arm/stm32/stm32.yaml properties: · line 146

Quoted 7 lines
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +4 -0
@@ -140,6 +140,13 @@ properties:
           - const: engicam,microgea-stm32mp1
           - const: st,stm32mp157
 
+      - description: MyirTech STM32MP15x SoM based Boards
+        items:
+          - const: myir,myd-ya15xc-t   # MYIR MYD-YA15XC-T STM32MP151C
+          - const: myir,myc-ya15xc-t   # MYIR MYC-YA15XC-T STM32MP15X SoM

I don't think you can have one compatible for all of them. The 153 and 157 variants differ by number of CANs, which are probably enabled in your board DTS?

Also, I cannot find ordering of 153 and 157 variants:
https://www.myirtech.com/list.asp?id=658
so I wonder if they have actually same part numbers.

Documentation/devicetree/bindings/arm/stm32/stm32.yaml properties: · line 148

Quoted 2 lines
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +2 -0
+          - enum:
+              - st,stm32mp151

This is highly unusual syntax - I think no other binding in Linux kernel uses it. It is correct and I understand why you did it, just might confuse others as we usually NAK it. I think less confusing would be to have here const (with the price of duplicating this per variant).

Best regards,
Krzysztof