drm: ci: fixes
Subsystems (11)
Vignesh Raman
maintainerv2 cover drm: ci: fixes
The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. This series is intended for drm branch topic/drm-ci.
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources
- Reworded the commit message for enabling jobs
- Added a new patch in the series to use scripts/config to enable/disable configs
Vignesh Raman (7):
drm: ci: igt_runner: remove todo
drm: ci: Force db410c to host mode
drm: ci: virtio: update ci variables
drm: ci: Enable configs to fix mt8173 boot hang issue
drm: ci: Update xfails
drm: ci: Enable new jobs
drm: ci: Use scripts/config to enable/disable configs
drivers/gpu/drm/ci/arm64.config | 2 ++ drivers/gpu/drm/ci/build.sh | 19 ++++++++++++------- .../ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- drivers/gpu/drm/ci/igt_runner.sh | 1 - drivers/gpu/drm/ci/test.yml | 14 ++++---------- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 1 - drivers/gpu/drm/ci/xfails/i915-cml-fails.txt | 1 - drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt | 2 ++ drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt | 1 + .../drm/ci/xfails/mediatek-mt8173-fails.txt | 2 -- .../drm/ci/xfails/mediatek-mt8173-flakes.txt | 16 ++++++++++++++++ .../gpu/drm/ci/xfails/msm-apq8016-flakes.txt | 2 ++ .../drm/ci/xfails/rockchip-rk3288-flakes.txt | 1 + .../drm/ci/xfails/rockchip-rk3399-fails.txt | 4 ++-- .../drm/ci/xfails/rockchip-rk3399-flakes.txt | 3 +++ 16 files changed, 59 insertions(+), 25 deletions(-) create mode 100644 drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 1/7 drm: ci: igt_runner: remove todo
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver. We do not test non-atomic drivers, so remove the todo.
---
v2:
- No changes
--- drivers/gpu/drm/ci/igt_runner.sh | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/ci/igt_runner.sh +0 -1
@@ -15,7 +15,6 @@ cat /sys/kernel/debug/device_component/* ' # Dump drm state to confirm that kernel was able to find a connected display: -# TODO this path might not exist for all drivers.. maybe run modetest instead? set +e cat /sys/kernel/debug/dri/*/state set -e
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 2/7 drm: ci: Force db410c to host mode
In reply to Vignesh RamanForce db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8
Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources
--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts
drivers/gpu/drm/ci/build.sh +5 -0
@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fi
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +13 -0
@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host"; + }; + }; + }; +};
Signature · 1 line
2.40.1
Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 56 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +13
-1@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host"; + }; + }; + }; +}; --
Quoted 1 line
2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
Signature · 2 lines
With best wishes Dmitry
Maxime Ripard
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Hi,
Quoted 52 lines · Dmitry Baryshkov
Quoted 51 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +9
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host";
Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +4
-1+ }; + }; + }; +}; --2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
What Dmitry is hinting about is to use the "Sugar Syntax". There a good documentation here:
https://source.android.com/docs/core/architecture/dto/syntax
Maxime
Vignesh Raman
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Hi Dmitry, Maxime,
Quoted 64 lines · Maxime Ripard
Hi,
Quoted 52 lines · Dmitry Baryshkov
Quoted 51 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +9
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host";Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +4
-1+ }; + }; + }; +}; --2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
Quoted 2 lines
What Dmitry is hinting about is to use the "Sugar Syntax". There a good documentation here:
https://source.android.com/docs/core/architecture/dto/syntax
With the below DTO syntax,
/dts-v1/;
/plugin/;
&usb {
usb@78d9000 {
dr_mode = "host"; };
};
Decoded dtbo file is,
/dts-v1/;
/ {
fragment@0 {
target = <0xffffffff>;
__overlay__ {
usb@78d9000 {
dr_mode = "host";
};
};
};
__fixups__ {
usb = "/fragment@0:target:0";
};
};With the previous fix using fragment we get,
/ {
fragment@0 {
target-path = "/soc@0";
__overlay__ {
usb@78d9000 {
dr_mode = "host";
};
};
};
};Decoded apq8016-sbc.dtb file with the fix (setting dr_mode to host) is, /dts-v1/;
/ {
soc@0 {
usb@78d9000 {
dr_mode = "host";
};
};
};How can set the target to "soc@0" using the DTO syntax? Otherwise fdtoverlay fails to apply the dtbo file with the base dtb.
Regards,
Vignesh
Maxime Ripard
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 127 lines · Vignesh Raman
Hi Dmitry, Maxime,
Quoted 64 lines · Maxime Ripard
Hi,
Quoted 52 lines · Dmitry Baryshkov
Quoted 51 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +9
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host";Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +4
-1+ }; + }; + }; +}; --2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
Quoted 2 lines
What Dmitry is hinting about is to use the "Sugar Syntax". There a good documentation here:
https://source.android.com/docs/core/architecture/dto/syntaxWith the below DTO syntax,
/dts-v1/;
/plugin/;&usb {
usb@78d9000 { dr_mode = "host";};
};Decoded dtbo file is,
/dts-v1/;/ {
fragment@0 { target = <0xffffffff>; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; __fixups__ { usb = "/fragment@0:target:0"; }; };With the previous fix using fragment we get,
/ {fragment@0 { target-path = "/soc@0"; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; };Decoded apq8016-sbc.dtb file with the fix (setting
dr_modeto host) is, /dts-v1/;/ { soc@0 { usb@78d9000 { dr_mode = "host"; }; }; };
Quoted 1 line
How can set the target to "soc@0" using the DTO syntax?
To strictly answer your question, that would be something like
&{/soc@0} {
usb@78d9000 {
dr_mode = "host";
};
};You can simplify this further however by doing:
&{/soc@0/usb@78d9000} {
dr_mode = "host";
};Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322
So you can end up with
&usb {
dr_mode = "host";
};All of them should be equivalent to the one you had in your patch.
Maxime
Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 146 lines · Maxime Ripard
Quoted 127 lines · Vignesh Raman
Hi Dmitry, Maxime,
Quoted 64 lines · Maxime Ripard
Hi,
Quoted 52 lines · Dmitry Baryshkov
Quoted 51 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +9
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host";Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +4
-1+ }; + }; + }; +}; --2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
Quoted 2 lines
What Dmitry is hinting about is to use the "Sugar Syntax". There a good documentation here:
https://source.android.com/docs/core/architecture/dto/syntaxWith the below DTO syntax,
/dts-v1/;
/plugin/;&usb {
usb@78d9000 { dr_mode = "host";};
};Decoded dtbo file is,
/dts-v1/;/ {
fragment@0 { target = <0xffffffff>; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; __fixups__ { usb = "/fragment@0:target:0"; }; };With the previous fix using fragment we get,
/ {fragment@0 { target-path = "/soc@0"; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; };Decoded apq8016-sbc.dtb file with the fix (setting
dr_modeto host) is, /dts-v1/;/ { soc@0 { usb@78d9000 { dr_mode = "host"; }; }; };Quoted 1 line
How can set the target to "soc@0" using the DTO syntax?
To strictly answer your question, that would be something like
&{/soc@0} { usb@78d9000 { dr_mode = "host"; }; };You can simplify this further however by doing:
&{/soc@0/usb@78d9000} { dr_mode = "host"; };
Quoted 8 lines
Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322So you can end up with
&usb { dr_mode = "host"; };
... which is the simplest and thus more robust one.
Quoted 3 lines
All of them should be equivalent to the one you had in your patch.
Maxime
Signature · 2 lines
With best wishes Dmitry
Vignesh Raman
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Hi,
Quoted 140 lines · Dmitry Baryshkov
Quoted 139 lines · Maxime Ripard
Quoted 127 lines · Vignesh Raman
Hi Dmitry, Maxime,
Quoted 64 lines · Maxime Ripard
Hi,
Quoted 52 lines · Dmitry Baryshkov
Quoted 51 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +9
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host";Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +4
-1+ }; + }; + }; +}; --2.40.1
Can we use normal dtso syntax here instead of defining fragments manually?
Quoted 2 lines
What Dmitry is hinting about is to use the "Sugar Syntax". There a good documentation here:
https://source.android.com/docs/core/architecture/dto/syntaxWith the below DTO syntax,
/dts-v1/;
/plugin/;&usb { usb@78d9000 { dr_mode = "host"; }; };Decoded dtbo file is,
/dts-v1/;/ {
fragment@0 { target = <0xffffffff>; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; __fixups__ { usb = "/fragment@0:target:0"; }; };With the previous fix using fragment we get,
/ {fragment@0 { target-path = "/soc@0"; __overlay__ { usb@78d9000 { dr_mode = "host"; }; }; }; };Decoded apq8016-sbc.dtb file with the fix (setting
dr_modeto host) is, /dts-v1/;/ { soc@0 { usb@78d9000 { dr_mode = "host"; }; }; };Quoted 1 line
How can set the target to "soc@0" using the DTO syntax?
To strictly answer your question, that would be something like
&{/soc@0} { usb@78d9000 { dr_mode = "host"; }; };
Quoted 6 lines
Quoted 6 lines
You can simplify this further however by doing:
&{/soc@0/usb@78d9000} { dr_mode = "host"; };
The above works. Thanks.
Quoted 4 lines
Quoted 4 lines
Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322
Quoted 8 lines
Quoted 5 lines
So you can end up with
&usb { dr_mode = "host"; };... which is the simplest and thus more robust one.
Should it be,
&{/soc@0/usb} {
dr_mode = "host";
};I will send a v3 version for this. Thank you.
Regards,
Vignesh
Maxime Ripard
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 9 lines · Vignesh Raman
Quoted 9 lines
Quoted 8 lines
Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322So you can end up with
&usb { dr_mode = "host"; };
Quoted 7 lines
Quoted 2 lines
... which is the simplest and thus more robust one.
Should it be,
&{/soc@0/usb} { dr_mode = "host"; };
No. The &{/...} syntax refers to a path. &... refers to a label. They are not equivalent.
Maxime
Vignesh Raman
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Hi Maxime,
Quoted 13 lines · Maxime Ripard
Quoted 12 lines · Vignesh Raman
Quoted 11 lines
Quoted 8 lines
Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322So you can end up with
&usb { dr_mode = "host"; };... which is the simplest and thus more robust one.
Quoted 7 lines
Quoted 4 lines
Should it be,
&{/soc@0/usb} { dr_mode = "host"; };No. The &{/...} syntax refers to a path. &... refers to a label. They are not equivalent.
Sorry I was not clear before.
With,
&usb {
dr_mode = "host";
};The target is <0xffffffff> and fdtoverlay fails to apply the dtbo.
With,
&{/soc@0/usb} {
dr_mode = "host";
};The target-path is "/soc@0/usb" (usb: usb@78d9000)
/ {
fragment@0 {
target-path = "/soc@0/usb";
__overlay__ {
dr_mode = "host";
};
};
};So will use &{/...} syntax in this case.
Regards,
Vignesh
Maxime Ripard
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 24 lines · Vignesh Raman
Hi Maxime,
Quoted 13 lines · Maxime Ripard
Quoted 12 lines · Vignesh Raman
Quoted 11 lines
Quoted 8 lines
Also, that node actually has a label ("usb"), defined here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi#n2322So you can end up with
&usb { dr_mode = "host"; };... which is the simplest and thus more robust one.
Quoted 7 lines
Quoted 4 lines
Should it be,
&{/soc@0/usb} { dr_mode = "host"; };No. The &{/...} syntax refers to a path. &... refers to a label. They are not equivalent.
Quoted 8 lines
Sorry I was not clear before.
With,
&usb { dr_mode = "host"; };The target is <
0xffffffff> and fdtoverlay fails to apply the dtbo.
You do have /plugin/ and have compiled the base device tree with overlay support, right?
Quoted 6 lines
With,
&{/soc@0/usb} { dr_mode = "host"; };The target-path is "/soc@0/usb" (usb: usb@78d9000)
Right, and that's not the path you want to modify. The path you want to modify is /soc@0/usb@78d9000. usb is the label, it's absolute, and you can't mix and match a path ("/soc@0/") and a label ("usb")
Maxime
Vignesh Raman
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Hi Maxime,
Quoted 9 lines · Maxime Ripard
Quoted 6 lines
With,
&usb { dr_mode = "host"; };The target is <
0xffffffff> and fdtoverlay fails to apply the dtbo.You do have /plugin/ and have compiled the base device tree with overlay support, right?
After compiling base dtbs with overlay support (make DTC_FLAGS=-@ dtbs) it works.
Quoted 11 lines
Quoted 7 lines
With,
&{/soc@0/usb} { dr_mode = "host"; };The target-path is "/soc@0/usb" (usb: usb@78d9000)
Right, and that's not the path you want to modify. The path you want to modify is /soc@0/usb@78d9000. usb is the label, it's absolute, and you can't mix and match a path ("/soc@0/") and a label ("usb")
Thanks for the clarification.
Regards,
Vignesh
Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode
In reply to Vignesh RamanHi!
Quoted 44 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +3
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; +
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts line 13
Quoted 10 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +10
-0+/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host"; + }; + }; + }; +};
Another thing that I was discussing with David and Vignesh, since we will need this overlay spinets not only for drm-ci but also for mesa ci (and every body who uses the farms), would it be interesting to move it to some place more official? like dts folders? Or would that be against Linux policy?
Regards,
Helen
Maxime Ripard
maintainerRe: [PATCH v2 2/7] drm: ci: Force db410c to host mode
Quoted 53 lines · Helen Koike
Hi!
Quoted 50 lines · Vignesh Raman
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8Use fdtoverlay command to merge base device tree with an overlay which contains the fix for USB controllers to work in host mode.
Signed-off-by Vignesh Raman <[email protected]>---
v2:
- Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying the kernel sources--- drivers/gpu/drm/ci/build.sh | 5 +++++ .../gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts | 13 +++++++++++++ 2 files changed, 18 insertions(+)create mode 100644
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtsdrivers/gpu/drm/ci/build.sh +5
-0@@ -92,6 +92,11 @@ done if [[ -n ${DEVICE_TREES} ]]; then make dtbs + if [[ -e arch/arm64/boot/dts/qcom/apq8016-sbc.dtb ]]; then + dtc -@ -I dts -O dtb -o drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts + fdtoverlay -i arch/arm64/boot/dts/qcom/apq8016-sbc.dtb -o arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dtbo + mv arch/arm64/boot/dts/qcom/apq8016-sbc-overlay.dtb arch/arm64/boot/dts/qcom/apq8016-sbc.dtb + fi cp ${DEVICE_TREES} /lava-files/. fidrivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +12
-0@@ -0,0 +1,13 @@ +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path = "/soc@0"; + __overlay__ { + usb@78d9000 { + dr_mode = "host"; + }; + }; + };
Quoted 8 lines
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts line 13
Quoted 1 line
drivers/gpu/drm/ci/dt-overlays/apq8016-sbc-overlay.dts new file +1
-0+};Another thing that I was discussing with David and Vignesh, since we will need this overlay spinets not only for drm-ci but also for mesa ci (and every body who uses the farms), would it be interesting to move it to some place more official? like dts folders? Or would that be against Linux policy?
AFAIK, the policy was changed recently to allow overlays to be merged, see $(find arch/ -name *.dtso). So generally speaking, it should be ok to send it.
Maxime
Vignesh Raman
maintainerPATCH v2 3/7 drm: ci: virtio: update ci variables
In reply to Vignesh RamanUpdate ci variables to fix the below error,
ERROR - Igt error: malloc(): corrupted top size
ERROR - Igt error: Received signal SIGABRT.
ERROR - Igt error: Stack trace:
ERROR - Igt error: #0 [fatal_sig_handler+0x17b]
---
v2:
- No changes
--- drivers/gpu/drm/ci/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/ci/test.yml +4 -1
@@ -316,8 +316,11 @@ virtio_gpu:none: stage: virtio-gpu variables: CROSVM_GALLIUM_DRIVER: llvmpipe - DRIVER_NAME: virtio_gpu + DRIVER_NAME: virtio GPU_VERSION: none + CROSVM_MEMORY: 12288 + CROSVM_CPU: $FDO_CI_CONCURRENT + CROSVM_GPU_ARGS: "vulkan=true,gles=false,backend=virglrenderer,egl=true,surfaceless=true" extends: - .test-gl tags:
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 4/7 drm: ci: Enable configs to fix mt8173 boot hang issue
In reply to Vignesh RamanEnable regulator
Enable MT6397 RTC driver
---
v2:
- No changes
--- drivers/gpu/drm/ci/arm64.config | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/ci/arm64.config +2 -0
@@ -184,6 +184,8 @@ CONFIG_HW_RANDOM_MTK=y CONFIG_MTK_DEVAPC=y CONFIG_PWM_MTK_DISP=y CONFIG_MTK_CMDQ=y +CONFIG_REGULATOR_DA9211=y +CONFIG_RTC_DRV_MT6397=y # For nouveau. Note that DRM must be a module so that it's loaded after NFS is up to provide the firmware. CONFIG_ARCH_TEGRA=y
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 5/7 drm: ci: Update xfails
In reply to Vignesh RamanUpdate amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files.
Add tests that fail sometimes into the *-flakes file and tests that are failing into the *-fails file.
---
v2:
- No changes
--- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 1 - drivers/gpu/drm/ci/xfails/i915-cml-fails.txt | 1 - drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt | 2 ++ drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt | 1 + .../gpu/drm/ci/xfails/mediatek-mt8173-fails.txt | 2 -- .../gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt | 16 ++++++++++++++++ drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt | 2 ++ .../gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt | 1 + .../gpu/drm/ci/xfails/rockchip-rk3399-fails.txt | 4 ++-- .../gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt | 3 +++ 10 files changed, 27 insertions(+), 6 deletions(-)
drivers/gpu/drm/ci/xfails/amdgpu-stoney-fails.txt +0 -1
@@ -1,7 +1,6 @@ kms_addfb_basic@bad-pitch-65536,Fail kms_addfb_basic@bo-too-small,Fail kms_async_flips@invalid-async-flip,Fail -kms_atomic@plane-immutable-zpos,Fail kms_atomic_transition@plane-toggle-modeset-transition,Fail kms_bw@linear-tiling-1-displays-2560x1440p,Fail kms_bw@linear-tiling-1-displays-3840x2160p,Fail
drivers/gpu/drm/ci/xfails/i915-cml-fails.txt +0 -1
@@ -1,4 +1,3 @@ -kms_color@ctm-0-25,Fail kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling,Fail kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling,Fail kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling,Fail
drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt +2 -0
@@ -7,6 +7,8 @@ kms_bw@linear-tiling-3-displays-3840x2160p kms_bw@linear-tiling-4-displays-1920x1080p kms_bw@linear-tiling-4-displays-2560x1440p kms_bw@linear-tiling-4-displays-3840x2160p +kms_color@ctm-0-25 +kms_cursor_legacy@torture-move kms_draw_crc@draw-method-xrgb8888-render-xtiled kms_flip@flip-vs-suspend kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling
drivers/gpu/drm/ci/xfails/i915-glk-flakes.txt +1 -0
@@ -8,6 +8,7 @@ kms_bw@linear-tiling-3-displays-3840x2160p kms_bw@linear-tiling-4-displays-1920x1080p kms_bw@linear-tiling-4-displays-2560x1440p kms_bw@linear-tiling-4-displays-3840x2160p +kms_cursor_legacy@torture-bo kms_flip@blocking-wf_vblank kms_flip@wf_vblank-ts-check kms_flip@wf_vblank-ts-check-interruptible
drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt +0 -2
@@ -1,5 +1,4 @@ kms_3d,Fail -kms_addfb_basic@addfb25-bad-modifier,Fail kms_bw@linear-tiling-1-displays-1920x1080p,Fail kms_bw@linear-tiling-1-displays-2560x1440p,Fail kms_bw@linear-tiling-1-displays-3840x2160p,Fail
@@ -11,7 +10,6 @@ kms_bw@linear-tiling-3-displays-2560x1440p,Fail kms_bw@linear-tiling-3-displays-3840x2160p,Fail kms_color@pipe-A-invalid-gamma-lut-sizes,Fail kms_color@pipe-B-invalid-gamma-lut-sizes,Fail -kms_force_connector_basic@force-connector-state,Fail kms_force_connector_basic@force-edid,Fail kms_force_connector_basic@force-load-detect,Fail kms_force_connector_basic@prune-stale-modes,Fail
drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt +16 -0
@@ -0,0 +1,16 @@ +core_setmaster_vs_auth +kms_addfb_basic@addfb25-bad-modifier +kms_color@invalid-gamma-lut-sizes +kms_cursor_legacy@cursor-vs-flip-atomic +kms_cursor_legacy@cursor-vs-flip-legacy +kms_force_connector_basic@force-connector-state +kms_hdmi_inject@inject-4k +kms_plane_scaling@plane-scaler-with-pixel-format-unity-scaling +kms_plane_scaling@plane-upscale-with-modifiers-20x20 +kms_plane_scaling@plane-upscale-with-pixel-format-20x20 +kms_plane_scaling@plane-upscale-with-rotation-20x20 +kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20 +kms_plane_scaling@planes-downscale-factor-0-5-upscale-20x20 +kms_plane_scaling@planes-downscale-factor-0-75-upscale-20x20 +kms_prop_blob@invalid-set-prop +kms_prop_blob@invalid-set-prop-any
drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt +2 -0
@@ -1,3 +1,5 @@ +kms_cursor_legacy@forked-bo +kms_cursor_legacy@forked-move kms_force_connector_basic@force-connector-state kms_force_connector_basic@force-edid kms_force_connector_basic@force-load-detect
drivers/gpu/drm/ci/xfails/rockchip-rk3288-flakes.txt +1 -0
@@ -1,6 +1,7 @@ kms_addfb_basic@addfb25-bad-modifier kms_cursor_crc@.* kms_flip@basic-flip-vs-wf_vblank +kms_flip@blocking-wf_vblank kms_invalid_mode@int-max-clock,Crash kms_pipe_crc_basic@.* kms_properties@connector-properties-atomic,Crash
drivers/gpu/drm/ci/xfails/rockchip-rk3399-fails.txt +2 -2
@@ -2,14 +2,13 @@ kms_color@legacy-gamma,Fail kms_color@pipe-A-legacy-gamma,Fail kms_color@pipe-B-legacy-gamma,Fail kms_flip@basic-flip-vs-wf_vblank,Fail -kms_flip@blocking-wf_vblank,Fail kms_flip@dpms-vs-vblank-race,Fail kms_flip@flip-vs-absolute-wf_vblank,Fail kms_flip@flip-vs-absolute-wf_vblank-interruptible,Fail kms_flip@flip-vs-blocking-wf-vblank,Fail kms_flip@flip-vs-panning,Fail kms_flip@flip-vs-panning-interruptible,Fail -kms_flip@flip-vs-wf_vblank-interruptible,Fail +kms_flip@modeset-vs-vblank-race,Fail kms_flip@plain-flip-fb-recreate,Fail kms_flip@plain-flip-fb-recreate-interruptible,Fail kms_flip@plain-flip-ts-check,Fail
@@ -35,3 +34,4 @@ kms_plane_multiple@atomic-pipe-B-tiling-none,Fail kms_plane_multiple@tiling-none,Fail kms_prime@basic-crc,Fail kms_rmfb@close-fd,Fail +kms_universal_plane@universal-plane-pipe-B-functional,Fail
drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt +3 -0
@@ -1,7 +1,10 @@ +kms_color@gamma kms_cursor_crc@.* +kms_flip@blocking-wf_vblank kms_flip@dpms-vs-vblank-race-interruptible kms_flip@flip-vs-expired-vblank +kms_flip@flip-vs-wf_vblank-interruptible kms_flip@modeset-vs-vblank-race-interruptible kms_pipe_crc_basic@.* kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-A
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 6/7 drm: ci: Enable new jobs
In reply to Vignesh RamanEnable the following jobs, as the issues noted in the TODO comments have been resolved. This will ensure that these jobs are now included and executed as part of the CI/CD pipeline.
msm:apq8016:
TODO: current issue: it is not fiding the NFS root. Fix and remove this rule.
mediatek:mt8173:
TODO: current issue: device is hanging. Fix and remove this rule.
virtio_gpu:none:
TODO: current issue: malloc(): corrupted top size. Fix and remove this rule.
---
v2:
- Reworded the commit message
--- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- drivers/gpu/drm/ci/test.yml | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/ci/gitlab-ci.yml +1 -1
@@ -248,4 +248,4 @@ sanity: # Jobs that need to pass before spending hardware resources on further testing .required-for-hardware-jobs: - needs: [] + needs: []
drivers/gpu/drm/ci/test.yml +0 -9
@@ -108,9 +108,6 @@ msm:apq8016: RUNNER_TAG: google-freedreno-db410c script: - ./install/bare-metal/fastboot.sh - rules: - # TODO: current issue: it is not fiding the NFS root. Fix and remove this rule. - - when: never msm:apq8096: extends:
@@ -273,9 +270,6 @@ mediatek:mt8173: DEVICE_TYPE: mt8173-elm-hana GPU_VERSION: mt8173 RUNNER_TAG: mesa-ci-x86-64-lava-mt8173-elm-hana - rules: - # TODO: current issue: device is hanging. Fix and remove this rule. - - when: never mediatek:mt8183: extends:
@@ -333,6 +327,3 @@ virtio_gpu:none: - debian/x86_64_test-gl - testing:x86_64 - igt:x86_64 - rules: - # TODO: current issue: malloc(): corrupted top size. Fix and remove this rule. - - when: never
Signature · 1 line
2.40.1
Vignesh Raman
maintainerPATCH v2 7/7 drm: ci: Use scripts/config to enable/disable configs
In reply to Vignesh RamanInstead of modifying files in git to enable/disable configs, use scripts/config on the .config file which will be used for building the kernel.
---
v2:
- Added a new patch in the series to use scripts/config to enable/disable configs
--- drivers/gpu/drm/ci/build.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/ci/build.sh +7 -7
@@ -70,19 +70,19 @@ if [ -z "$CI_MERGE_REQUEST_PROJECT_PATH" ]; then fi fi -for opt in $ENABLE_KCONFIGS; do - echo CONFIG_$opt=y >> drivers/gpu/drm/ci/${KERNEL_ARCH}.config -done -for opt in $DISABLE_KCONFIGS; do - echo CONFIG_$opt=n >> drivers/gpu/drm/ci/${KERNEL_ARCH}.config -done - if [[ -n "${MERGE_FRAGMENT}" ]]; then ./scripts/kconfig/merge_config.sh ${DEFCONFIG} drivers/gpu/drm/ci/${MERGE_FRAGMENT} else make `basename ${DEFCONFIG}` fi +for opt in $ENABLE_KCONFIGS; do + ./scripts/config --enable CONFIG_$opt +done +for opt in $DISABLE_KCONFIGS; do + ./scripts/config --disable CONFIG_$opt +done + make ${KERNEL_IMAGE_NAME} mkdir -p /lava-files/
Signature · 1 line
2.40.1