Skip to contentSkip to conversation

dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible

PATCH Applied Andrew Davis 4 participants 7 messages Sep 11, 2023 – Sep 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible

Add TI DSS OLDI-IO control registers compatible. This is a region of 5 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They are used to control the characteristics of the OLDI DATA/CLK IO as needed by the DSS display controller node.

[0] https://www.ti.com/lit/pdf/spruid7

---

Changes for v2:
- Use device specific compatible string

 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 8103154bbb529..ab7e26c3469af 100644
@@ -69,6 +69,7 @@ properties:
               - rockchip,rk3588-qos
               - rockchip,rv1126-qos
               - starfive,jh7100-sysmain
+              - ti,am654-dss-oldi-io-ctrl
 
           - const: syscon
 
Signature · 7 lines
2.39.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH v2 2/2 arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node

This matches the binding for this register region which fixes a couple DTS check warnings.

While here trim the leading 0s from the "reg" definition.

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index bc460033a37a8..d5f217427893d 100644
@@ -498,8 +498,8 @@ serdes_mux: mux-controller {
 		};
 
 		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
-			compatible = "syscon";
-			reg = <0x000041e0 0x14>;
+			compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
+			reg = <0x41e0 0x14>;
 		};
 
 		ehrpwm_tbclk: clock-controller@4140 {
Signature · 7 lines
2.39.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node

Quoted 6 lines · Andrew Davis

This matches the binding for this register region which fixes a couple DTS check warnings.

While here trim the leading 0s from the "reg" definition.

For both the patches, 1/2 and 2/2,

Quoted 19 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index bc460033a37a8..d5f217427893d 100644
@@ -498,8 +498,8 @@ serdes_mux: mux-controller {
 		};
 
 		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
-			compatible = "syscon";
-			reg = <0x000041e0 0x14>;
+			compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
+			reg = <0x41e0 0x14>;
 		};
 
 		ehrpwm_tbclk: clock-controller@4140 {
maintainer
#3 lore raw

Re: [PATCH v2 2/2] arm64: dts: ti: k3-am65: Add full compatible to dss-oldi-io-ctrl node

Quoted 11 lines · Aradhya Bhatia
Quoted 6 lines · Andrew Davis

This matches the binding for this register region which fixes a couple DTS check warnings.

While here trim the leading 0s from the "reg" definition.

For both the patches, 1/2 and 2/2,

If you want to Ack both patches, you have to Ack both patches.

Quoted 21 lines
Quoted 19 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index bc460033a37a8..d5f217427893d 100644
@@ -498,8 +498,8 @@ serdes_mux: mux-controller {
 		};
 
 		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
-			compatible = "syscon";
-			reg = <0x000041e0 0x14>;
+			compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
+			reg = <0x41e0 0x14>;
 		};
 
 		ehrpwm_tbclk: clock-controller@4140 {
Signature · 1 line
Lee Jones [李琼斯]
Acked-by on v2 1/2
#4 lore raw
In reply to Andrew Davis
Quoted 10 lines · Andrew Davis

Add TI DSS OLDI-IO control registers compatible. This is a region of 5 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They are used to control the characteristics of the OLDI DATA/CLK IO as needed by the DSS display controller node.

[0] https://www.ti.com/lit/pdf/spruid7

---

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 1/2
#5 lore raw
In reply to Andrew Davis
Quoted 8 lines · Andrew Davis

Add TI DSS OLDI-IO control registers compatible. This is a region of 5 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They are used to control the characteristics of the OLDI DATA/CLK IO as needed by the DSS display controller node.

[0] https://www.ti.com/lit/pdf/spruid7

Quoted 20 lines

---

Changes for v2:
- Use device specific compatible string

 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index 8103154bbb529..ab7e26c3469af 100644
@@ -69,6 +69,7 @@ properties:
               - rockchip,rk3588-qos
               - rockchip,rv1126-qos
               - starfive,jh7100-sysmain
+              - ti,am654-dss-oldi-io-ctrl
 
           - const: syscon
 
maintainer Applied
#6 lore raw

Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible

In reply to Andrew Davis
Quoted 8 lines · Andrew Davis

Add TI DSS OLDI-IO control registers compatible. This is a region of 5 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They are used to control the characteristics of the OLDI DATA/CLK IO as needed by the DSS display controller node.

[0] https://www.ti.com/lit/pdf/spruid7

[...]

Applied, thanks!

[1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible

      commit: 9cfffe6a730feea95e7bc827537f5b0a2931171c

--
Lee Jones [李琼斯]