board: phytec: am62x: Add PHYTEC phyCORE-AM62x SoM
Subsystems (2)
PATCH 1/2 board: phytec: am62x: Add PHYTEC phyCORE-AM62x SoM
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UART
Product page SoM: https://www.phytec.com/product/phycore-am62x
--- arch/arm/dts/Makefile | 4 +- .../arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am62-phycore-som.dtsi | 324 +++ .../k3-am625-phyboard-lyra-rdk-u-boot.dtsi | 229 ++ arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 266 ++ arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 532 ++++ arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts | 134 + arch/arm/mach-k3/Kconfig | 1 + board/phytec/phycore_am62x/Kconfig | 52 + board/phytec/phycore_am62x/MAINTAINERS | 15 + board/phytec/phycore_am62x/Makefile | 8 + board/phytec/phycore_am62x/board-cfg.yaml | 36 + board/phytec/phycore_am62x/phycore-am62x.c | 59 + board/phytec/phycore_am62x/phycore_am62x.env | 23 + board/phytec/phycore_am62x/pm-cfg.yaml | 12 + board/phytec/phycore_am62x/rm-cfg.yaml | 1088 ++++++++ board/phytec/phycore_am62x/sec-cfg.yaml | 379 +++ configs/phycore_am62x_a53_defconfig | 116 + configs/phycore_am62x_r5_defconfig | 131 + include/configs/phycore_am62x.h | 15 + 20 files changed, 5613 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi create mode 100644 arch/arm/dts/k3-am62-phycore-som.dtsi create mode 100644 arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts create mode 100644 arch/arm/dts/k3-am625-phycore-som-binman.dtsi create mode 100644 arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts create mode 100644 board/phytec/phycore_am62x/Kconfig create mode 100644 board/phytec/phycore_am62x/MAINTAINERS create mode 100644 board/phytec/phycore_am62x/Makefile create mode 100644 board/phytec/phycore_am62x/board-cfg.yaml create mode 100644 board/phytec/phycore_am62x/phycore-am62x.c create mode 100644 board/phytec/phycore_am62x/phycore_am62x.env create mode 100644 board/phytec/phycore_am62x/pm-cfg.yaml create mode 100644 board/phytec/phycore_am62x/rm-cfg.yaml create mode 100644 board/phytec/phycore_am62x/sec-cfg.yaml create mode 100644 configs/phycore_am62x_a53_defconfig create mode 100644 configs/phycore_am62x_r5_defconfig create mode 100644 include/configs/phycore_am62x.h
arch/arm/dts/Makefile +3 -1
@@ -1383,7 +1383,9 @@ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-beagleplay.dtb \ k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ - k3-am625-verdin-r5.dtb + k3-am625-verdin-r5.dtb \ + k3-am625-phyboard-lyra-rdk.dtb \ + k3-am625-r5-phycore-som-2gb.dtb dtb-$(CONFIG_SOC_K3_AM62A7) += k3-am62a7-sk.dtb \ k3-am62a7-r5-sk.dtb
arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi new file +2190 -0
2,190 lines not on this page · raw message
arch/arm/dts/k3-am62-phycore-som.dtsi new file +324 -0
324 lines not on this page · raw message
arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsi new file +229 -0
229 lines not on this page · raw message
arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts new file +266 -0
247 lines not on this page · raw message
arch/arm/dts/k3-am625-phycore-som-binman.dtsi new file +532 -0
532 lines not on this page · raw message
arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts new file +134 -0
134 lines not on this page · raw message
board/phytec/phycore_am62x/Kconfig new file +52 -0
52 lines not on this page · raw message
board/phytec/phycore_am62x/MAINTAINERS new file +15 -0
Lines of this file are not shown. View the raw message.
board/phytec/phycore_am62x/Makefile new file +8 -0
Lines of this file are not shown. View the raw message.
board/phytec/phycore_am62x/board-cfg.yaml new file +36 -0
Lines of this file are not shown. View the raw message.
board/phytec/phycore_am62x/phycore-am62x.c new file +59 -0
59 lines not on this page · raw message
board/phytec/phycore_am62x/phycore_am62x.env new file +23 -0
Lines of this file are not shown. View the raw message.
board/phytec/phycore_am62x/pm-cfg.yaml new file +12 -0
Lines of this file are not shown. View the raw message.
board/phytec/phycore_am62x/rm-cfg.yaml new file +1088 -0
1,088 lines not on this page · raw message
board/phytec/phycore_am62x/sec-cfg.yaml new file +379 -0
379 lines not on this page · raw message
configs/phycore_am62x_a53_defconfig new file +116 -0
116 lines not on this page · raw message
configs/phycore_am62x_r5_defconfig new file +131 -0
131 lines not on this page · raw message
include/configs/phycore_am62x.h new file +15 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.34.1
Part of the diff is not shown here. View the raw message.
PATCH 2/2 doc: board: phytec: Add phyCORE-AM62x
Add documentation for PHYTEC phyCORE-AM62x SoM.
--- doc/board/phytec/index.rst | 1 + doc/board/phytec/phycore-am62x.rst | 125 +++++++++++++++++++++++++++++ doc/board/ti/k3.rst | 1 + 3 files changed, 127 insertions(+) create mode 100644 doc/board/phytec/phycore-am62x.rst
doc/board/phytec/index.rst +1 -0
@@ -6,5 +6,6 @@ PHYTEC .. toctree:: :maxdepth: 2 + phycore-am62x phycore-imx8mm phycore-imx8mp
doc/board/phytec/phycore-am62x.rst new file +125 -0
125 lines not on this page · raw message
doc/board/ti/k3.rst +1 -0
@@ -32,6 +32,7 @@ K3 Based SoCs am62x_beagleplay am62x_sk + ../phytec/phycore-am62x ../toradex/verdin-am62 am64x_evm am65x_evm
Signature · 1 line
2.34.1
Hi,
Quoted 59 lines · Wadim Egorov
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UARTProduct page SoM: https://www.phytec.com/product/phycore-am62x
Signed-off-by Wadim Egorov <[email protected]>--- arch/arm/dts/Makefile | 4 +- .../arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am62-phycore-som.dtsi | 324 +++ .../k3-am625-phyboard-lyra-rdk-u-boot.dtsi | 229 ++ arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 266 ++ arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 532 ++++ arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts | 134 + arch/arm/mach-k3/Kconfig | 1 + board/phytec/phycore_am62x/Kconfig | 52 + board/phytec/phycore_am62x/MAINTAINERS | 15 + board/phytec/phycore_am62x/Makefile | 8 + board/phytec/phycore_am62x/board-cfg.yaml | 36 + board/phytec/phycore_am62x/phycore-am62x.c | 59 + board/phytec/phycore_am62x/phycore_am62x.env | 23 + board/phytec/phycore_am62x/pm-cfg.yaml | 12 + board/phytec/phycore_am62x/rm-cfg.yaml | 1088 ++++++++ board/phytec/phycore_am62x/sec-cfg.yaml | 379 +++ configs/phycore_am62x_a53_defconfig | 116 + configs/phycore_am62x_r5_defconfig | 131 + include/configs/phycore_am62x.h | 15 + 20 files changed, 5613 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi create mode 100644 arch/arm/dts/k3-am62-phycore-som.dtsi create mode 100644 arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts create mode 100644 arch/arm/dts/k3-am625-phycore-som-binman.dtsi create mode 100644 arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts create mode 100644 board/phytec/phycore_am62x/Kconfig create mode 100644 board/phytec/phycore_am62x/MAINTAINERS create mode 100644 board/phytec/phycore_am62x/Makefile create mode 100644 board/phytec/phycore_am62x/board-cfg.yaml create mode 100644 board/phytec/phycore_am62x/phycore-am62x.c create mode 100644 board/phytec/phycore_am62x/phycore_am62x.env create mode 100644 board/phytec/phycore_am62x/pm-cfg.yaml create mode 100644 board/phytec/phycore_am62x/rm-cfg.yaml create mode 100644 board/phytec/phycore_am62x/sec-cfg.yaml create mode 100644 configs/phycore_am62x_a53_defconfig create mode 100644 configs/phycore_am62x_r5_defconfig create mode 100644 include/configs/phycore_am62x.harch/arm/dts/Makefile +0
-0
arch/arm/dts/Makefile dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ · line 1388
Quoted 7 lines
arch/arm/dts/Makefile +3
-1@@ -1383,7 +1383,9 @@ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-beagleplay.dtb \ k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ - k3-am625-verdin-r5.dtb + k3-am625-verdin-r5.dtb \ + k3-am625-phyboard-lyra-rdk.dtb \ + k3-am625-r5-phycore-som-2gb.dtb
Thanks for upstreaming Wadim!
However I would prefer that you split all these patches into smaller chunks for each file (preferrably) or group together files that have like 20-30 lines of changes.
It's difficult to review thousands of lines of code at once, hope you understand.
Also would appreciate it if you sent the series with a cover letter summarising your changes. You can also attach boot logs or any additional info you may want the people reviewing/ testing the patches to know in the cover letter.
Quoted 3 lines
arch/arm/dts/Makefile +0
-0dtb-$(CONFIG_SOC_K3_AM62A7) += k3-am62a7-sk.dtb \ k3-am62a7-r5-sk.dtb
[..snip..]
Signature · 2 lines
Best regards, Dhruva Gole <[email protected]>
Hi Dhruva,
Am 01.11.23 um 16:57 schrieb Dhruva Gole:
Quoted 71 lines
Hi,
Quoted 59 lines · Wadim Egorov
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UARTProduct page SoM: https://www.phytec.com/product/phycore-am62x
Signed-off-by Wadim Egorov <[email protected]>--- arch/arm/dts/Makefile | 4 +- .../arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am62-phycore-som.dtsi | 324 +++ .../k3-am625-phyboard-lyra-rdk-u-boot.dtsi | 229 ++ arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 266 ++ arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 532 ++++ arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts | 134 + arch/arm/mach-k3/Kconfig | 1 + board/phytec/phycore_am62x/Kconfig | 52 + board/phytec/phycore_am62x/MAINTAINERS | 15 + board/phytec/phycore_am62x/Makefile | 8 + board/phytec/phycore_am62x/board-cfg.yaml | 36 + board/phytec/phycore_am62x/phycore-am62x.c | 59 + board/phytec/phycore_am62x/phycore_am62x.env | 23 + board/phytec/phycore_am62x/pm-cfg.yaml | 12 + board/phytec/phycore_am62x/rm-cfg.yaml | 1088 ++++++++ board/phytec/phycore_am62x/sec-cfg.yaml | 379 +++ configs/phycore_am62x_a53_defconfig | 116 + configs/phycore_am62x_r5_defconfig | 131 + include/configs/phycore_am62x.h | 15 + 20 files changed, 5613 insertions(+), 1 deletion(-)create mode 100644
arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsicreate mode 100644arch/arm/dts/k3-am62-phycore-som.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk.dtscreate mode 100644arch/arm/dts/k3-am625-phycore-som-binman.dtsicreate mode 100644arch/arm/dts/k3-am625-r5-phycore-som-2gb.dtscreate mode 100644 board/phytec/phycore_am62x/Kconfig create mode 100644 board/phytec/phycore_am62x/MAINTAINERS create mode 100644 board/phytec/phycore_am62x/Makefile create mode 100644board/phytec/phycore_am62x/board-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/phycore-am62x.ccreate mode 100644 board/phytec/phycore_am62x/phycore_am62x.env create mode 100644board/phytec/phycore_am62x/pm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/rm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/sec-cfg.yamlcreate mode 100644 configs/phycore_am62x_a53_defconfig create mode 100644 configs/phycore_am62x_r5_defconfig create mode 100644include/configs/phycore_am62x.harch/arm/dts/Makefile +0
-0arch/arm/dts/Makefile dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ · line 1388
Quoted 7 lines
arch/arm/dts/Makefile +3
-1@@ -1383,7 +1383,9 @@ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-beagleplay.dtb \ k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ - k3-am625-verdin-r5.dtb + k3-am625-verdin-r5.dtb \ + k3-am625-phyboard-lyra-rdk.dtb \ + k3-am625-r5-phycore-som-2gb.dtbThanks for upstreaming Wadim!
Quoted 3 lines
However I would prefer that you split all these patches into smaller chunks for each file (preferrably) or group together files that have like 20-30 lines of changes.
Hm, seems to be difficult and not really reasonable to split like that.
The big files are generated files or copy pasted from TI's evm. So I do not think they need a big attention in the review process.
- All yaml files are identical to TI's evm
- k3-am62-phycore-som-ddr4-2gb.dtsi generated with TI's SysConfig DDR Tool
- k3-am62-phycore-som.dtsi & k3-am625-phyboard-lyra-rdk.dts are 1:1 copies from vanilla Linux tree
The rest is pretty small and reviewable IMO.
I agree, I should have created a cover letter. I can do that in the next series.
Please let me know if you still want me to split it into more patches.
But it would be nice if you could tell me how to split it exactly without ending up with broken pieces.
Regards,
Wadim
Quoted 14 lines
It's difficult to review thousands of lines of code at once, hope you understand.
Also would appreciate it if you sent the series with a cover letter summarising your changes. You can also attach boot logs or any additional info you may want the people reviewing/ testing the patches to know in the cover letter.
Quoted 3 lines
arch/arm/dts/Makefile +0
-0dtb-$(CONFIG_SOC_K3_AM62A7) += k3-am62a7-sk.dtb \ k3-am62a7-r5-sk.dtb[..snip..]
Quoted 87 lines · Wadim Egorov
Hi Dhruva,
Am 01.11.23 um 16:57 schrieb Dhruva Gole:
Quoted 71 lines
Hi,
Quoted 59 lines · Wadim Egorov
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UARTProduct page SoM: https://www.phytec.com/product/phycore-am62x
Signed-off-by Wadim Egorov <[email protected]>--- arch/arm/dts/Makefile | 4 +- .../arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am62-phycore-som.dtsi | 324 +++ .../k3-am625-phyboard-lyra-rdk-u-boot.dtsi | 229 ++ arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 266 ++ arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 532 ++++ arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts | 134 + arch/arm/mach-k3/Kconfig | 1 + board/phytec/phycore_am62x/Kconfig | 52 + board/phytec/phycore_am62x/MAINTAINERS | 15 + board/phytec/phycore_am62x/Makefile | 8 + board/phytec/phycore_am62x/board-cfg.yaml | 36 + board/phytec/phycore_am62x/phycore-am62x.c | 59 + board/phytec/phycore_am62x/phycore_am62x.env | 23 + board/phytec/phycore_am62x/pm-cfg.yaml | 12 + board/phytec/phycore_am62x/rm-cfg.yaml | 1088 ++++++++ board/phytec/phycore_am62x/sec-cfg.yaml | 379 +++ configs/phycore_am62x_a53_defconfig | 116 + configs/phycore_am62x_r5_defconfig | 131 + include/configs/phycore_am62x.h | 15 + 20 files changed, 5613 insertions(+), 1 deletion(-)create mode 100644
arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsicreate mode 100644arch/arm/dts/k3-am62-phycore-som.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk.dtscreate mode 100644arch/arm/dts/k3-am625-phycore-som-binman.dtsicreate mode 100644arch/arm/dts/k3-am625-r5-phycore-som-2gb.dtscreate mode 100644 board/phytec/phycore_am62x/Kconfig create mode 100644 board/phytec/phycore_am62x/MAINTAINERS create mode 100644 board/phytec/phycore_am62x/Makefile create mode 100644board/phytec/phycore_am62x/board-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/phycore-am62x.ccreate mode 100644 board/phytec/phycore_am62x/phycore_am62x.env create mode 100644board/phytec/phycore_am62x/pm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/rm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/sec-cfg.yamlcreate mode 100644 configs/phycore_am62x_a53_defconfig create mode 100644 configs/phycore_am62x_r5_defconfig create mode 100644include/configs/phycore_am62x.harch/arm/dts/Makefile +0
-0arch/arm/dts/Makefile dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ · line 1388
Quoted 7 lines
arch/arm/dts/Makefile +3
-1@@ -1383,7 +1383,9 @@ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-beagleplay.dtb \ k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ - k3-am625-verdin-r5.dtb + k3-am625-verdin-r5.dtb \ + k3-am625-phyboard-lyra-rdk.dtb \ + k3-am625-r5-phycore-som-2gb.dtbThanks for upstreaming Wadim!
Quoted 3 lines
However I would prefer that you split all these patches into smaller chunks for each file (preferrably) or group together files that have like 20-30 lines of changes.
Hm, seems to be difficult and not really reasonable to split like that. The big files are generated files or copy pasted from TI's evm. So I do not think they need a big attention in the review process.
- All yaml files are identical to TI's evm
-k3-am62-phycore-som-ddr4-2gb.dtsigenerated with TI's SysConfig DDR Tool
-k3-am62-phycore-som.dtsi&k3-am625-phyboard-lyra-rdk.dtsare 1:1 copies from vanilla Linux tree
Quoted 8 lines
The rest is pretty small and reviewable IMO.
I agree, I should have created a cover letter. I can do that in the next series.
Please let me know if you still want me to split it into more patches. But it would be nice if you could tell me how to split it exactly without ending up with broken pieces.
Yes, I don't see the value in splitting this up further, but we do need to note where the upstream dts files are synced from.
Signature · 1 line
Tom
Am 02.11.23 um 00:21 schrieb Tom Rini:
Quoted 89 lines · Wadim Egorov
Quoted 88 lines
Hi Dhruva,
Am 01.11.23 um 16:57 schrieb Dhruva Gole:
Quoted 71 lines
Hi,
Quoted 59 lines · Wadim Egorov
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UARTProduct page SoM: https://www.phytec.com/product/phycore-am62x
Signed-off-by Wadim Egorov <[email protected]>--- arch/arm/dts/Makefile | 4 +- .../arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am62-phycore-som.dtsi | 324 +++ .../k3-am625-phyboard-lyra-rdk-u-boot.dtsi | 229 ++ arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 266 ++ arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 532 ++++ arch/arm/dts/k3-am625-r5-phycore-som-2gb.dts | 134 + arch/arm/mach-k3/Kconfig | 1 + board/phytec/phycore_am62x/Kconfig | 52 + board/phytec/phycore_am62x/MAINTAINERS | 15 + board/phytec/phycore_am62x/Makefile | 8 + board/phytec/phycore_am62x/board-cfg.yaml | 36 + board/phytec/phycore_am62x/phycore-am62x.c | 59 + board/phytec/phycore_am62x/phycore_am62x.env | 23 + board/phytec/phycore_am62x/pm-cfg.yaml | 12 + board/phytec/phycore_am62x/rm-cfg.yaml | 1088 ++++++++ board/phytec/phycore_am62x/sec-cfg.yaml | 379 +++ configs/phycore_am62x_a53_defconfig | 116 + configs/phycore_am62x_r5_defconfig | 131 + include/configs/phycore_am62x.h | 15 + 20 files changed, 5613 insertions(+), 1 deletion(-)create mode 100644
arch/arm/dts/k3-am62-phycore-som-ddr4-2gb.dtsicreate mode 100644arch/arm/dts/k3-am62-phycore-som.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk-u-boot.dtsicreate mode 100644arch/arm/dts/k3-am625-phyboard-lyra-rdk.dtscreate mode 100644arch/arm/dts/k3-am625-phycore-som-binman.dtsicreate mode 100644arch/arm/dts/k3-am625-r5-phycore-som-2gb.dtscreate mode 100644 board/phytec/phycore_am62x/Kconfig create mode 100644 board/phytec/phycore_am62x/MAINTAINERS create mode 100644 board/phytec/phycore_am62x/Makefile create mode 100644board/phytec/phycore_am62x/board-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/phycore-am62x.ccreate mode 100644 board/phytec/phycore_am62x/phycore_am62x.env create mode 100644board/phytec/phycore_am62x/pm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/rm-cfg.yamlcreate mode 100644board/phytec/phycore_am62x/sec-cfg.yamlcreate mode 100644 configs/phycore_am62x_a53_defconfig create mode 100644 configs/phycore_am62x_r5_defconfig create mode 100644include/configs/phycore_am62x.harch/arm/dts/Makefile +0
-0arch/arm/dts/Makefile dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ · line 1388
Quoted 7 lines
arch/arm/dts/Makefile +3
-1@@ -1383,7 +1383,9 @@ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-beagleplay.dtb \ k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ - k3-am625-verdin-r5.dtb + k3-am625-verdin-r5.dtb \ + k3-am625-phyboard-lyra-rdk.dtb \ + k3-am625-r5-phycore-som-2gb.dtbThanks for upstreaming Wadim!
Quoted 3 lines
However I would prefer that you split all these patches into smaller chunks for each file (preferrably) or group together files that have like 20-30 lines of changes.
Hm, seems to be difficult and not really reasonable to split like that. The big files are generated files or copy pasted from TI's evm. So I do not think they need a big attention in the review process.
- All yaml files are identical to TI's evm
-k3-am62-phycore-som-ddr4-2gb.dtsigenerated with TI's SysConfig DDR Tool
-k3-am62-phycore-som.dtsi&k3-am625-phyboard-lyra-rdk.dtsare 1:1 copies from vanilla Linux treeThe rest is pretty small and reviewable IMO.
Quoted 8 lines
Quoted 6 lines
I agree, I should have created a cover letter. I can do that in the next series.
Please let me know if you still want me to split it into more patches. But it would be nice if you could tell me how to split it exactly without ending up with broken pieces.
Yes, I don't see the value in splitting this up further, but we do need to note where the upstream dts files are synced from.
Took the devicetrees from linux v6.6-rc7. I can mention that in the commit message in a v2.
Quoted 10 lines · Wadim Egorov
Add basic support for PHYTEC phyCORE-AM62x SoM.
Supported features:
- 2GB DDR4 RAM
- eMMC Flash
- OSPI NOR Flash
- external uSD
- Ethernet
- debug UART
Quoted 3 lines
Product page SoM: https://www.phytec.com/product/phycore-am62x
Signed-off-by Wadim Egorov <[email protected]>
For clarity, please rebase this on top of current -next as there's been a number of updates just now for K3 SoCs in general, thanks.
Signature · 1 line
Tom