staging: vme_user: Fix misaligned closing comment */
PATCH 1/2 staging: vme_user: Fix misaligned closing comment */
This patch makes the following change:
* Ensures the trailing */ for comments is on the same line as the opening /*
--- drivers/staging/vme_user/vme_tsi148.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/vme_user/vme_tsi148.h +2 -4
@@ -691,8 +691,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,#define TSI148_LCSR_VMCTRL_RMWEN BIT(20)/* RMW Enable */ -#define TSI148_LCSR_VMCTRL_ATO_M (7 << 16)/* Master Access Time-out Mask -*/ +#define TSI148_LCSR_VMCTRL_ATO_M (7 << 16)/* Master Access Time-out Mask */ #define TSI148_LCSR_VMCTRL_ATO_32 (0 << 16)/* 32 us */ #define TSI148_LCSR_VMCTRL_ATO_128 BIT(16)/* 128 us */ #define TSI148_LCSR_VMCTRL_ATO_512 (2 << 16)/* 512 us */
@@ -753,8 +752,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,#define TSI148_LCSR_VCTRL_DLT_16384 (0xB << 24)/* 16384 VCLKS */ #define TSI148_LCSR_VCTRL_DLT_32768 (0xC << 24)/* 32768 VCLKS */ -#define TSI148_LCSR_VCTRL_NERBB BIT(20)/* No Early Release of Bus Busy -*/ +#define TSI148_LCSR_VCTRL_NERBB BIT(20)/* No Early Release of Bus Busy */ #define TSI148_LCSR_VCTRL_SRESET BIT(17)/* System Reset */ #define TSI148_LCSR_VCTRL_LRESET BIT(16)/* Local Reset */
Signature · 1 line
2.40.1
PATCH 2/2 staging: vme_user: Add a newline after variable declarations
This patch makes the following change:
* Adds a newline after the variable declarations as per checkpatch's warning
--- drivers/staging/vme_user/vme_tsi148.h | 1 + 1 file changed, 1 insertion(+)
drivers/staging/vme_user/vme_tsi148.h +1 -0
@@ -34,6 +34,7 @@ struct tsi148_driver {void __iomem *base;/* Base Address of device registers */ wait_queue_head_t dma_queue[2 ];wait_queue_head_t iack_queue; +void (*lm_callback[4 ])(void *);/* Called in interrupt handler */ void *lm_data[4 ];void *crcsr_kernel;
Signature · 1 line
2.40.1
Greg KH
maintainerRe: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations
Quoted 14 lines · Jonathan Bergh
This patch makes the following change:
* Adds a newline after the variable declarations as per checkpatch's warningSigned-off-by Jonathan Bergh <[email protected]>--- drivers/staging/vme_user/vme_tsi148.h | 1 + 1 file changed, 1 insertion(+)drivers/staging/vme_user/vme_tsi148.h +0
-0
drivers/staging/vme_user/vme_tsi148.h struct tsi148_driver { · line 40
Quoted 7 lines
drivers/staging/vme_user/vme_tsi148.h +1
-0@@ -34,6 +34,7 @@ struct tsi148_driver {void __iomem *base;/* Base Address of device registers */ wait_queue_head_t dma_queue[2 ];wait_queue_head_t iack_queue; +void (*lm_callback[4 ])(void *);/* Called in interrupt handler */ void *lm_data[4 ];void *crcsr_kernel;
Please always look at the change to see if checkpatch is correct or not (hint, for this one, it is not.) Also see the archives for many people who have done the same thing in the past :)
thanks,
greg k-h
Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations
Quoted 10 lines · Greg KH
Quoted 9 lines · Jonathan Bergh
This patch makes the following change:
* Adds a newline after the variable declarations as per checkpatch's warningSigned-off-by Jonathan Bergh <[email protected]>--- drivers/staging/vme_user/vme_tsi148.h | 1 + 1 file changed, 1 insertion(+)
Quoted 16 lines
drivers/staging/vme_user/vme_tsi148.h struct tsi148_driver { · line 40
Quoted 12 lines
drivers/staging/vme_user/vme_tsi148.h +1
-0@@ -34,6 +34,7 @@ struct tsi148_driver {void __iomem *base;/* Base Address of device registers */ wait_queue_head_t dma_queue[2 ];wait_queue_head_t iack_queue; +void (*lm_callback[4 ])(void *);/* Called in interrupt handler */ void *lm_data[4 ];void *crcsr_kernel;Please always look at the change to see if checkpatch is correct or not (hint, for this one, it is not.) Also see the archives for many people who have done the same thing in the past :)
Got it, thanks for that.
Quoted 4 lines
thanks,
greg k-h