Skip to contentSkip to conversation

iio: imu: inv_icm42600: add support of ICM-42688-P

PATCH Superseded [email protected] 4 participants 7 messages Mar 29, 2024 – Apr 1, 2024

Subsystems (3)
Device tree bindings IIO Invensense ICM-426xx IMU driver

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#3 lore raw

Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

In reply to [email protected]
Quoted 5 lines · On Fri, Mar 29, 2024 at 03:15:35PM +0000, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

Signed-off-by Jean-Baptiste Maneyrol <[email protected]>

My initial thought was that you're missing a sign-off, but is "[email protected]" some system you have to bypass corporate email garbage?

Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml properties: · line 34

Quoted 13 lines
---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -0
index 7cd05bcbee31..152aec8d82ff 100644
@@ -31,6 +31,7 @@ properties:
       - invensense,icm42602
       - invensense,icm42605
       - invensense,icm42622
+      - invensense,icm42688

Can you add this in alphanumerical order please?

Also, this patch should be the first in the series.

Thanks,
Conor.

Quoted 6 lines
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +0 -1
       - invensense,icm42631
 
   reg:
--

2.34.1

[email protected]

author
#0 lore raw

cover iio: imu: inv_icm42600: add support of ICM-42688-P

From: Jean-Baptiste Maneyrol <[email protected]>

This series is for adding support of high-end specs ICM-42688-P chip.

Jean-Baptiste Maneyrol (2):
iio: imu: inv_icm42600: add support of ICM-42688-P
dt-bindings: iio: imu: add icm42688 inside inv_icm42600

 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml     | 1 +
 drivers/iio/imu/inv_icm42600/inv_icm42600.h                  | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c             | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c              | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c              | 3 +++
 5 files changed, 14 insertions(+)

--
2.34.1

author
#2 lore raw

PATCH 2/2 dt-bindings: iio: imu: add icm42688 inside inv_icm42600

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

Signed-off-by Jean-Baptiste Maneyrol <[email protected]>
---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -0
index 7cd05bcbee31..152aec8d82ff 100644
@@ -31,6 +31,7 @@ properties:
       - invensense,icm42602
       - invensense,icm42605
       - invensense,icm42622
+      - invensense,icm42688
       - invensense,icm42631
 
   reg:

--
2.34.1

author
#1 lore raw

PATCH 1/2 iio: imu: inv_icm42600: add support of ICM-42688-P

In reply to [email protected]

From: Jean-Baptiste Maneyrol <[email protected]>

Signed-off-by Jean-Baptiste Maneyrol <[email protected]>
---
 drivers/iio/imu/inv_icm42600/inv_icm42600.h      | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c  | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c  | 3 +++
 4 files changed, 13 insertions(+)
drivers/iio/imu/inv_icm42600/inv_icm42600.h +2 -0
index 0e290c807b0f..0566340b2660 100644
@@ -22,6 +22,7 @@ enum inv_icm42600_chip {
 	INV_CHIP_ICM42602,
 	INV_CHIP_ICM42605,
 	INV_CHIP_ICM42622,
+	INV_CHIP_ICM42688,
 	INV_CHIP_ICM42631,
 	INV_CHIP_NB,
 };

@@ -304,6 +305,7 @@ struct inv_icm42600_state {
 #define INV_ICM42600_WHOAMI_ICM42602			0x41
 #define INV_ICM42600_WHOAMI_ICM42605			0x42
 #define INV_ICM42600_WHOAMI_ICM42622			0x46
+#define INV_ICM42600_WHOAMI_ICM42688			0x47
 #define INV_ICM42600_WHOAMI_ICM42631			0x5C
 
 /* User bank 1 (MSB 0x10) */
drivers/iio/imu/inv_icm42600/inv_icm42600_core.c +5 -0
index a5e81906e37e..82e0a2e2ad70 100644
@@ -87,6 +87,11 @@ static const struct inv_icm42600_hw inv_icm42600_hw[INV_CHIP_NB] = {
 		.name = "icm42622",
 		.conf = &inv_icm42600_default_conf,
 	},
+	[INV_CHIP_ICM42688] = {
+		.whoami = INV_ICM42600_WHOAMI_ICM42688,
+		.name = "icm42688",
+		.conf = &inv_icm42600_default_conf,
+	},
 	[INV_CHIP_ICM42631] = {
 		.whoami = INV_ICM42600_WHOAMI_ICM42631,
 		.name = "icm42631",
drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c +3 -0
index 1af559403ba6..ebb28f84ba98 100644
@@ -84,6 +84,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
 	}, {
 		.compatible = "invensense,icm42622",
 		.data = (void *)INV_CHIP_ICM42622,
+	}, {
+		.compatible = "invensense,icm42688",
+		.data = (void *)INV_CHIP_ICM42688,
 	}, {
 		.compatible = "invensense,icm42631",
 		.data = (void *)INV_CHIP_ICM42631,
drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c +3 -0
index 6be4ac794937..50217a10e0bb 100644
@@ -80,6 +80,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
 	}, {
 		.compatible = "invensense,icm42622",
 		.data = (void *)INV_CHIP_ICM42622,
+	}, {
+		.compatible = "invensense,icm42688",
+		.data = (void *)INV_CHIP_ICM42688,
 	}, {
 		.compatible = "invensense,icm42631",
 		.data = (void *)INV_CHIP_ICM42631,

--
2.34.1

maintainer
#4 lore raw

Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

In reply to Conor Dooley
Quoted 10 lines · On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <[email protected]> wrote:
Quoted 5 lines · On Fri, Mar 29, 2024 at 03:15:35PM +0000, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

Signed-off-by Jean-Baptiste Maneyrol <[email protected]>

My initial thought was that you're missing a sign-off, but is "[email protected]" some system you have to bypass corporate email garbage?

Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied.

Quoted 17 lines
Quoted 10 lines
---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +0 -0
index 7cd05bcbee31..152aec8d82ff 100644

Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml properties: · line 34

Quoted 4 lines
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -0
@@ -31,6 +31,7 @@ properties:
       - invensense,icm42602
       - invensense,icm42605
       - invensense,icm42622
+      - invensense,icm42688

Can you add this in alphanumerical order please?

Quoted 1 line

Also, this patch should be the first in the series.

Agreed on both, otherwise this series LGTM

Jonathan

Quoted 10 lines

Thanks,
Conor.

Quoted 6 lines
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +0 -1
       - invensense,icm42631
 
   reg:
--

2.34.1

#5 lore raw

Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

Quoted 8 lines · Jonathan Cameron
Quoted 5 lines · On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <[email protected]> wrote:
Quoted 4 lines · On Fri, Mar 29, 2024 at 03:15:35PM +0000, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Jean-Baptiste Maneyrol <[email protected]>

My initial thought was that you're missing a sign-off, but is "[email protected]" some system you have to bypass corporate email garbage?

Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied.

Yeah, I know how it works, I do it all the time. Even found, or rather caused, a b4 bug where it would use the sending email in the eventual commit rather than the author:
https://lore.kernel.org/tools/[email protected]/

I'm just double checking that there's not a missing signoff. When I've seen these corp-email-bypass accounts before people set a proper "from" in git send-email so there's a name in it: "A Dev <[email protected]>"

#6 lore raw

Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

Quoted 18 lines · On Mon, 1 Apr 2024 12:04:55 +0100 Conor Dooley <[email protected]> wrote:
Quoted 8 lines · Jonathan Cameron
Quoted 5 lines · On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <[email protected]> wrote:
Quoted 4 lines · On Fri, Mar 29, 2024 at 03:15:35PM +0000, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Jean-Baptiste Maneyrol <[email protected]>

My initial thought was that you're missing a sign-off, but is "[email protected]" some system you have to bypass corporate email garbage?

Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied.

Quoted 9 lines

Yeah, I know how it works, I do it all the time. Even found, or rather caused, a b4 bug where it would use the sending email in the eventual commit rather than the author:
https://lore.kernel.org/tools/[email protected]/

I'm just double checking that there's not a missing signoff. When I've seen these corp-email-bypass accounts before people set a proper "from" in git send-email so there's a name in it: "A Dev <[email protected]>"

Ah. Got it now :)
I guess it depends on how their weird setup wires everything up!

Jonathan