Skip to contentSkip to conversation

arm64: dts: imx8mn-evk: Fix ADV7535 dt-schema warnings

PATCH Superseded Fabio Estevam 1 participant 3 messages Apr 3, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 arm64: dts: imx8mn-evk: Fix ADV7535 dt-schema warnings

From: Fabio Estevam <[email protected]>

Currently, there are several ADV7535 dt-schema warnings.

Fx them the same way as in commit efa97aed071e060 ("arm64: dts:
imx8mm-evk: Fix hdmi@3d node").

As there are two different PMICs used on the imx8mn-evk variants, describe the ADV7535 power supplies in each board devicetree.

Fixes 5aafda608f73 ("arm64: dts: imx8mn-evk: Add camera support")
---
 .../boot/dts/freescale/imx8mn-ddr3l-evk.dts   | 10 +++++++
 .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 10 +++++++
 arch/arm64/boot/dts/freescale/imx8mn-evk.dts  | 10 +++++++
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 27 ++++++++++---------
 4 files changed, 45 insertions(+), 12 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts +10 -0
index 000e2c0596df..9ebd81e7eb7c 100644
@@ -112,3 +112,13 @@ ldo5: LDO5 {
 		};
 	};
 };
+
+&i2c2 {
+	hdmi@3d {
+		avdd-supply = <&buck5>;
+		dvdd-supply = <&buck5>;
+		pvdd-supply = <&buck5>;
+		a2vdd-supply = <&buck5>;
+		v1p2-supply = <&buck5>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +10 -0
index cc2ff59ac53b..1a4ac39ebde8 100644
@@ -158,3 +158,13 @@ ldo6_reg: LDO6 {
 		};
 	};
 };
+
+&i2c2 {
+	hdmi@3d {
+		avdd-supply = <&buck5_reg>;
+		dvdd-supply = <&buck5_reg>;
+		pvdd-supply = <&buck5_reg>;
+		a2vdd-supply = <&buck5_reg>;
+		v1p2-supply = <&buck5_reg>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-evk.dts +10 -0
index 0b71f50d936e..6f7f409c4181 100644
@@ -125,3 +125,13 @@ ldo5: LDO5 {
 		};
 	};
 };
+
+&i2c2 {
+	hdmi@3d {
+		avdd-supply = <&buck5>;
+		dvdd-supply = <&buck5>;
+		pvdd-supply = <&buck5>;
+		a2vdd-supply = <&buck5>;
+		v1p2-supply = <&buck5>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +15 -12
index 269e70f66a13..c06bcf86bb73 100644
@@ -30,7 +30,7 @@ hdmi-connector {
 
 		port {
 			hdmi_connector_in: endpoint {
-				remote-endpoint = <&adv7533_out>;
+				remote-endpoint = <&adv7535_out>;
 			};
 		};
 	};
@@ -52,6 +52,13 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		enable-active-high;
 	};
 
+	reg_vddext_3v3: regulator-vddext-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDEXT_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
 	ir-receiver {
 		compatible = "gpio-ir-receiver";
 		gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
@@ -193,15 +200,11 @@ &i2c2 {
 
 	hdmi@3d {
 		compatible = "adi,adv7535";
-		reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
-		reg-names = "main", "cec", "edid", "packet";
+		reg = <0x3d>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
 		adi,dsi-lanes = <4>;
-
-		adi,input-depth = <8>;
-		adi,input-colorspace = "rgb";
-		adi,input-clock = "1x";
-		adi,input-style = <1>;
-		adi,input-justification = "evenly";
+		v3p3-supply = <&reg_vddext_3v3>;
 
 		ports {
 			#address-cells = <1>;
@@ -210,7 +213,7 @@ ports {
 			port@0 {
 				reg = <0>;
 
-				adv7533_in: endpoint {
+				adv7535_in: endpoint {
 					remote-endpoint = <&dsi_out>;
 				};
 			};
@@ -218,7 +221,7 @@ adv7533_in: endpoint {
 			port@1 {
 				reg = <1>;
 
-				adv7533_out: endpoint {
+				adv7535_out: endpoint {
 					remote-endpoint = <&hdmi_connector_in>;
 				};
 			};
@@ -335,7 +338,7 @@ port@1 {
 			reg = <1>;
 
 			dsi_out: endpoint {
-				remote-endpoint = <&adv7533_in>;
+				remote-endpoint = <&adv7535_in>;
 				data-lanes = <1 2 3 4>;
 			};
 		};
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/3 arm64: dts: imx8mn-evk: Describe the OV5640 supplies

From: Fabio Estevam <[email protected]>

Per ovti,ov5640.yaml, the OV5640 power supplies are mandatory properties.

Describe them to fix dt-schema warnings.

As there are two different PMICs used on the imx8mn-evk variants, describe the OV5640 power supplies in each board devicetree.

---
 .../boot/dts/freescale/imx8mn-ddr3l-evk.dts      |  6 ++++++
 .../arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts |  6 ++++++
 arch/arm64/boot/dts/freescale/imx8mn-evk.dts     |  6 ++++++
 arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi    | 16 ++++++++++++++++
 4 files changed, 34 insertions(+)
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts +6 -0
index 9ebd81e7eb7c..d25032e3ceab 100644
@@ -122,3 +122,9 @@ hdmi@3d {
 		v1p2-supply = <&buck5>;
 	};
 };
+
+&i2c3 {
+	camera@3c {
+		DOVDD-supply = <&buck5>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +6 -0
index 1a4ac39ebde8..6d85a0b052c9 100644
@@ -168,3 +168,9 @@ hdmi@3d {
 		v1p2-supply = <&buck5_reg>;
 	};
 };
+
+&i2c3 {
+	camera@3c {
+		DOVDD-supply = <&buck5_reg>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-evk.dts +6 -0
index 6f7f409c4181..41330210a05f 100644
@@ -135,3 +135,9 @@ hdmi@3d {
 		v1p2-supply = <&buck5>;
 	};
 };
+
+&i2c3 {
+	camera@3c {
+		DOVDD-supply = <&buck5>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi +16 -0
index c06bcf86bb73..690da24a4335 100644
@@ -52,6 +52,20 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		enable-active-high;
 	};
 
+	reg_1v5: regulator-1v5 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_1V5";
+		regulator-min-microvolt = <1500000>;
+		regulator-max-microvolt = <1500000>;
+	};
+
+	reg_1v8: regulator-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_1V8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	reg_vddext_3v3: regulator-vddext-3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "VDDEXT_3V3";
@@ -287,6 +301,8 @@ camera@3c {
 		assigned-clock-rates = <24000000>;
 		powerdown-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
 		reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+		AVDD-supply = <&reg_1v8>;
+		DVDD-supply = <&reg_1v5>;
 
 		port {
 			ov5640_to_mipi_csi2: endpoint {
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#2 lore raw

PATCH 3/3 imx8mm-evk: Describe the OV5640 supplies

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Per ovti,ov5640.yaml, the OV5640 power supplies are mandatory properties.

Describe them to fix dt-schema warnings.

As there are two different PMICs used on the imx8mn-evk variants, describe the OV5640 power supplies in each board devicetree.

---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +17 -0
index bd5b365867fd..888070b8b287 100644
@@ -72,6 +72,20 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		enable-active-high;
 	};
 
+	reg_1v5: regulator-1v5 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_1V5";
+		regulator-min-microvolt = <1500000>;
+		regulator-max-microvolt = <1500000>;
+	};
+
+	reg_1v8: regulator-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_1V8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	reg_vddext_3v3: regulator-vddext-3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "VDDEXT_3V3";
@@ -441,6 +455,9 @@ camera@3c {
 		assigned-clock-rates = <24000000>;
 		powerdown-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
 		reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+		DOVDD-supply = <&buck5_reg>;
+		AVDD-supply = <&reg_1v8>;
+		DVDD-supply = <&reg_1v5>;
 
 		port {
 			ov5640_to_mipi_csi2: endpoint {
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel