Add JH7110 MIPI DPHY TX support
v5 cover Add JH7110 MIPI DPHY TX support
This patchset adds mipi dphy tx support for the StarFive JH7110 SoC. It is used to transfer DSI data. The series has been tested on the VisionFive 2 board.
change since v4:
- Rebased on tag v6.9-rc4.
patch 2:
-Drop shift macro definitions.
-Drop useless member variables of config array.
-Drop stf_dphy_set_reg() and stf_dphy_get_reg().
-Add readl_poll_timeout_atomic() for delay in stf_dphy_hw_reset(). -Rewrite register configure logic with FIELD_PREP()/FIELD_GET() and writel()/readl().
v4: https://patchwork.kernel.org/project/linux-phy/cover/[email protected]/
change since v3:
- Rebased on tag v6.8-rc6.
patch 2:
- Lower case for hex value.
- Replace bit shifts operation with macro definitions.
- Drop delay in stf_dphy_hw_reset().
- Change variable declarations order in stf_dphy_configure().
v3: https://patchwork.kernel.org/project/linux-phy/cover/[email protected]/
change since v2:
- Rebased on tag v6.8-rc3.
patch 2:
- Drop regulator operation.
v2: https://patchwork.kernel.org/project/linux-phy/cover/[email protected]/
changes since v1:
- Rebased on tag v6.7.
patch 1:
- Drop 'dphy_'prefix.
- Drop DSI reset.
- Drop unnecessary resets.
patch 2:
- Changed the commit message.
- Use dev_err_probe() and PTR_ERR() in probing.
- Drop DSI reset operation.
- Drop unnecessary resets operation.
- Add configs in array for full support of the module
- Changed 'void *io_addr' to 'void __iomem *io_addr'.
v1: https://patchwork.kernel.org/project/linux-phy/cover/[email protected]/
Shengyang Chen (2):
dt-bindings: phy: Add starfive,jh7110-dphy-tx
phy: starfive: Add mipi dphy tx support
.../bindings/phy/starfive,jh7110-dphy-tx.yaml | 68 +++ MAINTAINERS | 7 + drivers/phy/starfive/Kconfig | 10 + drivers/phy/starfive/Makefile | 1 + drivers/phy/starfive/phy-jh7110-dphy-tx.c | 459 ++++++++++++++++++ 5 files changed, 545 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c
Signature · 7 lines
2.17.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v5 1/2 dt-bindings: phy: Add starfive,jh7110-dphy-tx
StarFive SoCs like the jh7110 use a MIPI D-PHY TX controller based on a M31 IP. Add a binding for it.
--- .../bindings/phy/starfive,jh7110-dphy-tx.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml
Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml new file +68 -0
@@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-tx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Starfive SoC MIPI D-PHY Tx Controller + +maintainers: + - Keith Zhao <[email protected]> + - Shengyang Chen <[email protected]> + +description: + The Starfive SoC uses the MIPI DSI D-PHY based on M31 IP to transfer + DSI data. + +properties: + compatible: + const: starfive,jh7110-dphy-tx + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: txesc + + resets: + items: + - description: MIPITX_DPHY_SYS reset + + reset-names: + items: + - const: sys + + power-domains: + maxItems: 1 + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - power-domains + - "#phy-cells" + +additionalProperties: false + +examples: + - | + phy@295e0000 { + compatible = "starfive,jh7110-dphy-tx"; + reg = <0x295e0000 0x10000>; + clocks = <&voutcrg 14>; + clock-names = "txesc"; + resets = <&syscrg 10>; + reset-names = "sys"; + power-domains = <&aon_syscon 0>; + #phy-cells = <0>; + };
Signature · 7 lines
2.17.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v5 2/2 phy: starfive: Add mipi dphy tx support
In reply to Shengyang ChenAdd mipi dphy tx support for the StarFive JH7110 SoC. It is a module which is used to receive data from DSI driver and transfer data to DSI interface like mipi screen.
--- MAINTAINERS | 7 + drivers/phy/starfive/Kconfig | 10 + drivers/phy/starfive/Makefile | 1 + drivers/phy/starfive/phy-jh7110-dphy-tx.c | 459 ++++++++++++++++++++++ 4 files changed, 477 insertions(+) create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c
MAINTAINERS +7 -0
@@ -21009,6 +21009,13 @@ S: Supported F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml F: drivers/phy/starfive/phy-jh7110-dphy-rx.c +STARFIVE JH7110 DPHY TX DRIVER +M: Keith Zhao <[email protected]> +M: Shengyang Chen <[email protected]> +S: Supported +F: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml +F: drivers/phy/starfive/phy-jh7110-dphy-tx.c + STARFIVE JH7110 MMC/SD/SDIO DRIVER M: William Qiu <[email protected]> S: Supported
drivers/phy/starfive/Kconfig +10 -0
@@ -15,6 +15,16 @@ config PHY_STARFIVE_JH7110_DPHY_RX system. If M is selected, the module will be called phy-jh7110-dphy-rx.ko. +config PHY_STARFIVE_JH7110_DPHY_TX + tristate "StarFive JH7110 D-PHY TX Support" + depends on HAS_IOMEM + select GENERIC_PHY + select GENERIC_PHY_MIPI_DPHY + help + Choose this option if you have a StarFive D-PHY TX in your + system. If M is selected, the module will be called + phy-jh7110-dphy-tx.ko. + config PHY_STARFIVE_JH7110_PCIE tristate "Starfive JH7110 PCIE 2.0/USB 3.0 PHY support" depends on HAS_IOMEM
drivers/phy/starfive/Makefile +1 -0
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_RX) += phy-jh7110-dphy-rx.o +obj-$(CONFIG_PHY_STARFIVE_JH7110_DPHY_TX) += phy-jh7110-dphy-tx.o obj-$(CONFIG_PHY_STARFIVE_JH7110_PCIE) += phy-jh7110-pcie.o obj-$(CONFIG_PHY_STARFIVE_JH7110_USB) += phy-jh7110-usb.o
drivers/phy/starfive/phy-jh7110-dphy-tx.c new file +459 -0
459 lines not on this page · raw message
Signature · 7 lines
2.17.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 5 lines
This patchset adds mipi dphy tx support for the StarFive JH7110 SoC. It is used to transfer DSI data. The series has been tested on the VisionFive 2 board.
Hi, Vinod and Kishon
Could you please help to review and give me some suggestions for this patch series? Thank you for your time.
Best regards,
Shengyang
Quoted 9 lines · Shengyang Chen
This patchset adds mipi dphy tx support for the StarFive JH7110 SoC. It is used to transfer DSI data. The series has been tested on the VisionFive 2 board.
change since v4:
- Rebased on tag v6.9-rc4.[...]
Applied, thanks!
[1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx
commit: e4a8e87250fc2c1ed2aec5d1e8521dc7d799ea77
[2/2] phy: starfive: Add mipi dphy tx support
commit: d3ab7955330843699cdcc413edd7993923e6c016Best regards,
Signature · 1 line
Vinod Koul <[email protected]>