Skip to contentSkip to conversation

mmc: sdhci-of-dwcmshc: set CQE irq-handler for rockchip variants

PATCH In review Heiko Stuebner 3 participants 3 messages May 30, 2024 – Jun 4, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-of-dwcmshc: set CQE irq-handler for rockchip variants

From: Heiko Stuebner <[email protected]>

The dwcmshc used on Rockchip rk3568 and rk3588 can use cqe, so set the needed irq handler.

Tested on a rk3588-tiger SoM with dd, hdparm and fio. fio performance does increase slightly from

Run status group 0 (all jobs):
READ: bw=209MiB/s (219MB/s), 209MiB/s-209MiB/s (219MB/s-219MB/s), io=4096MiB (4295MB), run=19607-19607msec

without CQE to

Run status group 0 (all jobs):
READ: bw=215MiB/s (225MB/s), 215MiB/s-215MiB/s (225MB/s-225MB/s), io=4096MiB (4295MB), run=19062-19062msec

with CQE enabled.

---
 drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-of-dwcmshc.c +1 -0
index 4410d4523728d..3c203857189f9 100644
@@ -908,6 +908,7 @@ static const struct sdhci_ops sdhci_dwcmshc_rk35xx_ops = {
 	.get_max_clock		= rk35xx_get_max_clock,
 	.reset			= rk35xx_sdhci_reset,
 	.adma_write_desc	= dwcmshc_adma_write_desc,
+	.irq			= dwcmshc_cqe_irq_handler,
 };
 
 static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
Signature · 1 line
2.39.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

The dwcmshc used on Rockchip rk3568 and rk3588 can use cqe, so set the needed irq handler.

Tested on a rk3588-tiger SoM with dd, hdparm and fio. fio performance does increase slightly from

Run status group 0 (all jobs):

   READ: bw=209MiB/s (219MB/s), 209MiB/s-209MiB/s (219MB/s-219MB/s), io=4096MiB (4295MB), run=19607-19607msec
Quoted 8 lines

without CQE to

Run status group 0 (all jobs):

   READ: bw=215MiB/s (225MB/s), 215MiB/s-215MiB/s (225MB/s-225MB/s), io=4096MiB (4295MB), run=19062-19062msec

with CQE enabled.

Quoted 16 lines
---
 drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-of-dwcmshc.c +1 -0
index 4410d4523728d..3c203857189f9 100644
@@ -908,6 +908,7 @@ static const struct sdhci_ops sdhci_dwcmshc_rk35xx_ops = {
 	.get_max_clock		= rk35xx_get_max_clock,
 	.reset			= rk35xx_sdhci_reset,
 	.adma_write_desc	= dwcmshc_adma_write_desc,
+	.irq			= dwcmshc_cqe_irq_handler,
 };
 
 static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
#2 lore raw
In reply to Heiko Stuebner
Quoted 12 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

The dwcmshc used on Rockchip rk3568 and rk3588 can use cqe, so set the needed irq handler.

Tested on a rk3588-tiger SoM with dd, hdparm and fio. fio performance does increase slightly from

Run status group 0 (all jobs):

   READ: bw=209MiB/s (219MB/s), 209MiB/s-209MiB/s (219MB/s-219MB/s), io=4096MiB (4295MB), run=19607-19607msec
Quoted 8 lines

without CQE to

Run status group 0 (all jobs):

   READ: bw=215MiB/s (225MB/s), 215MiB/s-215MiB/s (225MB/s-225MB/s), io=4096MiB (4295MB), run=19062-19062msec

with CQE enabled.

Applied for next, thanks!

Kind regards
Uffe

Quoted 19 lines
---
 drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-of-dwcmshc.c +1 -1
index 4410d4523728d..3c203857189f9 100644
@@ -908,6 +908,7 @@ static const struct sdhci_ops sdhci_dwcmshc_rk35xx_ops = {
        .get_max_clock          = rk35xx_get_max_clock,
        .reset                  = rk35xx_sdhci_reset,
        .adma_write_desc        = dwcmshc_adma_write_desc,
+       .irq                    = dwcmshc_cqe_irq_handler,
 };
 
 static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
--

2.39.2