Secure Boot Advanced Targeting (SBAT) support on powerpc
v2 cover Secure Boot Advanced Targeting (SBAT) support on powerpc
In powerpc, PE format Binary are not supported and can't use shim (https://github.com/rhboot/shim/blob/main/SBAT.md).
However, ELF binary are supported. So, we created new ELF note for SBAT in ELF binary which store the SBAT data and SBAT verifier will be there in firmware to read SBAT data from ELF note and validate it.
this patch series consists of 2 parts:
1) Patch 1: create new ELF Note for SBAT
In order to store the SBAT data, we create a new ELF note. The string "Secure-Boot-Advanced-Targeting", zero-padded to 4 byte alignment, shall be entered in the name field. The string "sbat"'s ASCII values, 0x41536967, should be entered in the type field.
2) Patch 2: adding sbat metadata into sbat ELF Note
The SBAT metadata, which is read from .csv file and transformed into an ELF note, is made into an image using the -s option.
(The rest of this cover letter concerns testing the entire end-to-end setup - SBAT.)
You can experiement with this using entirely free software.
You need the following trees:
https://github.com/SudhakarKuppusamy1/qemu branch sbat
https://github.com/SudhakarKuppusamy1/SLOF branch sbat
https://github.com/SudhakarKuppusamy1/grub branch sbat
You also need:
- the SBAT metadata (.csv file)
- the SBAT Variable (.csv file)
Both should followed the SBAT specification (https://github.com/rhboot/shim/blob/main/SBAT.md)
Example: https://github.com/SudhakarKuppusamy1/testing/sbat
sbat_metadata.csv
sbat_var.csv
Lastly you will need a working a ppc64(le) vm.
sample vm: https://github.com/SudhakarKuppusamy1/testing/vm
pseries-ubuntu-20.04.6.qcow2
Then:
- build qemu (./configure --target-list=ppc64-softmmu && make). You need qemu-system-ppc64.
- use xxd (ex: xxd -i sbat_var.csv sbat_var.h) to convert the SBAT Variable for verifying grub into a header file, and copy it in to SLOF/lib/libcrypto/sbat_var.h. It must
create variables sbat_var_csv and sbat_var_csv_len.
- build SLOF for qemu (make qemu)
- verify that you can boot your VM with new SLOF and stock grub.
To boot with new SLOF, pass -bios ./SLOF/boot_rom.bin . It should boot with new slof in secure boot mode.
sudo ./build/qemu-system-ppc64 -m 8192 -M pseries-2.12,accel=kvm,cap-ail-mode-3=off,secure-boot=on -nographic -vga none -smp 4 -hdd pseries-ubuntu-20.04.6.qcow2 -bios ./boot_rom.bin
- Build grub in your VM.
- Build the SBAT metadata into grub.The following incantation should give you a working but non-portable grub, assuming you have grub installed on /dev/sda2:
GRUB_MODULES="all_video boot btrfs cat configfile echo ext2 fat font gfxmenu gfxterm gzio halt hfsplus http iso9660 jpeg loadenv loopback linux lvm mdraid09 mdraid1x minicmd net normal part_apple part_msdos part_gpt password_pbkdf2 png reboot regexp search search_fs_uuid search_fs_file search_label serial sleep syslinuxcfg test tftp video xfs"
sudo ./grub-install --modules "$GRUB_MODULES" -d ./grub-core/ -v "/dev/sda2" --sbat=./sbat_metadata.csv dd if=/boot/grub/powerpc-ieee1275/core.elf of=/dev/sda2
Sudhakar Kuppusamy (2):
mkimage: create new ELF Note for SBAT
mkimage: adding sbat metadata into sbat ELF Note on powerpc
include/grub/util/mkimage.h | 4 +-- util/grub-mkimagexx.c | 51 +++++++++++++++++++++++++++++++++++-- util/mkimage.c | 17 ++++++++++--- 3 files changed, 64 insertions(+), 8 deletions(-)
Signature · 7 lines
2.39.3 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
PATCH v2 1/2 mkimage: create new ELF Note for SBAT
In order to store the SBAT data, we create a new ELF note. The string "Secure-Boot-Advanced-Targeting", zero-padded to 4 byte alignment, shall be entered in the name field. The string "sbat"'s ASCII values, 0x41536967, should be entered in the type field.
--- include/grub/util/mkimage.h | 4 +-- util/grub-mkimagexx.c | 51 +++++++++++++++++++++++++++++++++++-- util/mkimage.c | 5 ++-- 3 files changed, 54 insertions(+), 6 deletions(-)
include/grub/util/mkimage.h +2 -2
@@ -51,12 +51,12 @@ grub_mkimage_load_image64 (const char *kernel_path, const struct grub_install_image_target_desc *image_target);void grub_mkimage_generate_elf32 (const struct grub_install_image_target_desc *image_target, -int note,char **core_img,size_t *core_size, +int note,char *sbat,char **core_img,size_t *core_size,Elf32_Addr target_addr,struct grub_mkimage_layout *layout);void grub_mkimage_generate_elf64 (const struct grub_install_image_target_desc *image_target, -int note,char **core_img,size_t *core_size, +int note,char *sbat,char **core_img,size_t *core_size,Elf64_Addr target_addr,struct grub_mkimage_layout *layout);
util/grub-mkimagexx.c +49 -2
96 lines not on this page · raw message
util/mkimage.c +3 -2
@@ -1813,6 +1813,7 @@ grub_install_generate_image (const char *dir, const char *prefix,case IMAGE_I386_IEEE1275 : {grub_uint64_t target_addr; +char *sbat =NULL ;if (image_target->id ==IMAGE_LOONGSON_ELF ) {if (comp ==GRUB_COMPRESSION_NONE )
@@ -1824,10 +1825,10 @@ grub_install_generate_image (const char *dir, const char *prefix,else target_addr = image_target->link_addr;if (image_target->voidp_sizeof ==4 ) -grub_mkimage_generate_elf32 (image_target, note, &core_img, &core_size, +grub_mkimage_generate_elf32 (image_target, note, sbat, &core_img, &core_size, target_addr, &layout);else -grub_mkimage_generate_elf64 (image_target, note, &core_img, &core_size, +grub_mkimage_generate_elf64 (image_target, note, sbat, &core_img, &core_size, target_addr, &layout); }break ;
Signature · 7 lines
2.39.3 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
PATCH v2 2/2 mkimage: adding sbat metadata into sbat ELF Note on powerpc
In reply to Sudhakar Kuppusamy via Grub-develThe SBAT metadata, which is read from .csv file and transformed into an ELF note, is made into an image using the -s option.
--- util/mkimage.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
util/mkimage.c +10 -2
@@ -943,8 +943,9 @@ grub_install_generate_image (const char *dir, const char *prefix, total_module_size += dtb_size +sizeof (struct grub_module_header ); } -if (sbat_path !=NULL && image_target->id !=IMAGE_EFI ) -grub_util_error (_ (".sbat section can be embedded into EFI images only" )); +if (sbat_path !=NULL && (image_target->id !=IMAGE_EFI && image_target->id !=IMAGE_PPC )) +grub_util_error (_ (".sbat section can be embedded into EFI images/" +"sbat ELF Note can be added into powerpc-ieee1275 images only" ));if (disable_shim_lock) total_module_size +=sizeof (struct grub_module_header );
@@ -1814,6 +1815,13 @@ grub_install_generate_image (const char *dir, const char *prefix, {grub_uint64_t target_addr;char *sbat =NULL ; +if (sbat_path !=NULL ) + { + sbat_size =grub_util_get_image_size (sbat_path); + sbat =xmalloc (sbat_size); +grub_util_load_image (sbat_path, sbat); + layout.sbat_size = sbat_size; + }if (image_target->id ==IMAGE_LOONGSON_ELF ) {if (comp ==GRUB_COMPRESSION_NONE )
Signature · 7 lines
2.39.3 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel