Skip to contentSkip to conversation

clk: npcm8xx: add clock controller

PATCH RESEND In review Tomer Maimon 2 participants 3 messages Jun 26, 2024 – Jun 27, 2024

Subsystems (2)
lore
Share & tools
lore

Tomer Maimon

author maintainer
#0 lore raw

PATCH RESEND 1/1 clk: npcm8xx: add clock controller

Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller which generates and supplies clocks to all modules within the BMC.

---
 drivers/clk/Kconfig       |   8 +
 drivers/clk/Makefile      |   1 +
 drivers/clk/clk-npcm8xx.c | 510 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 519 insertions(+)
 create mode 100644 drivers/clk/clk-npcm8xx.c
drivers/clk/Kconfig +8 -0
index c30099866174..9bc5f2dfc7e2 100644
@@ -325,6 +325,14 @@ config COMMON_CLK_LOCHNAGAR
 	  This driver supports the clocking features of the Cirrus Logic
 	  Lochnagar audio development board.
 
+config COMMON_CLK_NPCM8XX
+	tristate "Clock driver for the NPCM8XX SoC Family"
+	depends on ARCH_NPCM || COMPILE_TEST
+	help
+	  This driver supports the clocks on the Nuvoton BMC NPCM8XX SoC Family,
+	  all the clocks are initialized by the bootloader, so this driver
+	  allows only reading of current settings directly from the hardware.
+
 config COMMON_CLK_LOONGSON2
 	bool "Clock driver for Loongson-2 SoC"
 	depends on LOONGARCH || COMPILE_TEST
drivers/clk/Makefile +1 -0
index 18969cbd4bb1..e2cbc6cceb8c 100644
@@ -51,6 +51,7 @@ obj-$(CONFIG_ARCH_MILBEAUT_M10V)	+= clk-milbeaut.o
 obj-$(CONFIG_ARCH_MOXART)		+= clk-moxart.o
 obj-$(CONFIG_ARCH_NOMADIK)		+= clk-nomadik.o
 obj-$(CONFIG_ARCH_NPCM7XX)	    	+= clk-npcm7xx.o
+obj-$(CONFIG_COMMON_CLK_NPCM8XX)	+= clk-npcm8xx.o
 obj-$(CONFIG_ARCH_NSPIRE)		+= clk-nspire.o
 obj-$(CONFIG_COMMON_CLK_PALMAS)		+= clk-palmas.o
 obj-$(CONFIG_CLK_LS1028A_PLLDIG)	+= clk-plldig.o
drivers/clk/clk-npcm8xx.c new file +510 -0

510 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#1 lore raw

Hi Tomer,

Quoted 4 lines · Tomer Maimon

Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller which generates and supplies clocks to all modules within the BMC.

How does this relate to the series that you've been iterating on upstream? Is this v25 of the patches?

It help me if you clarified this in the commit message (ideally with a link to the upstream series in question if it's a direct backport).

If it is v25 then there seem to be some concerns from the CI bots:

- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/

It looks like you also need to fix the dts to address the new constraints you've added to the binding (and also address the build failure).

Andrew

author maintainer
#2 lore raw

Hi Andrew,

Thanks for your reply.

I will send the NPCM8XX clock driver according to V25.

Thanks,

Tomer

Quoted 25 lines · Andrew Jeffery

Hi Tomer,

Quoted 4 lines · Tomer Maimon

Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller which generates and supplies clocks to all modules within the BMC.

How does this relate to the series that you've been iterating on upstream? Is this v25 of the patches?

It help me if you clarified this in the commit message (ideally with a link to the upstream series in question if it's a direct backport).

If it is v25 then there seem to be some concerns from the CI bots:

- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/

It looks like you also need to fix the dts to address the new constraints you've added to the binding (and also address the build failure).

Andrew