Skip to contentSkip to conversation

Disable Clk-gate_tests for s390

PATCH Applied Audra Mitchell 2 participants 2 messages Jul 2, 2024 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Disable Clk-gate_tests for s390

Currently clk-gate tests for s390 fail as the tests create a pretend clk-gate and use a "fake_reg" to emulate the expected behavior of the clk_gate->reg. I added some debug statements to the driver and noticed that the reg changes after initialization to -1, which is coming from an error coming from zpci_load(). This is likely because the test is using fake iomem and the s390 architecture likely isn't designed to handle that. Turn off the clk-gate tests for s390 for now as there is no clear work around for this problem as discussed in upstream conversation [1].

[1] https://lore.kernel.org/all/[email protected]/T/#t

---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/Kconfig +1 -0
index 3e9099504fad..3c3e0b969020 100644
@@ -514,6 +514,7 @@ config CLK_KUNIT_TEST
 config CLK_GATE_KUNIT_TEST
 	tristate "Basic gate type Kunit test" if !KUNIT_ALL_TESTS
 	depends on KUNIT
+	depends on !S390
 	default KUNIT_ALL_TESTS
 	help
 	  Kunit test for the basic clk gate type.
Signature · 1 line
2.44.0
maintainer Applied
#1 lore raw

Quoting Audra Mitchell (2024-07-02 05:55:39)

Quoted 10 lines

Currently clk-gate tests for s390 fail as the tests create a pretend clk-gate and use a "fake_reg" to emulate the expected behavior of the clk_gate->reg. I added some debug statements to the driver and noticed that the reg changes after initialization to -1, which is coming from an error coming from zpci_load(). This is likely because the test is using fake iomem and the s390 architecture likely isn't designed to handle that. Turn off the clk-gate tests for s390 for now as there is no clear work around for this problem as discussed in upstream conversation [1].

Quoted 4 lines

[1] https://lore.kernel.org/all/[email protected]/T/#t

---

Applied to clk-next