Skip to contentSkip to conversation

rkisp1 extensible parameters format

GIT PULL Laurent Pinchart 2 participants 4 messages Aug 12, 2024 – Aug 14, 2024 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Hans, Mauro,

The following changes since commit c80bfa4f9e0ebfce6ac909488d412347acbcb4f9:

media: ti: cal: use 'time_left' variable with wait_event_timeout() (2024-08-09 07:56:39 +0200)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/next-media-rkisp1-20240813

for you to fetch changes up to 32be6029c1c1e8c628077403b2096e9d9085f6c8:

media: rkisp1: Add support for the companding block (2024-08-12 13:36:50 +0300)

----------------------------------------------------------------
Extensible parameters support for the rkisp1 driver

----------------------------------------------------------------
Jacopo Mondi (7):
media: uapi: rkisp1-config: Add extensible params format
media: uapi: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS
media: rkisp1: Add struct rkisp1_params_buffer
media: rkisp1: Copy the parameters buffer
media: rkisp1: Cache the currently active format
media: rkisp1: Implement extensible params support
media: rkisp1: Implement s_fmt/try_fmt

Laurent Pinchart (2):
media: rkisp1: Add helper function to swap colour channels
media: rkisp1: Add features mask to extensible block handlers

Ondrej Jirman (1):
media: rkisp1: Adapt to different SoCs having different size limits

Paul Elder (3):
media: rkisp1: Add register definitions for the companding block
media: rkisp1: Add feature flags for BLS and compand
media: rkisp1: Add support for the companding block

 Documentation/admin-guide/media/rkisp1.rst         |   11 +-
 .../userspace-api/media/v4l/metafmt-rkisp1.rst     |   57 +-
 .../media/platform/rockchip/rkisp1/rkisp1-common.c |   14 +
 .../media/platform/rockchip/rkisp1/rkisp1-common.h |   49 +-
 .../media/platform/rockchip/rkisp1/rkisp1-csi.c    |    5 +-
 .../media/platform/rockchip/rkisp1/rkisp1-dev.c    |   15 +-
 .../media/platform/rockchip/rkisp1/rkisp1-isp.c    |    9 +-
 .../media/platform/rockchip/rkisp1/rkisp1-params.c | 1037 ++++++++++++++++++--
 .../media/platform/rockchip/rkisp1/rkisp1-regs.h   |   23 +
 .../platform/rockchip/rkisp1/rkisp1-resizer.c      |    4 +-
 .../media/platform/rockchip/rkisp1/rkisp1-stats.c  |   51 +-
 drivers/media/v4l2-core/v4l2-ioctl.c               |    1 +
 include/uapi/linux/rkisp1-config.h                 |  578 +++++++++++
 include/uapi/linux/videodev2.h                     |    1 +
 14 files changed, 1689 insertions(+), 166 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by Laurent Pinchart Reviewed-by Jacopo Mondi Reviewed-by Paul Elder Tested-by Kieran Bingham Acked-by Sakari Ailus Reviewed-by
#1 lore raw

Hi Laurent,

Quoted 1 line · Laurent Pinchart

Hi Hans, Mauro,

commit 5ef3fcc8e42b43523498c7b0ede19a47fbdf8353 (media: rkisp1: Implement extensible params support) failed to push because the commit log contains a local changelog:

...
Implement parameter buffer validation for the extensible format at .buf_prepare() time.

---
Changes since v10:

- Use %zu to print size_t arguments

I can either just take these patches (i.e. I don't merge them), and manually remove this before committing, or you need to update your tree yourself.

If you decide to do the latter, then please add my:

to patches 2 and 3 (uAPI changes).

Regards,

Hans

Quoted 54 lines

The following changes since commit c80bfa4f9e0ebfce6ac909488d412347acbcb4f9:

media: ti: cal: use 'time_left' variable with wait_event_timeout() (2024-08-09 07:56:39 +0200)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/next-media-rkisp1-20240813

for you to fetch changes up to 32be6029c1c1e8c628077403b2096e9d9085f6c8:

media: rkisp1: Add support for the companding block (2024-08-12 13:36:50 +0300)

----------------------------------------------------------------
Extensible parameters support for the rkisp1 driver

----------------------------------------------------------------
Jacopo Mondi (7):
media: uapi: rkisp1-config: Add extensible params format
media: uapi: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS
media: rkisp1: Add struct rkisp1_params_buffer
media: rkisp1: Copy the parameters buffer
media: rkisp1: Cache the currently active format
media: rkisp1: Implement extensible params support
media: rkisp1: Implement s_fmt/try_fmt

Laurent Pinchart (2):
media: rkisp1: Add helper function to swap colour channels
media: rkisp1: Add features mask to extensible block handlers

Ondrej Jirman (1):
media: rkisp1: Adapt to different SoCs having different size limits

Paul Elder (3):
media: rkisp1: Add register definitions for the companding block
media: rkisp1: Add feature flags for BLS and compand
media: rkisp1: Add support for the companding block

 Documentation/admin-guide/media/rkisp1.rst         |   11 +-
 .../userspace-api/media/v4l/metafmt-rkisp1.rst     |   57 +-
 .../media/platform/rockchip/rkisp1/rkisp1-common.c |   14 +
 .../media/platform/rockchip/rkisp1/rkisp1-common.h |   49 +-
 .../media/platform/rockchip/rkisp1/rkisp1-csi.c    |    5 +-
 .../media/platform/rockchip/rkisp1/rkisp1-dev.c    |   15 +-
 .../media/platform/rockchip/rkisp1/rkisp1-isp.c    |    9 +-
 .../media/platform/rockchip/rkisp1/rkisp1-params.c | 1037 ++++++++++++++++++--
 .../media/platform/rockchip/rkisp1/rkisp1-regs.h   |   23 +
 .../platform/rockchip/rkisp1/rkisp1-resizer.c      |    4 +-
 .../media/platform/rockchip/rkisp1/rkisp1-stats.c  |   51 +-
 drivers/media/v4l2-core/v4l2-ioctl.c               |    1 +
 include/uapi/linux/rkisp1-config.h                 |  578 +++++++++++
 include/uapi/linux/videodev2.h                     |    1 +
 14 files changed, 1689 insertions(+), 166 deletions(-)
#2 lore raw
Quoted 24 lines · Hans Verkuil

Hi Laurent,

Quoted 1 line · Laurent Pinchart

Hi Hans, Mauro,

commit 5ef3fcc8e42b43523498c7b0ede19a47fbdf8353 (media: rkisp1: Implement extensible params support) failed to push because the commit log contains a local changelog:

...
Implement parameter buffer validation for the extensible format at .buf_prepare() time.

---
Changes since v10:

- Use %zu to print size_t arguments

Quoted 8 lines

I can either just take these patches (i.e. I don't merge them), and manually remove this before committing, or you need to update your tree yourself.

If you decide to do the latter, then please add my:

to patches 2 and 3 (uAPI changes).

Oooops. I'll resend now. I wonder how I didn't notice that.

Quoted 53 lines
Quoted 53 lines

The following changes since commit c80bfa4f9e0ebfce6ac909488d412347acbcb4f9:

media: ti: cal: use 'time_left' variable with wait_event_timeout() (2024-08-09 07:56:39 +0200)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/next-media-rkisp1-20240813

for you to fetch changes up to 32be6029c1c1e8c628077403b2096e9d9085f6c8:

media: rkisp1: Add support for the companding block (2024-08-12 13:36:50 +0300)

----------------------------------------------------------------
Extensible parameters support for the rkisp1 driver

----------------------------------------------------------------
Jacopo Mondi (7):
media: uapi: rkisp1-config: Add extensible params format
media: uapi: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS
media: rkisp1: Add struct rkisp1_params_buffer
media: rkisp1: Copy the parameters buffer
media: rkisp1: Cache the currently active format
media: rkisp1: Implement extensible params support
media: rkisp1: Implement s_fmt/try_fmt

Laurent Pinchart (2):
media: rkisp1: Add helper function to swap colour channels
media: rkisp1: Add features mask to extensible block handlers

Ondrej Jirman (1):
media: rkisp1: Adapt to different SoCs having different size limits

Paul Elder (3):
media: rkisp1: Add register definitions for the companding block
media: rkisp1: Add feature flags for BLS and compand
media: rkisp1: Add support for the companding block

 Documentation/admin-guide/media/rkisp1.rst         |   11 +-
 .../userspace-api/media/v4l/metafmt-rkisp1.rst     |   57 +-
 .../media/platform/rockchip/rkisp1/rkisp1-common.c |   14 +
 .../media/platform/rockchip/rkisp1/rkisp1-common.h |   49 +-
 .../media/platform/rockchip/rkisp1/rkisp1-csi.c    |    5 +-
 .../media/platform/rockchip/rkisp1/rkisp1-dev.c    |   15 +-
 .../media/platform/rockchip/rkisp1/rkisp1-isp.c    |    9 +-
 .../media/platform/rockchip/rkisp1/rkisp1-params.c | 1037 ++++++++++++++++++--
 .../media/platform/rockchip/rkisp1/rkisp1-regs.h   |   23 +
 .../platform/rockchip/rkisp1/rkisp1-resizer.c      |    4 +-
 .../media/platform/rockchip/rkisp1/rkisp1-stats.c  |   51 +-
 drivers/media/v4l2-core/v4l2-ioctl.c               |    1 +
 include/uapi/linux/rkisp1-config.h                 |  578 +++++++++++
 include/uapi/linux/videodev2.h                     |    1 +
 14 files changed, 1689 insertions(+), 166 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw
Quoted 26 lines · Laurent Pinchart
Quoted 25 lines · Hans Verkuil
Quoted 1 line · Laurent Pinchart

Hi Hans, Mauro,

commit 5ef3fcc8e42b43523498c7b0ede19a47fbdf8353 (media: rkisp1: Implement extensible params support) failed to push because the commit log contains a local changelog:

...
Implement parameter buffer validation for the extensible format at .buf_prepare() time.

---
Changes since v10:

- Use %zu to print size_t arguments

I can either just take these patches (i.e. I don't merge them), and manually remove this before committing, or you need to update your tree yourself.

Quoted 7 lines
Quoted 5 lines

If you decide to do the latter, then please add my:

to patches 2 and 3 (uAPI changes).

Oooops. I'll resend now. I wonder how I didn't notice that.

Pull request resent, and local scripts updated to make sure this won't happen again.

Quoted 53 lines
Quoted 53 lines
Quoted 53 lines

The following changes since commit c80bfa4f9e0ebfce6ac909488d412347acbcb4f9:

media: ti: cal: use 'time_left' variable with wait_event_timeout() (2024-08-09 07:56:39 +0200)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/next-media-rkisp1-20240813

for you to fetch changes up to 32be6029c1c1e8c628077403b2096e9d9085f6c8:

media: rkisp1: Add support for the companding block (2024-08-12 13:36:50 +0300)

----------------------------------------------------------------
Extensible parameters support for the rkisp1 driver

----------------------------------------------------------------
Jacopo Mondi (7):
media: uapi: rkisp1-config: Add extensible params format
media: uapi: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS
media: rkisp1: Add struct rkisp1_params_buffer
media: rkisp1: Copy the parameters buffer
media: rkisp1: Cache the currently active format
media: rkisp1: Implement extensible params support
media: rkisp1: Implement s_fmt/try_fmt

Laurent Pinchart (2):
media: rkisp1: Add helper function to swap colour channels
media: rkisp1: Add features mask to extensible block handlers

Ondrej Jirman (1):
media: rkisp1: Adapt to different SoCs having different size limits

Paul Elder (3):
media: rkisp1: Add register definitions for the companding block
media: rkisp1: Add feature flags for BLS and compand
media: rkisp1: Add support for the companding block

 Documentation/admin-guide/media/rkisp1.rst         |   11 +-
 .../userspace-api/media/v4l/metafmt-rkisp1.rst     |   57 +-
 .../media/platform/rockchip/rkisp1/rkisp1-common.c |   14 +
 .../media/platform/rockchip/rkisp1/rkisp1-common.h |   49 +-
 .../media/platform/rockchip/rkisp1/rkisp1-csi.c    |    5 +-
 .../media/platform/rockchip/rkisp1/rkisp1-dev.c    |   15 +-
 .../media/platform/rockchip/rkisp1/rkisp1-isp.c    |    9 +-
 .../media/platform/rockchip/rkisp1/rkisp1-params.c | 1037 ++++++++++++++++++--
 .../media/platform/rockchip/rkisp1/rkisp1-regs.h   |   23 +
 .../platform/rockchip/rkisp1/rkisp1-resizer.c      |    4 +-
 .../media/platform/rockchip/rkisp1/rkisp1-stats.c  |   51 +-
 drivers/media/v4l2-core/v4l2-ioctl.c               |    1 +
 include/uapi/linux/rkisp1-config.h                 |  578 +++++++++++
 include/uapi/linux/videodev2.h                     |    1 +
 14 files changed, 1689 insertions(+), 166 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart