nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE
PATCH 1/1 nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE
NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not 'struct nvme_ns'.
--- drivers/nvme/host/multipath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/multipath.c +1 -1
@@ -646,7 +646,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns) rc =device_add_disk (&head->subsys->dev, head->disk, nvme_ns_attr_groups);if (rc) { -clear_bit (NVME_NSHEAD_DISK_LIVE , &ns->flags); +clear_bit (NVME_NSHEAD_DISK_LIVE , &head->flags);return ; }nvme_add_ns_head_cdev (head);
Signature · 1 line
2.35.3
Quoted 2 lines · Hannes Reinecke
NVME_NSHEAD_DISK_LIVEis a flag for 'structnvme_nshead', not 'structnvme_ns'.
Hannes, what is the phenomenon here? Is anything leaked or functionally broken?
The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.
For the patch itself,
Quoted 7 lines · Sagi Grimberg
Quoted 2 lines · Hannes Reinecke
NVME_NSHEAD_DISK_LIVEis a flag for 'structnvme_nshead', not 'structnvme_ns'.
Quoted 8 lines
Hannes, what is the phenomenon here? Is anything leaked or functionally broken?
The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.
For the patch itself,
Reviewed-by Sagi Grimberg <[email protected]>
We've seen the issue popping up during repeated map/unmap operations with reusing NSIDs; occasionally we would end up with stale multipath namespaces and non-existing generic devices.
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Sagi Grimberg
maintainerQuoted 14 lines · Hannes Reinecke
Quoted 13 lines · Sagi Grimberg
Quoted 2 lines · Hannes Reinecke
NVME_NSHEAD_DISK_LIVEis a flag for 'structnvme_nshead', not 'structnvme_ns'.Hannes, what is the phenomenon here? Is anything leaked or functionally broken?
The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.
Quoted 6 lines
Quoted 2 lines
For the patch itself,
Reviewed-by Sagi Grimberg <[email protected]>We've seen the issue popping up during repeated map/unmap operations with reusing NSIDs; occasionally we would end up with stale multipath namespaces and non-existing generic devices.
Great, please reword the change log to explain _what_ is fixed in the patch title and how you fix it in the patch body.
Christoph Hellwig
maintainerThe change itself looks good, but as Sagi already said please write a proper commit message.