Skip to contentSkip to conversation

nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE

PATCH In review Hannes Reinecke 4 participants 5 messages Aug 19, 2024 – Aug 22, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE

NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not 'struct nvme_ns'.

Fixes 11384580e332 ("nvme-multipath: add error handling support for add_disk()")
---
 drivers/nvme/host/multipath.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/multipath.c +1 -1
index 91d9eb3c22ef..c9d23b1b8efc 100644
@@ -646,7 +646,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns)
 		rc = device_add_disk(&head->subsys->dev, head->disk,
 				     nvme_ns_attr_groups);
 		if (rc) {
-			clear_bit(NVME_NSHEAD_DISK_LIVE, &ns->flags);
+			clear_bit(NVME_NSHEAD_DISK_LIVE, &head->flags);
 			return;
 		}
 		nvme_add_ns_head_cdev(head);
Signature · 1 line
2.35.3
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Hannes Reinecke

NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not 'struct nvme_ns'.

Hannes, what is the phenomenon here? Is anything leaked or functionally broken?

The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.

For the patch itself,

#2 lore raw
Quoted 7 lines · Sagi Grimberg
Quoted 2 lines · Hannes Reinecke

NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not 'struct nvme_ns'.

Quoted 8 lines

Hannes, what is the phenomenon here? Is anything leaked or functionally broken?

The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.

For the patch itself,

We've seen the issue popping up during repeated map/unmap operations with reusing NSIDs; occasionally we would end up with stale multipath namespaces and non-existing generic devices.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
maintainer
#3 lore raw
Quoted 14 lines · Hannes Reinecke
Quoted 13 lines · Sagi Grimberg
Quoted 2 lines · Hannes Reinecke

NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not 'struct nvme_ns'.

Hannes, what is the phenomenon here? Is anything leaked or functionally broken?

The patch looks good, but please explain if this is caught from code inspection or a real issue that surfaced.

Quoted 6 lines
Quoted 2 lines

For the patch itself,

We've seen the issue popping up during repeated map/unmap operations with reusing NSIDs; occasionally we would end up with stale multipath namespaces and non-existing generic devices.

Great, please reword the change log to explain _what_ is fixed in the patch title and how you fix it in the patch body.