Skip to contentSkip to conversation

staging: rtl8192e: Fix alignment parenthesis

PATCH In review Nilo Alexandre 2 participants 2 messages Aug 27, 2024 Staging

lore
Share & tools
lore

Nilo Alexandre

author
#0 lore raw

PATCH v2 1/1 staging: rtl8192e: Fix alignment parenthesis

Fix alignment parenthesis in _rtl92e_read_eeprom_info

CHECK: Alignment should match open parenthesis

---
Changes in v2:
- Using tabs instead of spaces

Signed-off-by Nilo Alexandre <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1
index b767dc00100aa..2d17d8e8898e7 100644
@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
 				usValue = rtl92e_eeprom_read(dev,
-					                     EEPROM_TxPwDiff_CrystalCap >> 1);
+								EEPROM_TxPwDiff_CrystalCap >> 1);
 				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
 				priv->eeprom_crystal_cap = (usValue & 0xf000)
 							 >> 12;
Signature · 1 line
2.46.0
#1 lore raw
Quoted 18 lines · Nilo Alexandre

Fix alignment parenthesis in _rtl92e_read_eeprom_info

CHECK: Alignment should match open parenthesis

---
Changes in v2:
- Using tabs instead of spaces

Signed-off-by Nilo Alexandre <[email protected]>
---
  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +0 -0
index b767dc00100aa..2d17d8e8898e7 100644

drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c static void _rtl92e_read_eeprom_info(struct net_device *dev) · line 328

Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1
@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
  		if (priv->epromtype == EEPROM_93C46) {
  			if (!priv->autoload_fail_flag) {
  				usValue = rtl92e_eeprom_read(dev,
-					                     EEPROM_TxPwDiff_CrystalCap >> 1);
+								EEPROM_TxPwDiff_CrystalCap >> 1);
  				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
  				priv->eeprom_crystal_cap = (usValue & 0xf000)
  							 >> 12;

Hi Nilo,

please make your "Subject" line more unique. Consider that we may end up with having dozen of commits like yours, all of them referring to different removals and all without the necessary information to tell what they differ in (except the driver/subsystem). So it would help if you add the changed file or function to make it more unique.

Please answer the why in the description and not so much what you did. Why do we need an empty line? Please use a dot to end the sentences. I propose:
Align parenthesis to improve readability.

You can mention the tool which gave you the hint but you do not have to.

Thanks for your support.

Bye Philipp