ARM: dts nuvoton: Add EDAC node
PATCH 1/1 ARM: dts nuvoton: Add EDAC node
From: "William A. Kennington III" <[email protected]>
We have the driver support code, now we just need to expose the device node which can export the EDAC properties for the system memory controller. Tested on real hardware to verify that error counters show up.
--- arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +7 -0
@@ -127,6 +127,13 @@ clk: clock-controller@f0801000 { clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>; }; + mc: memory-controller@f0824000 { + compatible = "nuvoton,"; + reg = <0xf0824000 0x1000>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + gmac0: eth@f0802000 { device_type = "network"; compatible = "snps,dwmac";
Signature · 1 line
2.46.1.824.gd892dcdcdd-goog
Hi William,
As a bit of a nit, you missed the : after dts in the patch subject.
Quoted 17 lines · William A. Kennington III
From: "William A. Kennington III" <[email protected]>
We have the driver support code, now we just need to expose the device node which can export the EDAC properties for the system memory controller. Tested on real hardware to verify that error counters show up.
Signed-off-by William A. Kennington III <[email protected]>--- arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0
-0
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi clk: clock-controller@f0801000 { · line 131
Quoted 5 lines
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +2
-0@@ -127,6 +127,13 @@ clk: clock-controller@f0801000 { clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>; }; + mc: memory-controller@f0824000 { + compatible = "nuvoton,";
This compatible string doesn't look right to me. Are you sure?
Andrew