Skip to contentSkip to conversation

mm: fix div by zero in bdi_ratio_from_pages

PATCH Superseded Stefan Roesch 2 participants 3 messages Jan 8, 2025 – Jan 9, 2025

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm: fix div by zero in bdi_ratio_from_pages

During testing it has been detected, that it is possible to get div by zero error in bdi_set_min_bytes. The error is caused by the function bdi_ratio_from_pages(). bdi_ratio_from_pages() calls global_dirty_limits. If the dirty threshold is 0, the div by zero is raised. This can happen if the root user is setting:

echo 0 > /proc/sys/vm/dirty_ratio

The following is a test case:

echo 0 > /proc/sys/vm/dirty_ratio
cd /sys/class/bdi/<device>
echo 1 > strict_limit
echo 8192 > min_bytes

==> error is raised.

The problem is addressed by returning -EINVAL if dirty_ratio or dirty_bytes is set to 0.

---
Changes in V2:
- check for -EINVAL in bdi_set_min_bytes()
- check for -EINVAL in bdi_set_max_bytes()

---
 mm/page-writeback.c | 6 ++++++
 1 file changed, 6 insertions(+)
mm/page-writeback.c +6 -0
index d213ead95675..fcc486e0d5c2 100644
@@ -692,6 +692,8 @@ static unsigned long bdi_ratio_from_pages(unsigned long pages)
 	unsigned long ratio;
 
 	global_dirty_limits(&background_thresh, &dirty_thresh);
+	if (!dirty_thresh)
+		return -EINVAL;
 	ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
 
 	return ratio;
@@ -797,6 +799,8 @@ int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes)
 		return ret;
 
 	min_ratio = bdi_ratio_from_pages(pages);
+	if (min_ratio == -EINVAL)
+		return -EINVAL;
 	return __bdi_set_min_ratio(bdi, min_ratio);
 }
 
@@ -816,6 +820,8 @@ int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes)
 		return ret;
 
 	max_ratio = bdi_ratio_from_pages(pages);
+	if (max_ratio == -EINVAL)
+		return -EINVAL;
 	return __bdi_set_max_ratio(bdi, max_ratio);
 }
 

base-commit: fbfd64d25c7af3b8695201ebc85efe90be28c5a3

Signature · 1 line
2.47.1
#1 lore raw
Quoted 55 lines · Stefan Roesch

During testing it has been detected, that it is possible to get div by zero error in bdi_set_min_bytes. The error is caused by the function bdi_ratio_from_pages(). bdi_ratio_from_pages() calls global_dirty_limits. If the dirty threshold is 0, the div by zero is raised. This can happen if the root user is setting:

echo 0 > /proc/sys/vm/dirty_ratio

The following is a test case:

echo 0 > /proc/sys/vm/dirty_ratio
cd /sys/class/bdi/<device>
echo 1 > strict_limit
echo 8192 > min_bytes

==> error is raised.

The problem is addressed by returning -EINVAL if dirty_ratio or dirty_bytes is set to 0.

---
Changes in V2:
- check for -EINVAL in bdi_set_min_bytes()
- check for -EINVAL in bdi_set_max_bytes()

---
  mm/page-writeback.c | 6 ++++++
  1 file changed, 6 insertions(+)
mm/page-writeback.c +4 -0
index d213ead95675..fcc486e0d5c2 100644
@@ -692,6 +692,8 @@ static unsigned long bdi_ratio_from_pages(unsigned long pages)
  	unsigned long ratio;
 
  	global_dirty_limits(&background_thresh, &dirty_thresh);
+	if (!dirty_thresh)
+		return -EINVAL;
  	ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
 
  	return ratio;
@@ -797,6 +799,8 @@ int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes)
  		return ret;
 
  	min_ratio = bdi_ratio_from_pages(pages);
+	if (min_ratio == -EINVAL)
+		return -EINVAL;
  	return __bdi_set_min_ratio(bdi, min_ratio);
  }
 

mm/page-writeback.c int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes) · line 824

Quoted 5 lines
mm/page-writeback.c +2 -0
@@ -816,6 +820,8 @@ int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes)
  		return ret;
 
  	max_ratio = bdi_ratio_from_pages(pages);
+	if (max_ratio == -EINVAL)
+		return -EINVAL;

I would have done it slightly differently, something like:

mm/page-writeback.c +9 -3
index d213ead956750..4b02f18f7d01f 100644
@@ -685,13 +685,15 @@ static int bdi_check_pages_limit(unsigned long pages)
        return 0;
 }
 
-static unsigned long bdi_ratio_from_pages(unsigned long pages)
+static long bdi_ratio_from_pages(unsigned long pages)
 {
        unsigned long background_thresh;
        unsigned long dirty_thresh;
        unsigned long ratio;
 
        global_dirty_limits(&background_thresh, &dirty_thresh);
+       if (!dirty_thresh)
+               return -EINVAL;
        ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
 
        return ratio;
@@ -790,13 +792,15 @@ int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes)
 {
        int ret;
        unsigned long pages = min_bytes >> PAGE_SHIFT;
-       unsigned long min_ratio;
+       long min_ratio;
 
        ret = bdi_check_pages_limit(pages);
        if (ret)
                return ret;
 
        min_ratio = bdi_ratio_from_pages(pages);
+       if (min_ratio < 0)
+               return min_ratio;
        return __bdi_set_min_ratio(bdi, min_ratio);
 }
 
@@ -809,13 +813,15 @@ int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes)
 {
        int ret;
        unsigned long pages = max_bytes >> PAGE_SHIFT;
-       unsigned long max_ratio;
+       long max_ratio;
 
        ret = bdi_check_pages_limit(pages);
        if (ret)
                return ret;
 
        max_ratio = bdi_ratio_from_pages(pages);
+       if (min_ratio < 0)
+               return min_ratio;
        return __bdi_set_max_ratio(bdi, max_ratio);
 }
 
Signature · 3 lines
Cheers,

David / dhildenb
#2 lore raw

David Hildenbrand <[email protected]> writes:

...

Quoted 41 lines

I would have done it slightly differently, something like:

mm/page-writeback.c +6 -1
index d213ead956750..4b02f18f7d01f 100644
@@ -685,13 +685,15 @@ static int bdi_check_pages_limit(unsigned long pages)
        return 0;
 }
 -static unsigned long bdi_ratio_from_pages(unsigned long pages)
+static long bdi_ratio_from_pages(unsigned long pages)
 {
        unsigned long background_thresh;
        unsigned long dirty_thresh;
        unsigned long ratio;
          global_dirty_limits(&background_thresh, &dirty_thresh);
+       if (!dirty_thresh)
+               return -EINVAL;
        ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
          return ratio;
@@ -790,13 +792,15 @@ int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes)
 {
        int ret;
        unsigned long pages = min_bytes >> PAGE_SHIFT;
-       unsigned long min_ratio;
+       long min_ratio;
          ret = bdi_check_pages_limit(pages);
        if (ret)
                return ret;
          min_ratio = bdi_ratio_from_pages(pages);
+       if (min_ratio < 0)
+               return min_ratio;
        return __bdi_set_min_ratio(bdi, min_ratio);
 }
 @@ -809,13 +813,15 @@ int bdi_set_max_bytes(struct backing_dev_info *bdi, u64
 max_bytes)
 {
        int ret;
        unsigned long pages = max_bytes >> PAGE_SHIFT;

mm/page-writeback.c int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes) · line 823

Quoted 7 lines
mm/page-writeback.c +2 -1
-       unsigned long max_ratio;
+       long max_ratio;
          ret = bdi_check_pages_limit(pages);
        if (ret)
                return ret;
          max_ratio = bdi_ratio_from_pages(pages);
+       if (min_ratio < 0)

I assume you meant max_ratio.

Quoted 5 lines
+               return min_ratio;
        return __bdi_set_max_ratio(bdi, max_ratio);

}
-- Cheers,

I'll use your recommendation for the next version of the patch.