Skip to contentSkip to conversation

i2c: tegra: Return if SMBUS message length is zero

PATCH In review Akhil R 2 participants 3 messages Mar 20, 2025

Subsystems (3)
lore
Share & tools
lore

Akhil R

author
#0 lore raw

PATCH 1/1 i2c: tegra: Return if SMBUS message length is zero

For SMBUS block read, do not continue to read if the message length passed from the device is '0'.

---
 drivers/i2c/busses/i2c-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-tegra.c +1 -1
index 87976e99e6d0..273d6aaa427b 100644
@@ -1393,7 +1393,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
 		/* If M_RECV_LEN use ContinueXfer to read the first byte */
 		if (msgs[i].flags & I2C_M_RECV_LEN) {
 			ret = tegra_i2c_xfer_msg(i2c_dev, &msgs[i], MSG_END_CONTINUE);
-			if (ret)
+			if (ret || msgs[i].buf[0] == 0)
 				break;
 			/* Set the msg length from first byte */
 			msgs[i].len += msgs[i].buf[0];
Signature · 1 line
2.43.2
#1 lore raw
Quoted 2 lines · Akhil R

For SMBUS block read, do not continue to read if the message length passed from the device is '0'.

You probably should also check for I2C_SMBUS_BLOCK_MAX while here.

author
#2 lore raw
Quoted 4 lines
Quoted 2 lines

For SMBUS block read, do not continue to read if the message length passed from the device is '0'.

You probably should also check for I2C_SMBUS_BLOCK_MAX while here.

Done. Posted a new version with this additional check.

Thanks,
Akhil