f2fs: support to disable linear lookup fallback
Chao Yu
maintainerPATCH 1/1 f2fs: support to disable linear lookup fallback
After commit 91b587ba79e1 ("f2fs: Introduce linear search for dentries"), f2fs forced to use linear lookup whenever a hash-based lookup fails on casefolded directory, it may affect performance for scenarios: a) create a new file w/ filename it doesn't exist in directory, b) lookup a file which may be removed.
This patch supports to disable linear lookup fallback, so, once there is a solution for commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points") to fix red heart unicode issue, then we can set an encodeing flag to disable the fallback for performance recovery.
The way is kept in line w/ ext4, refer to commit 9e28059d5664 ("ext4:
introduce linear search for dentries").
--- fs/f2fs/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/dir.c +2 -1
@@ -366,7 +366,8 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, out:#if IS_ENABLED (CONFIG_UNICODE ) -if (IS_CASEFOLDED (dir) && !de && use_hash) { +if (IS_CASEFOLDED (dir) && !de && use_hash && + !sb_no_casefold_compat_fallback (dir->i_sb)) { use_hash = false; goto start_find_entry; }
Signature · 1 line
2.49.0
Quoted 27 lines · Chao Yu
After commit
91b587ba79e1("f2fs: Introduce linear search for dentries"), f2fs forced to use linear lookup whenever a hash-based lookup fails on casefolded directory, it may affect performance for scenarios: a) create a new file w/ filename it doesn't exist in directory, b) lookup a file which may be removed.This patch supports to disable linear lookup fallback, so, once there is a solution for commit
5c26d2f1d3f5("unicode: Don't special case ignorable code points") to fix red heart unicode issue, then we can set an encodeing flag to disable the fallback for performance recovery.The way is kept in line w/ ext4, refer to commit
9e28059d5664("ext4:
introduce linear search for dentries").Cc Daniel Lee <[email protected]>Cc Gabriel Krisman Bertazi <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/dir.c +0
-0
fs/f2fs/dir.c struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, · line 370
Quoted 6 lines
fs/f2fs/dir.c +2
-1@@ -366,7 +366,8 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, out:#if IS_ENABLED (CONFIG_UNICODE ) -if (IS_CASEFOLDED (dir) && !de && use_hash) { +if (IS_CASEFOLDED (dir) && !de && use_hash && + !sb_no_casefold_compat_fallback (dir->i_sb)) {
Would it be beneficial to evaluate !sb_no_casefold_compat_fallback(dir->i_sb) first for short-circuiting?
Quoted 7 lines
fs/f2fs/dir.c +0
-1use_hash = false; goto start_find_entry; } --2.49.0
Chao Yu
maintainerQuoted 29 lines · Daniel Lee
Quoted 28 lines · Chao Yu
After commit
91b587ba79e1("f2fs: Introduce linear search for dentries"), f2fs forced to use linear lookup whenever a hash-based lookup fails on casefolded directory, it may affect performance for scenarios: a) create a new file w/ filename it doesn't exist in directory, b) lookup a file which may be removed.This patch supports to disable linear lookup fallback, so, once there is a solution for commit
5c26d2f1d3f5("unicode: Don't special case ignorable code points") to fix red heart unicode issue, then we can set an encodeing flag to disable the fallback for performance recovery.The way is kept in line w/ ext4, refer to commit
9e28059d5664("ext4:
introduce linear search for dentries").Cc Daniel Lee <[email protected]>Cc Gabriel Krisman Bertazi <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/dir.c +0
-0@@ -366,7 +366,8 @@ struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir,
Quoted 9 lines
fs/f2fs/dir.c struct f2fs_dir_entry *__f2fs_find_entry(struct inode *dir, · line 370
Quoted 5 lines
fs/f2fs/dir.c +2
-1out:#if IS_ENABLED (CONFIG_UNICODE ) -if (IS_CASEFOLDED (dir) && !de && use_hash) { +if (IS_CASEFOLDED (dir) && !de && use_hash && + !sb_no_casefold_compat_fallback (dir->i_sb)) {Would it be beneficial to evaluate !sb_no_casefold_compat_fallback(dir->i_sb) first for short-circuiting?
Yeah, I guess it will when we disable the fallback by default, will update v2, thank you!
Thanks,
Quoted 9 lines
Quoted 9 lines
fs/f2fs/dir.c +0
-1use_hash = false; goto start_find_entry; } --2.49.0