staging: gpib: Fix lpvo request_system_control
PATCH 1/1 staging: gpib: Fix lpvo request_system_control
The board should not set the controller-in-charge status in request_system_control. It can only become controller-in-charge by issuing an interface_clear.
Remove the setting of controller-in-charge from request_system_control.
Fixes fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by Dave Penkler <[email protected]>
--- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0 -1
@@ -916,7 +916,6 @@ static int usb_gpib_request_system_control(struct gpib_board *board, int requestif (!request_control)return -EINVAL ; -set_bit (CIC_NUM , &board->status);DIA_LOG (1 ,"done with %d -> %lx\n" , request_control, board->status);return 0 ; }
Signature · 1 line
2.49.0
Quoted 6 lines · Dave Penkler
The board should not set the controller-in-charge status in
request_system_control. It can only become controller-in-charge by issuing aninterface_clear.Remove the setting of controller-in-charge from
request_system_control.
The commit message needs to say what this bug looks like to the user.
regards,
dan carpetner