Skip to contentSkip to conversation

staging: gpib: Fix lpvo request_system_control

PATCH Superseded Dave Penkler 2 participants 2 messages Apr 19, 2025 – Apr 22, 2025 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: gpib: Fix lpvo request_system_control

The board should not set the controller-in-charge status in request_system_control. It can only become controller-in-charge by issuing an interface_clear.

Remove the setting of controller-in-charge from request_system_control.

Fixes fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
---
 drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0 -1
index 2e315c7756c4..3cf5037c0cd2 100644
@@ -916,7 +916,6 @@ static int usb_gpib_request_system_control(struct gpib_board *board, int request
 	if (!request_control)
 		return -EINVAL;
 
-	set_bit(CIC_NUM, &board->status);
 	DIA_LOG(1, "done with %d -> %lx\n", request_control, board->status);
 	return 0;
 }
Signature · 1 line
2.49.0
#1 lore raw
Quoted 6 lines · Dave Penkler

The board should not set the controller-in-charge status in request_system_control. It can only become controller-in-charge by issuing an interface_clear.

Remove the setting of controller-in-charge from request_system_control.

The commit message needs to say what this bug looks like to the user.

regards,
dan carpetner