staging: gpib: Fix lpvo request_system_control
PATCH v2 1/1 staging: gpib: Fix lpvo request_system_control
The IEEE-488 GPIB standard was designed to ensure that there is only ever one controller-in-charge on the bus at any one time. If a board becomes controller-in-charge on request_system_control there is no way to ensure that there is not another board also acting as controller-in-charge. This can lead to bus conflicts and hangs.
Remove the setting of controller-in-charge from request_system_control.
Fixes fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by Dave Penkler <[email protected]>
---
Changes V1->V2: Expand commit message to include user impact of bug
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +0 -1
@@ -916,7 +916,6 @@ static int usb_gpib_request_system_control(struct gpib_board *board, int requestif (!request_control)return -EINVAL ; -set_bit (CIC_NUM , &board->status);DIA_LOG (1 ,"done with %d -> %lx\n" , request_control, board->status);return 0 ; }
Signature · 1 line
2.49.0