kunit: fix longest symbol length test
Subsystems (4)
PATCH 1/1 kunit: fix longest symbol length test
The kunit test that checks the longests symbol length [1], has triggered warnings in some CI pilelines when symbol prefixes are used [2]. The test is adjusted to depend on !CONFIG_PREFIX_SYMBOLS as sujested in [3].
[1] https://lore.kernel.org/rust-for-linux/CABVgOSm=5Q0fM6neBhxSbOUHBgNzmwf2V22vsYC10YRBT=kN1g@mail.gmail.com/T/#t
[2] https://lore.kernel.org/all/[email protected]/T/#u
[3] https://lore.kernel.org/all/ycgbf7jcq7nc62ndqiynogt6hkabgl3hld4uyelgo7rksylf32@oysq7jpchtp4/
--- lib/Kconfig.debug | 2 +- lib/tests/longest_symbol_kunit.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
lib/Kconfig.debug +1 -1
@@ -2885,7 +2885,7 @@ config FORTIFY_KUNIT_TEST config LONGEST_SYM_KUNIT_TEST tristate "Test the longest symbol possible" if !KUNIT_ALL_TESTS - depends on KUNIT && KPROBES + depends on KUNIT && KPROBES && !CONFIG_PREFIX_SYMBOLS default KUNIT_ALL_TESTS help Tests the longest symbol possible
lib/tests/longest_symbol_kunit.c +1 -2
@@ -3,8 +3,7 @@* Test the longest symbol length. Execute with: * ./tools/testing/kunit/kunit.py run longest-symbol * --arch=x86_64 --kconfig_add CONFIG_KPROBES=y --kconfig_add CONFIG_MODULES=y -* --kconfig_add CONFIG_RETPOLINE=n --kconfig_add CONFIG_CFI_CLANG=n -* --kconfig_add CONFIG_MITIGATION_RETPOLINE=n +* --kconfig_add CONFIG_CPU_MITIGATIONS=n */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
base-commit: f1a3944c860b0615d0513110d8cf62bb94adbb41
Signature · 1 line
2.39.2
Nathan Chancellor
maintainerHi Sergio,
Quoted 20 lines · Sergio González Collado
The kunit test that checks the longests symbol length [1], has triggered warnings in some CI pilelines when symbol prefixes are used [2]. The test is adjusted to depend on !CONFIG_PREFIX_SYMBOLS as sujested in [3].
[1] https://lore.kernel.org/rust-for-linux/CABVgOSm=5Q0fM6neBhxSbOUHBgNzmwf2V22vsYC10YRBT=kN1g@mail.gmail.com/T/#t
[2] https://lore.kernel.org/all/[email protected]/T/#u
[3] https://lore.kernel.org/all/ycgbf7jcq7nc62ndqiynogt6hkabgl3hld4uyelgo7rksylf32@oysq7jpchtp4/Fixes c104c16073b7 ("Kunit to check the longest symbol length")Signed-off-by Sergio González Collado <[email protected]>--- lib/Kconfig.debug | 2 +- lib/tests/longest_symbol_kunit.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)lib/Kconfig.debug +0
-0
lib/Kconfig.debug config FORTIFY_KUNIT_TEST · line 2888
Quoted 5 lines
lib/Kconfig.debug +1
-1@@ -2885,7 +2885,7 @@ config FORTIFY_KUNIT_TEST config LONGEST_SYM_KUNIT_TEST tristate "Test the longest symbol possible" if !KUNIT_ALL_TESTS - depends on KUNIT && KPROBES + depends on KUNIT && KPROBES && !CONFIG_PREFIX_SYMBOLS
This should be !PREFIX_SYMBOLS, otherwise it would be looking for a CONFIG_CONFIG_PREFIX_SYMBOLS not to exist, which will always be true.
This solution does not appear to take into account Peter's comment around how kCFI will prefix these symbols as well? Should it depend on !CFI_CLANG as well?
Quoted 22 lines
lib/Kconfig.debug +0
-0default KUNIT_ALL_TESTS help Tests the longest symbol possiblelib/tests/longest_symbol_kunit.c +1
-2@@ -3,8 +3,7 @@* Test the longest symbol length. Execute with: * ./tools/testing/kunit/kunit.py run longest-symbol * --arch=x86_64 --kconfig_add CONFIG_KPROBES=y --kconfig_add CONFIG_MODULES=y -* --kconfig_add CONFIG_RETPOLINE=n --kconfig_add CONFIG_CFI_CLANG=n -* --kconfig_add CONFIG_MITIGATION_RETPOLINE=n +* --kconfig_add CONFIG_CPU_MITIGATIONS=n */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmtbase-commit:
f1a3944c860b0615d0513110d8cf62bb94adbb41Signature · 1 line
2.39.2