[PATCH 0/2]
Subsystems (3)
cover [PATCH 0/2]
This patch introduces a driver for the Eswin eic7700 SoC pinctrl controller, adding support for the pinctrl functionality in the Linux kernel. The driver provides basic functionality to manage and control the pinctrl signals for the eic7700 SoC.
The driver integrates with the Linux pinctrl subsystem, enabling kernel code to trigger pinctrl operations on hardware and ensuring support for pin multiplexing and pin configuration.
Features:
Implements support for the Eswin eic7700 SoC pinctrl controller. Provides API to manage pinctrl for the eic7700 SoC. Integration with the Linux pinctrl subsystem for consistency and scalability.
Supported chips:
Eswin eic7700 SoC.
Test:
I tested this patch on the Sifive HiFive Premier P550 (which uses the EIC7700 SoC), including system boot, networking, EMMC, display, and other peripherals. The drivers for these modules all use the pinctrl module, so this verifies that this pinctrl driver patch is working properly.
luyulin (2):
dt-bindings: pinctrl: eswin: Document for eic7700 SoC
pinctrl: eswin: Add eic7700 pinctrl driver
.../pinctrl/eswin,eic7700-pinctrl.yaml | 156 ++++ drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-eic7700.c | 701 ++++++++++++++++++ 4 files changed, 869 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml create mode 100644 drivers/pinctrl/pinctrl-eic7700.c
Signature · 1 line
2.25.1
PATCH 1/2 dt-bindings: pinctrl: eswin: Document for eic7700 SoC
This commit adds Device Tree binding documentation for the ESWIN EIC7700 pinctrl controller module. The document describes the required properties, compatible strings, and usage examples in the device tree configuration when applying this module.
--- .../pinctrl/eswin,eic7700-pinctrl.yaml | 156 ++++++++++++++++++ 1 file changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +156 -0
@@ -0,0 +1,156 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/eswin,eic7700-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Eswin Eic7700 Pinctrl + +maintainers: + - LuYuLin <[email protected]> + +description: | + Please refer to pinctrl-bindings.txt in this directory for details of the + common pinctrl bindings used by client devices, including the meaning of the + phrase "pin configuration node". + + eic7700 pin configuration nodes act as a container for an arbitrary number of + subnodes. Each of these subnodes represents some desired configuration for one or + more pins. This configuration can include the mux function to select on those pin(s), + and various pin configuration parameters, such as input-enable, pull-up, etc. + +properties: + compatible: + const: eswin,eic7700-pinctrl + + reg: + description: Specifies the base address and size of the SLCR space. + maxItems: 1 + + "vrgmii-supply": + description: + Regulator supply for the RGMII interface IO power domain. + This property should reference a regulator that provides either 1.8V or 3.3V, + depending on the board-level voltage configuration required by the RGMII interface. + +patternProperties: + '^(.*-)?(pins)$': + type: object + description: + Pinctrl node's client devices use subnodes for pin muxes, + which in turn use below standard properties. + + properties: + pins: + description: + For eic7700, specifies the name(s) of one or more pins to be configured by + this node. + items: + enum: [ chip_mode, mode_set0, mode_set1, mode_set2, mode_set3, xin, + rst_out_n, key_reset_n, gpio0, por_sel, jtag0_tck, jtag0_tms, + jtag0_tdi, jtag0_tdo, gpio5, spi2_cs0_n, jtag1_tck, jtag1_tms, + jtag1_tdi, jtag1_tdo, gpio11, spi2_cs1_n, pcie_clkreq_n, + pcie_wake_n, pcie_perst_n, hdmi_scl, hdmi_sda, hdmi_cec, + jtag2_trst, rgmii0_clk_125, rgmii0_txen, rgmii0_txclk, + rgmii0_txd0, rgmii0_txd1, rgmii0_txd2, rgmii0_txd3, i2s0_bclk, + i2s0_wclk, i2s0_sdi, i2s0_sdo, i2s_mclk, rgmii0_rxclk, + rgmii0_rxdv, rgmii0_rxd0, rgmii0_rxd1, rgmii0_rxd2, rgmii0_rxd3, + i2s2_bclk, i2s2_wclk, i2s2_sdi, i2s2_sdo, gpio27, gpio28, gpio29, + rgmii0_mdc, rgmii0_mdio, rgmii0_intb, rgmii1_clk_125, rgmii1_txen, + rgmii1_txclk, rgmii1_txd0, rgmii1_txd1, rgmii1_txd2, rgmii1_txd3, + i2s1_bclk, i2s1_wclk, i2s1_sdi, i2s1_sdo, gpio34, rgmii1_rxclk, + rgmii1_rxdv, rgmii1_rxd0, rgmii1_rxd1, rgmii1_rxd2, rgmii1_rxd3, + spi1_cs0_n, spi1_clk, spi1_d0, spi1_d1, spi1_d2, spi1_d3, spi1_cs1_n, + rgmii1_mdc, rgmii1_mdio, rgmii1_intb, usb0_pwren, usb1_pwren, + i2c0_scl, i2c0_sda, i2c1_scl, i2c1_sda, i2c2_scl, i2c2_sda, + i2c3_scl, i2c3_sda, i2c4_scl, i2c4_sda, i2c5_scl, i2c5_sda, + uart0_tx, uart0_rx, uart1_tx, uart1_rx, uart1_cts, uart1_rts, + uart2_tx, uart2_rx, jtag2_tck, jtag2_tms, jtag2_tdi, jtag2_tdo, + fan_pwm, fan_tach, mipi_csi0_xvs, mipi_csi0_xhs, mipi_csi0_mclk, + mipi_csi1_xvs, mipi_csi1_xhs, mipi_csi1_mclk, mipi_csi2_xvs, + mipi_csi2_xhs, mipi_csi2_mclk, mipi_csi3_xvs, mipi_csi3_xhs, + mipi_csi3_mclk, mipi_csi4_xvs, mipi_csi4_xhs, mipi_csi4_mclk, + mipi_csi5_xvs, mipi_csi5_xhs, mipi_csi5_mclk, spi3_cs_n, spi3_clk, + spi3_di, spi3_do, gpio92, gpio93, s_mode, gpio95, spi0_cs_n, + spi0_clk, spi0_d0, spi0_d1, spi0_d2, spi0_d3, i2c10_scl, + i2c10_sda, i2c11_scl, i2c11_sda, gpio106, boot_sel0, boot_sel1, + boot_sel2, boot_sel3, gpio111, lpddr_ref_clk ] + + function: + description: + Specify the alternative function to be configured for the + given pins. + enum: [ disabled, boot_sel, chip_mode, emmc, fan_tach, + gpio, hdmi, i2c, i2s, jtag, ddr_ref_clk_sel, + lpddr_ref_clk, mipi_csi, osc, pcie, pwm, + rgmii, reset, sata, sdio, spi, s_mode, uart, usb ] + + input-schmitt-enable: true + + input-schmitt-disable: true + + bias-disable: true + + bias-pull-down: true + + bias-pull-up: true + + input-enable: true + + input-disable: true + + drive-strength-microamp: true + + allOf: + - $ref: pincfg-node.yaml# + - $ref: pinmux-node.yaml# + + - if: + properties: + pins: + anyOf: + - pattern: '^rgmii' + - const: lpddr_ref_clk + then: + properties: + drive-strength-microamp: + enum: [3000, 6000, 9000, 12000, 15000, 18000, 21000, 24000] + else: + properties: + drive-strength-microamp: + enum: [6000, 9000, 12000, 15000, 18000, 21000, 24000, 27000] + + required: + - pins + + additionalProperties: false + +allOf: + - $ref: pinctrl.yaml# + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pinctrl@51600080 { + compatible = "eswin,eic7700-pinctrl"; + reg = <0x51600080 0x1fff80>; + vrgmii-supply = <&vcc_1v8>; + gpio10_pins: gpio10-pins { + pins = "jtag1_tdo"; + function = "gpio"; + input-enable; + bias-pull-up; + }; + }; + + i2c2 { + pinctrl-names = "default"; + pinctrl-0 = <&gpio10_pins>; + }; + +...
Signature · 1 line
2.25.1
Re: [PATCH 1/2] dt-bindings: pinctrl: eswin: Document for eic7700 SoC
Quoted 1 line · luyulin
This commit adds Device Tree binding documentation for the
Please do not use "This commit/patch/change", but imperative mood. See longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
Quoted 3 lines
ESWIN EIC7700 pinctrl controller module. The document describes the required properties, compatible strings, and usage examples in the device tree configuration when applying this module.
Do not explain what DT binding is. We all know. Explain the hardware. See also other comits as examples.
Quoted 4 lines
Co-developed-by Samuel Holland <[email protected]>Signed-off-by Samuel Holland <[email protected]>Signed-off-by luyulin <[email protected]>
Looks like you used login name as full name. Use rather latin transcription or your name in your native language.
Quoted 2 lines
--- .../pinctrl/eswin,eic7700-pinctrl.yaml | 156 ++++++++++++++++++
This was already send and reviewed. Implement previous feedback
https://lore.kernel.org/all/20250326-owl-of-algebraic-wealth-61aeda@krzk-bin/
Then please version your patches correctly, e.g. use b4 or git format-patch -vX, and add changelog in cover letter or under '---' of individual patches describing changes from previous version.
Quoted 14 lines
1 file changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yamlDocumentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +5
-0@@ -0,0 +1,156 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/eswin,eic7700-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 15
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +10
-0+ +title: Eswin Eic7700 Pinctrl + +maintainers: + - LuYuLin <[email protected]> + +description: | + Please refer to pinctrl-bindings.txt in this directory for details of the + common pinctrl bindings used by client devices, including the meaning of the + phrase "pin configuration node".
Drop this paragraph, redundant.
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 27
Quoted 12 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +12
-0+ + eic7700 pin configuration nodes act as a container for an arbitrary number of + subnodes. Each of these subnodes represents some desired configuration for one or + more pins. This configuration can include the mux function to select on those pin(s), + and various pin configuration parameters, such as input-enable, pull-up, etc. + +properties: + compatible: + const: eswin,eic7700-pinctrl + + reg: + description: Specifies the base address and size of the SLCR space.
Drop description, redundant.
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 30
Quoted 3 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +3
-0+ maxItems: 1 + + "vrgmii-supply":
Open existing bindings. Do you see any property written like that? No, therefore do not come with own syntax,
Drop quotes,
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 37
Quoted 7 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +7
-0+ description: + Regulator supply for the RGMII interface IO power domain. + This property should reference a regulator that provides either 1.8V or 3.3V, + depending on the board-level voltage configuration required by the RGMII interface. + +patternProperties: + '^(.*-)?(pins)$':
Weirdly complicated pattern. Why not just "-pins$"? For which case do you need "pins" name?
Quoted 96 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +96
-0+ type: object + description: + Pinctrl node's client devices use subnodes for pin muxes, + which in turn use below standard properties. + + properties: + pins: + description: + For eic7700, specifies the name(s) of one or more pins to be configured by + this node. + items: + enum: [ chip_mode, mode_set0, mode_set1, mode_set2, mode_set3, xin, + rst_out_n, key_reset_n, gpio0, por_sel, jtag0_tck, jtag0_tms, + jtag0_tdi, jtag0_tdo, gpio5, spi2_cs0_n, jtag1_tck, jtag1_tms, + jtag1_tdi, jtag1_tdo, gpio11, spi2_cs1_n, pcie_clkreq_n, + pcie_wake_n, pcie_perst_n, hdmi_scl, hdmi_sda, hdmi_cec, + jtag2_trst, rgmii0_clk_125, rgmii0_txen, rgmii0_txclk, + rgmii0_txd0, rgmii0_txd1, rgmii0_txd2, rgmii0_txd3, i2s0_bclk, + i2s0_wclk, i2s0_sdi, i2s0_sdo, i2s_mclk, rgmii0_rxclk, + rgmii0_rxdv, rgmii0_rxd0, rgmii0_rxd1, rgmii0_rxd2, rgmii0_rxd3, + i2s2_bclk, i2s2_wclk, i2s2_sdi, i2s2_sdo, gpio27, gpio28, gpio29, + rgmii0_mdc, rgmii0_mdio, rgmii0_intb, rgmii1_clk_125, rgmii1_txen, + rgmii1_txclk, rgmii1_txd0, rgmii1_txd1, rgmii1_txd2, rgmii1_txd3, + i2s1_bclk, i2s1_wclk, i2s1_sdi, i2s1_sdo, gpio34, rgmii1_rxclk, + rgmii1_rxdv, rgmii1_rxd0, rgmii1_rxd1, rgmii1_rxd2, rgmii1_rxd3, + spi1_cs0_n, spi1_clk, spi1_d0, spi1_d1, spi1_d2, spi1_d3, spi1_cs1_n, + rgmii1_mdc, rgmii1_mdio, rgmii1_intb, usb0_pwren, usb1_pwren, + i2c0_scl, i2c0_sda, i2c1_scl, i2c1_sda, i2c2_scl, i2c2_sda, + i2c3_scl, i2c3_sda, i2c4_scl, i2c4_sda, i2c5_scl, i2c5_sda, + uart0_tx, uart0_rx, uart1_tx, uart1_rx, uart1_cts, uart1_rts, + uart2_tx, uart2_rx, jtag2_tck, jtag2_tms, jtag2_tdi, jtag2_tdo, + fan_pwm, fan_tach, mipi_csi0_xvs, mipi_csi0_xhs, mipi_csi0_mclk, + mipi_csi1_xvs, mipi_csi1_xhs, mipi_csi1_mclk, mipi_csi2_xvs, + mipi_csi2_xhs, mipi_csi2_mclk, mipi_csi3_xvs, mipi_csi3_xhs, + mipi_csi3_mclk, mipi_csi4_xvs, mipi_csi4_xhs, mipi_csi4_mclk, + mipi_csi5_xvs, mipi_csi5_xhs, mipi_csi5_mclk, spi3_cs_n, spi3_clk, + spi3_di, spi3_do, gpio92, gpio93, s_mode, gpio95, spi0_cs_n, + spi0_clk, spi0_d0, spi0_d1, spi0_d2, spi0_d3, i2c10_scl, + i2c10_sda, i2c11_scl, i2c11_sda, gpio106, boot_sel0, boot_sel1, + boot_sel2, boot_sel3, gpio111, lpddr_ref_clk ] + + function: + description: + Specify the alternative function to be configured for the + given pins. + enum: [ disabled, boot_sel, chip_mode, emmc, fan_tach, + gpio, hdmi, i2c, i2s, jtag, ddr_ref_clk_sel, + lpddr_ref_clk, mipi_csi, osc, pcie, pwm, + rgmii, reset, sata, sdio, spi, s_mode, uart, usb ] + + input-schmitt-enable: true + + input-schmitt-disable: true + + bias-disable: true + + bias-pull-down: true + + bias-pull-up: true + + input-enable: true + + input-disable: true + + drive-strength-microamp: true + + allOf: + - $ref: pincfg-node.yaml# + - $ref: pinmux-node.yaml# + + - if: + properties: + pins: + anyOf: + - pattern: '^rgmii' + - const: lpddr_ref_clk + then: + properties: + drive-strength-microamp: + enum: [3000, 6000, 9000, 12000, 15000, 18000, 21000, 24000] + else: + properties: + drive-strength-microamp: + enum: [6000, 9000, 12000, 15000, 18000, 21000, 24000, 27000] + + required: + - pins + + additionalProperties: false + +allOf: + - $ref: pinctrl.yaml# + +required: + - compatible + - reg
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 143
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +10
-0+ +additionalProperties: false + +examples: + - | + pinctrl@51600080 { + compatible = "eswin,eic7700-pinctrl"; + reg = <0x51600080 0x1fff80>; + vrgmii-supply = <&vcc_1v8>; + gpio10_pins: gpio10-pins {
Drop label.
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml line 151
Quoted 8 lines
Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml new file +8
-0+ pins = "jtag1_tdo"; + function = "gpio"; + input-enable; + bias-pull-up; + }; + }; + + i2c2 {
Drop this node, not relevant.
Best regards,
Krzysztof
PATCH 2/2 pinctrl: eswin: Add eic7700 pinctrl driver
In reply to luyulinAdd support for the pin controller in ESWIN's EIC7700 SoC, which supports pin multiplexing, pin configuration, and rgmii voltage control.
--- drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-eic7700.c | 701 ++++++++++++++++++++++++++++++ 3 files changed, 713 insertions(+) create mode 100644 drivers/pinctrl/pinctrl-eic7700.c
drivers/pinctrl/Kconfig +11 -0
@@ -208,6 +208,17 @@ config PINCTRL_DIGICOLOR select PINMUX select GENERIC_PINCONF +config PINCTRL_EIC7700 + tristate "EIC7700 PINCTRL driver" + depends on ARCH_ESWIN || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver support for the pin controller in ESWIN's EIC7700 SoC, + which supports pin multiplexing, pin configuration,and rgmii voltage + control. + Say Y here to enable the eic7700 pinctrl driver + config PINCTRL_EP93XX bool depends on ARCH_EP93XX || COMPILE_TEST
drivers/pinctrl/Makefile +1 -0
@@ -23,6 +23,7 @@ obj-$(CONFIG_PINCTRL_CY8C95X0) += pinctrl-cy8c95x0.o obj-$(CONFIG_PINCTRL_DA850_PUPD) += pinctrl-da850-pupd.o obj-$(CONFIG_PINCTRL_DA9062) += pinctrl-da9062.o obj-$(CONFIG_PINCTRL_DIGICOLOR) += pinctrl-digicolor.o +obj-$(CONFIG_PINCTRL_EIC7700) += pinctrl-eic7700.o obj-$(CONFIG_PINCTRL_EQUILIBRIUM) += pinctrl-equilibrium.o obj-$(CONFIG_PINCTRL_EP93XX) += pinctrl-ep93xx.o obj-$(CONFIG_PINCTRL_EYEQ5) += pinctrl-eyeq5.o
drivers/pinctrl/pinctrl-eic7700.c new file +701 -0
701 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH 2/2] pinctrl: eswin: Add eic7700 pinctrl driver
Quoted 10 lines · luyulin
drivers/pinctrl/pinctrl-eic7700.c new file +10
-0+static int eic7700_pinctrl_probe (struct platform_device *pdev) +{ +struct device *dev = &pdev->dev; +struct pinctrl_dev *pctldev; +struct eic7700_pinctrl *pc; +struct regulator *regulator; +u32 voltage, rgmii0_mode, rgmii1_mode; +int ret; + + pc =devm_kzalloc (dev,struct_size (pc, functions,EIC7700_FUNCTIONS_COUNT ),GFP_KERNEL );
drivers/pinctrl/pinctrl-eic7700.c line 636
Quoted 10 lines
drivers/pinctrl/pinctrl-eic7700.c new file +10
-0+if (!pc) +return -ENOMEM ; + + pc->base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (pc->base)) +return PTR_ERR (pc->base); + + regulator =devm_regulator_get (dev,"vrgmii" ); +if (IS_ERR_OR_NULL (regulator)) { +dev_err (dev,"failed to get vrgmii regulator!\n" );
Hm? So here you do not use dev_err_probe, even though it is actually important, but...
...
drivers/pinctrl/pinctrl-eic7700.c line 678
Quoted 4 lines
drivers/pinctrl/pinctrl-eic7700.c new file +4
-0+ + ret =devm_pinctrl_register_and_init (dev, &pc->desc, pc, &pctldev); +if (ret) +return dev_err_probe (dev, ret,"could not register pinctrl driver\n" );
Here you use, even though here it actually does not matter? It makes no sense, it is not logical. If using dev_err_probe selectively, then use it when it matters - so for probe deferal. Or preferred is to use it always.
Best regards,
Krzysztof
kernel test robot
build botRe: [PATCH 2/2] pinctrl: eswin: Add eic7700 pinctrl driver
In reply to luyulinkernel test robot noticed the following build errors:
Hi luyulin,
kernel test robot noticed the following build errors:
[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on linusw-pinctrl/for-next robh/for-next linus/master v6.15-rc5 next-20250507] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/luyulin/pinctrl-eswin-Add-eic7700-pinctrl-driver/20250506-181212 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20250506091241.941-1-luyulin%40eswincomputing.com patch subject: [PATCH 2/2] pinctrl: eswin: Add eic7700 pinctrl driver config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250508/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250508/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:123:9: note: in expansion of macro 'EIC7700_PIN'
123 | EIC7700_PIN(0, "chip_mode", [0] = F_CHIP_MODE),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:123:9: note: in expansion of macro 'EIC7700_PIN'
123 | EIC7700_PIN(0, "chip_mode", [0] = F_CHIP_MODE),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:123:9: note: in expansion of macro 'EIC7700_PIN'
123 | EIC7700_PIN(0, "chip_mode", [0] = F_CHIP_MODE),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:124:9: note: in expansion of macro 'EIC7700_PIN'
124 | EIC7700_PIN(1, "mode_set0", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:124:9: note: in expansion of macro 'EIC7700_PIN'
124 | EIC7700_PIN(1, "mode_set0", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:124:9: note: in expansion of macro 'EIC7700_PIN'
124 | EIC7700_PIN(1, "mode_set0", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:125:9: note: in expansion of macro 'EIC7700_PIN'
125 | EIC7700_PIN(2, "mode_set1", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:125:9: note: in expansion of macro 'EIC7700_PIN'
125 | EIC7700_PIN(2, "mode_set1", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:125:9: note: in expansion of macro 'EIC7700_PIN'
125 | EIC7700_PIN(2, "mode_set1", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:126:9: note: in expansion of macro 'EIC7700_PIN'
126 | EIC7700_PIN(3, "mode_set2", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:126:9: note: in expansion of macro 'EIC7700_PIN'
126 | EIC7700_PIN(3, "mode_set2", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:126:9: note: in expansion of macro 'EIC7700_PIN'
126 | EIC7700_PIN(3, "mode_set2", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:127:9: note: in expansion of macro 'EIC7700_PIN'
127 | EIC7700_PIN(4, "mode_set3", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:127:9: note: in expansion of macro 'EIC7700_PIN'
127 | EIC7700_PIN(4, "mode_set3", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:127:9: note: in expansion of macro 'EIC7700_PIN'
127 | EIC7700_PIN(4, "mode_set3", [0] = F_SDIO, [2] = F_GPIO),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:128:9: note: in expansion of macro 'EIC7700_PIN'
128 | EIC7700_PIN(5, "xin", [0] = F_OSC),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:128:9: note: in expansion of macro 'EIC7700_PIN'
128 | EIC7700_PIN(5, "xin", [0] = F_OSC),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:128:9: note: in expansion of macro 'EIC7700_PIN'
128 | EIC7700_PIN(5, "xin", [0] = F_OSC),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:129:9: note: in expansion of macro 'EIC7700_PIN'
129 | EIC7700_PIN(6, "rtc_xin", [0] = F_DISABLED),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:129:9: note: in expansion of macro 'EIC7700_PIN'
129 | EIC7700_PIN(6, "rtc_xin", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:129:9: note: in expansion of macro 'EIC7700_PIN'
129 | EIC7700_PIN(6, "rtc_xin", [0] = F_DISABLED),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:130:9: note: in expansion of macro 'EIC7700_PIN'
130 | EIC7700_PIN(7, "rst_out_n", [0] = F_RESET),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:130:9: note: in expansion of macro 'EIC7700_PIN'
130 | EIC7700_PIN(7, "rst_out_n", [0] = F_RESET),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:130:9: note: in expansion of macro 'EIC7700_PIN'
130 | EIC7700_PIN(7, "rst_out_n", [0] = F_RESET),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:131:9: note: in expansion of macro 'EIC7700_PIN'
131 | EIC7700_PIN(8, "key_reset_n", [0] = F_RESET),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:131:9: note: in expansion of macro 'EIC7700_PIN'
131 | EIC7700_PIN(8, "key_reset_n", [0] = F_RESET),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:131:9: note: in expansion of macro 'EIC7700_PIN'
131 | EIC7700_PIN(8, "key_reset_n", [0] = F_RESET),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:132:9: note: in expansion of macro 'EIC7700_PIN'
132 | EIC7700_PIN(9, "rst_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
>> drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:132:9: note: in expansion of macro 'EIC7700_PIN'
132 | EIC7700_PIN(9, "rst_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:132:9: note: in expansion of macro 'EIC7700_PIN'
132 | EIC7700_PIN(9, "rst_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:133:9: note: in expansion of macro 'EIC7700_PIN'
133 | EIC7700_PIN(10, "por_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:133:9: note: in expansion of macro 'EIC7700_PIN'
133 | EIC7700_PIN(10, "por_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:133:9: note: in expansion of macro 'EIC7700_PIN'
133 | EIC7700_PIN(10, "por_in_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:134:9: note: in expansion of macro 'EIC7700_PIN'
134 | EIC7700_PIN(11, "por_out_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:134:9: note: in expansion of macro 'EIC7700_PIN'
134 | EIC7700_PIN(11, "por_out_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:134:9: note: in expansion of macro 'EIC7700_PIN'
134 | EIC7700_PIN(11, "por_out_n", [0] = F_DISABLED),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:135:9: note: in expansion of macro 'EIC7700_PIN'
135 | EIC7700_PIN(12, "gpio0", [0] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:135:9: note: in expansion of macro 'EIC7700_PIN'
135 | EIC7700_PIN(12, "gpio0", [0] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:135:9: note: in expansion of macro 'EIC7700_PIN'
135 | EIC7700_PIN(12, "gpio0", [0] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:136:9: note: in expansion of macro 'EIC7700_PIN'
136 | EIC7700_PIN(13, "por_sel", [0] = F_RESET),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:136:9: note: in expansion of macro 'EIC7700_PIN'
136 | EIC7700_PIN(13, "por_sel", [0] = F_RESET),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:136:9: note: in expansion of macro 'EIC7700_PIN'
136 | EIC7700_PIN(13, "por_sel", [0] = F_RESET),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:39: error: expected expression before 'static'
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^~~~~~
drivers/pinctrl/pinctrl-eic7700.c:137:9: note: in expansion of macro 'EIC7700_PIN'
137 | EIC7700_PIN(14, "jtag0_tck", [0] = F_JTAG, [1] = F_SPI, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:119:72: error: expected '}' before '{' token
119 | .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \
| ^
drivers/pinctrl/pinctrl-eic7700.c:137:9: note: in expansion of macro 'EIC7700_PIN'
137 | EIC7700_PIN(14, "jtag0_tck", [0] = F_JTAG, [1] = F_SPI, [2] = F_GPIO),
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-eic7700.c:116:9: note: to match this '{'
116 | { \
| ^
drivers/pinctrl/pinctrl-eic7700.c:137:9: note: in expansion of macro 'EIC7700_PIN'
137 | EIC7700_PIN(14, "jtag0_tck", [0] = F_JTAG, [1] = F_SPI, [2] = F_GPIO),vim +/static +119 drivers/pinctrl/pinctrl-eic7700.c
114
115 #define EIC7700_PIN(_number, _name, ...) \
116 { \
117 .number = _number, \
118 .name = _name, \
> 119 .drv_data = (void *)&(static const struct eic7700_pin) { { __VA_ARGS__ } } \ 120 }
121
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki