Skip to contentSkip to conversation

clk: meson-g12a: fix missing spicc clks to clk_sel

PATCH Superseded Da Xue 2 participants 2 messages May 11, 2025

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Da Xue

author
#0 lore raw

PATCH 1/1 clk: meson-g12a: fix missing spicc clks to clk_sel

HHI_SPICC_CLK_CNTL bits 25:23 controls spicc clk_sel.

It is missing fclk_div 2 and gp0_pll which causes the spicc module to output the incorrect clocks for spicc sclk at 2.5x the expected rate.

Add the missing clocks resolves this.

Cc <[email protected]> # 6.1.x: a18c8e0: clk: meson: g12a: add
---
 drivers/clk/meson/g12a.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/meson/g12a.c +2 -0
index 4f92b83965d5a..892862bf39996 100644
@@ -4099,8 +4099,10 @@ static const struct clk_parent_data spicc_sclk_parent_data[] = {
 	{ .hw = &g12a_clk81.hw },
 	{ .hw = &g12a_fclk_div4.hw },
 	{ .hw = &g12a_fclk_div3.hw },
+	{ .hw = &g12a_fclk_div2.hw },
 	{ .hw = &g12a_fclk_div5.hw },
 	{ .hw = &g12a_fclk_div7.hw },
+	{ .hw = &g12a_gp0_pll.hw, },
 };
 
 static struct clk_regmap g12a_spicc0_sclk_sel = {
Signature · 1 line
2.39.5
#1 lore raw

Sorry, this is an older version of the patch without Fixes tag from a mv error. I'm sending a v2, ignore this one.

Quoted 37 lines · Da Xue

HHI_SPICC_CLK_CNTL bits 25:23 controls spicc clk_sel.

It is missing fclk_div 2 and gp0_pll which causes the spicc module to output the incorrect clocks for spicc sclk at 2.5x the expected rate.

Add the missing clocks resolves this.

Cc <[email protected]> # 6.1.x: a18c8e0: clk: meson: g12a: add
---
 drivers/clk/meson/g12a.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/meson/g12a.c +2 -1
index 4f92b83965d5a..892862bf39996 100644
@@ -4099,8 +4099,10 @@ static const struct clk_parent_data spicc_sclk_parent_data[] = {
        { .hw = &g12a_clk81.hw },
        { .hw = &g12a_fclk_div4.hw },
        { .hw = &g12a_fclk_div3.hw },
+       { .hw = &g12a_fclk_div2.hw },
        { .hw = &g12a_fclk_div5.hw },
        { .hw = &g12a_fclk_div7.hw },
+       { .hw = &g12a_gp0_pll.hw, },
 };
 
 static struct clk_regmap g12a_spicc0_sclk_sel = {
--

2.39.5

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic