hmp-cmds-target.c: add CPU_DUMP_VPU in hmp_info_registers()
PATCH 1/1 hmp-cmds-target.c: add CPU_DUMP_VPU in hmp_info_registers()
Commit b84694defb added the CPU_DUMP_VPU to allow vector registers to be logged by log_cpu_exec() in TCG. This flag was then used in commit b227f6a8a7 to print RISC-V vector registers using this flag. Note that this change was done in riscv_cpu_dump_state(), the cpu_dump_state() callback for RISC-V, the same callback used in hmp_info_registers().
Back then we forgot to change hmp_info_registers(), and 'info registers' isn't showing RISC-V vector registers as a result. No other target is impacted since only RISC-V is using CPU_DUMP_VPU.
There's no reason to not show VPU regs in info_registers(), so add CPU_DUMP_VPU to hmp_info_registers(). This will print vector registers for all RISC-V machines and, as said above, has no impact in other archs.
--- monitor/hmp-cmds-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
monitor/hmp-cmds-target.c +2 -2
@@ -102,7 +102,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict)if (all_cpus) {CPU_FOREACH (cs) {monitor_printf (mon,"\nCPU#%d\n" , cs->cpu_index); -cpu_dump_state (cs,NULL ,CPU_DUMP_FPU ); +cpu_dump_state (cs,NULL ,CPU_DUMP_FPU |CPU_DUMP_VPU ); } }else { cs = vcpu >=0 ?qemu_get_cpu (vcpu) :mon_get_cpu (mon);
@@ -117,7 +117,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict) }monitor_printf (mon,"\nCPU#%d\n" , cs->cpu_index); -cpu_dump_state (cs,NULL ,CPU_DUMP_FPU ); +cpu_dump_state (cs,NULL ,CPU_DUMP_FPU |CPU_DUMP_VPU ); } }
Signature · 1 line
2.49.0
Quoted 11 lines · Daniel Henrique Barboza
Commit
b84694defbadded theCPU_DUMP_VPUto allow vector registers to be logged bylog_cpu_exec()in TCG. This flag was then used in commitb227f6a8a7to print RISC-V vector registers using this flag. Note that this change was done inriscv_cpu_dump_state(), thecpu_dump_state()callback for RISC-V, the same callback used inhmp_info_registers().Back then we forgot to change
hmp_info_registers(), and 'info registers' isn't showing RISC-V vector registers as a result. No other target is impacted since only RISC-V is usingCPU_DUMP_VPU.
Quoted 7 lines
There's no reason to not show VPU regs in
info_registers(), so addCPU_DUMP_VPUtohmp_info_registers(). This will print vector registers for all RISC-V machines and, as said above, has no impact in other archs.Cc Dr. David Alan Gilbert <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>
Alistair
Quoted 30 lines
--- monitor/hmp-cmds-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)monitor/hmp-cmds-target.c +2
-3@@ -102,7 +102,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict)if (all_cpus) {CPU_FOREACH (cs) {monitor_printf (mon,"\nCPU#%d\n" , cs->cpu_index); -cpu_dump_state (cs,NULL ,CPU_DUMP_FPU ); +cpu_dump_state (cs,NULL ,CPU_DUMP_FPU |CPU_DUMP_VPU ); } }else { cs = vcpu >=0 ?qemu_get_cpu (vcpu) :mon_get_cpu (mon);@@ -117,7 +117,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict) }monitor_printf (mon,"\nCPU#%d\n" , cs->cpu_index); -cpu_dump_state (cs,NULL ,CPU_DUMP_FPU ); +cpu_dump_state (cs,NULL ,CPU_DUMP_FPU |CPU_DUMP_VPU ); } } --2.49.0
Quoted 15 lines · Daniel Henrique Barboza
Commit
b84694defbadded theCPU_DUMP_VPUto allow vector registers to be logged bylog_cpu_exec()in TCG. This flag was then used in commitb227f6a8a7to print RISC-V vector registers using this flag. Note that this change was done inriscv_cpu_dump_state(), thecpu_dump_state()callback for RISC-V, the same callback used inhmp_info_registers().Back then we forgot to change
hmp_info_registers(), and 'info registers' isn't showing RISC-V vector registers as a result. No other target is impacted since only RISC-V is usingCPU_DUMP_VPU.There's no reason to not show VPU regs in
info_registers(), so addCPU_DUMP_VPUtohmp_info_registers(). This will print vector registers for all RISC-V machines and, as said above, has no impact in other archs.
Quoted 5 lines
Cc Dr. David Alan Gilbert <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>--- monitor/hmp-cmds-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 15 lines · Daniel Henrique Barboza
Commit
b84694defbadded theCPU_DUMP_VPUto allow vector registers to be logged bylog_cpu_exec()in TCG. This flag was then used in commitb227f6a8a7to print RISC-V vector registers using this flag. Note that this change was done inriscv_cpu_dump_state(), thecpu_dump_state()callback for RISC-V, the same callback used inhmp_info_registers().Back then we forgot to change
hmp_info_registers(), and 'info registers' isn't showing RISC-V vector registers as a result. No other target is impacted since only RISC-V is usingCPU_DUMP_VPU.There's no reason to not show VPU regs in
info_registers(), so addCPU_DUMP_VPUtohmp_info_registers(). This will print vector registers for all RISC-V machines and, as said above, has no impact in other archs.
Quoted 5 lines
Cc Dr. David Alan Gilbert <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>--- monitor/hmp-cmds-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks.