Skip to contentSkip to conversation

xen/efi: Do not undefined not defined macro

PATCH Superseded Frediano Ziglio 2 participants 4 messages Jun 24, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/efi: Do not undefined not defined macro

The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff (cfr "xen/keyhandler: Drop keyhandler_scratch").

---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
index ded7cc129d..1a9b4e7dae 100644
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
Signature · 1 line
2.43.0
#1 lore raw
Quoted 1 line · Frediano Ziglio

Typo on title "Do not undefined not defined macro" -> "Do not undefine not defined macro"

Quoted 21 lines

The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff (cfr "xen/keyhandler: Drop keyhandler_scratch").

---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
index ded7cc129d..1a9b4e7dae 100644
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
#2 lore raw
Quoted 6 lines · Frediano Ziglio
Quoted 1 line · Frediano Ziglio

Typo on title "Do not undefined not defined macro" -> "Do not undefine not defined macro"

With typo fixed:

Quoted 21 lines
Quoted 21 lines

The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff (cfr "xen/keyhandler: Drop keyhandler_scratch").

---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
index ded7cc129d..1a9b4e7dae 100644
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
Signature · 3 lines
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
#3 lore raw
Quoted 11 lines · Marek Marczykowski-Górecki
Quoted 6 lines · Frediano Ziglio
Quoted 1 line · Frediano Ziglio

Typo on title "Do not undefined not defined macro" -> "Do not undefine not defined macro"

With typo fixed:

Oh, and maybe:

Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
Quoted 26 lines
Quoted 21 lines
Quoted 21 lines

The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff (cfr "xen/keyhandler: Drop keyhandler_scratch").

---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
index ded7cc129d..1a9b4e7dae 100644
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
Signature · 3 lines
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
Signature · 3 lines
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab