xen/efi: Do not undefine not defined macro
PATCH v2 1/1 xen/efi: Do not undefine not defined macro
The "buffer" macro is not defined.
---
Changes since v1:
- fixed commit message;
- added Acked-by.
--- xen/common/efi/boot.c | 1 - 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
@@ -556,7 +556,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_ielse *leaf = buffer;#undef BUFFERSIZE -#undef bufferreturn dir_handle; }
Signature · 1 line
2.43.0
Quoted 5 lines · Frediano Ziglio
The "buffer" macro is not defined.
Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")Signed-off-by Frediano Ziglio <[email protected]>
While correct, the grammar isn't great. I'd suggest "Drop stale #undef buffer" for the subject, and "The "buffer" macro was removed when keyhandler_scratch was removed."
Can fix on commit.
~Andrew
Quoted 4 lines · Andrew Cooper
Quoted 2 lines · Frediano Ziglio
The "buffer" macro is not defined.
Quoted 8 lines
Quoted 3 lines
Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")Signed-off-by Frediano Ziglio <[email protected]>While correct, the grammar isn't great. I'd suggest "Drop stale #undef buffer" for the subject, and "The "buffer" macro was removed when
keyhandler_scratchwas removed."
Fine for me.
Not sure about the acknowledgement.
Quoted 3 lines
Can fix on commit.
~Andrew
Frediano
Quoted 10 lines · Frediano Ziglio
Quoted 8 lines · Andrew Cooper
Quoted 5 lines · Frediano Ziglio
The "buffer" macro is not defined.
Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")Signed-off-by Frediano Ziglio <[email protected]>
Quoted 6 lines
Quoted 4 lines
While correct, the grammar isn't great. I'd suggest "Drop stale #undef buffer" for the subject, and "The "buffer" macro was removed when
keyhandler_scratchwas removed."Fine for me.
Fine with me too.
Quoted 7 lines
Not sure about the acknowledgement.
Quoted 3 lines
Can fix on commit.
~Andrew
Frediano
Signature · 3 lines
Best Regards, Marek Marczykowski-Górecki Invisible Things Lab