Skip to contentSkip to conversation

xen/efi: Do not undefine not defined macro

PATCH In review Frediano Ziglio 3 participants 4 messages Jun 24, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xen/efi: Do not undefine not defined macro

The "buffer" macro is not defined.

Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")

---
Changes since v1:
- fixed commit message;
- added Acked-by.

---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)
xen/common/efi/boot.c +0 -1
index 1a181ba933..c5625ccecf 100644
@@ -556,7 +556,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
Signature · 1 line
2.43.0
#2 lore raw
Quoted 4 lines · Andrew Cooper
Quoted 2 lines · Frediano Ziglio

The "buffer" macro is not defined.

Quoted 8 lines
Quoted 3 lines
Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")

While correct, the grammar isn't great. I'd suggest "Drop stale #undef buffer" for the subject, and "The "buffer" macro was removed when keyhandler_scratch was removed."

Fine for me.
Not sure about the acknowledgement.

Quoted 3 lines

Can fix on commit.

~Andrew

Frediano

#3 lore raw
Quoted 10 lines · Frediano Ziglio
Quoted 8 lines · Andrew Cooper
Quoted 5 lines · Frediano Ziglio

The "buffer" macro is not defined.

Fixes 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
Quoted 6 lines
Quoted 4 lines

While correct, the grammar isn't great. I'd suggest "Drop stale #undef buffer" for the subject, and "The "buffer" macro was removed when keyhandler_scratch was removed."

Fine for me.

Fine with me too.

Quoted 7 lines

Not sure about the acknowledgement.

Quoted 3 lines

Can fix on commit.

~Andrew

Frediano

Signature · 3 lines
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab