Skip to contentSkip to conversation

of: Clarify OF device context in of_match_device() comment

PATCH Applied Bagas Sanjaya 3 participants 3 messages Jul 30, 2025 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: Clarify OF device context in of_match_device() comment

Open Firmware abbreviation (OF) in of_match_device() comment is written in lowercase instead, which is mistaken for prepositional word "of" ([1], [2], [3], [4]) duplicate.

Clarify the context.

---
 drivers/of/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/of/device.c +2 -2
index c80426510ec2c0..f7e75e5276677e 100644
@@ -17,8 +17,8 @@
 
 /**
  * of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
- * @dev: the of device structure to match against
+ * @matches: array of of_device_id match structures to search in
+ * @dev: the OF device structure to match against
  *
  * Used by a driver to check whether an platform_device present in the
  * system is in its list of supported devices.

base-commit: 0121898ec05fa4c1f566fc05c7e8b3caf0998f97

Signature · 1 line
An old man doll... just what I always wanted! - Clara
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Bagas Sanjaya

Open Firmware abbreviation (OF) in of_match_device() comment is written in lowercase instead, which is mistaken for prepositional word "of" ([1], [2], [3], [4]) duplicate.

Clarify the context.

Wow, that's confusing (the "of" parts).
Hopefully Rob won't mind losing the entertainment factor here.

Thanks.

Quoted 21 lines
---
 drivers/of/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/of/device.c +2 -2
index c80426510ec2c0..f7e75e5276677e 100644
@@ -17,8 +17,8 @@
 
 /**
  * of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
- * @dev: the of device structure to match against
+ * @matches: array of of_device_id match structures to search in
+ * @dev: the OF device structure to match against
  *
  * Used by a driver to check whether an platform_device present in the
  * system is in its list of supported devices.

base-commit: 0121898ec05fa4c1f566fc05c7e8b3caf0998f97

Signature · 1 line
~Randy
maintainer Applied
#2 lore raw
In reply to Bagas Sanjaya
Quoted 6 lines · Bagas Sanjaya

Open Firmware abbreviation (OF) in of_match_device() comment is written in lowercase instead, which is mistaken for prepositional word "of" ([1], [2], [3], [4]) duplicate.

Clarify the context.

Quoted 9 lines
---
 drivers/of/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!