Skip to contentSkip to conversation

perf/core: Replace memset(0) + strscpy() with strscpy_pad()

PATCH In review Thorsten Blum 1 participant 2 messages Aug 11, 2025 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 perf/core: Replace memset(0) + strscpy() with strscpy_pad()

Replace memset(0) followed by strscpy() with strscpy_pad() to improve perf_event_comm_event(). This avoids zeroing the memory before copying the string and ensures the destination buffer is only written to once, simplifying the code and improving efficiency.

---
Changes in v2:
- Keep strlen() as we're not checking the return value of strscpy_pad()
for string truncation
- Link to v1: https://lore.kernel.org/lkml/[email protected]/

---
 kernel/events/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/events/core.c +1 -2
index 8060c2857bb2..414212b02d54 100644
@@ -8981,8 +8981,7 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)
 	char comm[TASK_COMM_LEN];
 	unsigned int size;
 
-	memset(comm, 0, sizeof(comm));
-	strscpy(comm, comm_event->task->comm);
+	strscpy_pad(comm, comm_event->task->comm);
 	size = ALIGN(strlen(comm)+1, sizeof(u64));
 
 	comm_event->comm = comm;
Signature · 1 line
2.50.1
#1 lore raw
Quoted 4 lines · Thorsten Blum

Changes in v2:
- Keep strlen() as we're not checking the return value of strscpy_pad()
for string truncation
- Link to v1: https://lore.kernel.org/lkml/[email protected]/

Actually v1 was just fine because both source and destination buffers have the same size 'TASK_COMM_LEN' and the string won't be truncated.

Sorry for the noise.