Indiedroid Nova Devicetree Updates
Subsystems (2)
cover Indiedroid Nova Devicetree Updates
From: Chris Morgan <[email protected]>
This series fixes up a few remaining issues with the devicetree for the Indiedroid Nova. Namely it adds or updates a few pinctrl definitions, it removes a few workarounds that no longer appear to be necessary for eMMC and bluetooth, it adds support for the NPU, and it sets the device type as embedded.
Chris Morgan (5):
arm64: dts: rockchip: Add device type for Indiedroid Nova.
arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova
arm64: dts: rockchip: enable NPU on Indiedroid Nova
arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
arm64: dts: rockchip: Fix DMA for Indiedroid Nova Bluetooth
.../dts/rockchip/rk3588s-indiedroid-nova.dts | 85 ++++++++++++++----- 1 file changed, 65 insertions(+), 20 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/5 arm64: dts: rockchip: Add device type for Indiedroid Nova.
From: Chris Morgan <[email protected]>
Update the devicetree node to note the device category of the Indiedroid Nova as an embedded device.
--- arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +1 -0
@@ -11,6 +11,7 @@ / { model = "Indiedroid Nova"; + chassis-type = "embedded"; compatible = "indiedroid,nova", "rockchip,rk3588s"; adc-keys-0 {
Signature · 1 line
2.43.0
PATCH 2/5 arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Define the pinctrl nodes for the WiFi interrupts, correct the pinctrl for the ethernet according to the schematic, and add the clk32k_in control for the RTC. Add the correct regulator mapping for the PCIE too.
--- .../dts/rockchip/rk3588s-indiedroid-nova.dts | 43 ++++++++++++------- 1 file changed, 28 insertions(+), 15 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +28 -15
@@ -406,7 +406,7 @@ rtc_hym8563: rtc@51 { clock-output-names = "hym8563"; interrupt-parent = <&gpio0>; interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>; - pinctrl-0 = <&hym8563_int>; + pinctrl-0 = <&hym8563_int>, <&clk32k_in>; pinctrl-names = "default"; wakeup-source; };
@@ -459,8 +459,11 @@ &i2s5_8ch { }; &pcie2x1l2 { - pinctrl-0 = <&rtl8111_perstb>; + pinctrl-0 = <&pcie20x1m0_perstn>, <&pcie20x1m0_clkreqn>, + <&pcie20x1m0_waken>; pinctrl-names = "default"; + reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>; + vpcie3v3-supply = <&vcc_3v3_s3>; status = "okay"; };
@@ -486,12 +489,6 @@ bt_wake_host: bt-wake-host { }; }; - ethernet-pins { - rtl8111_perstb: rtl8111-perstb { - rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>; - }; - }; - hym8563 { hym8563_int: hym8563-int {
@@ -500,13 +497,6 @@ hym8563_int: hym8563-int { }; }; - sdio-pwrseq { - wifi_enable_h: wifi-enable-h { - rockchip,pins = - <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; - }; - }; - usb-typec { usbc0_int: usbc0-int { rockchip,pins =
@@ -518,6 +508,18 @@ typec5v_pwren: typec5v-pwren { <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>; }; }; + + wifi { + wifi_enable_h: wifi-enable-h { + rockchip,pins = + <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; + }; + + wifi_host_wake_irq: wifi-host-wake-irq { + rockchip,pins = + <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_down>; + }; + }; }; &saradc {
@@ -538,6 +540,7 @@ &sdhci { }; &sdio { + #address-cells = <1>; bus-width = <4>; cap-sd-highspeed; cap-sdio-irq;
@@ -549,9 +552,19 @@ &sdio { no-sd; non-removable; sd-uhs-sdr104; + #size-cells = <0>; vmmc-supply = <&vcc_3v3_s3>; vqmmc-supply = <&vcc_1v8_s3>; status = "okay"; + + sdio_wifi: wifi@1 { + reg = <1>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "host-wake"; + pinctrl-0 = <&wifi_host_wake_irq>; + pinctrl-names = "default"; + }; }; &sdmmc {
Signature · 1 line
2.43.0
Heiko Stuebner
maintainerRe: [PATCH 2/5] arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova
Hi Chris,
Am Mittwoch, 5. November 2025, 21:57:05 Mitteleuropäische Normalzeit schrieb Chris Morgan:
Quoted 6 lines
From: Chris Morgan <[email protected]>
Define the pinctrl nodes for the WiFi interrupts, correct the pinctrl for the ethernet according to the schematic, and add the
clk32k_incontrol for the RTC. Add the correct regulator mapping for the PCIE too.
way too much completely different things to stuff into one patch.
- Adding the sdio wifi is one
- ethernet is next ... you're not fixing, but removing the pinctrl?
- pcie2 fixes is another one
- and the clkin32k as well
Heiko
Quoted 107 lines
Signed-off-by Chris Morgan <[email protected]>--- .../dts/rockchip/rk3588s-indiedroid-nova.dts | 43 ++++++++++++------- 1 file changed, 28 insertions(+), 15 deletions(-)arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +28
-15@@ -406,7 +406,7 @@ rtc_hym8563: rtc@51 { clock-output-names = "hym8563"; interrupt-parent = <&gpio0>; interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>; - pinctrl-0 = <&hym8563_int>; + pinctrl-0 = <&hym8563_int>, <&clk32k_in>; pinctrl-names = "default"; wakeup-source; };@@ -459,8 +459,11 @@ &i2s5_8ch { }; &pcie2x1l2 { - pinctrl-0 = <&rtl8111_perstb>; + pinctrl-0 = <&pcie20x1m0_perstn>, <&pcie20x1m0_clkreqn>, + <&pcie20x1m0_waken>; pinctrl-names = "default"; + reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>; + vpcie3v3-supply = <&vcc_3v3_s3>; status = "okay"; };@@ -486,12 +489,6 @@ bt_wake_host: bt-wake-host { }; }; - ethernet-pins { - rtl8111_perstb: rtl8111-perstb { - rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>; - }; - }; - hym8563 { hym8563_int: hym8563-int {@@ -500,13 +497,6 @@ hym8563_int: hym8563-int { }; }; - sdio-pwrseq { - wifi_enable_h: wifi-enable-h { - rockchip,pins = - <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; - }; - }; - usb-typec { usbc0_int: usbc0-int { rockchip,pins =@@ -518,6 +508,18 @@ typec5v_pwren: typec5v-pwren { <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>; }; }; + + wifi { + wifi_enable_h: wifi-enable-h { + rockchip,pins = + <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; + }; + + wifi_host_wake_irq: wifi-host-wake-irq { + rockchip,pins = + <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_down>; + }; + }; }; &saradc {@@ -538,6 +540,7 @@ &sdhci { }; &sdio { + #address-cells = <1>; bus-width = <4>; cap-sd-highspeed; cap-sdio-irq;@@ -549,9 +552,19 @@ &sdio { no-sd; non-removable; sd-uhs-sdr104; + #size-cells = <0>; vmmc-supply = <&vcc_3v3_s3>; vqmmc-supply = <&vcc_1v8_s3>; status = "okay"; + + sdio_wifi: wifi@1 { + reg = <1>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "host-wake"; + pinctrl-0 = <&wifi_host_wake_irq>; + pinctrl-names = "default"; + }; }; &sdmmc {
Re: [PATCH 2/5] arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova
Quoted 11 lines · Heiko Stuebner
Hi Chris,
Am Mittwoch, 5. November 2025, 21:57:05 Mitteleuropäische Normalzeit schrieb Chris Morgan:
Quoted 6 lines
From: Chris Morgan <[email protected]>
Define the pinctrl nodes for the WiFi interrupts, correct the pinctrl for the ethernet according to the schematic, and add the
clk32k_incontrol for the RTC. Add the correct regulator mapping for the PCIE too.way too much completely different things to stuff into one patch.
Sorry, to me this seemed like a few tiny fixes that, excluding the pcie regulator addition, all related to correcting pinctrl definitions. I'll be happy to split it up if need be. The SDIO wifi is really just adding the interrupt pin... there was just a bit of stuff to add on top so I could define it correctly; for ethernet I'm replacing the reset pin with the PCIE port reset pin and adding other PCIE pins defined in the schematic, and the clk32k_in is just adding another pin to note that the RTC output is connected to that pin.
Thank you,
Chris
Quoted 120 lines
- Adding the sdio wifi is one
- ethernet is next ... you're not fixing, but removing the pinctrl?
- pcie2 fixes is another one
- and the clkin32k as wellHeiko
Quoted 107 lines
Signed-off-by Chris Morgan <[email protected]>--- .../dts/rockchip/rk3588s-indiedroid-nova.dts | 43 ++++++++++++------- 1 file changed, 28 insertions(+), 15 deletions(-)arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +28
-15@@ -406,7 +406,7 @@ rtc_hym8563: rtc@51 { clock-output-names = "hym8563"; interrupt-parent = <&gpio0>; interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>; - pinctrl-0 = <&hym8563_int>; + pinctrl-0 = <&hym8563_int>, <&clk32k_in>; pinctrl-names = "default"; wakeup-source; };@@ -459,8 +459,11 @@ &i2s5_8ch { }; &pcie2x1l2 { - pinctrl-0 = <&rtl8111_perstb>; + pinctrl-0 = <&pcie20x1m0_perstn>, <&pcie20x1m0_clkreqn>, + <&pcie20x1m0_waken>; pinctrl-names = "default"; + reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>; + vpcie3v3-supply = <&vcc_3v3_s3>; status = "okay"; };@@ -486,12 +489,6 @@ bt_wake_host: bt-wake-host { }; }; - ethernet-pins { - rtl8111_perstb: rtl8111-perstb { - rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>; - }; - }; - hym8563 { hym8563_int: hym8563-int {@@ -500,13 +497,6 @@ hym8563_int: hym8563-int { }; }; - sdio-pwrseq { - wifi_enable_h: wifi-enable-h { - rockchip,pins = - <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; - }; - }; - usb-typec { usbc0_int: usbc0-int { rockchip,pins =@@ -518,6 +508,18 @@ typec5v_pwren: typec5v-pwren { <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>; }; }; + + wifi { + wifi_enable_h: wifi-enable-h { + rockchip,pins = + <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>; + }; + + wifi_host_wake_irq: wifi-host-wake-irq { + rockchip,pins = + <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_down>; + }; + }; }; &saradc {@@ -538,6 +540,7 @@ &sdhci { }; &sdio { + #address-cells = <1>; bus-width = <4>; cap-sd-highspeed; cap-sdio-irq;@@ -549,9 +552,19 @@ &sdio { no-sd; non-removable; sd-uhs-sdr104; + #size-cells = <0>; vmmc-supply = <&vcc_3v3_s3>; vqmmc-supply = <&vcc_1v8_s3>; status = "okay"; + + sdio_wifi: wifi@1 { + reg = <1>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "host-wake"; + pinctrl-0 = <&wifi_host_wake_irq>; + pinctrl-names = "default"; + }; }; &sdmmc {
PATCH 3/5 arm64: dts: rockchip: enable NPU on Indiedroid Nova
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Enable the NPU on the Indiedroid Nova.
--- .../dts/rockchip/rk3588s-indiedroid-nova.dts | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +34 -0
@@ -471,6 +471,10 @@ &pd_gpu { domain-supply = <&vdd_gpu_s0>; }; +&pd_npu { + domain-supply = <&vdd_npu_s0>; +}; + &pinctrl { bluetooth-pins { bt_reset: bt-reset {
@@ -522,6 +526,36 @@ wifi_host_wake_irq: wifi-host-wake-irq { }; }; +&rknn_core_0 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_core_1 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_core_2 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_mmu_0 { + status = "okay"; +}; + +&rknn_mmu_1 { + status = "okay"; +}; + +&rknn_mmu_2 { + status = "okay"; +}; + &saradc { vref-supply = <&vcca_1v8_s0>; status = "okay";
Signature · 1 line
2.43.0
PATCH 4/5 arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Once the DLL_STRBIN_TAPNUM_DEFAULT is set to the correct value [1], the workaround to ensure stable eMMC operation is no longer needed. I have observed testing this that hdparm went from:
"Timing buffered disk reads: 502 MB in 3.00 seconds = 167.14 MB/sec" to the following:
"Timing buffered disk reads: 832 MB in 3.00 seconds = 277.32 MB/sec"
--- arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +2 -2
@@ -561,10 +561,10 @@ &saradc { status = "okay"; }; -/* HS400 modes seemed to cause io errors. */ &sdhci { bus-width = <8>; - no-mmc-hs400; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; no-sd; no-sdio; non-removable;
Signature · 1 line
2.43.0
Heiko Stuebner
maintainerRe: [PATCH 4/5] arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
Am Mittwoch, 5. November 2025, 21:57:07 Mitteleuropäische Normalzeit schrieb Chris Morgan:
Quoted 9 lines
From: Chris Morgan <[email protected]>
Once the
DLL_STRBIN_TAPNUM_DEFAULTis set to the correct value [1], the workaround to ensure stable eMMC operation is no longer needed. I have observed testing this that hdparm went from:
"Timing buffered disk reads: 502 MB in 3.00 seconds = 167.14 MB/sec" to the following:
"Timing buffered disk reads: 832 MB in 3.00 seconds = 277.32 MB/sec"
Quoted 3 lines
Fixes 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
This needs the patch you linked to, to actually work, so I'll drop the fixes tag when applying, because this should likely not be backported to older kernels.
Same reasoning for patch 5.
Heiko
Quoted 23 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +2
-2@@ -561,10 +561,10 @@ &saradc { status = "okay"; }; -/* HS400 modes seemed to cause io errors. */ &sdhci { bus-width = <8>; - no-mmc-hs400; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; no-sd; no-sdio; non-removable;
Re: [PATCH 4/5] arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
Quoted 12 lines · Heiko Stuebner
Am Mittwoch, 5. November 2025, 21:57:07 Mitteleuropäische Normalzeit schrieb Chris Morgan:
Quoted 11 lines
From: Chris Morgan <[email protected]>
Once the
DLL_STRBIN_TAPNUM_DEFAULTis set to the correct value [1], the workaround to ensure stable eMMC operation is no longer needed. I have observed testing this that hdparm went from:
"Timing buffered disk reads: 502 MB in 3.00 seconds = 167.14 MB/sec" to the following:
"Timing buffered disk reads: 832 MB in 3.00 seconds = 277.32 MB/sec"
Quoted 7 lines
Quoted 1 line
Fixes 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")This needs the patch you linked to, to actually work, so I'll drop the fixes tag when applying, because this should likely not be backported to older kernels.
Same reasoning for patch 5.
Thank you, I wasn't sure about that or not. I can say with certanty you don't want the eMMC device tree changes prior to that patch going through or bad things will happen.
Chris
Quoted 31 lines
Heiko
Quoted 23 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +2
-2@@ -561,10 +561,10 @@ &saradc { status = "okay"; }; -/* HS400 modes seemed to cause io errors. */ &sdhci { bus-width = <8>; - no-mmc-hs400; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; no-sd; no-sdio; non-removable;
PATCH 5/5 arm64: dts: rockchip: Fix DMA for Indiedroid Nova Bluetooth
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
When the device was first added, there was a problem with the bluetooth controller that manifested when DMA was enabled for the underlying UART interface. At some point in the intervening time the problem appears to have been resolved. Add the UART rx and tx channels back to re-enable UART.
--- arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 3 --- 1 file changed, 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +0 -3
@@ -944,12 +944,9 @@ &uart2 { status = "okay"; }; -/* DMA seems to interfere with bluetooth device normal operation. */ &uart9 { pinctrl-0 = <&uart9m2_xfer>, <&uart9m2_ctsn>, <&uart9m2_rtsn>; pinctrl-names = "default"; - /delete-property/ dma-names; - /delete-property/ dmas; uart-has-rtscts; status = "okay";
Signature · 1 line
2.43.0
Re: (subset) [PATCH 0/5] Indiedroid Nova Devicetree Updates
In reply to Chris MorganQuoted 6 lines · Chris Morgan
This series fixes up a few remaining issues with the devicetree for the Indiedroid Nova. Namely it adds or updates a few pinctrl definitions, it removes a few workarounds that no longer appear to be necessary for eMMC and bluetooth, it adds support for the NPU, and it sets the device type as embedded.
Quoted 8 lines
Chris Morgan (5):
arm64: dts: rockchip: Add device type for Indiedroid Nova.
arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova
arm64: dts: rockchip: enable NPU on Indiedroid Nova
arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
arm64: dts: rockchip: Fix DMA for Indiedroid Nova Bluetooth[...]
Applied, thanks!
[1/5] arm64: dts: rockchip: Add device type for Indiedroid Nova.
commit: 318bc4b5ad229435abbb7b9a7c8b1876fae311e7
[3/5] arm64: dts: rockchip: enable NPU on Indiedroid Nova
commit: dfa4f7f5cb2c66fac5a17d63e5fcf1bf50ea7344
[4/5] arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
commit: cce837b7a3599dc83cd9c08afc07b076f127354b
[5/5] arm64: dts: rockchip: Fix DMA for Indiedroid Nova Bluetooth
commit: c6c76445c30bb73fd4cfba8f4742e642dcfe90f5Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>