arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
cover arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
---
Robert Eckelmann (2):
arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
.../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 30 +++++++++++++++++----- 1 file changed, 23 insertions(+), 7 deletions(-)
---
base-commit: d724c6f85e80a23ed46b7ebc6e38b527c09d64f5
change-id: 20251126-slpi-c616e3a391ce
Best regards,
Signature · 1 line
Robert Eckelmann <[email protected]>
PATCH 1/2 arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +7 -0
@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; }; +&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn"; + + status = "okay"; +}; + &sound { compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard"; pinctrl-0 = <&quat_mi2s_active
@@ -637,3 +643,4 @@ &wifi { vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; vdd-3.3-ch1-supply = <&vreg_l23a_3p3>; }; +
Signature · 1 line
2.52.0
Quoted 15 lines · On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
Signed-off-by Robert Eckelmann <[email protected]>Signed-off-by David Heidelberg <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +0
-0
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &sdhc_2 { · line 429
Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; }; +&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
qcom/sdm845/Xiaomi/beryllium/slpi.mbn
Quoted 17 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +5
-0+ + status = "okay"; +}; + &sound { compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard"; pinctrl-0 = <&quat_mi2s_active@@ -637,3 +643,4 @@ &wifi { vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; vdd-3.3-ch1-supply = <&vreg_l23a_3p3>; }; +Signature · 2 lines
-- 2.52.0
Signature · 2 lines
With best wishes Dmitry
Quoted 19 lines · Dmitry Baryshkov
Quoted 18 lines · On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
Signed-off-by Robert Eckelmann <[email protected]>Signed-off-by David Heidelberg <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +0
-0@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; };
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &sdhc_2 { · line 429
Quoted 2 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0+&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";qcom/sdm845/Xiaomi/beryllium/slpi.mbn
Could be this change done for all the firmware files at once but later?
Currently all the firmwares using this legacy path.
David
[...]
Quoted 24 lines · David Heidelberg
Quoted 11 lines · Dmitry Baryshkov
Quoted 10 lines · On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
Signed-off-by Robert Eckelmann <[email protected]>Signed-off-by David Heidelberg <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &sdhc_2 { · line 428
Quoted 9 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; }; +&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";qcom/sdm845/Xiaomi/beryllium/slpi.mbn
Quoted 3 lines
Could be this change done for all the firmware files at once but later?
Currently all the firmwares using this legacy path.
I'd rather see the patch fixing firmware paths first and then the patch adding SLPI with the correct path from the day 0 (I feel sorry for causing pain to PmOS maintainers). Of course both patches can come as a part of the same series.
Quoted 4 lines
David
[...]
Signature · 2 lines
With best wishes Dmitry
Quoted 25 lines · Dmitry Baryshkov
Quoted 24 lines · David Heidelberg
Quoted 22 lines · Dmitry Baryshkov
Quoted 15 lines · On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
Signed-off-by Robert Eckelmann <[email protected]>Signed-off-by David Heidelberg <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +0
-0arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &sdhc_2 { · line 428
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; }; +&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";qcom/sdm845/Xiaomi/beryllium/slpi.mbn
Quoted 8 lines
Quoted 3 lines
Could be this change done for all the firmware files at once but later?
Currently all the firmwares using this legacy path.
I'd rather see the patch fixing firmware paths first and then the patch adding SLPI with the correct path from the day 0 (I feel sorry for causing pain to PmOS maintainers). Of course both patches can come as a part of the same series.
Would it make sense as a follow up, I would changed "the whole sdm845" to the new paths, so distros maintainers can update paths everywhere with 6.19?
David
Quoted 6 lines
Quoted 5 lines
David
[...]
Signature · 1 line
David Heidelberg
Quoted 31 lines · David Heidelberg
Quoted 29 lines · Dmitry Baryshkov
Quoted 27 lines · David Heidelberg
Quoted 11 lines · Dmitry Baryshkov
Quoted 10 lines · On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
Signed-off-by Robert Eckelmann <[email protected]>Signed-off-by David Heidelberg <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &sdhc_2 { · line 428
Quoted 9 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0@@ -425,6 +425,12 @@ &sdhc_2 { cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>; }; +&slpi_pas { + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";qcom/sdm845/Xiaomi/beryllium/slpi.mbn
Could be this change done for all the firmware files at once but later?
Currently all the firmwares using this legacy path.
Quoted 8 lines
Quoted 4 lines
I'd rather see the patch fixing firmware paths first and then the patch adding SLPI with the correct path from the day 0 (I feel sorry for causing pain to PmOS maintainers). Of course both patches can come as a part of the same series.
Would it make sense as a follow up, I would changed "the whole sdm845" to the new paths, so distros maintainers can update paths everywhere with 6.19?
I think so.
Quoted 13 lines
David
Quoted 6 lines
Quoted 5 lines
David
[...]
--
David Heidelberg
Signature · 2 lines
With best wishes Dmitry
PATCH 2/2 arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
In reply to Robert EckelmannWe know these devices are present, most of them are supported by downstream and close to the mainline kernels.
This is very handy when rebasing the integration tree with the support.
No functional changes.
--- .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 23 +++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +16 -7
@@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 { }; }; +&cci_i2c0 { + /* IMX363 @ 10 */ +}; + &cdsp_pas { status = "okay"; firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
@@ -261,6 +265,18 @@ &ibb { qcom,discharge-resistor-kohms = <300>; }; +&ipa { + qcom,gsi-loader = "self"; + memory-region = <&ipa_fw_mem>; + firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn"; + + status = "okay"; +}; + +&i2c5 { + /* TAS2559 @ 4C */ +}; + &lab { regulator-min-microvolt = <4600000>; regulator-max-microvolt = <6000000>;
@@ -311,13 +327,6 @@ &mss_pil { firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn"; }; -&ipa { - qcom,gsi-loader = "self"; - memory-region = <&ipa_fw_mem>; - firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn"; - status = "okay"; -}; - &pm8998_gpios { vol_up_pin_a: vol-up-active-state { pins = "gpio6";
Signature · 1 line
2.52.0
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Quoted 5 lines · On 26/11/2025 13:08, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
We know these devices are present, most of them are supported by downstream and close to the mainline kernels.
Quoted 9 lines
This is very handy when rebasing the integration tree with the support.
No functional changes.
Signed-off-by Robert Eckelmann <[email protected]>--- .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 23 +++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
In reply to Robert EckelmannQuoted 19 lines · On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
We know these devices are present, most of them are supported by downstream and close to the mainline kernels.
This is very handy when rebasing the integration tree with the support.
No functional changes.
Signed-off-by Robert Eckelmann <[email protected]>--- .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 23 +++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +0
-0
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi vreg_l26a_1p2: ldo26 { · line 231
Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0@@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 { }; }; +&cci_i2c0 { + /* IMX363 @ 10 */
It may be useful for you to add 'status = "okay"' here, so that the busses are accessible, and you can poke at the device with e.g. i2c-tools
Konrad
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Quoted 23 lines · Konrad Dybcio
Quoted 22 lines · On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
From: Robert Eckelmann <[email protected]>
We know these devices are present, most of them are supported by downstream and close to the mainline kernels.
This is very handy when rebasing the integration tree with the support.
No functional changes.
Signed-off-by Robert Eckelmann <[email protected]>--- .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 23 +++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +0
-0@@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 { }; };
Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi vreg_l26a_1p2: ldo26 { · line 231
Quoted 2 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +2
-0+&cci_i2c0 { + /* IMX363 @ 10 */It may be useful for you to add 'status = "okay"' here, so that the busses are accessible, and you can poke at the device with e.g. i2c-tools
And a bus frequency then.
Quoted 2 lines
Konrad
Signature · 2 lines
With best wishes Dmitry