Skip to contentSkip to conversation

arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

PATCH Superseded Robert Eckelmann 3 participants 7 messages Dec 5, 2025

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

---
Changes in v2:
- adjusted firmware paths
- enabled i2c busses
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Robert Eckelmann (3):
arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
arm64: dts: qcom: sdm845-xiaomi-beryllium: Adjust firmware paths
arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

 .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 47 ++++++++++++++++------
 1 file changed, 35 insertions(+), 12 deletions(-)

---
base-commit: 6987d58a9cbc5bd57c983baa514474a86c945d56
change-id: 20251126-slpi-c616e3a391ce

Best regards,

Signature · 1 line
Robert Eckelmann <[email protected]>
#1 lore raw

PATCH v2 1/3 arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +7 -0
index 785006a15e97..cadddcf63ef6 100644
@@ -425,6 +425,12 @@ &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
 };
 
+&slpi_pas {
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/slpi.mbn";
+
+	status = "okay";
+};
+
 &sound {
 	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
 	pinctrl-0 = <&quat_mi2s_active
@@ -637,3 +643,4 @@ &wifi {
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 };
+
Signature · 1 line
2.52.0
#2 lore raw
Quoted 29 lines · On 12/5/25 2:00 PM, Robert Eckelmann via B4 Relay wrote:

From: Robert Eckelmann <[email protected]>

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +6 -0
index 785006a15e97..cadddcf63ef6 100644
@@ -425,6 +425,12 @@ &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
 };
 
+&slpi_pas {
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/slpi.mbn";
+
+	status = "okay";
+};
+
 &sound {
 	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
 	pinctrl-0 = <&quat_mi2s_active

arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &wifi { · line 646

Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +1 -0
@@ -637,3 +643,4 @@ &wifi {
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 };
+

Stray hunk?

Konrad

#3 lore raw

On 05/12/2025 14:27, Konrad Dybcio wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &wifi { · line 646

Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +1 -0
@@ -637,3 +643,4 @@ &wifi {
  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
  	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
  };
+

Stray hunk?

I think your comment goes into the category of "extreme nitpicks".

Here as usual I guess there are three options:
- another revision because of newline
- maintainer merge it with it and nothing happens
- while merge, maintainer remove the line

David

Quoted 2 lines

Konrad

#4 lore raw
Quoted 13 lines · David Heidelberg

On 05/12/2025 14:27, Konrad Dybcio wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi &wifi { · line 646

Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +1 -0
@@ -637,3 +643,4 @@ &wifi {
       vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
       vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
   };
+

Stray hunk?

Quoted 6 lines

I think your comment goes into the category of "extreme nitpicks".

Here as usual I guess there are three options:
 - another revision because of newline
 - maintainer merge it with it and nothing happens
 - while merge, maintainer remove the line

$ LC_ALL=C b4 shazam [email protected] -P 1

Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 6 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
[PATCH v2 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
---
✗ No key: openpgp/[email protected]
---
Total patches: 1 (cherrypicked: 1)
---
Base: using specified base-commit 6987d58a9cbc5bd57c983baa514474a86c945d56
Applying: arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
/<snip path>/.git/rebase-apply/patch:26: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

It works best when both submitters and maintainers check their work..

Konrad

#5 lore raw

PATCH v2 2/3 arm64: dts: qcom: sdm845-xiaomi-beryllium: Adjust firmware paths

In reply to Robert Eckelmann

Firmware patht adjusted to include device maker "Xiaomi"

---
 .../arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +7 -6
index cadddcf63ef6..8ce592cabd35 100644
@@ -136,7 +136,7 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
 
 &adsp_pas {
 	status = "okay";
-	firmware-name = "qcom/sdm845/beryllium/adsp.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/adsp.mbn";
 };
 
 &apps_rsc {
@@ -229,7 +229,7 @@ vreg_l26a_1p2: ldo26 {
 
 &cdsp_pas {
 	status = "okay";
-	firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/cdsp.mbn";
 };
 
 &gcc {
@@ -249,7 +249,7 @@ &gpu {
 };
 
 &gpu_zap_shader {
-	firmware-name = "qcom/sdm845/beryllium/a630_zap.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/a630_zap.mbn";
 };
 
 &ibb {
@@ -308,13 +308,14 @@ &mdss_dsi0_phy {
 
 &mss_pil {
 	status = "okay";
-	firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/mba.mbn",
+	"qcom/sdm845/Xiaomi/beryllium/modem.mbn";
 };
 
 &ipa {
 	qcom,gsi-loader = "self";
 	memory-region = <&ipa_fw_mem>;
-	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/ipa_fws.mbn";
 	status = "okay";
 };
 
@@ -618,7 +619,7 @@ &usb_1_qmpphy {
 
 &venus {
 	status = "okay";
-	firmware-name = "qcom/sdm845/beryllium/venus.mbn";
+	firmware-name = "qcom/sdm845/Xiaomi/beryllium/venus.mbn";
 };
 
 &wcd9340 {
Signature · 1 line
2.52.0
#6 lore raw

PATCH v2 3/3 arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

In reply to Robert Eckelmann

We know these devices are present, most of them are supported by downstream and close to the mainline kernels.

This is very handy when rebasing the integration tree with the support.

No functional changes.

---
 .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 29 ++++++++++++++++------
 1 file changed, 22 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +22 -7
index 8ce592cabd35..8df5311f4afd 100644
@@ -227,6 +227,12 @@ vreg_l26a_1p2: ldo26 {
 	};
 };
 
+&cci_i2c0 {
+	status = "okay";
+
+	/* IMX363 @ 10 */
+};
+
 &cdsp_pas {
 	status = "okay";
 	firmware-name = "qcom/sdm845/Xiaomi/beryllium/cdsp.mbn";
@@ -261,6 +267,22 @@ &ibb {
 	qcom,discharge-resistor-kohms = <300>;
 };
 
+&ipa {
+	qcom,gsi-loader = "self";
+	memory-region = <&ipa_fw_mem>;
+	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
+
+	status = "okay";
+};
+
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	/* TAS2559 @ 4C */
+};
+
 &lab {
 	regulator-min-microvolt = <4600000>;
 	regulator-max-microvolt = <6000000>;
@@ -312,13 +334,6 @@ &mss_pil {
 	"qcom/sdm845/Xiaomi/beryllium/modem.mbn";
 };
 
-&ipa {
-	qcom,gsi-loader = "self";
-	memory-region = <&ipa_fw_mem>;
-	firmware-name = "qcom/sdm845/Xiaomi/beryllium/ipa_fws.mbn";
-	status = "okay";
-};
-
 &pm8998_gpios {
 	vol_up_pin_a: vol-up-active-state {
 		pins = "gpio6";
Signature · 1 line
2.52.0