Skip to contentSkip to conversation

rcu-tasks: Remove unnecessary smp_store operations in the cblist_init_generic()

PATCH Superseded Zqiang 2 participants 3 messages Dec 14, 2025 – Dec 31, 2025 RCU

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Zqiang

author reviewer
#0 lore raw

PATCH 1/1 rcu-tasks: Remove unnecessary smp_store operations in the cblist_init_generic()

The cblist_init_generic() is executed during the CPU early boot phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists at rcu_init() time"), at this time, only one boot CPU is online. this commit therefore use WRITE_ONCE() to replace the smp_store_release() to assigning rtp->percpu_enqueue_lim in the cblist_init_generic().

---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tasks.h +1 -1
index 76f952196a29..f763f60d5e50 100644
@@ -292,7 +292,7 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
 		shift++;
 	WRITE_ONCE(rtp->percpu_enqueue_shift, shift);
 	WRITE_ONCE(rtp->percpu_dequeue_lim, lim);
-	smp_store_release(&rtp->percpu_enqueue_lim, lim);
+	WRITE_ONCE(rtp->percpu_enqueue_lim, lim);
 
 	pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n",
 			rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),
Signature · 1 line
2.48.1
maintainer
#1 lore raw
Quoted 8 lines · Zqiang

The cblist_init_generic() is executed during the CPU early boot phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists at rcu_init() time"), at this time, only one boot CPU is online. this commit therefore use WRITE_ONCE() to replace the smp_store_release() to assigning rtp->percpu_enqueue_lim in the cblist_init_generic().

Good eyes, thank you!

But in that case, we are running on a single CPU with interrupts disables, so do we even need WRITE_ONCE()?

Thanx, Paul

Quoted 20 lines
---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tasks.h +1 -1
index 76f952196a29..f763f60d5e50 100644
@@ -292,7 +292,7 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
 		shift++;
 	WRITE_ONCE(rtp->percpu_enqueue_shift, shift);
 	WRITE_ONCE(rtp->percpu_dequeue_lim, lim);
-	smp_store_release(&rtp->percpu_enqueue_lim, lim);
+	WRITE_ONCE(rtp->percpu_enqueue_lim, lim);
 
 	pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n",
 			rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),
Signature · 1 line
2.48.1
author reviewer
#2 lore raw
Quoted 11 lines · Zqiang
Quoted 9 lines

The cblist_init_generic() is executed during the CPU early boot
phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists at rcu_init() time"), at this time, only one boot CPU is online. this commit therefore use WRITE_ONCE() to replace the smp_store_release() to assigning rtp->percpu_enqueue_lim in the cblist_init_generic().

Quoted 6 lines
Quoted 2 lines

Good eyes, thank you!

But in that case, we are running on a single CPU with interrupts disables, so do we even need WRITE_ONCE()?

I missed the interrupts disabled, It seems like there are no need use WRITE_ONCE() and include above, I will update and resend.

Thanks
Zqiang

Quoted 25 lines

Thanx, Paul

Quoted 21 lines
---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 76f952196a29..f763f60d5e50 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -292,7 +292,7 @@ static void cblist_init_generic(struct rcu_tasks *rtp) shift++;
WRITE_ONCE(rtp->percpu_enqueue_shift, shift); WRITE_ONCE(rtp->percpu_dequeue_lim, lim);
- smp_store_release(&rtp->percpu_enqueue_lim, lim);
+ WRITE_ONCE(rtp->percpu_enqueue_lim, lim);

pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n", rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim), --
2.48.1