nvme/host: fixup some typos
PATCH v4 1/1 nvme/host: fixup some typos
From: Wilfred Mallawa <[email protected]>
Fix up some minor typos/grammar in the nvme host tcp driver and a comment style to conform to the standard kernel style.
---
V4:
- Minor grammar fixup
--- drivers/nvme/host/tcp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/nvme/host/tcp.c +5 -3
@@ -25,7 +25,8 @@struct nvme_tcp_queue ; -/* Define the socket priority to use for connections were it is desirable +/* +* Define the socket priority to use for connections where it is desirable * that the NIC consider performing optimized packet processing or filtering. * A non-zero value being sufficient to indicate general consideration of any * possible optimization. Making it a module param allows for alternative
@@ -926,8 +927,9 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb, req->curr_bio = req->curr_bio->bi_next;/* -* If we don`t have any bios it means that controller -* sent more data than we requested, hence error +* If we do not have any bios, it means that the +* controller sent more data than we requested, +* hence error */ if (!req->curr_bio) { dev_err(queue->ctrl->ctrl.device,
Signature · 1 line
2.52.0
On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
Gentle ping, in-case this got lost in the threads :)
Wilfred
Quoted 52 lines
From: Wilfred Mallawa <[email protected]>
Fix up some minor typos/grammar in the nvme host tcp driver and a comment
style to conform to the standard kernel style.Signed-off-by Wilfred Mallawa <[email protected]>Reviewed-by Damien Le Moal <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>---
V4:
- Minor grammar fixup
---
drivers/nvme/host/tcp.c | 8 +++++---1 file changed, 5 insertions(+), 3 deletions(-)drivers/nvme/host/tcp.c +0
-0@@ -25,7 +25,8 @@
structnvme_tcp_queue;
-/* Define the socket priority to use for connections were it is desirable
+/*
+ * Define the socket priority to use for connections where it is desirable
* that the NIC consider performing optimized packet processing or filtering.
* A non-zero value being sufficient to indicate general consideration of any
* possible optimization. Making it a module param allows for alternativedrivers/nvme/host/tcp.c +0
-0@@ -926,8 +927,9 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb, req->curr_bio = req->curr_bio->bi_next;
/*drivers/nvme/host/tcp.c +0
-1-* If we don`t have any bios it means that controller
drivers/nvme/host/tcp.c +0
-1-* sent more data than we requested, hence error
drivers/nvme/host/tcp.c +1
-0+* If we do not have any bios, it means that the
drivers/nvme/host/tcp.c +1
-0+* controller sent more data than we requested,
drivers/nvme/host/tcp.c +1
-0+* hence error */
if (!req->curr_bio) { dev_err(queue->ctrl->ctrl.device,
Keith Busch
maintainerQuoted 3 lines · Wilfred Mallawa
On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
Gentle ping, in-case this got lost in the threads :)
The previous version was already applied:
https://git.infradead.org/?p=nvme.git;a=commitdiff;h=f947d9e77b26238b821b5227afb4fee8c7ea0d5a
Quoted 6 lines · Keith Busch
Quoted 3 lines · Wilfred Mallawa
On Wed, 2026-01-14 at 16:37 +1000, Wilfred Mallawa wrote:
Gentle ping, in-case this got lost in the threads :)
The previous version was already applied:
Ah missed that, sorry for the noise!
Wilfred