Skip to contentSkip to conversation

staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B

PATCH Superseded Haroen Tmimi 2 participants 3 messages Feb 10 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B

The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).

Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.

---
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0 -1
index 9df3274c1048..f712d0345b99 100644
@@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
 	}
 
 	if (Method == TXAGC) {
-		struct adapter *Adapter = pDM_Odm->Adapter;
 
 		pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
 
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 27 lines · Haroen Tmimi

The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).

Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.

---
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0 -1
index 9df3274c1048..f712d0345b99 100644
@@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
 	}
 
 	if (Method == TXAGC) {
-		struct adapter *Adapter = pDM_Odm->Adapter;
 
 		pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
 
Signature · 1 line
2.53.0

And now you have another coding style warning :(

Please be more careful when doing code cleanups so as to not add additional problems.

thanks,

greg k-h

#2 lore raw

My apologies, I should have been more careful before sending the patch.

With kind regards,

Haroen Tmimi

Op di 10 feb 2026 om 17:35 schreef Greg KH <[email protected]>:

Quoted 38 lines · Haroen Tmimi
Quoted 25 lines

The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).

Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.

---
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0 -2
index 9df3274c1048..f712d0345b99 100644
@@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
      }
 
      if (Method == TXAGC) {
-             struct adapter *Adapter = pDM_Odm->Adapter;
 
              pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
 
--
Quoted 2 lines

2.53.0

And now you have another coding style warning :(

Please be more careful when doing code cleanups so as to not add additional problems.

thanks,

greg k-h