Skip to contentSkip to conversation

staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B

PATCH In review Haroen Tmimi 2 participants 2 messages Feb 10 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B

The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).

Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.

---
Changes in v3:
Correctly removed the black space left after the opening brace. (v2 was sent wrong).

Changes in v2:
Removed the white space in line 211, which caused a coding style warning (reported by Greg K-H).

 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0 -2
index 9df3274c1048..0f915589b518 100644
@@ -208,8 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
 	}
 
 	if (Method == TXAGC) {
-		struct adapter *Adapter = pDM_Odm->Adapter;
-
 		pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
 
 		pDM_Odm->Modify_TxAGC_Flag_PathA = true;
Signature · 1 line
2.53.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 9 lines · Haroen Tmimi

The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).

Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.

---

LGTM.

Thanks,

ET