riscv: kvm: fix vector context allocation leak
Subsystems (3)
PATCH 1/1 riscv: kvm: fix vector context allocation leak
When the second kzalloc (host_context.vector.datap) fails in kvm_riscv_vcpu_alloc_vector_context, the first allocation (guest_context.vector.datap) is leaked. Free it before returning.
--- arch/riscv/kvm/vcpu_vector.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/riscv/kvm/vcpu_vector.c +4 -1
@@ -80,8 +80,11 @@ int kvm_riscv_vcpu_alloc_vector_context(struct kvm_vcpu *vcpu)return -ENOMEM ; vcpu->arch.host_context.vector.datap =kzalloc (riscv_v_vsize,GFP_KERNEL ); -if (!vcpu->arch.host_context.vector.datap) +if (!vcpu->arch.host_context.vector.datap) { +kfree (vcpu->arch.guest_context.vector.datap); + vcpu->arch.guest_context.vector.datap =NULL ;return -ENOMEM ; + }return 0 ; }
Signature · 1 line
2.43.0
Quoted 3 lines
When the second kzalloc (host_context.vector.datap) fails in
kvm_riscv_vcpu_alloc_vector_context, the first allocation (guest_context.vector.datap) is leaked. Free it before returning.
Were any source code analysis tools involved here?
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
Regards,
Markus
Quoted 6 lines · Markus Elfring
Quoted 3 lines
When the second kzalloc (host_context.vector.datap) fails in
kvm_riscv_vcpu_alloc_vector_context, the first allocation (guest_context.vector.datap) is leaked. Free it before returning.Were any source code analysis tools involved here?
No, there were found during manual review.
Quoted 4 lines
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
Done, I just sent v2, thank you.
Quoted 2 lines
Regards,
Markus
Best regards,
Osama
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
When the second kzalloc (host_context.vector.datap) fails in
kvm_riscv_vcpu_alloc_vector_context, the first allocation (guest_context.vector.datap) is leaked. Free it before returning.Were any source code analysis tools involved here?
No, there were found during manual review.
Would be looking for the support of advanced approaches which would make such a “inspection” more convenient?
Regards,
Markus