iio: st_sensors: drop temporary kmalloc buffer and reuse buffer_data
PATCH v4 1/1 iio: st_sensors: drop temporary kmalloc buffer and reuse buffer_data
From: Sanjay Chitroda <[email protected]>
Replace the per-call kmalloc() scratch buffer with the existing buffer_data[] field present in struct st_sensor_data. The existing buffer is DMA-aligned and sufficiently sized for all channel widths, so using it avoids unnecessary dynamic memory allocation on each read.
This simplifies the code, removes redundant allocation and cleanup. No functional change intended.
---
Changes in v4:
- Rectify commit message review by David Lechner
- Link to v3 https://lore.kernel.org/all/[email protected]/
Changes in v3:
- fix variable declartion placement to follow kernel coding style
- Link to v2 https://lore.kernel.org/all/[email protected]/
Changes in v2:
- split series to individual patch
- address review comment from David Lechner and reuse exising buffer instead of allocation
- Link to v1 https://lore.kernel.org/all/[email protected]/
--- drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/iio/common/st_sensors/st_sensors_core.c +3 -8
@@ -501,14 +501,12 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev, byte_for_channel =DIV_ROUND_UP (ch->scan_type.realbits + ch->scan_type.shift,8 ); - outdata =kmalloc (byte_for_channel,GFP_DMA |GFP_KERNEL ); -if (!outdata) -return -ENOMEM ; + outdata = sdata->buffer_data; err =regmap_bulk_read (sdata->regmap, ch->address, outdata, byte_for_channel);if (err <0 ) - goto st_sensors_free_memory; +return err;if (byte_for_channel ==1 ) *data = (s8)*outdata;
@@ -517,10 +515,7 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev,else if (byte_for_channel ==3 ) *data = (s32 )sign_extend32 (get_unaligned_le24 (outdata),23 ); -st_sensors_free_memory: -kfree (outdata); - -return err; +return 0 ; } int st_sensors_read_info_raw(struct iio_dev *indio_dev,
Signature · 1 line
2.34.1
Jonathan Cameron
maintainerQuoted 7 lines · On Sun, 15 Mar 2026 17:46:25 +0530 Sanjay Chitroda…
From: Sanjay Chitroda <[email protected]>
Replace the per-call
kmalloc()scratch buffer with the existing buffer_data[] field present in structst_sensor_data. The existing buffer is DMA-aligned and sufficiently sized for all channel widths, so using it avoids unnecessary dynamic memory allocation on each read.
Quoted 5 lines
This simplifies the code, removes redundant allocation and cleanup. No functional change intended.
Signed-off-by Sanjay Chitroda <[email protected]>Reviewed-by David Lechner <[email protected]>
I briefly wondered if the locking was strong enough to ensure this isn't used at the same time as the use of the buffer in the trigger handler. I think it's fine though due to the fact the only path to this function has claimed direct mode.
I haven't completely ruled out a race around the disable path for the buffer but given the worst that can happen is wrong sensor data I think we are fine even if there is one.
So with that in mind applied to the testing branch of iio.git which will become togreg and get picked up by linux-next once the bots have taken a first look at it.
Thanks,
Jonathan
Quoted 48 lines
---
Changes in v4:
- Rectify commit message review by David Lechner
- Link to v3 https://lore.kernel.org/all/[email protected]/
Changes in v3:
- fix variable declartion placement to follow kernel coding style
- Link to v2 https://lore.kernel.org/all/[email protected]/
Changes in v2:
- split series to individual patch
- address review comment from David Lechner and reuse exising buffer instead of allocation
- Link to v1 https://lore.kernel.org/all/[email protected]/--- drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)drivers/iio/common/st_sensors/st_sensors_core.c +3
-8@@ -501,14 +501,12 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev, byte_for_channel =DIV_ROUND_UP (ch->scan_type.realbits + ch->scan_type.shift,8 ); - outdata =kmalloc (byte_for_channel,GFP_DMA |GFP_KERNEL ); -if (!outdata) -return -ENOMEM ; + outdata = sdata->buffer_data; err =regmap_bulk_read (sdata->regmap, ch->address, outdata, byte_for_channel);if (err <0 ) - goto st_sensors_free_memory; +return err;if (byte_for_channel ==1 ) *data = (s8)*outdata;@@ -517,10 +515,7 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev,else if (byte_for_channel ==3 ) *data = (s32 )sign_extend32 (get_unaligned_le24 (outdata),23 ); -st_sensors_free_memory: -kfree (outdata); - -return err; +return 0 ; } int st_sensors_read_info_raw(struct iio_dev *indio_dev,