Add Qualcomm SA8650P SoC to socinfo
cover Add Qualcomm SA8650P SoC to socinfo
Add SoC ID for SA8650P to socinfo.
Note: Posting patches originally by Lei Wang <[email protected]>. Minor edits to commit messages for better clarity and to match previous submissions that add a SoC to socinfo.
Lei wang (2):
dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
soc: qcom: socinfo: Add SoC ID for SA8650P
drivers/soc/qcom/socinfo.c | 1 + include/dt-bindings/arm/qcom,ids.h | 1 + 2 files changed, 2 insertions(+)
Signature · 1 line
2.53.0
PATCH 1/2 dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
--- include/dt-bindings/arm/qcom,ids.h | 1 + 1 file changed, 1 insertion(+)
include/dt-bindings/arm/qcom,ids.h +1 -0
@@ -260,6 +260,7 @@#define QCOM_ID_SM8475 530#define QCOM_ID_SM8475P 531#define QCOM_ID_SA8255P 532 +#define QCOM_ID_SA8650P 533#define QCOM_ID_SA8775P 534#define QCOM_ID_QRU1000 539#define QCOM_ID_SM8475_2 540
Signature · 1 line
2.53.0
Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
Quoted 10 lines · Radu Rendec
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
Signed-off-by Lei Wang <[email protected]>Signed-off-by Radu Rendec <[email protected]>--- include/dt-bindings/arm/qcom,ids.h | 1 + 1 file changed, 1 insertion(+)
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
In reply to Radu RendecQuoted 5 lines · Radu Rendec
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
Signed-off-by Lei Wang <[email protected]>
Please keep consistent spelling of identities. Not sure where the mistake was done - either by Lei or you added his SoB?
Quoted 5 lines
Signed-off-by Radu Rendec <[email protected]>--- include/dt-bindings/arm/qcom,ids.h | 1 + 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · Radu Rendec
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
Signed-off-by Lei Wang <[email protected]>Please keep consistent spelling of identities. Not sure where the mistake was done - either by Lei or you added his SoB?
Yes, sorry, my bad! By the time I realized what I did, I had already sent it. I'll send out v2 shortly.
Quoted 5 lines
Quoted 5 lines
Signed-off-by Radu Rendec <[email protected]>---
include/dt-bindings/arm/qcom,ids.h | 1 +1 file changed, 1 insertion(+)
Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
Quoted 6 lines · Radu Rendec
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Radu Rendec
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Lei Wang <[email protected]>Please keep consistent spelling of identities. Not sure where the mistake was done - either by Lei or you added his SoB?
Yes, sorry, my bad! By the time I realized what I did, I had already sent it. I'll send out v2 shortly.
Does that mean there was no original Signed-off-by? If so, you should not add it, because you cannot certify for someone else.
Please explain the origins of this patch.
Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Radu Rendec
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Radu Rendec
From: Lei wang <[email protected]>
Add unique ID for Qualcomm SA8650P SoC.
Signed-off-by Lei Wang <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Please keep consistent spelling of identities. Not sure where the mistake was done - either by Lei or you added his SoB?
Yes, sorry, my bad! By the time I realized what I did, I had already sent it. I'll send out v2 shortly.
Does that mean there was no original Signed-off-by? If so, you should not add it, because you cannot certify for someone else.
It did have an original Signed-off-by tag, which I modified accidentally.
Quoted 1 line
Please explain the origins of this patch.
This is the origin of the patch:
https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/cecaf4e3bec17fe4fb63c52e51a02065e60c87d0
And FWIW, the origin of patch 2 is this:
https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/8050aeaebdcb3ab120d847658d831f20bd475315
Please let me know if there's anything else missing or unclear. Thanks!
Signature · 2 lines
Best regards, Radu
PATCH 2/2 soc: qcom: socinfo: Add SoC ID for SA8650P
In reply to Radu RendecFrom: Lei wang <[email protected]>
Add SoC ID table entry for Qualcomm SA8650P.
--- drivers/soc/qcom/socinfo.c | 1 + 1 file changed, 1 insertion(+)
drivers/soc/qcom/socinfo.c +1 -0
@@ -488,6 +488,7 @@ static const struct soc_id soc_id[] = { { qcom_board_id(SM8475) }, { qcom_board_id(SM8475P) }, { qcom_board_id(SA8255P) }, + { qcom_board_id(SA8650P) }, { qcom_board_id(SA8775P) }, { qcom_board_id(QRU1000) }, { qcom_board_id(SM8475_2) },
Signature · 1 line
2.53.0
Re: [PATCH 2/2] soc: qcom: socinfo: Add SoC ID for SA8650P
Quoted 10 lines · Radu Rendec
From: Lei wang <[email protected]>
Add SoC ID table entry for Qualcomm SA8650P.
Signed-off-by Lei Wang <[email protected]>Signed-off-by Radu Rendec <[email protected]>--- drivers/soc/qcom/socinfo.c | 1 + 1 file changed, 1 insertion(+)
Signature · 2 lines
With best wishes Dmitry