Skip to contentSkip to conversation

Add Qualcomm SA8650P SoC to socinfo

PATCH Applied Radu Rendec 3 participants 8 messages Mar 21 – Mar 30

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Add Qualcomm SA8650P SoC to socinfo

Add SoC ID for SA8650P to socinfo.

Note: Posting patches originally by Lei wang <[email protected]>. Minor edits to commit messages for better clarity and to match previous submissions that add a SoC to socinfo.

---
Changes in v2:
- Fix incorrect spelling of Lei's identity (no code change)

---
Lei wang (2):
dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P
soc: qcom: socinfo: Add SoC ID for SA8650P

 drivers/soc/qcom/socinfo.c         | 1 +
 include/dt-bindings/arm/qcom,ids.h | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
2.53.0
#1 lore raw

PATCH v2 1/2 dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P

From: Lei wang <[email protected]>

Add unique ID for Qualcomm SA8650P SoC.

---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
include/dt-bindings/arm/qcom,ids.h +1 -0
index 8776844e0eeb3..85282029d80cf 100644
@@ -260,6 +260,7 @@
 #define QCOM_ID_SM8475			530
 #define QCOM_ID_SM8475P			531
 #define QCOM_ID_SA8255P			532
+#define QCOM_ID_SA8650P			533
 #define QCOM_ID_SA8775P			534
 #define QCOM_ID_QRU1000			539
 #define QCOM_ID_SM8475_2		540
Signature · 1 line
2.53.0
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P

Quoted 7 lines · Radu Rendec

From: Lei wang <[email protected]>

Add unique ID for Qualcomm SA8650P SoC.

---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed. </form letter>

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P

Quoted 10 lines · Krzysztof Kozlowski
Quoted 7 lines · Radu Rendec

From: Lei wang <[email protected]>

Add unique ID for Qualcomm SA8650P SoC.

---

Quoted 5 lines

<form letter>
This is a friendly reminder during the review process.

And I read now answer to v1, so the DCO and patch provenance still needs clarifications.

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P

Quoted 11 lines · Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski
Quoted 7 lines · Radu Rendec

From: Lei wang <[email protected]>

Add unique ID for Qualcomm SA8650P SoC.

---

Quoted 8 lines
Quoted 5 lines

<form letter>
This is a friendly reminder during the review process.

And I read now answer to v1, so the DCO and patch provenance still needs clarifications.

It's fine, SoB now matches original patch.

Best regards,
Krzysztof

#5 lore raw

PATCH v2 2/2 soc: qcom: socinfo: Add SoC ID for SA8650P

In reply to Radu Rendec

From: Lei wang <[email protected]>

Add SoC ID table entry for Qualcomm SA8650P.

---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/qcom/socinfo.c +1 -0
index 003a2304d535c..01eae575afd27 100644
@@ -488,6 +488,7 @@ static const struct soc_id soc_id[] = {
 	{ qcom_board_id(SM8475) },
 	{ qcom_board_id(SM8475P) },
 	{ qcom_board_id(SA8255P) },
+	{ qcom_board_id(SA8650P) },
 	{ qcom_board_id(SA8775P) },
 	{ qcom_board_id(QRU1000) },
 	{ qcom_board_id(SM8475_2) },
Signature · 1 line
2.53.0
Reviewed-by on v2 2/2
#6 lore raw

Re: [PATCH v2 2/2] soc: qcom: socinfo: Add SoC ID for SA8650P

Quoted 7 lines · Radu Rendec

From: Lei wang <[email protected]>

Add SoC ID table entry for Qualcomm SA8650P.

---

Here tag is missing as well.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed. </form letter>

Best regards,
Krzysztof

maintainer Applied
#7 lore raw
In reply to Radu Rendec
Quoted 5 lines · Radu Rendec

Add SoC ID for SA8650P to socinfo.

Minor edits to commit messages for better clarity and to match previous submissions that add a SoC to socinfo.

Applied, thanks!

[1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SA8650P

      commit: a559a742c95c55ae3b347f2b57d26830c0cdd566
[2/2] soc: qcom: socinfo: Add SoC ID for SA8650P
      commit: f55fa3e3dcd8f766266fdf878994f0ec09459a7d

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>