Engine initialization cleanup
Subsystems (2)
cover Engine initialization cleanup
A lot of our engine initialization code was inherited from i915 and hasn't received too much cleanup since that time. There's also some inconsistencies between the main initialization path used on all platforms, and the vestigial execlist code which isn't actually used but still remains in the driver as dead code for now. Let's clean things up a bit and, where possible, move the required engine programming into the RTP infrastructure so that it will be applied on both initialization paths, and be dumpable/checkable via debugfs.
There's some more restructuring that should happen to more clearly distinguish software state initialization from hardware initialization (and re-initialization on various resets & suspend/resume), but I'll leave that to a follow-up series to prevent this one from getting too complicated.
---
Matt Roper (10):
drm/xe: Move CCS enablement to engine setup RTP drm/xe/rtp: Add "always true" match function
drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms drm/xe: Move HWSTAM programming to RTP
drm/xe: Fix name and definition of GFX_MODE register drm/xe: Const-ify parameters to xe_device_has_* functions drm/xe: Move GFX_MODE programming to RTP
drm/xe: Drop unnecessary STOP_RING clearing
drm/xe: Drop xe_hw_engine_mmio_write32()
drm/xe: Mark BCS engines as belonging to the GT forcewake domain
drivers/gpu/drm/xe/regs/xe_engine_regs.h | 5 +- drivers/gpu/drm/xe/xe_device.h | 14 +++--- drivers/gpu/drm/xe/xe_execlist.c | 9 ---- drivers/gpu/drm/xe/xe_guc_ads.c | 2 - drivers/gpu/drm/xe/xe_guc_capture.c | 2 +- drivers/gpu/drm/xe/xe_hw_engine.c | 82 +++++++++++++------------------- drivers/gpu/drm/xe/xe_lrc.c | 20 -------- drivers/gpu/drm/xe/xe_rtp.c | 15 ++++++ drivers/gpu/drm/xe/xe_rtp.h | 24 ++++++++++ 9 files changed, 81 insertions(+), 92 deletions(-)
---
base-commit: 021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4
change-id: 20260402-engine-setup-e66851295e18
Best regards,
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
PATCH 2/10 drm/xe/rtp: Add "always true" match function
All RTP table entries are required to have at least one rule. In cases where an entry should apply unconditionally across all platforms we've been using a graphics version range of 12.00 - forever since this covers all platforms supported by the driver. However if the primary GT is disabled via configfs (not actually possible today, but probably possible in the future) or if we have a future platform that lacks a primary GT and only supports media/display, this rule would cause important programming to fail to apply on the media GT.
Add a simple match function that just always returns true unconditionally. This solves the worries above while also being more immediately human-readable.
--- drivers/gpu/drm/xe/xe_hw_engine.c | 2 +- drivers/gpu/drm/xe/xe_rtp.c | 7 +++++++ drivers/gpu/drm/xe/xe_rtp.h | 12 ++++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_hw_engine.c +1 -1
@@ -430,7 +430,7 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)struct xe_rtp_process_ctx ctx =XE_RTP_PROCESS_CTX_INITIALIZER (hwe);const struct xe_rtp_entry_sr engine_entries[] = { {XE_RTP_NAME ("RING_CMD_CCTL_default_MOCS" ), -XE_RTP_RULES (GRAPHICS_VERSION_RANGE (1200 ,XE_RTP_END_VERSION_UNDEFINED )), +XE_RTP_RULES (FUNC (xe_rtp_match_always)), XE_RTP_ACTIONS(FIELD_SET(RING_CMD_CCTL(0), CMD_CCTL_WRITE_OVERRIDE_MASK | CMD_CCTL_READ_OVERRIDE_MASK,
drivers/gpu/drm/xe/xe_rtp.c +7 -0
@@ -352,6 +352,13 @@ void xe_rtp_process(struct xe_rtp_process_ctx *ctx, }EXPORT_SYMBOL_IF_KUNIT (xe_rtp_process); +bool xe_rtp_match_always (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe) +{ +return true; +} +bool xe_rtp_match_even_instance (const struct xe_device *xe,const struct xe_gt *gt,const struct xe_hw_engine *hwe)
drivers/gpu/drm/xe/xe_rtp.h +12 -0
@@ -459,6 +459,18 @@ void xe_rtp_process(struct xe_rtp_process_ctx *ctx,/* Match functions to be used with XE_RTP_MATCH_FUNC */ +/** +* xe_rtp_match_always - Match RTP entry unconditionally +* @xe: Device structure +* @gt: GT structure +* @hwe: Engine instance +* +* Returns: true, regardless of inputs +*/ +bool xe_rtp_match_always (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe); +/** * xe_rtp_match_even_instance - Match if engine instance is even * @xe: Device structure
Signature · 1 line
2.53.0
PATCH 5/10 drm/xe: Fix name and definition of GFX_MODE register
In reply to Matt RoperThe register located at $base+0x29c is referred to as GFX_MODE in the bspec. Although many other registers have RING_* prefixes for historical reasons, this register does not, so using a name that does not match the bspec just makes it harder to recognize/find.
Also, GFX_MODE is a masked register (updating bits [15:0] requires that the corresponding bit(s) in [31:16] are also set), so add the XE_REG_OPTION_MASKED flag to the register definition; this will become important when we start programming this register via RTP tables in a future patch.
Finally swap the order of the register's two bit definitions to match our regular coding style of descending order for register bits/fields.
Bspec: 45928
--- drivers/gpu/drm/xe/regs/xe_engine_regs.h | 4 ++-- drivers/gpu/drm/xe/xe_execlist.c | 2 +- drivers/gpu/drm/xe/xe_guc_ads.c | 2 +- drivers/gpu/drm/xe/xe_guc_capture.c | 2 +- drivers/gpu/drm/xe/xe_hw_engine.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/regs/xe_engine_regs.h +2 -2
@@ -165,9 +165,9 @@#define CTX_CTRL_INHIBIT_SYN_CTX_SWITCH REG_BIT(3)#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT REG_BIT(0) -#define RING_MODE (base) XE_REG((base) + 0x29c) -#define GFX_DISABLE_LEGACY_MODE REG_BIT(3) +#define GFX_MODE (base) XE_REG((base) + 0x29c, XE_REG_OPTION_MASKED)#define GFX_MSIX_INTERRUPT_ENABLE REG_BIT(13) +#define GFX_DISABLE_LEGACY_MODE REG_BIT(3)#define RING_CSMQDEBUG (base) XE_REG((base) + 0x2b0)
drivers/gpu/drm/xe/xe_execlist.c +1 -1
@@ -80,7 +80,7 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc,if (xe_device_has_msix (gt_to_xe (hwe->gt))) ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_mmio_write32 (mmio,RING_MODE (hwe->mmio_base), ring_mode); +xe_mmio_write32 (mmio,GFX_MODE (hwe->mmio_base), ring_mode);xe_mmio_write32 (mmio,RING_EXECLIST_SQ_CONTENTS_LO (hwe->mmio_base),lower_32_bits (lrc_desc));
drivers/gpu/drm/xe/xe_guc_ads.c +1 -1
@@ -745,7 +745,7 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,struct xe_reg reg;bool skip; } *e, extra_regs[] = { - { .reg = RING_MODE(hwe->mmio_base), }, + { .reg = GFX_MODE(hwe->mmio_base), }, { .reg = RING_HWS_PGA(hwe->mmio_base), }, { .reg = RING_IMR(hwe->mmio_base), }, { .reg = CCS_MODE,
drivers/gpu/drm/xe/xe_guc_capture.c +1 -1
@@ -111,7 +111,7 @@ struct __guc_capture_parsed_output { { RING_TAIL(0), REG_32BIT, 0, 0, 0, "RING_TAIL"}, \ { RING_CTL(0), REG_32BIT, 0, 0, 0, "RING_CTL"}, \ { RING_MI_MODE(0), REG_32BIT, 0, 0, 0, "RING_MI_MODE"}, \ - { RING_MODE(0), REG_32BIT, 0, 0, 0, "RING_MODE"}, \ + { GFX_MODE(0), REG_32BIT, 0, 0, 0, "GFX_MODE"}, \ { RING_ESR(0), REG_32BIT, 0, 0, 0, "RING_ESR"}, \ { RING_EMR(0), REG_32BIT, 0, 0, 0, "RING_EMR"}, \ { RING_EIR(0), REG_32BIT, 0, 0, 0, "RING_EIR"}, \
drivers/gpu/drm/xe/xe_hw_engine.c +1 -1
@@ -332,7 +332,7 @@ void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe)if (xe_device_has_msix (gt_to_xe (hwe->gt))) ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_hw_engine_mmio_write32 (hwe,RING_MODE (0 ), ring_mode); +xe_hw_engine_mmio_write32 (hwe,GFX_MODE (0 ), ring_mode);xe_hw_engine_mmio_write32 (hwe,RING_MI_MODE (0 ),REG_MASKED_FIELD_DISABLE (STOP_RING ));xe_hw_engine_mmio_read32 (hwe,RING_MI_MODE (0 ));
Signature · 1 line
2.53.0
PATCH 1/10 drm/xe: Move CCS enablement to engine setup RTP
In reply to Matt RoperMost register programming for engine setup happens via RTP tables in hw_engine_setup_default_state(). Move the programming of RCU_MODE[0] which enables the platform's CCS engine(s) there. This both makes the code more consistent (other RCU_MODE register programming is already happening in this RTP table) and improves debuggability (since RTP contents and checks of their correct programming are exposed via debugfs). It also helps consolidate the regular driver initialization paths with the vestigial and currently unused execlist (i.e., non-GuC) initialization.
With the original programming, the RCU_MODE register (which is a single global register, not a per-engine register) was getting re-programmed with the same value during the initialization of each CCS engine. When moved to the RTP table, we use the xe_rtp_match_first_render_or_compute match function so that it will just be programmed once, while doing the initialization for the first RCS/CCS engine, which avoids the redundant and unnecessary repetition.
We can also safely drop the explicit addition of RCU_MODE from the GuC ADS save-restore list now since all registers programmed via RTP tables are automatically added to the GuC's list.
--- drivers/gpu/drm/xe/xe_execlist.c | 4 ---- drivers/gpu/drm/xe/xe_guc_ads.c | 1 - drivers/gpu/drm/xe/xe_hw_engine.c | 10 ++++------ 3 files changed, 4 insertions(+), 11 deletions(-)
drivers/gpu/drm/xe/xe_execlist.c +0 -4
@@ -59,10 +59,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc, lrc_desc |=FIELD_PREP (SW_CTX_ID , ctx_id); } -if (hwe->class ==XE_ENGINE_CLASS_COMPUTE ) -xe_mmio_write32 (mmio,RCU_MODE , -REG_MASKED_FIELD_ENABLE (RCU_MODE_CCS_ENABLE )); -xe_lrc_write_ctx_reg (lrc,CTX_RING_TAIL , lrc->ring.tail); lrc->ring.old_tail = lrc->ring.tail;
drivers/gpu/drm/xe/xe_guc_ads.c +0 -1
@@ -748,7 +748,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads, { .reg = RING_MODE(hwe->mmio_base), }, { .reg = RING_HWS_PGA(hwe->mmio_base), }, { .reg = RING_IMR(hwe->mmio_base), }, - { .reg = RCU_MODE, .skip = hwe != hwe_rcs_reset_domain }, { .reg = CCS_MODE, .skip = hwe != hwe_rcs_reset_domain || !xe_gt_ccs_mode_enabled(hwe->gt) }, };
drivers/gpu/drm/xe/xe_hw_engine.c +4 -6
@@ -325,14 +325,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg)void xe_hw_engine_enable_ring (struct xe_hw_engine *hwe) { -u32 ccs_mask = -xe_hw_engine_mask_per_class (hwe->gt,XE_ENGINE_CLASS_COMPUTE );u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -if (hwe->class ==XE_ENGINE_CLASS_COMPUTE && ccs_mask) -xe_mmio_write32 (&hwe->gt->mmio,RCU_MODE , -REG_MASKED_FIELD_ENABLE (RCU_MODE_CCS_ENABLE )); -xe_hw_engine_mmio_write32 (hwe,RING_HWSTAM (0 ), ~0x0 );xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp));
@@ -465,6 +459,10 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)XE_RTP_ACTIONS (SET (CSFE_CHICKEN1 (0 ),CS_PRIORITY_MEM_READ ,XE_RTP_ACTION_FLAG (ENGINE_BASE ))) }, + { XE_RTP_NAME("Enable CCS Engine(s)"), +XE_RTP_RULES (FUNC (xe_rtp_match_first_render_or_compute)), +XE_RTP_ACTIONS (SET (RCU_MODE ,RCU_MODE_CCS_ENABLE )) + },/* Use Fixed slice CCS mode */ { XE_RTP_NAME("RCU_MODE_FIXED_SLICE_CCS_MODE"), XE_RTP_RULES(FUNC(xe_hw_engine_match_fixed_cslice_mode)),
Signature · 1 line
2.53.0
PATCH 3/10 drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms
In reply to Matt RoperXe1 platforms used the BLIT_CCTL register to specify the MOCS value that would be used for BCS engine instructions that did not have a way of specifying a MOCS index directly. From Xe2 onward, all BCS instructions now have explicit instruction fields for specifying a MOCS index and the BLIT_CCTL register is now a dummy register with no valid fields. Although continuing to write to it today has no effect, the register could repurposed in future platforms, so restrict the BLIT_CCTL RTP entry to only apply to Xe1 platforms.
Bspec: 60280
--- drivers/gpu/drm/xe/xe_hw_engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_hw_engine.c +1 -1
@@ -384,7 +384,7 @@ xe_hw_engine_setup_default_lrc_state(struct xe_hw_engine *hwe)* BLIT_CCTL registers are needed to be programmed to un-cached. */ {XE_RTP_NAME ("BLIT_CCTL_default_MOCS" ), -XE_RTP_RULES (GRAPHICS_VERSION_RANGE (1200 ,XE_RTP_END_VERSION_UNDEFINED ), +XE_RTP_RULES (GRAPHICS_VERSION_RANGE (1200 ,1274 ),ENGINE_CLASS (COPY )), XE_RTP_ACTIONS(FIELD_SET(BLIT_CCTL(0), BLIT_CCTL_DST_MOCS_MASK |
Signature · 1 line
2.53.0
PATCH 4/10 drm/xe: Move HWSTAM programming to RTP
In reply to Matt RoperThe write to RING_HWSTAM to disable hardware status page writes on interrupt was unnecessarily open-coded in xe_hw_engine_enable_ring(); it's preferable to do such programming in the engine_entries[] RTP table since gets reflected/verified in debugfs, and will also automatically ensure that the register is properly saved/restored around engine resets.
In this case the HWSTAM register wasn't explicitly added to the GuC ADS' save-restore list, so there was the potential for the value to be lost on engine resets. This doesn't seem to have happened in practice, so likely the GuC firmware is automatically saving/restoring this register on our behalf, but we shouldn't rely on this implicit behavior going forward.
One other slight change with this patch is that HWSTAM will now be programmed on the vestigial execlist (non-GuC) initialization path. Since the register's default value is 0x0 and the documentation indicates that it's only legal to leave a single bit unmasked at a time, this likely would have been an illegal situation if the execlist code were actually usable.
--- drivers/gpu/drm/xe/xe_hw_engine.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_hw_engine.c +5 -1
@@ -327,7 +327,6 @@ void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe) {u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -xe_hw_engine_mmio_write32 (hwe,RING_HWSTAM (0 ), ~0x0 );xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp));
@@ -437,6 +436,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe) ring_cmd_cctl_val, XE_RTP_ACTION_FLAG(ENGINE_BASE))) }, + {XE_RTP_NAME ("Disable HW status page updates for interrupts" ), +XE_RTP_RULES (FUNC (xe_rtp_match_always)), +XE_RTP_ACTIONS (SET (RING_HWSTAM (0 ), ~0x0 , +XE_RTP_ACTION_FLAG (ENGINE_BASE ))) + },/* * To allow the GSC engine to go idle on MTL we need to enable * idle messaging and set the hysteresis value (we use 0xA=5us
Signature · 1 line
2.53.0
PATCH 6/10 drm/xe: Const-ify parameters to xe_device_has_* functions
In reply to Matt RoperNone of these functions modify the Xe device parameter, and marking it as const will avoid warnings when the callsite wants to pass a const pointer.
--- drivers/gpu/drm/xe/xe_device.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/xe/xe_device.h +7 -7
@@ -146,37 +146,37 @@ static inline struct xe_force_wake *gt_to_fw(struct xe_gt *gt)void xe_device_assert_mem_access (struct xe_device *xe); -static inline bool xe_device_has_flat_ccs (struct xe_device *xe) +static inline bool xe_device_has_flat_ccs (const struct xe_device *xe) {return xe->info.has_flat_ccs; } -static inline bool xe_device_has_sriov (struct xe_device *xe) +static inline bool xe_device_has_sriov (const struct xe_device *xe) {return xe->info.has_sriov; } -static inline bool xe_device_has_msix (struct xe_device *xe) +static inline bool xe_device_has_msix (const struct xe_device *xe) {return xe->irq.msix.nvec >0 ; } -static inline bool xe_device_has_memirq (struct xe_device *xe) +static inline bool xe_device_has_memirq (const struct xe_device *xe) {return GRAPHICS_VERx100 (xe) >=1250 ; } -static inline bool xe_device_uses_memirq (struct xe_device *xe) +static inline bool xe_device_uses_memirq (const struct xe_device *xe) {return xe_device_has_memirq (xe) && (IS_SRIOV_VF (xe) ||xe_device_has_msix (xe)); } -static inline bool xe_device_has_lmtt (struct xe_device *xe) +static inline bool xe_device_has_lmtt (const struct xe_device *xe) {return IS_DGFX (xe); } -static inline bool xe_device_has_mert (struct xe_device *xe) +static inline bool xe_device_has_mert (const struct xe_device *xe) {return xe->info.has_mert; }
Signature · 1 line
2.53.0
PATCH 10/10 drm/xe: Mark BCS engines as belonging to the GT forcewake domain
In reply to Matt RoperOn all platforms supported by the Xe driver, BCS engines are part of the GT forcewake domain, not the RENDER domain. Fix the engine list definition to match the spec. This mistake didn't really cause any real problems because the forcewake domain here was only used in a couple assertions that aren't really necessary and included in the information dumped during error capture.
Bspec: 66696, 66534, 67609, 71185, 74417, 75242, 78286
--- drivers/gpu/drm/xe/xe_hw_engine.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_hw_engine.c +9 -9
@@ -67,7 +67,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 0, .irq_offset = ilog2(INTR_BCS(0)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = BLT_RING_BASE, }, [XE_HW_ENGINE_BCS1] = {
@@ -75,7 +75,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 1, .irq_offset = ilog2(INTR_BCS(1)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS1_RING_BASE, }, [XE_HW_ENGINE_BCS2] = {
@@ -83,7 +83,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 2, .irq_offset = ilog2(INTR_BCS(2)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS2_RING_BASE, }, [XE_HW_ENGINE_BCS3] = {
@@ -91,7 +91,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 3, .irq_offset = ilog2(INTR_BCS(3)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS3_RING_BASE, }, [XE_HW_ENGINE_BCS4] = {
@@ -99,7 +99,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 4, .irq_offset = ilog2(INTR_BCS(4)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS4_RING_BASE, }, [XE_HW_ENGINE_BCS5] = {
@@ -107,7 +107,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 5, .irq_offset = ilog2(INTR_BCS(5)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS5_RING_BASE, }, [XE_HW_ENGINE_BCS6] = {
@@ -115,7 +115,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 6, .irq_offset = ilog2(INTR_BCS(6)), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS6_RING_BASE, }, [XE_HW_ENGINE_BCS7] = {
@@ -123,7 +123,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .irq_offset = ilog2(INTR_BCS(7)), .instance = 7, - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS7_RING_BASE, }, [XE_HW_ENGINE_BCS8] = {
@@ -131,7 +131,7 @@ static const struct engine_info engine_infos[] = { .class = XE_ENGINE_CLASS_COPY, .instance = 8, .irq_offset = ilog2(INTR_BCS8), - .domain = XE_FW_RENDER, + .domain = XE_FW_GT, .mmio_base = XEHPC_BCS8_RING_BASE, },
Signature · 1 line
2.53.0
PATCH 7/10 drm/xe: Move GFX_MODE programming to RTP
In reply to Matt RoperThe write GFX_MODE to disable engine "legacy mode" and to enable MSI-X support was unnecessarily open-coded in xe_hw_engine_enable_ring(); it's preferable to do such programming in the engine_entries[] RTP table since gets reflected/verified in debugfs, and will also automatically ensure that the register is properly saved/restored around engine resets. This also helps consolidate common logic that was duplicated between the main driver initialization path and the dead-code execlist initialization path.
This also allows us to drop GFX_MODE from the list of extra registers to be added to the GuC ADS' save-restore list since all registers on the RTP table are added automatically.
--- drivers/gpu/drm/xe/xe_execlist.c | 5 ----- drivers/gpu/drm/xe/xe_guc_ads.c | 1 - drivers/gpu/drm/xe/xe_hw_engine.c | 16 ++++++++++------ drivers/gpu/drm/xe/xe_rtp.c | 8 ++++++++ drivers/gpu/drm/xe/xe_rtp.h | 12 ++++++++++++ 5 files changed, 30 insertions(+), 12 deletions(-)
drivers/gpu/drm/xe/xe_execlist.c +0 -5
@@ -47,7 +47,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc,struct xe_mmio *mmio = >->mmio;struct xe_device *xe =gt_to_xe (gt);u64 lrc_desc; -u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); lrc_desc =xe_lrc_descriptor (lrc);
@@ -78,10 +77,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc, xe_bo_ggtt_addr(hwe->hwsp));xe_mmio_read32 (mmio,RING_HWS_PGA (hwe->mmio_base)); -if (xe_device_has_msix (gt_to_xe (hwe->gt))) - ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_mmio_write32 (mmio,GFX_MODE (hwe->mmio_base), ring_mode); -xe_mmio_write32 (mmio,RING_EXECLIST_SQ_CONTENTS_LO (hwe->mmio_base),lower_32_bits (lrc_desc)); xe_mmio_write32(mmio, RING_EXECLIST_SQ_CONTENTS_HI(hwe->mmio_base),
drivers/gpu/drm/xe/xe_guc_ads.c +0 -1
@@ -745,7 +745,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,struct xe_reg reg;bool skip; } *e, extra_regs[] = { - { .reg = GFX_MODE(hwe->mmio_base), }, { .reg = RING_HWS_PGA(hwe->mmio_base), }, { .reg = RING_IMR(hwe->mmio_base), }, { .reg = CCS_MODE,
drivers/gpu/drm/xe/xe_hw_engine.c +10 -6
@@ -325,14 +325,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg)void xe_hw_engine_enable_ring (struct xe_hw_engine *hwe) { -u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp)); - -if (xe_device_has_msix (gt_to_xe (hwe->gt))) - ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_hw_engine_mmio_write32 (hwe,GFX_MODE (0 ), ring_mode);xe_hw_engine_mmio_write32 (hwe,RING_MI_MODE (0 ),REG_MASKED_FIELD_DISABLE (STOP_RING ));xe_hw_engine_mmio_read32 (hwe,RING_MI_MODE (0 ));
@@ -441,6 +435,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)XE_RTP_ACTIONS (SET (RING_HWSTAM (0 ), ~0x0 ,XE_RTP_ACTION_FLAG (ENGINE_BASE ))) }, + { XE_RTP_NAME("Disable engine 'legacy' mode"), +XE_RTP_RULES (FUNC (xe_rtp_match_always)), +XE_RTP_ACTIONS (SET (GFX_MODE (0 ),GFX_DISABLE_LEGACY_MODE , +XE_RTP_ACTION_FLAG (ENGINE_BASE ))) + },/* * To allow the GSC engine to go idle on MTL we need to enable * idle messaging and set the hysteresis value (we use 0xA=5us
@@ -473,6 +472,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe) XE_RTP_ACTIONS(FIELD_SET(RCU_MODE, RCU_MODE_FIXED_SLICE_CCS_MODE, RCU_MODE_FIXED_SLICE_CCS_MODE)) }, + { XE_RTP_NAME("Enable MSI-X interrupt support"), + XE_RTP_RULES(FUNC(xe_rtp_match_always)), + XE_RTP_ACTIONS(SET(GFX_MODE(0), GFX_MSIX_INTERRUPT_ENABLE, + XE_RTP_ACTION_FLAG(ENGINE_BASE))) + }, }; xe_rtp_process_to_sr(&ctx, engine_entries, ARRAY_SIZE(engine_entries),
drivers/gpu/drm/xe/xe_rtp.c +8 -0
@@ -10,6 +10,7 @@#include <uapi/drm/xe_drm.h> #include "xe_configfs.h" +#include "xe_device.h" #include "xe_gt.h" #include "xe_gt_topology.h" #include "xe_reg_sr.h"
@@ -404,3 +405,10 @@ bool xe_rtp_match_has_flat_ccs(const struct xe_device *xe, {return xe->info.has_flat_ccs; } + +bool xe_rtp_match_has_msix (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe) +{ +return xe_device_has_msix (xe); +}
drivers/gpu/drm/xe/xe_rtp.h +12 -0
@@ -536,4 +536,16 @@ bool xe_rtp_match_has_flat_ccs(const struct xe_device *xe,const struct xe_gt *gt, const struct xe_hw_engine *hwe); +/** +* xe_rtp_match_has_msix - Match when platform has MSI-X +* @xe: Device structure +* @gt: GT structure +* @hwe: Engine instance +* +* Returns: true if platform has MSI-X interrupt support +*/ +bool xe_rtp_match_has_msix (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe); +#endif
Signature · 1 line
2.53.0
PATCH 9/10 drm/xe: Drop xe_hw_engine_mmio_write32()
In reply to Matt Roperxe_hw_engine_mmio_write32() is only used in a single place and is easily replaced by a regular xe_mmio_write32() call. Register read/write interfaces are already complicated enough with MCR vs non-MCR handling, so we should avoid adding extra wrappers that just make it more confusing what to use.
xe_hw_engine_mmio_write32() did have a forcewake assertion that we're dropping here, but that assertion wasn't entirely correct anyway. It was checking hwe->domain which is currently set to XE_FW_RENDER for the BCS engine, even though BCS engines reside in the GT domain.
--- drivers/gpu/drm/xe/xe_hw_engine.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-)
drivers/gpu/drm/xe/xe_hw_engine.c +2 -23
@@ -282,27 +282,6 @@ static void hw_engine_fini(void *arg) hwe->gt =NULL ; } -/** -* xe_hw_engine_mmio_write32() - Write engine register -* @hwe: engine -* @reg: register to write into -* @val: desired 32-bit value to write -* -* This function will write val into an engine specific register. -* Forcewake must be held by the caller. -* -*/ -void xe_hw_engine_mmio_write32 (struct xe_hw_engine *hwe, -struct xe_reg reg,u32 val) -{ -xe_gt_assert (hwe->gt, !(reg.addr & hwe->mmio_base)); -xe_force_wake_assert_held (gt_to_fw (hwe->gt), hwe->domain); - - reg.addr += hwe->mmio_base; - -xe_mmio_write32 (&hwe->gt->mmio, reg, val); -} -/** * xe_hw_engine_mmio_read32() - Read engine register * @hwe: engine
@@ -325,8 +304,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg)void xe_hw_engine_enable_ring (struct xe_hw_engine *hwe) { -xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ), -xe_bo_ggtt_addr (hwe->hwsp)); +xe_mmio_write32 (&hwe->gt->mmio,RING_HWS_PGA (hwe->mmio_base), +xe_bo_ggtt_addr (hwe->hwsp)); } static bool xe_hw_engine_match_fixed_cslice_mode(const struct xe_device *xe,
Signature · 1 line
2.53.0
PATCH 8/10 drm/xe: Drop unnecessary STOP_RING clearing
In reply to Matt RoperThe STOP_RING bit in MI_MODE is already clear by default out of hardware reset and will only be '1' if the driver intentionally sets it after that. Furthermore, MI_MODE is part of the CSFE context, so even if the hardware bit did somehow get set, a fresh value with the bit clear would be re-loaded from the LRC (which is initialized zeroed).
The logic of clearing this bit appears to originate from very early (pre-GuC, pre-execlist) code in i915 where we needed to stop the ring before performing a host-initiated engine reset; after the reset the STOP_RING bit needed to be cleared to allow execution to resume.
None of that is relevant to Xe (or even modern i915) since STOP_RING isn't necessary for execlist-based engine resets (and even if it were, Xe doesn't initiate any engine resets; the GuC handles that now).
Bspec: 60356, 60184
--- drivers/gpu/drm/xe/regs/xe_engine_regs.h | 1 - drivers/gpu/drm/xe/xe_hw_engine.c | 3 --- drivers/gpu/drm/xe/xe_lrc.c | 20 -------------------- 3 files changed, 24 deletions(-)
drivers/gpu/drm/xe/regs/xe_engine_regs.h +0 -1
@@ -176,7 +176,6 @@#define RING_TIMESTAMP_UDW (base) XE_REG((base) + 0x358 + 4)#define RING_VALID_MASK 0x00000001#define RING_VALID 0x00000001 -#define STOP_RING REG_BIT(8)#define RING_CTX_TIMESTAMP (base) XE_REG((base) + 0x3a8)#define RING_CTX_TIMESTAMP_UDW (base) XE_REG((base) + 0x3ac)
drivers/gpu/drm/xe/xe_hw_engine.c +0 -3
@@ -327,9 +327,6 @@ void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe) {xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp)); -xe_hw_engine_mmio_write32 (hwe,RING_MI_MODE (0 ), -REG_MASKED_FIELD_DISABLE (STOP_RING )); -xe_hw_engine_mmio_read32 (hwe,RING_MI_MODE (0 )); } static bool xe_hw_engine_match_fixed_cslice_mode(const struct xe_device *xe,
drivers/gpu/drm/xe/xe_lrc.c +0 -20
@@ -682,25 +682,6 @@ static void set_memory_based_intr(u32 *regs, struct xe_hw_engine *hwe) } } -static int lrc_ring_mi_mode (struct xe_hw_engine *hwe) -{ -struct xe_device *xe =gt_to_xe (hwe->gt); - -if (GRAPHICS_VERx100 (xe) >=1250 ) -return 0x70 ; -else -return 0x60 ; -} - -static void reset_stop_ring (u32 *regs,struct xe_hw_engine *hwe) -{ -int x; - - x =lrc_ring_mi_mode (hwe); - regs[x +1 ] &= ~STOP_RING ; - regs[x +1 ] |=STOP_RING <<16 ; -} -static inline bool xe_lrc_has_indirect_ring_state (struct xe_lrc *lrc) {return lrc->flags &XE_LRC_FLAG_INDIRECT_RING_STATE ;
@@ -980,7 +961,6 @@ static void *empty_lrc_data(struct xe_hw_engine *hwe)set_offsets (regs,reg_offsets (gt_to_xe (gt), hwe->class), hwe);set_context_control (regs, hwe);set_memory_based_intr (regs, hwe); -reset_stop_ring (regs, hwe);if (xe_gt_has_indirect_ring_state (gt)) { regs = data +xe_gt_lrc_size (gt, hwe->class) -LRC_INDIRECT_RING_STATE_SIZE ;
Signature · 1 line
2.53.0
Patchwork
CI✓ CI.KUnit: success for Engine initialization cleanup
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Engine initialization cleanup
URL : https://patchwork.freedesktop.org/series/165392/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [22:55:28] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [22:55:32] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [22:56:03] Starting KUnit Kernel (1/1)... [22:56:03] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [22:56:03] ================== guc_buf (11 subtests) =================== [22:56:03] [PASSED] test_smallest [22:56:03] [PASSED] test_largest [22:56:03] [PASSED] test_granular [22:56:03] [PASSED] test_unique [22:56:03] [PASSED] test_overlap [22:56:03] [PASSED] test_reusable [22:56:03] [PASSED] test_too_big [22:56:03] [PASSED] test_flush [22:56:03] [PASSED] test_lookup [22:56:03] [PASSED] test_data [22:56:03] [PASSED] test_class [22:56:03] ===================== [PASSED] guc_buf ===================== [22:56:03] =================== guc_dbm (7 subtests) =================== [22:56:03] [PASSED] test_empty [22:56:03] [PASSED] test_default [22:56:03] ======================== test_size ======================== [22:56:03] [PASSED] 4 [22:56:03] [PASSED] 8 [22:56:03] [PASSED] 32 [22:56:03] [PASSED] 256 [22:56:03] ==================== [PASSED] test_size ==================== [22:56:03] ======================= test_reuse ======================== [22:56:03] [PASSED] 4 [22:56:03] [PASSED] 8 [22:56:03] [PASSED] 32 [22:56:03] [PASSED] 256 [22:56:03] =================== [PASSED] test_reuse ==================== [22:56:03] =================== test_range_overlap ==================== [22:56:03] [PASSED] 4 [22:56:03] [PASSED] 8 [22:56:03] [PASSED] 32 [22:56:03] [PASSED] 256 [22:56:03] =============== [PASSED] test_range_overlap ================ [22:56:03] =================== test_range_compact ==================== [22:56:03] [PASSED] 4 [22:56:03] [PASSED] 8 [22:56:03] [PASSED] 32 [22:56:03] [PASSED] 256 [22:56:03] =============== [PASSED] test_range_compact ================ [22:56:03] ==================== test_range_spare ===================== [22:56:03] [PASSED] 4 [22:56:03] [PASSED] 8 [22:56:03] [PASSED] 32 [22:56:03] [PASSED] 256 [22:56:03] ================ [PASSED] test_range_spare ================= [22:56:03] ===================== [PASSED] guc_dbm ===================== [22:56:03] =================== guc_idm (6 subtests) =================== [22:56:03] [PASSED] bad_init [22:56:03] [PASSED] no_init [22:56:03] [PASSED] init_fini [22:56:03] [PASSED] check_used [22:56:03] [PASSED] check_quota [22:56:03] [PASSED] check_all [22:56:03] ===================== [PASSED] guc_idm ===================== [22:56:03] ================== no_relay (3 subtests) =================== [22:56:03] [PASSED] xe_drops_guc2pf_if_not_ready [22:56:03] [PASSED] xe_drops_guc2vf_if_not_ready [22:56:03] [PASSED] xe_rejects_send_if_not_ready [22:56:03] ==================== [PASSED] no_relay ===================== [22:56:03] ================== pf_relay (14 subtests) ================== [22:56:03] [PASSED] pf_rejects_guc2pf_too_short [22:56:03] [PASSED] pf_rejects_guc2pf_too_long [22:56:03] [PASSED] pf_rejects_guc2pf_no_payload [22:56:03] [PASSED] pf_fails_no_payload [22:56:03] [PASSED] pf_fails_bad_origin [22:56:03] [PASSED] pf_fails_bad_type [22:56:03] [PASSED] pf_txn_reports_error [22:56:03] [PASSED] pf_txn_sends_pf2guc [22:56:03] [PASSED] pf_sends_pf2guc [22:56:03] [SKIPPED] pf_loopback_nop [22:56:03] [SKIPPED] pf_loopback_echo [22:56:03] [SKIPPED] pf_loopback_fail [22:56:03] [SKIPPED] pf_loopback_busy [22:56:03] [SKIPPED] pf_loopback_retry [22:56:03] ==================== [PASSED] pf_relay ===================== [22:56:03] ================== vf_relay (3 subtests) =================== [22:56:03] [PASSED] vf_rejects_guc2vf_too_short [22:56:03] [PASSED] vf_rejects_guc2vf_too_long [22:56:03] [PASSED] vf_rejects_guc2vf_no_payload [22:56:03] ==================== [PASSED] vf_relay ===================== [22:56:03] ================ pf_gt_config (9 subtests) ================= [22:56:03] [PASSED] fair_contexts_1vf [22:56:03] [PASSED] fair_doorbells_1vf [22:56:03] [PASSED] fair_ggtt_1vf [22:56:03] ====================== fair_vram_1vf ====================== [22:56:03] [PASSED] 3.50 GiB [22:56:03] [PASSED] 11.5 GiB [22:56:03] [PASSED] 15.5 GiB [22:56:03] [PASSED] 31.5 GiB [22:56:03] [PASSED] 63.5 GiB [22:56:03] [PASSED] 1.91 GiB [22:56:03] ================== [PASSED] fair_vram_1vf ================== [22:56:03] ================ fair_vram_1vf_admin_only ================= [22:56:03] [PASSED] 3.50 GiB [22:56:03] [PASSED] 11.5 GiB [22:56:03] [PASSED] 15.5 GiB [22:56:03] [PASSED] 31.5 GiB [22:56:03] [PASSED] 63.5 GiB [22:56:03] [PASSED] 1.91 GiB [22:56:03] ============ [PASSED] fair_vram_1vf_admin_only ============= [22:56:03] ====================== fair_contexts ====================== [22:56:03] [PASSED] 1 VF [22:56:03] [PASSED] 2 VFs [22:56:03] [PASSED] 3 VFs [22:56:03] [PASSED] 4 VFs [22:56:03] [PASSED] 5 VFs [22:56:03] [PASSED] 6 VFs [22:56:03] [PASSED] 7 VFs [22:56:03] [PASSED] 8 VFs [22:56:03] [PASSED] 9 VFs [22:56:03] [PASSED] 10 VFs [22:56:03] [PASSED] 11 VFs [22:56:03] [PASSED] 12 VFs [22:56:03] [PASSED] 13 VFs [22:56:03] [PASSED] 14 VFs [22:56:03] [PASSED] 15 VFs [22:56:03] [PASSED] 16 VFs [22:56:03] [PASSED] 17 VFs [22:56:03] [PASSED] 18 VFs [22:56:03] [PASSED] 19 VFs [22:56:03] [PASSED] 20 VFs [22:56:03] [PASSED] 21 VFs [22:56:03] [PASSED] 22 VFs [22:56:03] [PASSED] 23 VFs [22:56:03] [PASSED] 24 VFs [22:56:03] [PASSED] 25 VFs [22:56:03] [PASSED] 26 VFs [22:56:03] [PASSED] 27 VFs [22:56:03] [PASSED] 28 VFs [22:56:03] [PASSED] 29 VFs [22:56:03] [PASSED] 30 VFs [22:56:03] [PASSED] 31 VFs [22:56:03] [PASSED] 32 VFs [22:56:03] [PASSED] 33 VFs [22:56:03] [PASSED] 34 VFs [22:56:03] [PASSED] 35 VFs [22:56:03] [PASSED] 36 VFs [22:56:03] [PASSED] 37 VFs [22:56:03] [PASSED] 38 VFs [22:56:03] [PASSED] 39 VFs [22:56:03] [PASSED] 40 VFs [22:56:03] [PASSED] 41 VFs [22:56:03] [PASSED] 42 VFs [22:56:03] [PASSED] 43 VFs [22:56:03] [PASSED] 44 VFs [22:56:03] [PASSED] 45 VFs [22:56:03] [PASSED] 46 VFs [22:56:03] [PASSED] 47 VFs [22:56:03] [PASSED] 48 VFs [22:56:03] [PASSED] 49 VFs [22:56:03] [PASSED] 50 VFs [22:56:03] [PASSED] 51 VFs [22:56:03] [PASSED] 52 VFs [22:56:03] [PASSED] 53 VFs [22:56:03] [PASSED] 54 VFs [22:56:03] [PASSED] 55 VFs [22:56:03] [PASSED] 56 VFs [22:56:03] [PASSED] 57 VFs [22:56:03] [PASSED] 58 VFs [22:56:03] [PASSED] 59 VFs [22:56:03] [PASSED] 60 VFs [22:56:03] [PASSED] 61 VFs [22:56:03] [PASSED] 62 VFs [22:56:03] [PASSED] 63 VFs [22:56:03] ================== [PASSED] fair_contexts ================== [22:56:03] ===================== fair_doorbells ====================== [22:56:03] [PASSED] 1 VF [22:56:03] [PASSED] 2 VFs [22:56:03] [PASSED] 3 VFs [22:56:03] [PASSED] 4 VFs [22:56:03] [PASSED] 5 VFs [22:56:03] [PASSED] 6 VFs [22:56:03] [PASSED] 7 VFs [22:56:03] [PASSED] 8 VFs [22:56:03] [PASSED] 9 VFs [22:56:03] [PASSED] 10 VFs [22:56:03] [PASSED] 11 VFs [22:56:03] [PASSED] 12 VFs [22:56:03] [PASSED] 13 VFs [22:56:03] [PASSED] 14 VFs [22:56:03] [PASSED] 15 VFs [22:56:03] [PASSED] 16 VFs [22:56:03] [PASSED] 17 VFs [22:56:03] [PASSED] 18 VFs [22:56:03] [PASSED] 19 VFs [22:56:03] [PASSED] 20 VFs [22:56:03] [PASSED] 21 VFs [22:56:03] [PASSED] 22 VFs [22:56:03] [PASSED] 23 VFs [22:56:03] [PASSED] 24 VFs [22:56:03] [PASSED] 25 VFs [22:56:03] [PASSED] 26 VFs [22:56:03] [PASSED] 27 VFs [22:56:03] [PASSED] 28 VFs [22:56:03] [PASSED] 29 VFs [22:56:03] [PASSED] 30 VFs [22:56:03] [PASSED] 31 VFs [22:56:03] [PASSED] 32 VFs [22:56:03] [PASSED] 33 VFs [22:56:03] [PASSED] 34 VFs [22:56:03] [PASSED] 35 VFs [22:56:03] [PASSED] 36 VFs [22:56:03] [PASSED] 37 VFs [22:56:03] [PASSED] 38 VFs [22:56:03] [PASSED] 39 VFs [22:56:03] [PASSED] 40 VFs [22:56:03] [PASSED] 41 VFs [22:56:03] [PASSED] 42 VFs [22:56:03] [PASSED] 43 VFs [22:56:03] [PASSED] 44 VFs [22:56:03] [PASSED] 45 VFs [22:56:03] [PASSED] 46 VFs [22:56:03] [PASSED] 47 VFs [22:56:03] [PASSED] 48 VFs [22:56:03] [PASSED] 49 VFs [22:56:03] [PASSED] 50 VFs [22:56:03] [PASSED] 51 VFs [22:56:03] [PASSED] 52 VFs [22:56:03] [PASSED] 53 VFs [22:56:03] [PASSED] 54 VFs [22:56:03] [PASSED] 55 VFs [22:56:03] [PASSED] 56 VFs [22:56:03] [PASSED] 57 VFs [22:56:03] [PASSED] 58 VFs [22:56:03] [PASSED] 59 VFs [22:56:03] [PASSED] 60 VFs [22:56:03] [PASSED] 61 VFs [22:56:03] [PASSED] 62 VFs [22:56:03] [PASSED] 63 VFs [22:56:03] ================= [PASSED] fair_doorbells ================== [22:56:03] ======================== fair_ggtt ======================== [22:56:03] [PASSED] 1 VF [22:56:03] [PASSED] 2 VFs [22:56:03] [PASSED] 3 VFs [22:56:03] [PASSED] 4 VFs [22:56:03] [PASSED] 5 VFs [22:56:03] [PASSED] 6 VFs [22:56:03] [PASSED] 7 VFs [22:56:03] [PASSED] 8 VFs [22:56:03] [PASSED] 9 VFs [22:56:03] [PASSED] 10 VFs [22:56:03] [PASSED] 11 VFs [22:56:03] [PASSED] 12 VFs [22:56:03] [PASSED] 13 VFs [22:56:03] [PASSED] 14 VFs [22:56:03] [PASSED] 15 VFs [22:56:03] [PASSED] 16 VFs [22:56:03] [PASSED] 17 VFs [22:56:03] [PASSED] 18 VFs [22:56:03] [PASSED] 19 VFs [22:56:03] [PASSED] 20 VFs [22:56:03] [PASSED] 21 VFs [22:56:03] [PASSED] 22 VFs [22:56:03] [PASSED] 23 VFs [22:56:03] [PASSED] 24 VFs [22:56:03] [PASSED] 25 VFs [22:56:03] [PASSED] 26 VFs [22:56:03] [PASSED] 27 VFs [22:56:03] [PASSED] 28 VFs [22:56:03] [PASSED] 29 VFs [22:56:03] [PASSED] 30 VFs [22:56:03] [PASSED] 31 VFs [22:56:03] [PASSED] 32 VFs [22:56:03] [PASSED] 33 VFs [22:56:03] [PASSED] 34 VFs [22:56:03] [PASSED] 35 VFs [22:56:03] [PASSED] 36 VFs [22:56:03] [PASSED] 37 VFs [22:56:03] [PASSED] 38 VFs [22:56:03] [PASSED] 39 VFs [22:56:03] [PASSED] 40 VFs [22:56:03] [PASSED] 41 VFs [22:56:03] [PASSED] 42 VFs [22:56:03] [PASSED] 43 VFs [22:56:03] [PASSED] 44 VFs [22:56:03] [PASSED] 45 VFs [22:56:03] [PASSED] 46 VFs [22:56:03] [PASSED] 47 VFs [22:56:03] [PASSED] 48 VFs [22:56:03] [PASSED] 49 VFs [22:56:03] [PASSED] 50 VFs [22:56:03] [PASSED] 51 VFs [22:56:03] [PASSED] 52 VFs [22:56:03] [PASSED] 53 VFs [22:56:03] [PASSED] 54 VFs [22:56:03] [PASSED] 55 VFs [22:56:03] [PASSED] 56 VFs [22:56:03] [PASSED] 57 VFs [22:56:03] [PASSED] 58 VFs [22:56:03] [PASSED] 59 VFs [22:56:03] [PASSED] 60 VFs [22:56:03] [PASSED] 61 VFs [22:56:03] [PASSED] 62 VFs [22:56:03] [PASSED] 63 VFs [22:56:03] ==================== [PASSED] fair_ggtt ==================== [22:56:03] ======================== fair_vram ======================== [22:56:03] [PASSED] 1 VF [22:56:03] [PASSED] 2 VFs [22:56:03] [PASSED] 3 VFs [22:56:03] [PASSED] 4 VFs [22:56:03] [PASSED] 5 VFs [22:56:03] [PASSED] 6 VFs [22:56:03] [PASSED] 7 VFs [22:56:03] [PASSED] 8 VFs [22:56:03] [PASSED] 9 VFs [22:56:03] [PASSED] 10 VFs [22:56:03] [PASSED] 11 VFs [22:56:03] [PASSED] 12 VFs [22:56:03] [PASSED] 13 VFs [22:56:03] [PASSED] 14 VFs [22:56:03] [PASSED] 15 VFs [22:56:03] [PASSED] 16 VFs [22:56:03] [PASSED] 17 VFs [22:56:03] [PASSED] 18 VFs [22:56:03] [PASSED] 19 VFs [22:56:03] [PASSED] 20 VFs [22:56:03] [PASSED] 21 VFs [22:56:03] [PASSED] 22 VFs [22:56:03] [PASSED] 23 VFs [22:56:03] [PASSED] 24 VFs [22:56:03] [PASSED] 25 VFs [22:56:03] [PASSED] 26 VFs [22:56:03] [PASSED] 27 VFs [22:56:03] [PASSED] 28 VFs [22:56:03] [PASSED] 29 VFs [22:56:03] [PASSED] 30 VFs [22:56:03] [PASSED] 31 VFs [22:56:03] [PASSED] 32 VFs [22:56:03] [PASSED] 33 VFs [22:56:03] [PASSED] 34 VFs [22:56:03] [PASSED] 35 VFs [22:56:03] [PASSED] 36 VFs [22:56:03] [PASSED] 37 VFs [22:56:03] [PASSED] 38 VFs [22:56:03] [PASSED] 39 VFs [22:56:03] [PASSED] 40 VFs [22:56:03] [PASSED] 41 VFs [22:56:03] [PASSED] 42 VFs [22:56:03] [PASSED] 43 VFs [22:56:03] [PASSED] 44 VFs [22:56:03] [PASSED] 45 VFs [22:56:03] [PASSED] 46 VFs [22:56:03] [PASSED] 47 VFs [22:56:03] [PASSED] 48 VFs [22:56:03] [PASSED] 49 VFs [22:56:03] [PASSED] 50 VFs [22:56:03] [PASSED] 51 VFs [22:56:03] [PASSED] 52 VFs [22:56:03] [PASSED] 53 VFs [22:56:03] [PASSED] 54 VFs [22:56:03] [PASSED] 55 VFs [22:56:03] [PASSED] 56 VFs [22:56:03] [PASSED] 57 VFs [22:56:03] [PASSED] 58 VFs [22:56:03] [PASSED] 59 VFs [22:56:03] [PASSED] 60 VFs [22:56:03] [PASSED] 61 VFs [22:56:03] [PASSED] 62 VFs [22:56:03] [PASSED] 63 VFs [22:56:03] ==================== [PASSED] fair_vram ==================== [22:56:03] ================== [PASSED] pf_gt_config =================== [22:56:03] ===================== lmtt (1 subtest) ===================== [22:56:03] ======================== test_ops ========================= [22:56:03] [PASSED] 2-level [22:56:03] [PASSED] multi-level [22:56:03] ==================== [PASSED] test_ops ===================== [22:56:03] ====================== [PASSED] lmtt ======================= [22:56:03] ================= pf_service (11 subtests) ================= [22:56:03] [PASSED] pf_negotiate_any [22:56:03] [PASSED] pf_negotiate_base_match [22:56:03] [PASSED] pf_negotiate_base_newer [22:56:03] [PASSED] pf_negotiate_base_next [22:56:03] [SKIPPED] pf_negotiate_base_older [22:56:03] [PASSED] pf_negotiate_base_prev [22:56:03] [PASSED] pf_negotiate_latest_match [22:56:03] [PASSED] pf_negotiate_latest_newer [22:56:03] [PASSED] pf_negotiate_latest_next [22:56:03] [SKIPPED] pf_negotiate_latest_older [22:56:03] [SKIPPED] pf_negotiate_latest_prev [22:56:03] =================== [PASSED] pf_service ==================== [22:56:03] ================= xe_guc_g2g (2 subtests) ================== [22:56:03] ============== xe_live_guc_g2g_kunit_default ============== [22:56:03] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [22:56:03] ============== xe_live_guc_g2g_kunit_allmem =============== [22:56:03] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [22:56:03] =================== [SKIPPED] xe_guc_g2g =================== [22:56:03] =================== xe_mocs (2 subtests) =================== [22:56:03] ================ xe_live_mocs_kernel_kunit ================ [22:56:03] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [22:56:03] ================ xe_live_mocs_reset_kunit ================= [22:56:03] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [22:56:03] ==================== [SKIPPED] xe_mocs ===================== [22:56:03] ================= xe_migrate (2 subtests) ================== [22:56:03] ================= xe_migrate_sanity_kunit ================= [22:56:03] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [22:56:03] ================== xe_validate_ccs_kunit ================== [22:56:03] ============= [SKIPPED] xe_validate_ccs_kunit ============== [22:56:03] =================== [SKIPPED] xe_migrate =================== [22:56:03] ================== xe_dma_buf (1 subtest) ================== [22:56:03] ==================== xe_dma_buf_kunit ===================== [22:56:03] ================ [SKIPPED] xe_dma_buf_kunit ================ [22:56:03] =================== [SKIPPED] xe_dma_buf =================== [22:56:03] ================= xe_bo_shrink (1 subtest) ================= [22:56:03] =================== xe_bo_shrink_kunit ==================== [22:56:03] =============== [SKIPPED] xe_bo_shrink_kunit =============== [22:56:03] ================== [SKIPPED] xe_bo_shrink ================== [22:56:03] ==================== xe_bo (2 subtests) ==================== [22:56:03] ================== xe_ccs_migrate_kunit =================== [22:56:03] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [22:56:03] ==================== xe_bo_evict_kunit ==================== [22:56:03] =============== [SKIPPED] xe_bo_evict_kunit ================ [22:56:03] ===================== [SKIPPED] xe_bo ====================== [22:56:03] ==================== args (13 subtests) ==================== [22:56:03] [PASSED] count_args_test [22:56:03] [PASSED] call_args_example [22:56:03] [PASSED] call_args_test [22:56:03] [PASSED] drop_first_arg_example [22:56:03] [PASSED] drop_first_arg_test [22:56:03] [PASSED] first_arg_example [22:56:03] [PASSED] first_arg_test [22:56:03] [PASSED] last_arg_example [22:56:03] [PASSED] last_arg_test [22:56:03] [PASSED] pick_arg_example [22:56:03] [PASSED] if_args_example [22:56:03] [PASSED] if_args_test [22:56:03] [PASSED] sep_comma_example [22:56:03] ====================== [PASSED] args ======================= [22:56:03] =================== xe_pci (3 subtests) ==================== [22:56:03] ==================== check_graphics_ip ==================== [22:56:03] [PASSED] 12.00 Xe_LP [22:56:03] [PASSED] 12.10 Xe_LP+ [22:56:03] [PASSED] 12.55 Xe_HPG [22:56:03] [PASSED] 12.60 Xe_HPC [22:56:03] [PASSED] 12.70 Xe_LPG [22:56:03] [PASSED] 12.71 Xe_LPG [22:56:03] [PASSED] 12.74 Xe_LPG+ [22:56:03] [PASSED] 20.01 Xe2_HPG [22:56:03] [PASSED] 20.02 Xe2_HPG [22:56:03] [PASSED] 20.04 Xe2_LPG [22:56:03] [PASSED] 30.00 Xe3_LPG [22:56:03] [PASSED] 30.01 Xe3_LPG [22:56:03] [PASSED] 30.03 Xe3_LPG [22:56:03] [PASSED] 30.04 Xe3_LPG [22:56:03] [PASSED] 30.05 Xe3_LPG [22:56:03] [PASSED] 35.10 Xe3p_LPG [22:56:03] [PASSED] 35.11 Xe3p_XPC [22:56:03] ================ [PASSED] check_graphics_ip ================ [22:56:03] ===================== check_media_ip ====================== [22:56:03] [PASSED] 12.00 Xe_M [22:56:03] [PASSED] 12.55 Xe_HPM [22:56:03] [PASSED] 13.00 Xe_LPM+ [22:56:03] [PASSED] 13.01 Xe2_HPM [22:56:03] [PASSED] 20.00 Xe2_LPM [22:56:03] [PASSED] 30.00 Xe3_LPM [22:56:03] [PASSED] 30.02 Xe3_LPM [22:56:03] [PASSED] 35.00 Xe3p_LPM [22:56:03] [PASSED] 35.03 Xe3p_HPM [22:56:03] ================= [PASSED] check_media_ip ================== [22:56:03] =================== check_platform_desc =================== [22:56:03] [PASSED] 0x9A60 (TIGERLAKE) [22:56:03] [PASSED] 0x9A68 (TIGERLAKE) [22:56:03] [PASSED] 0x9A70 (TIGERLAKE) [22:56:03] [PASSED] 0x9A40 (TIGERLAKE) [22:56:03] [PASSED] 0x9A49 (TIGERLAKE) [22:56:03] [PASSED] 0x9A59 (TIGERLAKE) [22:56:03] [PASSED] 0x9A78 (TIGERLAKE) [22:56:03] [PASSED] 0x9AC0 (TIGERLAKE) [22:56:03] [PASSED] 0x9AC9 (TIGERLAKE) [22:56:03] [PASSED] 0x9AD9 (TIGERLAKE) [22:56:03] [PASSED] 0x9AF8 (TIGERLAKE) [22:56:03] [PASSED] 0x4C80 (ROCKETLAKE) [22:56:03] [PASSED] 0x4C8A (ROCKETLAKE) [22:56:03] [PASSED] 0x4C8B (ROCKETLAKE) [22:56:03] [PASSED] 0x4C8C (ROCKETLAKE) [22:56:03] [PASSED] 0x4C90 (ROCKETLAKE) [22:56:03] [PASSED] 0x4C9A (ROCKETLAKE) [22:56:03] [PASSED] 0x4680 (ALDERLAKE_S) [22:56:03] [PASSED] 0x4682 (ALDERLAKE_S) [22:56:03] [PASSED] 0x4688 (ALDERLAKE_S) [22:56:03] [PASSED] 0x468A (ALDERLAKE_S) [22:56:03] [PASSED] 0x468B (ALDERLAKE_S) [22:56:03] [PASSED] 0x4690 (ALDERLAKE_S) [22:56:03] [PASSED] 0x4692 (ALDERLAKE_S) [22:56:03] [PASSED] 0x4693 (ALDERLAKE_S) [22:56:03] [PASSED] 0x46A0 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46A1 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46A2 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46A3 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46A6 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46A8 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46AA (ALDERLAKE_P) [22:56:03] [PASSED] 0x462A (ALDERLAKE_P) [22:56:03] [PASSED] 0x4626 (ALDERLAKE_P) [22:56:03] [PASSED] 0x4628 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46B0 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46B1 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46B2 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46B3 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46C0 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46C1 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46C2 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46C3 (ALDERLAKE_P) [22:56:03] [PASSED] 0x46D0 (ALDERLAKE_N) [22:56:03] [PASSED] 0x46D1 (ALDERLAKE_N) [22:56:03] [PASSED] 0x46D2 (ALDERLAKE_N) [22:56:03] [PASSED] 0x46D3 (ALDERLAKE_N) [22:56:03] [PASSED] 0x46D4 (ALDERLAKE_N) [22:56:03] [PASSED] 0xA721 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7A1 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7A9 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7AC (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7AD (ALDERLAKE_P) [22:56:03] [PASSED] 0xA720 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7A0 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7A8 (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7AA (ALDERLAKE_P) [22:56:03] [PASSED] 0xA7AB (ALDERLAKE_P) [22:56:03] [PASSED] 0xA780 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA781 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA782 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA783 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA788 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA789 (ALDERLAKE_S) [22:56:03] [PASSED] 0xA78A (ALDERLAKE_S) [22:56:03] [PASSED] 0xA78B (ALDERLAKE_S) [22:56:03] [PASSED] 0x4905 (DG1) [22:56:03] [PASSED] 0x4906 (DG1) [22:56:03] [PASSED] 0x4907 (DG1) [22:56:03] [PASSED] 0x4908 (DG1) [22:56:03] [PASSED] 0x4909 (DG1) [22:56:03] [PASSED] 0x56C0 (DG2) [22:56:03] [PASSED] 0x56C2 (DG2) [22:56:03] [PASSED] 0x56C1 (DG2) [22:56:03] [PASSED] 0x7D51 (METEORLAKE) [22:56:03] [PASSED] 0x7DD1 (METEORLAKE) [22:56:03] [PASSED] 0x7D41 (METEORLAKE) [22:56:03] [PASSED] 0x7D67 (METEORLAKE) [22:56:03] [PASSED] 0xB640 (METEORLAKE) [22:56:03] [PASSED] 0x56A0 (DG2) [22:56:03] [PASSED] 0x56A1 (DG2) [22:56:03] [PASSED] 0x56A2 (DG2) [22:56:03] [PASSED] 0x56BE (DG2) [22:56:03] [PASSED] 0x56BF (DG2) [22:56:03] [PASSED] 0x5690 (DG2) [22:56:03] [PASSED] 0x5691 (DG2) [22:56:03] [PASSED] 0x5692 (DG2) [22:56:03] [PASSED] 0x56A5 (DG2) [22:56:03] [PASSED] 0x56A6 (DG2) [22:56:03] [PASSED] 0x56B0 (DG2) [22:56:03] [PASSED] 0x56B1 (DG2) [22:56:03] [PASSED] 0x56BA (DG2) [22:56:03] [PASSED] 0x56BB (DG2) [22:56:03] [PASSED] 0x56BC (DG2) [22:56:03] [PASSED] 0x56BD (DG2) [22:56:03] [PASSED] 0x5693 (DG2) [22:56:03] [PASSED] 0x5694 (DG2) [22:56:03] [PASSED] 0x5695 (DG2) [22:56:03] [PASSED] 0x56A3 (DG2) [22:56:03] [PASSED] 0x56A4 (DG2) [22:56:03] [PASSED] 0x56B2 (DG2) [22:56:03] [PASSED] 0x56B3 (DG2) [22:56:03] [PASSED] 0x5696 (DG2) [22:56:03] [PASSED] 0x5697 (DG2) [22:56:03] [PASSED] 0xB69 (PVC) [22:56:03] [PASSED] 0xB6E (PVC) [22:56:03] [PASSED] 0xBD4 (PVC) [22:56:03] [PASSED] 0xBD5 (PVC) [22:56:03] [PASSED] 0xBD6 (PVC) [22:56:03] [PASSED] 0xBD7 (PVC) [22:56:03] [PASSED] 0xBD8 (PVC) [22:56:03] [PASSED] 0xBD9 (PVC) [22:56:03] [PASSED] 0xBDA (PVC) [22:56:03] [PASSED] 0xBDB (PVC) [22:56:03] [PASSED] 0xBE0 (PVC) [22:56:03] [PASSED] 0xBE1 (PVC) [22:56:03] [PASSED] 0xBE5 (PVC) [22:56:03] [PASSED] 0x7D40 (METEORLAKE) [22:56:03] [PASSED] 0x7D45 (METEORLAKE) [22:56:03] [PASSED] 0x7D55 (METEORLAKE) [22:56:03] [PASSED] 0x7D60 (METEORLAKE) [22:56:03] [PASSED] 0x7DD5 (METEORLAKE) [22:56:03] [PASSED] 0x6420 (LUNARLAKE) [22:56:03] [PASSED] 0x64A0 (LUNARLAKE) [22:56:03] [PASSED] 0x64B0 (LUNARLAKE) [22:56:03] [PASSED] 0xE202 (BATTLEMAGE) [22:56:03] [PASSED] 0xE209 (BATTLEMAGE) [22:56:03] [PASSED] 0xE20B (BATTLEMAGE) [22:56:03] [PASSED] 0xE20C (BATTLEMAGE) [22:56:03] [PASSED] 0xE20D (BATTLEMAGE) [22:56:03] [PASSED] 0xE210 (BATTLEMAGE) [22:56:03] [PASSED] 0xE211 (BATTLEMAGE) [22:56:03] [PASSED] 0xE212 (BATTLEMAGE) [22:56:03] [PASSED] 0xE216 (BATTLEMAGE) [22:56:03] [PASSED] 0xE220 (BATTLEMAGE) [22:56:03] [PASSED] 0xE221 (BATTLEMAGE) [22:56:03] [PASSED] 0xE222 (BATTLEMAGE) [22:56:03] [PASSED] 0xE223 (BATTLEMAGE) [22:56:03] [PASSED] 0xB080 (PANTHERLAKE) [22:56:03] [PASSED] 0xB081 (PANTHERLAKE) [22:56:03] [PASSED] 0xB082 (PANTHERLAKE) [22:56:03] [PASSED] 0xB083 (PANTHERLAKE) [22:56:03] [PASSED] 0xB084 (PANTHERLAKE) [22:56:03] [PASSED] 0xB085 (PANTHERLAKE) [22:56:03] [PASSED] 0xB086 (PANTHERLAKE) [22:56:03] [PASSED] 0xB087 (PANTHERLAKE) [22:56:03] [PASSED] 0xB08F (PANTHERLAKE) [22:56:03] [PASSED] 0xB090 (PANTHERLAKE) [22:56:03] [PASSED] 0xB0A0 (PANTHERLAKE) [22:56:03] [PASSED] 0xB0B0 (PANTHERLAKE) [22:56:03] [PASSED] 0xFD80 (PANTHERLAKE) [22:56:03] [PASSED] 0xFD81 (PANTHERLAKE) [22:56:03] [PASSED] 0xD740 (NOVALAKE_S) [22:56:03] [PASSED] 0xD741 (NOVALAKE_S) [22:56:03] [PASSED] 0xD742 (NOVALAKE_S) [22:56:03] [PASSED] 0xD743 (NOVALAKE_S) [22:56:03] [PASSED] 0xD744 (NOVALAKE_S) [22:56:03] [PASSED] 0xD745 (NOVALAKE_S) [22:56:03] [PASSED] 0x674C (CRESCENTISLAND) [22:56:03] [PASSED] 0xD750 (NOVALAKE_P) [22:56:03] [PASSED] 0xD751 (NOVALAKE_P) [22:56:03] [PASSED] 0xD752 (NOVALAKE_P) [22:56:03] [PASSED] 0xD753 (NOVALAKE_P) [22:56:03] [PASSED] 0xD754 (NOVALAKE_P) [22:56:03] [PASSED] 0xD755 (NOVALAKE_P) [22:56:03] [PASSED] 0xD756 (NOVALAKE_P) [22:56:03] [PASSED] 0xD757 (NOVALAKE_P) [22:56:03] [PASSED] 0xD75F (NOVALAKE_P) [22:56:03] =============== [PASSED] check_platform_desc =============== [22:56:03] ===================== [PASSED] xe_pci ====================== [22:56:03] =================== xe_rtp (2 subtests) ==================== [22:56:03] =============== xe_rtp_process_to_sr_tests ================ [22:56:03] [PASSED] coalesce-same-reg [22:56:03] [PASSED] no-match-no-add [22:56:03] [PASSED] match-or [22:56:03] [PASSED] match-or-xfail [22:56:03] [PASSED] no-match-no-add-multiple-rules [22:56:03] [PASSED] two-regs-two-entries [22:56:03] [PASSED] clr-one-set-other [22:56:03] [PASSED] set-field [22:56:03] [PASSED] conflict-duplicate stty: 'standard input': Inappropriate ioctl for device [22:56:03] [PASSED] conflict-not-disjoint [22:56:03] [PASSED] conflict-reg-type [22:56:03] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [22:56:03] ================== xe_rtp_process_tests =================== [22:56:03] [PASSED] active1 [22:56:03] [PASSED] active2 [22:56:03] [PASSED] active-inactive [22:56:04] [PASSED] inactive-active [22:56:04] [PASSED] inactive-1st_or_active-inactive [22:56:04] [PASSED] inactive-2nd_or_active-inactive [22:56:04] [PASSED] inactive-last_or_active-inactive [22:56:04] [PASSED] inactive-no_or_active-inactive [22:56:04] ============== [PASSED] xe_rtp_process_tests =============== [22:56:04] ===================== [PASSED] xe_rtp ====================== [22:56:04] ==================== xe_wa (1 subtest) ===================== [22:56:04] ======================== xe_wa_gt ========================= [22:56:04] [PASSED] TIGERLAKE B0 [22:56:04] [PASSED] DG1 A0 [22:56:04] [PASSED] DG1 B0 [22:56:04] [PASSED] ALDERLAKE_S A0 [22:56:04] [PASSED] ALDERLAKE_S B0 [22:56:04] [PASSED] ALDERLAKE_S C0 [22:56:04] [PASSED] ALDERLAKE_S D0 [22:56:04] [PASSED] ALDERLAKE_P A0 [22:56:04] [PASSED] ALDERLAKE_P B0 [22:56:04] [PASSED] ALDERLAKE_P C0 [22:56:04] [PASSED] ALDERLAKE_S RPLS D0 [22:56:04] [PASSED] ALDERLAKE_P RPLU E0 [22:56:04] [PASSED] DG2 G10 C0 [22:56:04] [PASSED] DG2 G11 B1 [22:56:04] [PASSED] DG2 G12 A1 [22:56:04] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [22:56:04] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [22:56:04] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [22:56:04] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [22:56:04] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [22:56:04] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [22:56:04] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [22:56:04] ==================== [PASSED] xe_wa_gt ===================== [22:56:04] ====================== [PASSED] xe_wa ====================== [22:56:04] ============================================================ [22:56:04] Testing complete. Ran 597 tests: passed: 579, skipped: 18 [22:56:04] Elapsed time: 35.625s total, 4.243s configuring, 30.765s building, 0.597s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [22:56:04] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [22:56:05] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [22:56:29] Starting KUnit Kernel (1/1)... [22:56:29] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [22:56:29] ============ drm_test_pick_cmdline (2 subtests) ============ [22:56:29] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [22:56:29] =============== drm_test_pick_cmdline_named =============== [22:56:29] [PASSED] NTSC [22:56:29] [PASSED] NTSC-J [22:56:29] [PASSED] PAL [22:56:29] [PASSED] PAL-M [22:56:29] =========== [PASSED] drm_test_pick_cmdline_named =========== [22:56:29] ============== [PASSED] drm_test_pick_cmdline ============== [22:56:29] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [22:56:29] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [22:56:29] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [22:56:29] =========== drm_validate_clone_mode (2 subtests) =========== [22:56:29] ============== drm_test_check_in_clone_mode =============== [22:56:29] [PASSED] in_clone_mode [22:56:29] [PASSED] not_in_clone_mode [22:56:29] ========== [PASSED] drm_test_check_in_clone_mode =========== [22:56:29] =============== drm_test_check_valid_clones =============== [22:56:29] [PASSED] not_in_clone_mode [22:56:29] [PASSED] valid_clone [22:56:29] [PASSED] invalid_clone [22:56:29] =========== [PASSED] drm_test_check_valid_clones =========== [22:56:29] ============= [PASSED] drm_validate_clone_mode ============= [22:56:29] ============= drm_validate_modeset (1 subtest) ============= [22:56:29] [PASSED] drm_test_check_connector_changed_modeset [22:56:29] ============== [PASSED] drm_validate_modeset =============== [22:56:29] ====== drm_test_bridge_get_current_state (2 subtests) ====== [22:56:29] [PASSED] drm_test_drm_bridge_get_current_state_atomic [22:56:29] [PASSED] drm_test_drm_bridge_get_current_state_legacy [22:56:29] ======== [PASSED] drm_test_bridge_get_current_state ======== [22:56:29] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [22:56:29] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [22:56:29] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [22:56:29] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [22:56:29] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [22:56:29] ============== drm_bridge_alloc (2 subtests) =============== [22:56:29] [PASSED] drm_test_drm_bridge_alloc_basic [22:56:29] [PASSED] drm_test_drm_bridge_alloc_get_put [22:56:29] ================ [PASSED] drm_bridge_alloc ================= [22:56:29] ============= drm_cmdline_parser (40 subtests) ============= [22:56:29] [PASSED] drm_test_cmdline_force_d_only [22:56:29] [PASSED] drm_test_cmdline_force_D_only_dvi [22:56:29] [PASSED] drm_test_cmdline_force_D_only_hdmi [22:56:29] [PASSED] drm_test_cmdline_force_D_only_not_digital [22:56:29] [PASSED] drm_test_cmdline_force_e_only [22:56:29] [PASSED] drm_test_cmdline_res [22:56:29] [PASSED] drm_test_cmdline_res_vesa [22:56:29] [PASSED] drm_test_cmdline_res_vesa_rblank [22:56:29] [PASSED] drm_test_cmdline_res_rblank [22:56:29] [PASSED] drm_test_cmdline_res_bpp [22:56:29] [PASSED] drm_test_cmdline_res_refresh [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [22:56:29] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [22:56:29] [PASSED] drm_test_cmdline_res_margins_force_on [22:56:29] [PASSED] drm_test_cmdline_res_vesa_margins [22:56:29] [PASSED] drm_test_cmdline_name [22:56:29] [PASSED] drm_test_cmdline_name_bpp [22:56:29] [PASSED] drm_test_cmdline_name_option [22:56:29] [PASSED] drm_test_cmdline_name_bpp_option [22:56:29] [PASSED] drm_test_cmdline_rotate_0 [22:56:29] [PASSED] drm_test_cmdline_rotate_90 [22:56:29] [PASSED] drm_test_cmdline_rotate_180 [22:56:29] [PASSED] drm_test_cmdline_rotate_270 [22:56:29] [PASSED] drm_test_cmdline_hmirror [22:56:29] [PASSED] drm_test_cmdline_vmirror [22:56:29] [PASSED] drm_test_cmdline_margin_options [22:56:29] [PASSED] drm_test_cmdline_multiple_options [22:56:29] [PASSED] drm_test_cmdline_bpp_extra_and_option [22:56:29] [PASSED] drm_test_cmdline_extra_and_option [22:56:29] [PASSED] drm_test_cmdline_freestanding_options [22:56:29] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [22:56:29] [PASSED] drm_test_cmdline_panel_orientation [22:56:29] ================ drm_test_cmdline_invalid ================= [22:56:29] [PASSED] margin_only [22:56:29] [PASSED] interlace_only [22:56:29] [PASSED] res_missing_x [22:56:29] [PASSED] res_missing_y [22:56:29] [PASSED] res_bad_y [22:56:29] [PASSED] res_missing_y_bpp [22:56:29] [PASSED] res_bad_bpp [22:56:29] [PASSED] res_bad_refresh [22:56:29] [PASSED] res_bpp_refresh_force_on_off [22:56:29] [PASSED] res_invalid_mode [22:56:29] [PASSED] res_bpp_wrong_place_mode [22:56:29] [PASSED] name_bpp_refresh [22:56:29] [PASSED] name_refresh [22:56:29] [PASSED] name_refresh_wrong_mode [22:56:29] [PASSED] name_refresh_invalid_mode [22:56:29] [PASSED] rotate_multiple [22:56:29] [PASSED] rotate_invalid_val [22:56:29] [PASSED] rotate_truncated [22:56:29] [PASSED] invalid_option [22:56:29] [PASSED] invalid_tv_option [22:56:29] [PASSED] truncated_tv_option [22:56:29] ============ [PASSED] drm_test_cmdline_invalid ============= [22:56:29] =============== drm_test_cmdline_tv_options =============== [22:56:29] [PASSED] NTSC [22:56:29] [PASSED] NTSC_443 [22:56:29] [PASSED] NTSC_J [22:56:29] [PASSED] PAL [22:56:29] [PASSED] PAL_M [22:56:29] [PASSED] PAL_N [22:56:29] [PASSED] SECAM [22:56:29] [PASSED] MONO_525 [22:56:29] [PASSED] MONO_625 [22:56:29] =========== [PASSED] drm_test_cmdline_tv_options =========== [22:56:29] =============== [PASSED] drm_cmdline_parser ================ [22:56:29] ========== drmm_connector_hdmi_init (20 subtests) ========== [22:56:29] [PASSED] drm_test_connector_hdmi_init_valid [22:56:29] [PASSED] drm_test_connector_hdmi_init_bpc_8 [22:56:29] [PASSED] drm_test_connector_hdmi_init_bpc_10 [22:56:29] [PASSED] drm_test_connector_hdmi_init_bpc_12 [22:56:29] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [22:56:29] [PASSED] drm_test_connector_hdmi_init_bpc_null [22:56:29] [PASSED] drm_test_connector_hdmi_init_formats_empty [22:56:29] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [22:56:29] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [22:56:29] [PASSED] supported_formats=0x9 yuv420_allowed=1 [22:56:29] [PASSED] supported_formats=0x9 yuv420_allowed=0 [22:56:29] [PASSED] supported_formats=0x5 yuv420_allowed=1 [22:56:29] [PASSED] supported_formats=0x5 yuv420_allowed=0 [22:56:29] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [22:56:29] [PASSED] drm_test_connector_hdmi_init_null_ddc [22:56:29] [PASSED] drm_test_connector_hdmi_init_null_product [22:56:29] [PASSED] drm_test_connector_hdmi_init_null_vendor [22:56:29] [PASSED] drm_test_connector_hdmi_init_product_length_exact [22:56:29] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [22:56:29] [PASSED] drm_test_connector_hdmi_init_product_valid [22:56:29] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [22:56:29] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [22:56:29] [PASSED] drm_test_connector_hdmi_init_vendor_valid [22:56:29] ========= drm_test_connector_hdmi_init_type_valid ========= [22:56:29] [PASSED] HDMI-A [22:56:29] [PASSED] HDMI-B [22:56:29] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [22:56:29] ======== drm_test_connector_hdmi_init_type_invalid ======== [22:56:29] [PASSED] Unknown [22:56:29] [PASSED] VGA [22:56:29] [PASSED] DVI-I [22:56:29] [PASSED] DVI-D [22:56:29] [PASSED] DVI-A [22:56:29] [PASSED] Composite [22:56:29] [PASSED] SVIDEO [22:56:29] [PASSED] LVDS [22:56:29] [PASSED] Component [22:56:29] [PASSED] DIN [22:56:29] [PASSED] DP [22:56:29] [PASSED] TV [22:56:29] [PASSED] eDP [22:56:29] [PASSED] Virtual [22:56:29] [PASSED] DSI [22:56:29] [PASSED] DPI [22:56:29] [PASSED] Writeback [22:56:29] [PASSED] SPI [22:56:29] [PASSED] USB [22:56:29] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [22:56:29] ============ [PASSED] drmm_connector_hdmi_init ============= [22:56:29] ============= drmm_connector_init (3 subtests) ============= [22:56:29] [PASSED] drm_test_drmm_connector_init [22:56:29] [PASSED] drm_test_drmm_connector_init_null_ddc [22:56:29] ========= drm_test_drmm_connector_init_type_valid ========= [22:56:29] [PASSED] Unknown [22:56:29] [PASSED] VGA [22:56:29] [PASSED] DVI-I [22:56:29] [PASSED] DVI-D [22:56:29] [PASSED] DVI-A [22:56:29] [PASSED] Composite [22:56:29] [PASSED] SVIDEO [22:56:29] [PASSED] LVDS [22:56:29] [PASSED] Component [22:56:29] [PASSED] DIN [22:56:29] [PASSED] DP [22:56:29] [PASSED] HDMI-A [22:56:29] [PASSED] HDMI-B [22:56:29] [PASSED] TV [22:56:29] [PASSED] eDP [22:56:29] [PASSED] Virtual [22:56:29] [PASSED] DSI [22:56:29] [PASSED] DPI [22:56:29] [PASSED] Writeback [22:56:29] [PASSED] SPI [22:56:29] [PASSED] USB [22:56:29] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [22:56:29] =============== [PASSED] drmm_connector_init =============== [22:56:29] ========= drm_connector_dynamic_init (6 subtests) ========== [22:56:29] [PASSED] drm_test_drm_connector_dynamic_init [22:56:29] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [22:56:29] [PASSED] drm_test_drm_connector_dynamic_init_not_added [22:56:29] [PASSED] drm_test_drm_connector_dynamic_init_properties [22:56:29] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [22:56:29] [PASSED] Unknown [22:56:29] [PASSED] VGA [22:56:29] [PASSED] DVI-I [22:56:29] [PASSED] DVI-D [22:56:29] [PASSED] DVI-A [22:56:29] [PASSED] Composite [22:56:29] [PASSED] SVIDEO [22:56:29] [PASSED] LVDS [22:56:29] [PASSED] Component [22:56:29] [PASSED] DIN [22:56:29] [PASSED] DP [22:56:29] [PASSED] HDMI-A [22:56:29] [PASSED] HDMI-B [22:56:29] [PASSED] TV [22:56:29] [PASSED] eDP [22:56:29] [PASSED] Virtual [22:56:29] [PASSED] DSI [22:56:29] [PASSED] DPI [22:56:29] [PASSED] Writeback [22:56:29] [PASSED] SPI [22:56:29] [PASSED] USB [22:56:29] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [22:56:29] ======== drm_test_drm_connector_dynamic_init_name ========= [22:56:29] [PASSED] Unknown [22:56:29] [PASSED] VGA [22:56:29] [PASSED] DVI-I [22:56:29] [PASSED] DVI-D [22:56:29] [PASSED] DVI-A [22:56:29] [PASSED] Composite [22:56:29] [PASSED] SVIDEO [22:56:29] [PASSED] LVDS [22:56:29] [PASSED] Component [22:56:29] [PASSED] DIN [22:56:29] [PASSED] DP [22:56:29] [PASSED] HDMI-A [22:56:29] [PASSED] HDMI-B [22:56:29] [PASSED] TV [22:56:29] [PASSED] eDP [22:56:29] [PASSED] Virtual [22:56:29] [PASSED] DSI [22:56:29] [PASSED] DPI [22:56:29] [PASSED] Writeback [22:56:29] [PASSED] SPI [22:56:29] [PASSED] USB [22:56:29] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [22:56:29] =========== [PASSED] drm_connector_dynamic_init ============ [22:56:29] ==== drm_connector_dynamic_register_early (4 subtests) ===== [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [22:56:29] ====== [PASSED] drm_connector_dynamic_register_early ======= [22:56:29] ======= drm_connector_dynamic_register (7 subtests) ======== [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_on_list [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_no_init [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [22:56:29] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [22:56:29] ========= [PASSED] drm_connector_dynamic_register ========== [22:56:29] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [22:56:29] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [22:56:29] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [22:56:29] === [PASSED] drm_connector_attach_broadcast_rgb_property === [22:56:29] ========== drm_get_tv_mode_from_name (2 subtests) ========== [22:56:29] ========== drm_test_get_tv_mode_from_name_valid =========== [22:56:29] [PASSED] NTSC [22:56:29] [PASSED] NTSC-443 [22:56:29] [PASSED] NTSC-J [22:56:29] [PASSED] PAL [22:56:29] [PASSED] PAL-M [22:56:29] [PASSED] PAL-N [22:56:29] [PASSED] SECAM [22:56:29] [PASSED] Mono [22:56:29] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [22:56:29] [PASSED] drm_test_get_tv_mode_from_name_truncated [22:56:29] ============ [PASSED] drm_get_tv_mode_from_name ============ [22:56:29] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [22:56:29] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [22:56:29] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [22:56:29] [PASSED] VIC 96 [22:56:29] [PASSED] VIC 97 [22:56:29] [PASSED] VIC 101 [22:56:29] [PASSED] VIC 102 [22:56:29] [PASSED] VIC 106 [22:56:29] [PASSED] VIC 107 [22:56:29] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [22:56:29] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [22:56:29] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [22:56:29] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [22:56:29] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [22:56:29] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [22:56:29] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [22:56:29] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [22:56:29] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [22:56:29] [PASSED] Automatic [22:56:29] [PASSED] Full [22:56:29] [PASSED] Limited 16:235 [22:56:29] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [22:56:29] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [22:56:29] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [22:56:29] == drm_hdmi_connector_get_output_format_name (2 subtests) == [22:56:29] === drm_test_drm_hdmi_connector_get_output_format_name ==== [22:56:29] [PASSED] RGB [22:56:29] [PASSED] YUV 4:2:0 [22:56:29] [PASSED] YUV 4:2:2 [22:56:29] [PASSED] YUV 4:4:4 [22:56:29] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [22:56:29] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [22:56:29] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [22:56:29] ============= drm_damage_helper (21 subtests) ============== [22:56:29] [PASSED] drm_test_damage_iter_no_damage [22:56:29] [PASSED] drm_test_damage_iter_no_damage_fractional_src [22:56:29] [PASSED] drm_test_damage_iter_no_damage_src_moved [22:56:29] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [22:56:29] [PASSED] drm_test_damage_iter_no_damage_not_visible [22:56:29] [PASSED] drm_test_damage_iter_no_damage_no_crtc [22:56:29] [PASSED] drm_test_damage_iter_no_damage_no_fb [22:56:29] [PASSED] drm_test_damage_iter_simple_damage [22:56:29] [PASSED] drm_test_damage_iter_single_damage [22:56:29] [PASSED] drm_test_damage_iter_single_damage_intersect_src [22:56:29] [PASSED] drm_test_damage_iter_single_damage_outside_src [22:56:29] [PASSED] drm_test_damage_iter_single_damage_fractional_src [22:56:29] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [22:56:29] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [22:56:29] [PASSED] drm_test_damage_iter_single_damage_src_moved [22:56:29] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [22:56:29] [PASSED] drm_test_damage_iter_damage [22:56:29] [PASSED] drm_test_damage_iter_damage_one_intersect [22:56:29] [PASSED] drm_test_damage_iter_damage_one_outside [22:56:29] [PASSED] drm_test_damage_iter_damage_src_moved [22:56:29] [PASSED] drm_test_damage_iter_damage_not_visible [22:56:29] ================ [PASSED] drm_damage_helper ================ [22:56:29] ============== drm_dp_mst_helper (3 subtests) ============== [22:56:29] ============== drm_test_dp_mst_calc_pbn_mode ============== [22:56:29] [PASSED] Clock 154000 BPP 30 DSC disabled [22:56:29] [PASSED] Clock 234000 BPP 30 DSC disabled [22:56:29] [PASSED] Clock 297000 BPP 24 DSC disabled [22:56:29] [PASSED] Clock 332880 BPP 24 DSC enabled [22:56:29] [PASSED] Clock 324540 BPP 24 DSC enabled [22:56:29] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [22:56:29] ============== drm_test_dp_mst_calc_pbn_div =============== [22:56:29] [PASSED] Link rate 2000000 lane count 4 [22:56:29] [PASSED] Link rate 2000000 lane count 2 [22:56:29] [PASSED] Link rate 2000000 lane count 1 [22:56:29] [PASSED] Link rate 1350000 lane count 4 [22:56:29] [PASSED] Link rate 1350000 lane count 2 [22:56:29] [PASSED] Link rate 1350000 lane count 1 [22:56:29] [PASSED] Link rate 1000000 lane count 4 [22:56:29] [PASSED] Link rate 1000000 lane count 2 [22:56:29] [PASSED] Link rate 1000000 lane count 1 [22:56:29] [PASSED] Link rate 810000 lane count 4 [22:56:29] [PASSED] Link rate 810000 lane count 2 [22:56:29] [PASSED] Link rate 810000 lane count 1 [22:56:29] [PASSED] Link rate 540000 lane count 4 [22:56:29] [PASSED] Link rate 540000 lane count 2 [22:56:29] [PASSED] Link rate 540000 lane count 1 [22:56:29] [PASSED] Link rate 270000 lane count 4 [22:56:29] [PASSED] Link rate 270000 lane count 2 [22:56:29] [PASSED] Link rate 270000 lane count 1 [22:56:29] [PASSED] Link rate 162000 lane count 4 [22:56:29] [PASSED] Link rate 162000 lane count 2 [22:56:29] [PASSED] Link rate 162000 lane count 1 [22:56:29] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [22:56:29] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [22:56:29] [PASSED] DP_ENUM_PATH_RESOURCES with port number [22:56:29] [PASSED] DP_POWER_UP_PHY with port number [22:56:29] [PASSED] DP_POWER_DOWN_PHY with port number [22:56:29] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [22:56:29] [PASSED] DP_ALLOCATE_PAYLOAD with port number [22:56:29] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [22:56:29] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [22:56:29] [PASSED] DP_QUERY_PAYLOAD with port number [22:56:29] [PASSED] DP_QUERY_PAYLOAD with VCPI [22:56:29] [PASSED] DP_REMOTE_DPCD_READ with port number [22:56:29] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [22:56:29] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [22:56:29] [PASSED] DP_REMOTE_DPCD_WRITE with port number [22:56:29] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [22:56:29] [PASSED] DP_REMOTE_DPCD_WRITE with data array [22:56:29] [PASSED] DP_REMOTE_I2C_READ with port number [22:56:29] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [22:56:29] [PASSED] DP_REMOTE_I2C_READ with transactions array [22:56:29] [PASSED] DP_REMOTE_I2C_WRITE with port number [22:56:29] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [22:56:29] [PASSED] DP_REMOTE_I2C_WRITE with data array [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [22:56:29] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [22:56:29] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [22:56:29] ================ [PASSED] drm_dp_mst_helper ================ [22:56:29] ================== drm_exec (7 subtests) =================== [22:56:29] [PASSED] sanitycheck [22:56:29] [PASSED] test_lock [22:56:29] [PASSED] test_lock_unlock [22:56:29] [PASSED] test_duplicates [22:56:29] [PASSED] test_prepare [22:56:29] [PASSED] test_prepare_array [22:56:29] [PASSED] test_multiple_loops [22:56:29] ==================== [PASSED] drm_exec ===================== [22:56:29] =========== drm_format_helper_test (17 subtests) =========== [22:56:29] ============== drm_test_fb_xrgb8888_to_gray8 ============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [22:56:29] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [22:56:29] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [22:56:29] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [22:56:29] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [22:56:29] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [22:56:29] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [22:56:29] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [22:56:29] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [22:56:29] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [22:56:29] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [22:56:29] ============== drm_test_fb_xrgb8888_to_mono =============== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [22:56:29] ==================== drm_test_fb_swab ===================== [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ================ [PASSED] drm_test_fb_swab ================= [22:56:29] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [22:56:29] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [22:56:29] [PASSED] single_pixel_source_buffer [22:56:29] [PASSED] single_pixel_clip_rectangle [22:56:29] [PASSED] well_known_colors [22:56:29] [PASSED] destination_pitch [22:56:29] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [22:56:29] ================= drm_test_fb_clip_offset ================= [22:56:29] [PASSED] pass through [22:56:29] [PASSED] horizontal offset [22:56:29] [PASSED] vertical offset [22:56:29] [PASSED] horizontal and vertical offset [22:56:29] [PASSED] horizontal offset (custom pitch) [22:56:29] [PASSED] vertical offset (custom pitch) [22:56:29] [PASSED] horizontal and vertical offset (custom pitch) [22:56:29] ============= [PASSED] drm_test_fb_clip_offset ============= [22:56:29] =================== drm_test_fb_memcpy ==================== [22:56:29] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [22:56:29] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [22:56:29] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [22:56:29] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [22:56:29] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [22:56:29] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [22:56:29] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [22:56:29] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [22:56:29] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [22:56:29] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [22:56:29] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [22:56:29] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [22:56:29] =============== [PASSED] drm_test_fb_memcpy ================ [22:56:29] ============= [PASSED] drm_format_helper_test ============== [22:56:29] ================= drm_format (18 subtests) ================= [22:56:29] [PASSED] drm_test_format_block_width_invalid [22:56:29] [PASSED] drm_test_format_block_width_one_plane [22:56:29] [PASSED] drm_test_format_block_width_two_plane [22:56:29] [PASSED] drm_test_format_block_width_three_plane [22:56:29] [PASSED] drm_test_format_block_width_tiled [22:56:29] [PASSED] drm_test_format_block_height_invalid [22:56:29] [PASSED] drm_test_format_block_height_one_plane [22:56:29] [PASSED] drm_test_format_block_height_two_plane [22:56:29] [PASSED] drm_test_format_block_height_three_plane [22:56:29] [PASSED] drm_test_format_block_height_tiled [22:56:29] [PASSED] drm_test_format_min_pitch_invalid [22:56:29] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [22:56:29] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [22:56:29] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [22:56:29] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [22:56:29] [PASSED] drm_test_format_min_pitch_two_plane [22:56:29] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [22:56:29] [PASSED] drm_test_format_min_pitch_tiled [22:56:29] =================== [PASSED] drm_format ==================== [22:56:29] ============== drm_framebuffer (10 subtests) =============== [22:56:29] ========== drm_test_framebuffer_check_src_coords ========== [22:56:29] [PASSED] Success: source fits into fb [22:56:29] [PASSED] Fail: overflowing fb with x-axis coordinate [22:56:29] [PASSED] Fail: overflowing fb with y-axis coordinate [22:56:29] [PASSED] Fail: overflowing fb with source width [22:56:29] [PASSED] Fail: overflowing fb with source height [22:56:29] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [22:56:29] [PASSED] drm_test_framebuffer_cleanup [22:56:29] =============== drm_test_framebuffer_create =============== [22:56:29] [PASSED] ABGR8888 normal sizes [22:56:29] [PASSED] ABGR8888 max sizes [22:56:29] [PASSED] ABGR8888 pitch greater than min required [22:56:29] [PASSED] ABGR8888 pitch less than min required [22:56:29] [PASSED] ABGR8888 Invalid width [22:56:29] [PASSED] ABGR8888 Invalid buffer handle [22:56:29] [PASSED] No pixel format [22:56:29] [PASSED] ABGR8888 Width 0 [22:56:29] [PASSED] ABGR8888 Height 0 [22:56:29] [PASSED] ABGR8888 Out of bound height * pitch combination [22:56:29] [PASSED] ABGR8888 Large buffer offset [22:56:29] [PASSED] ABGR8888 Buffer offset for inexistent plane [22:56:29] [PASSED] ABGR8888 Invalid flag [22:56:29] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [22:56:29] [PASSED] ABGR8888 Valid buffer modifier [22:56:29] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [22:56:29] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] NV12 Normal sizes [22:56:29] [PASSED] NV12 Max sizes [22:56:29] [PASSED] NV12 Invalid pitch [22:56:29] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [22:56:29] [PASSED] NV12 different modifier per-plane [22:56:29] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [22:56:29] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] NV12 Modifier for inexistent plane [22:56:29] [PASSED] NV12 Handle for inexistent plane [22:56:29] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [22:56:29] [PASSED] YVU420 Normal sizes [22:56:29] [PASSED] YVU420 Max sizes [22:56:29] [PASSED] YVU420 Invalid pitch [22:56:29] [PASSED] YVU420 Different pitches [22:56:29] [PASSED] YVU420 Different buffer offsets/pitches [22:56:29] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [22:56:29] [PASSED] YVU420 Valid modifier [22:56:29] [PASSED] YVU420 Different modifiers per plane [22:56:29] [PASSED] YVU420 Modifier for inexistent plane [22:56:29] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [22:56:29] [PASSED] X0L2 Normal sizes [22:56:29] [PASSED] X0L2 Max sizes [22:56:29] [PASSED] X0L2 Invalid pitch [22:56:29] [PASSED] X0L2 Pitch greater than minimum required [22:56:29] [PASSED] X0L2 Handle for inexistent plane [22:56:29] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [22:56:29] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [22:56:29] [PASSED] X0L2 Valid modifier [22:56:29] [PASSED] X0L2 Modifier for inexistent plane [22:56:29] =========== [PASSED] drm_test_framebuffer_create =========== [22:56:29] [PASSED] drm_test_framebuffer_free [22:56:29] [PASSED] drm_test_framebuffer_init [22:56:29] [PASSED] drm_test_framebuffer_init_bad_format [22:56:29] [PASSED] drm_test_framebuffer_init_dev_mismatch [22:56:29] [PASSED] drm_test_framebuffer_lookup [22:56:29] [PASSED] drm_test_framebuffer_lookup_inexistent [22:56:29] [PASSED] drm_test_framebuffer_modifiers_not_supported [22:56:29] ================= [PASSED] drm_framebuffer ================= [22:56:29] ================ drm_gem_shmem (8 subtests) ================ [22:56:29] [PASSED] drm_gem_shmem_test_obj_create [22:56:29] [PASSED] drm_gem_shmem_test_obj_create_private [22:56:29] [PASSED] drm_gem_shmem_test_pin_pages [22:56:29] [PASSED] drm_gem_shmem_test_vmap [22:56:29] [PASSED] drm_gem_shmem_test_get_sg_table [22:56:29] [PASSED] drm_gem_shmem_test_get_pages_sgt [22:56:29] [PASSED] drm_gem_shmem_test_madvise [22:56:29] [PASSED] drm_gem_shmem_test_purge [22:56:29] ================== [PASSED] drm_gem_shmem ================== [22:56:29] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [22:56:29] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [22:56:29] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [22:56:29] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [22:56:29] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [22:56:29] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [22:56:29] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [22:56:29] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [22:56:29] [PASSED] Automatic [22:56:29] [PASSED] Full [22:56:29] [PASSED] Limited 16:235 [22:56:29] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [22:56:29] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [22:56:29] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [22:56:29] [PASSED] drm_test_check_disable_connector [22:56:29] [PASSED] drm_test_check_hdmi_funcs_reject_rate [22:56:29] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [22:56:29] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [22:56:29] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [22:56:29] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [22:56:29] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [22:56:29] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [22:56:29] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [22:56:29] [PASSED] drm_test_check_output_bpc_dvi [22:56:29] [PASSED] drm_test_check_output_bpc_format_vic_1 [22:56:29] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [22:56:29] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [22:56:29] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [22:56:29] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [22:56:29] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [22:56:29] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [22:56:29] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [22:56:29] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [22:56:29] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [22:56:29] [PASSED] drm_test_check_broadcast_rgb_value [22:56:29] [PASSED] drm_test_check_bpc_8_value [22:56:29] [PASSED] drm_test_check_bpc_10_value [22:56:29] [PASSED] drm_test_check_bpc_12_value [22:56:29] [PASSED] drm_test_check_format_value [22:56:29] [PASSED] drm_test_check_tmds_char_value [22:56:29] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [22:56:29] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [22:56:29] [PASSED] drm_test_check_mode_valid [22:56:29] [PASSED] drm_test_check_mode_valid_reject [22:56:29] [PASSED] drm_test_check_mode_valid_reject_rate [22:56:29] [PASSED] drm_test_check_mode_valid_reject_max_clock [22:56:29] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [22:56:29] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) = [22:56:29] [PASSED] drm_test_check_infoframes [22:56:29] [PASSED] drm_test_check_reject_avi_infoframe [22:56:29] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8 [22:56:29] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10 [22:56:29] [PASSED] drm_test_check_reject_audio_infoframe [22:56:29] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes === [22:56:29] ================= drm_managed (2 subtests) ================= [22:56:29] [PASSED] drm_test_managed_release_action [22:56:29] [PASSED] drm_test_managed_run_action [22:56:29] =================== [PASSED] drm_managed =================== [22:56:29] =================== drm_mm (6 subtests) ==================== [22:56:29] [PASSED] drm_test_mm_init [22:56:29] [PASSED] drm_test_mm_debug [22:56:29] [PASSED] drm_test_mm_align32 [22:56:29] [PASSED] drm_test_mm_align64 [22:56:29] [PASSED] drm_test_mm_lowest [22:56:29] [PASSED] drm_test_mm_highest [22:56:29] ===================== [PASSED] drm_mm ====================== [22:56:29] ============= drm_modes_analog_tv (5 subtests) ============= [22:56:29] [PASSED] drm_test_modes_analog_tv_mono_576i [22:56:29] [PASSED] drm_test_modes_analog_tv_ntsc_480i [22:56:29] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [22:56:29] [PASSED] drm_test_modes_analog_tv_pal_576i [22:56:29] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [22:56:29] =============== [PASSED] drm_modes_analog_tv =============== [22:56:29] ============== drm_plane_helper (2 subtests) =============== [22:56:29] =============== drm_test_check_plane_state ================ [22:56:29] [PASSED] clipping_simple [22:56:29] [PASSED] clipping_rotate_reflect [22:56:29] [PASSED] positioning_simple [22:56:29] [PASSED] upscaling [22:56:29] [PASSED] downscaling [22:56:29] [PASSED] rounding1 [22:56:29] [PASSED] rounding2 [22:56:29] [PASSED] rounding3 [22:56:29] [PASSED] rounding4 [22:56:29] =========== [PASSED] drm_test_check_plane_state ============ [22:56:29] =========== drm_test_check_invalid_plane_state ============ [22:56:29] [PASSED] positioning_invalid [22:56:29] [PASSED] upscaling_invalid [22:56:29] [PASSED] downscaling_invalid [22:56:29] ======= [PASSED] drm_test_check_invalid_plane_state ======== [22:56:29] ================ [PASSED] drm_plane_helper ================= [22:56:29] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [22:56:29] ====== drm_test_connector_helper_tv_get_modes_check ======= [22:56:29] [PASSED] None [22:56:29] [PASSED] PAL [22:56:29] [PASSED] NTSC [22:56:29] [PASSED] Both, NTSC Default [22:56:29] [PASSED] Both, PAL Default [22:56:29] [PASSED] Both, NTSC Default, with PAL on command-line [22:56:29] [PASSED] Both, PAL Default, with NTSC on command-line [22:56:29] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [22:56:29] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [22:56:29] ================== drm_rect (9 subtests) =================== [22:56:29] [PASSED] drm_test_rect_clip_scaled_div_by_zero [22:56:29] [PASSED] drm_test_rect_clip_scaled_not_clipped [22:56:29] [PASSED] drm_test_rect_clip_scaled_clipped [22:56:29] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [22:56:29] ================= drm_test_rect_intersect ================= [22:56:29] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [22:56:29] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [22:56:29] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [22:56:29] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [22:56:29] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [22:56:29] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [22:56:29] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [22:56:29] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [22:56:29] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [22:56:29] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [22:56:29] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [22:56:29] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [22:56:29] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [22:56:29] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [22:56:29] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [22:56:29] ============= [PASSED] drm_test_rect_intersect ============= [22:56:29] ================ drm_test_rect_calc_hscale ================ [22:56:29] [PASSED] normal use [22:56:29] [PASSED] out of max range [22:56:29] [PASSED] out of min range [22:56:29] [PASSED] zero dst [22:56:29] [PASSED] negative src [22:56:29] [PASSED] negative dst [22:56:29] ============ [PASSED] drm_test_rect_calc_hscale ============ [22:56:29] ================ drm_test_rect_calc_vscale ================ [22:56:29] [PASSED] normal use [22:56:29] [PASSED] out of max range [22:56:29] [PASSED] out of min range [22:56:29] [PASSED] zero dst [22:56:29] [PASSED] negative src [22:56:29] [PASSED] negative dst stty: 'standard input': Inappropriate ioctl for device [22:56:29] ============ [PASSED] drm_test_rect_calc_vscale ============ [22:56:29] ================== drm_test_rect_rotate =================== [22:56:29] [PASSED] reflect-x [22:56:29] [PASSED] reflect-y [22:56:29] [PASSED] rotate-0 [22:56:29] [PASSED] rotate-90 [22:56:29] [PASSED] rotate-180 [22:56:29] [PASSED] rotate-270 [22:56:29] ============== [PASSED] drm_test_rect_rotate =============== [22:56:29] ================ drm_test_rect_rotate_inv ================= [22:56:29] [PASSED] reflect-x [22:56:29] [PASSED] reflect-y [22:56:29] [PASSED] rotate-0 [22:56:29] [PASSED] rotate-90 [22:56:29] [PASSED] rotate-180 [22:56:29] [PASSED] rotate-270 [22:56:29] ============ [PASSED] drm_test_rect_rotate_inv ============= [22:56:29] ==================== [PASSED] drm_rect ===================== [22:56:29] ============ drm_sysfb_modeset_test (1 subtest) ============ [22:56:29] ============ drm_test_sysfb_build_fourcc_list ============= [22:56:29] [PASSED] no native formats [22:56:29] [PASSED] XRGB8888 as native format [22:56:29] [PASSED] remove duplicates [22:56:29] [PASSED] convert alpha formats [22:56:29] [PASSED] random formats [22:56:29] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [22:56:29] ============= [PASSED] drm_sysfb_modeset_test ============== [22:56:29] ================== drm_fixp (2 subtests) =================== [22:56:29] [PASSED] drm_test_int2fixp [22:56:29] [PASSED] drm_test_sm2fixp [22:56:29] ==================== [PASSED] drm_fixp ===================== [22:56:29] ============================================================ [22:56:29] Testing complete. Ran 621 tests: passed: 621 [22:56:30] Elapsed time: 25.886s total, 1.703s configuring, 24.012s building, 0.135s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [22:56:30] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [22:56:31] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [22:56:41] Starting KUnit Kernel (1/1)... [22:56:41] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [22:56:41] ================= ttm_device (5 subtests) ================== [22:56:41] [PASSED] ttm_device_init_basic [22:56:41] [PASSED] ttm_device_init_multiple [22:56:41] [PASSED] ttm_device_fini_basic [22:56:41] [PASSED] ttm_device_init_no_vma_man [22:56:41] ================== ttm_device_init_pools ================== [22:56:41] [PASSED] No DMA allocations, no DMA32 required [22:56:41] [PASSED] DMA allocations, DMA32 required [22:56:41] [PASSED] No DMA allocations, DMA32 required [22:56:41] [PASSED] DMA allocations, no DMA32 required [22:56:41] ============== [PASSED] ttm_device_init_pools ============== [22:56:41] =================== [PASSED] ttm_device ==================== [22:56:41] ================== ttm_pool (8 subtests) =================== [22:56:41] ================== ttm_pool_alloc_basic =================== [22:56:41] [PASSED] One page [22:56:41] [PASSED] More than one page [22:56:41] [PASSED] Above the allocation limit [22:56:41] [PASSED] One page, with coherent DMA mappings enabled [22:56:41] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [22:56:41] ============== [PASSED] ttm_pool_alloc_basic =============== [22:56:41] ============== ttm_pool_alloc_basic_dma_addr ============== [22:56:41] [PASSED] One page [22:56:41] [PASSED] More than one page [22:56:41] [PASSED] Above the allocation limit [22:56:41] [PASSED] One page, with coherent DMA mappings enabled [22:56:41] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [22:56:41] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [22:56:41] [PASSED] ttm_pool_alloc_order_caching_match [22:56:41] [PASSED] ttm_pool_alloc_caching_mismatch [22:56:41] [PASSED] ttm_pool_alloc_order_mismatch [22:56:41] [PASSED] ttm_pool_free_dma_alloc [22:56:41] [PASSED] ttm_pool_free_no_dma_alloc [22:56:41] [PASSED] ttm_pool_fini_basic [22:56:41] ==================== [PASSED] ttm_pool ===================== [22:56:41] ================ ttm_resource (8 subtests) ================= [22:56:41] ================= ttm_resource_init_basic ================= [22:56:41] [PASSED] Init resource in TTM_PL_SYSTEM [22:56:41] [PASSED] Init resource in TTM_PL_VRAM [22:56:41] [PASSED] Init resource in a private placement [22:56:41] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [22:56:41] ============= [PASSED] ttm_resource_init_basic ============= [22:56:41] [PASSED] ttm_resource_init_pinned [22:56:41] [PASSED] ttm_resource_fini_basic [22:56:41] [PASSED] ttm_resource_manager_init_basic [22:56:41] [PASSED] ttm_resource_manager_usage_basic [22:56:41] [PASSED] ttm_resource_manager_set_used_basic [22:56:41] [PASSED] ttm_sys_man_alloc_basic [22:56:41] [PASSED] ttm_sys_man_free_basic [22:56:41] ================== [PASSED] ttm_resource =================== [22:56:41] =================== ttm_tt (15 subtests) =================== [22:56:41] ==================== ttm_tt_init_basic ==================== [22:56:41] [PASSED] Page-aligned size [22:56:41] [PASSED] Extra pages requested [22:56:41] ================ [PASSED] ttm_tt_init_basic ================ [22:56:41] [PASSED] ttm_tt_init_misaligned [22:56:41] [PASSED] ttm_tt_fini_basic [22:56:41] [PASSED] ttm_tt_fini_sg [22:56:41] [PASSED] ttm_tt_fini_shmem [22:56:41] [PASSED] ttm_tt_create_basic [22:56:41] [PASSED] ttm_tt_create_invalid_bo_type [22:56:41] [PASSED] ttm_tt_create_ttm_exists [22:56:41] [PASSED] ttm_tt_create_failed [22:56:41] [PASSED] ttm_tt_destroy_basic [22:56:41] [PASSED] ttm_tt_populate_null_ttm [22:56:41] [PASSED] ttm_tt_populate_populated_ttm [22:56:41] [PASSED] ttm_tt_unpopulate_basic [22:56:41] [PASSED] ttm_tt_unpopulate_empty_ttm [22:56:41] [PASSED] ttm_tt_swapin_basic [22:56:41] ===================== [PASSED] ttm_tt ====================== [22:56:41] =================== ttm_bo (14 subtests) =================== [22:56:41] =========== ttm_bo_reserve_optimistic_no_ticket =========== [22:56:41] [PASSED] Cannot be interrupted and sleeps [22:56:41] [PASSED] Cannot be interrupted, locks straight away [22:56:41] [PASSED] Can be interrupted, sleeps [22:56:41] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [22:56:41] [PASSED] ttm_bo_reserve_locked_no_sleep [22:56:41] [PASSED] ttm_bo_reserve_no_wait_ticket [22:56:41] [PASSED] ttm_bo_reserve_double_resv [22:56:41] [PASSED] ttm_bo_reserve_interrupted [22:56:41] [PASSED] ttm_bo_reserve_deadlock [22:56:41] [PASSED] ttm_bo_unreserve_basic [22:56:41] [PASSED] ttm_bo_unreserve_pinned [22:56:41] [PASSED] ttm_bo_unreserve_bulk [22:56:41] [PASSED] ttm_bo_fini_basic [22:56:41] [PASSED] ttm_bo_fini_shared_resv [22:56:41] [PASSED] ttm_bo_pin_basic [22:56:41] [PASSED] ttm_bo_pin_unpin_resource [22:56:41] [PASSED] ttm_bo_multiple_pin_one_unpin [22:56:41] ===================== [PASSED] ttm_bo ====================== [22:56:41] ============== ttm_bo_validate (22 subtests) =============== [22:56:41] ============== ttm_bo_init_reserved_sys_man =============== [22:56:41] [PASSED] Buffer object for userspace [22:56:41] [PASSED] Kernel buffer object [22:56:41] [PASSED] Shared buffer object [22:56:41] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [22:56:41] ============== ttm_bo_init_reserved_mock_man ============== [22:56:41] [PASSED] Buffer object for userspace [22:56:41] [PASSED] Kernel buffer object [22:56:41] [PASSED] Shared buffer object [22:56:41] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [22:56:41] [PASSED] ttm_bo_init_reserved_resv [22:56:41] ================== ttm_bo_validate_basic ================== [22:56:41] [PASSED] Buffer object for userspace [22:56:41] [PASSED] Kernel buffer object [22:56:41] [PASSED] Shared buffer object [22:56:41] ============== [PASSED] ttm_bo_validate_basic ============== [22:56:41] [PASSED] ttm_bo_validate_invalid_placement [22:56:41] ============= ttm_bo_validate_same_placement ============== [22:56:41] [PASSED] System manager [22:56:41] [PASSED] VRAM manager [22:56:41] ========= [PASSED] ttm_bo_validate_same_placement ========== [22:56:41] [PASSED] ttm_bo_validate_failed_alloc [22:56:41] [PASSED] ttm_bo_validate_pinned [22:56:41] [PASSED] ttm_bo_validate_busy_placement [22:56:41] ================ ttm_bo_validate_multihop ================= [22:56:41] [PASSED] Buffer object for userspace [22:56:41] [PASSED] Kernel buffer object [22:56:41] [PASSED] Shared buffer object [22:56:41] ============ [PASSED] ttm_bo_validate_multihop ============= [22:56:41] ========== ttm_bo_validate_no_placement_signaled ========== [22:56:41] [PASSED] Buffer object in system domain, no page vector [22:56:41] [PASSED] Buffer object in system domain with an existing page vector [22:56:41] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [22:56:41] ======== ttm_bo_validate_no_placement_not_signaled ======== [22:56:41] [PASSED] Buffer object for userspace [22:56:41] [PASSED] Kernel buffer object [22:56:41] [PASSED] Shared buffer object [22:56:41] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [22:56:41] [PASSED] ttm_bo_validate_move_fence_signaled [22:56:41] ========= ttm_bo_validate_move_fence_not_signaled ========= [22:56:41] [PASSED] Waits for GPU [22:56:41] [PASSED] Tries to lock straight away [22:56:41] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [22:56:41] [PASSED] ttm_bo_validate_swapout [22:56:41] [PASSED] ttm_bo_validate_happy_evict [22:56:41] [PASSED] ttm_bo_validate_all_pinned_evict [22:56:41] [PASSED] ttm_bo_validate_allowed_only_evict [22:56:41] [PASSED] ttm_bo_validate_deleted_evict [22:56:41] [PASSED] ttm_bo_validate_busy_domain_evict [22:56:41] [PASSED] ttm_bo_validate_evict_gutting [22:56:41] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [22:56:41] ================= [PASSED] ttm_bo_validate ================= [22:56:41] ============================================================ [22:56:41] Testing complete. Ran 102 tests: passed: 102 [22:56:41] Elapsed time: 11.429s total, 1.648s configuring, 9.564s building, 0.178s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ Xe.CI.BAT: failure for Engine initialization cleanup
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Engine initialization cleanup
URL : https://patchwork.freedesktop.org/series/165392/
State : failure
== Summary ==
CI Bug Log - changes from xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4_BAT -> xe-pw-165392v1_BAT
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-165392v1_BAT absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-165392v1_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-165392v1_BAT:
### IGT changes ###
#### Possible regressions ####
* igt@xe_intel_bb@render@render-linear-256:
- bat-adlp-vm: [PASS][1] -> [FAIL][2] +6 other tests fail
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-adlp-vm/igt@xe_intel_bb@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-adlp-vm/igt@xe_intel_bb@[email protected]
* igt@xe_pat@pat-index-xelp:
- bat-adlp-7: [PASS][3] -> [FAIL][4] +11 other tests fail
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-adlp-7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-adlp-7/igt@[email protected]
#### Warnings ####
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-7: [DMESG-WARN][5] ([Intel XE#7483]) -> [FAIL][6] +6 other tests fail
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-adlp-7/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-adlp-7/igt@kms_flip@[email protected]
Known issues
------------
Here are the changes found in xe-pw-165392v1_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
- bat-adlp-7: [PASS][7] -> [FAIL][8] ([Intel XE#3149]) +2 other tests fail
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-adlp-7/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-adlp-7/igt@kms_flip@[email protected]
* igt@xe_waitfence@reltime:
- bat-ptl-1: [PASS][9] -> [FAIL][10] ([Intel XE#6520])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-ptl-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-ptl-1/igt@[email protected]
#### Warnings ####
* igt@kms_flip@basic-flip-vs-dpms:
- bat-adlp-7: [DMESG-WARN][11] ([Intel XE#7483]) -> [FAIL][12] ([Intel XE#3149]) +4 other tests fail
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/bat-adlp-7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/bat-adlp-7/igt@[email protected]
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#6520]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6520
[Intel XE#7483]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7483
Build changes
-------------
* Linux: xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4 -> xe-pw-165392v1
IGT_8872: e70db143b7bafe09bdea4d33188cb10d2070d0e5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4: 021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4
xe-pw-165392v1: 165392v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/index.html
Patchwork
CI✓ Xe.CI.FULL: success for Engine initialization cleanup
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Engine initialization cleanup
URL : https://patchwork.freedesktop.org/series/165392/
State : success
== Summary ==
CI Bug Log - changes from xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4_FULL -> xe-pw-165392v1_FULL
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-165392v1_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_flip@2x-flip-vs-dpms-on-nop-interruptible:
- shard-bmg: [PASS][1] -> [SKIP][2] ([Intel XE#2316])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-3/igt@[email protected]
* igt@kms_hdr@invalid-hdr:
- shard-bmg: [PASS][3] -> [SKIP][4] ([Intel XE#1503])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-9/igt@[email protected]
#### Possible fixes ####
* igt@kms_flip@blocking-wf_vblank@b-dp2:
- shard-bmg: [FAIL][5] ([Intel XE#7705]) -> [PASS][6] +1 other test pass
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-3/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-5/igt@kms_flip@[email protected]
* igt@kms_setmode@basic@pipe-b-edp-1:
- shard-lnl: [FAIL][7] ([Intel XE#6361]) -> [PASS][8] +2 other tests pass
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-lnl-7/igt@kms_setmode@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-lnl-2/igt@kms_setmode@[email protected]
* igt@xe_survivability@runtime-survivability:
- shard-bmg: [DMESG-WARN][9] ([Intel XE#6627] / [Intel XE#7419]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-10/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
#### Warnings ####
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: [SKIP][11] ([Intel XE#2509] / [Intel XE#7437]) -> [SKIP][12] ([Intel XE#2426] / [Intel XE#5848])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-1/igt@[email protected]
* igt@xe_module_load@load:
- shard-bmg: ([PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [SKIP][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38]) ([Intel XE#2457] / [Intel XE#7405]) -> ([PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [DMESG-WARN][46], [PASS][47], [PASS][48], [DMESG-WARN][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [DMESG-WARN][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [SKIP][64]) ([Intel XE#2457] / [Intel XE#7405] / [Intel XE#7725])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-8/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-10/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-10/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-10/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-5/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-9/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-6/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-5/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-2/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-2/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-7/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-3/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-9/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4/shard-bmg-8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-10/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-9/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-8/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-5/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-7/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-9/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-3/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-10/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-1/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-1/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-5/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/shard-bmg-7/igt@[email protected]
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2457]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2457
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#6361]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6361
[Intel XE#6627]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6627
[Intel XE#7405]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7405
[Intel XE#7419]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7419
[Intel XE#7437]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7437
[Intel XE#7705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7705
[Intel XE#7725]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7725
Build changes
-------------
* Linux: xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4 -> xe-pw-165392v1
IGT_8872: e70db143b7bafe09bdea4d33188cb10d2070d0e5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4930-021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4: 021ccd6f29b34f09e4b3aac0d6d52b8adaa1c4b4
xe-pw-165392v1: 165392v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-165392v1/index.html
Re: [PATCH 06/10] drm/xe: Const-ify parameters to xe_device_has_* functions
In reply to Matt RoperQuoted 5 lines · Matt Roper
None of these functions modify the Xe device parameter, and marking it as const will avoid warnings when the callsite wants to pass a const pointer.
Signed-off-by Matt Roper <[email protected]>
RE: [PATCH 10/10] drm/xe: Mark BCS engines as belonging to the GT forcewake domain
In reply to Matt RoperQuoted 8 lines · Matt Roper
On all platforms supported by the Xe driver, BCS engines are part of the GT forcewake domain, not the RENDER domain. Fix the engine list definition to match the spec. This mistake didn't really cause any real problems because the forcewake domain here was only used in a couple assertions that aren't really necessary and included in the information dumped during error capture.
Bspec: 66696, 66534, 67609, 71185, 74417, 75242, 78286
Signed-off-by Matt Roper <[email protected]>
LGTM.
RE: [PATCH 09/10] drm/xe: Drop xe_hw_engine_mmio_write32()
In reply to Matt RoperQuoted 5 lines · Matt Roper
xe_hw_engine_mmio_write32()is only used in a single place and is easily replaced by a regularxe_mmio_write32()call. Register read/write interfaces are already complicated enough with MCR vs non-MCR handling, so we should avoid adding extra wrappers that just make it more confusing what to use.
The code itself LGTM.
BTW, the function declaration in header file could be removed also.
From git history, it is added for eudebug code. Add original author to confirm whether it is still needed or not.
Shuicheng
Quoted 60 lines
xe_hw_engine_mmio_write32()did have a forcewake assertion that we're dropping here, but that assertion wasn't entirely correct anyway. It was checkinghwe->domainwhich is currently set toXE_FW_RENDERfor the BCS engine, even though BCS engines reside in the GT domain.Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/xe/xe_hw_engine.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-)drivers/gpu/drm/xe/xe_hw_engine.c +2
-23@@ -282,27 +282,6 @@ static void hw_engine_fini(void *arg) hwe->gt =NULL ; } -/** -* xe_hw_engine_mmio_write32() - Write engine register -* @hwe: engine -* @reg: register to write into -* @val: desired 32-bit value to write -* -* This function will write val into an engine specific register. -* Forcewake must be held by the caller. -* -*/ -void xe_hw_engine_mmio_write32 (struct xe_hw_engine *hwe, -struct xe_reg reg,u32 val) -{ -xe_gt_assert (hwe->gt, !(reg.addr & hwe->mmio_base)); -xe_force_wake_assert_held (gt_to_fw (hwe->gt), hwe->domain); - - reg.addr += hwe->mmio_base; - -xe_mmio_write32 (&hwe->gt->mmio, reg, val); -} -/** * xe_hw_engine_mmio_read32() - Read engine register * @hwe: engine @@ -325,8 +304,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg) void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe) { - xe_hw_engine_mmio_write32(hwe, RING_HWS_PGA(0), - xe_bo_ggtt_addr(hwe->hwsp)); + xe_mmio_write32(&hwe->gt->mmio, RING_HWS_PGA(hwe- >mmio_base), + xe_bo_ggtt_addr(hwe->hwsp)); }static bool xe_hw_engine_match_fixed_cslice_mode(const struct
xe_device
*xe,--
2.53.0
RE: [PATCH 02/10] drm/xe/rtp: Add "always true" match function
In reply to Matt RoperQuoted 12 lines · Matt Roper
All RTP table entries are required to have at least one rule. In cases where an entry should apply unconditionally across all platforms we've been using a graphics version range of 12.00 - forever since this covers all platforms supported by the driver. However if the primary GT is disabled via configfs (not actually possible today, but probably possible in the future) or if we have a future platform that lacks a primary GT and only supports media/display, this rule would cause important programming to fail to apply on the media GT.
Add a simple match function that just always returns true unconditionally. This solves the worries above while also being more immediately human- readable.
Quoted 6 lines
Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/xe/xe_hw_engine.c | 2 +- drivers/gpu/drm/xe/xe_rtp.c | 7 +++++++ drivers/gpu/drm/xe/xe_rtp.h | 12 ++++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-)
LGTM.
RE: [PATCH 07/10] drm/xe: Move GFX_MODE programming to RTP
In reply to Matt RoperQuoted 103 lines · Matt Roper
The write
GFX_MODEto disable engine "legacy mode" and to enable MSI-X support was unnecessarily open-coded inxe_hw_engine_enable_ring(); it's preferable to do such programming in the engine_entries[] RTP table since gets reflected/verified in debugfs, and will also automatically ensure that the register is properly saved/restored around engine resets. This also helps consolidate common logic that was duplicated between the main driver initialization path and the dead-code execlist initialization path.This also allows us to drop
GFX_MODEfrom the list of extra registers to be added to the GuC ADS' save-restore list since all registers on the RTP table are added automatically.Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/xe/xe_execlist.c | 5 ----- drivers/gpu/drm/xe/xe_guc_ads.c | 1 - drivers/gpu/drm/xe/xe_hw_engine.c | 16 ++++++++++------ drivers/gpu/drm/xe/xe_rtp.c | 8 ++++++++ drivers/gpu/drm/xe/xe_rtp.h | 12 ++++++++++++ 5 files changed, 30 insertions(+), 12 deletions(-)drivers/gpu/drm/xe/xe_execlist.c +0
-1@@ -47,7 +47,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, structxe_lrc *lrc, struct xe_mmio *mmio = >->mmio;struct xe_device *xe =gt_to_xe (gt);u64 lrc_desc; -u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE );drivers/gpu/drm/xe/xe_execlist.c +0
-4lrc_desc =xe_lrc_descriptor (lrc);@@ -78,10 +77,6 @@ static void __start_lrc(struct xe_hw_engine *hwe,struct xe_lrc *lrc, xe_bo_ggtt_addr(hwe->hwsp));xe_mmio_read32 (mmio,RING_HWS_PGA (hwe->mmio_base)); -if (xe_device_has_msix (gt_to_xe (hwe->gt))) - ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_mmio_write32 (mmio,GFX_MODE (hwe->mmio_base), ring_mode); -xe_mmio_write32(mmio, RING_EXECLIST_SQ_CONTENTS_LO(hwe-
Quoted 1 line
mmio_base),drivers/gpu/drm/xe/xe_execlist.c +0
-0lower_32_bits(lrc_desc)); xe_mmio_write32(mmio, RING_EXECLIST_SQ_CONTENTS_HI(hwe-Quoted 1 line
mmio_base),(quoted diff) +0
-0
b/drivers/gpu/drm/xe/xe_guc_ads.cindexb403ee0b5e74..ce651da6f318100644drivers/gpu/drm/xe/xe_guc_ads.c +0
-1@@ -745,7 +745,6 @@ static unsigned int guc_mmio_regset_write(structxe_guc_ads *ads, struct xe_reg reg;bool skip; } *e, extra_regs[] = { - { .reg = GFX_MODE(hwe->mmio_base), }, { .reg = RING_HWS_PGA(hwe->mmio_base), },drivers/gpu/drm/xe/xe_guc_ads.c +0
-0{ .reg = RING_IMR(hwe->mmio_base), }, { .reg = CCS_MODE,drivers/gpu/drm/xe/xe_hw_engine.c +0
-6@@ -325,14 +325,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg) void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe) { - u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp)); - -if (xe_device_has_msix (gt_to_xe (hwe->gt))) - ring_mode |=REG_MASKED_FIELD_ENABLE (GFX_MSIX_INTERRUPT_ENABLE ); -xe_hw_engine_mmio_write32 (hwe,GFX_MODE (0 ), ring_mode); xe_hw_engine_mmio_write32(hwe, RING_MI_MODE(0),drivers/gpu/drm/xe/xe_hw_engine.c +4
-0REG_MASKED_FIELD_DISABLE(STOP_RING)); xe_hw_engine_mmio_read32(hwe, RING_MI_MODE(0)); @@ -441,6 +435,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)XE_RTP_ACTIONS (SET (RING_HWSTAM (0 ), ~0x0 ,XE_RTP_ACTION_FLAG (ENGINE_BASE ))) }, + { XE_RTP_NAME("Disable engine 'legacy' mode"), +XE_RTP_RULES (FUNC (xe_rtp_match_always)), + XE_RTP_ACTIONS(SET(GFX_MODE(0),
GFX_DISABLE_LEGACY_MODE,drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ XE_RTP_ACTION_FLAG(ENGINE_BASE))) + },/* * To allow the GSC engine to go idle on MTL we need to enable * idle messaging and set the hysteresis value (we use 0xA=5us
drivers/gpu/drm/xe/xe_hw_engine.c hw_engine_setup_default_state(struct · line 479
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0@@ -473,6 +472,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe) XE_RTP_ACTIONS(FIELD_SET(RCU_MODE, RCU_MODE_FIXED_SLICE_CCS_MODE, RCU_MODE_FIXED_SLICE_CCS_MODE)) }, + { XE_RTP_NAME("Enable MSI-X interrupt support"), + XE_RTP_RULES(FUNC(xe_rtp_match_always)),
The rule should be xe_rtp_match_has_msix?
Shuicheng
Quoted 54 lines
drivers/gpu/drm/xe/xe_hw_engine.c +1
-0+ XE_RTP_ACTIONS(SET(GFX_MODE(0),
GFX_MSIX_INTERRUPT_ENABLE,drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ XE_RTP_ACTION_FLAG(ENGINE_BASE))) + }, }; xe_rtp_process_to_sr(&ctx, engine_entries,
ARRAY_SIZE(engine_entries), diff --gita/drivers/gpu/drm/xe/xe_rtp.cb/drivers/gpu/drm/xe/xe_rtp.cindex728933a1c34f..1a4dcbbbc176100644drivers/gpu/drm/xe/xe_rtp.c +8
-0@@ -10,6 +10,7 @@#include <uapi/drm/xe_drm.h> #include "xe_configfs.h" +#include "xe_device.h" #include "xe_gt.h" #include "xe_gt_topology.h" #include "xe_reg_sr.h" @@ -404,3 +405,10 @@ bool xe_rtp_match_has_flat_ccs(const struct xe_device *xe, {return xe->info.has_flat_ccs; } + +bool xe_rtp_match_has_msix (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe) +{ +return xe_device_has_msix (xe); +}drivers/gpu/drm/xe/xe_rtp.h index renamed from drivers/gpu/drm/xe/xe_rtp.h +0
-0
d058a629cd3e..562082b18d7b100644drivers/gpu/drm/xe/xe_rtp.h +11
-1@@ -536,4 +536,16 @@ bool xe_rtp_match_has_flat_ccs(const structxe_device *xe, const struct xe_gt *gt, const struct xe_hw_engine *hwe); +/** +* xe_rtp_match_has_msix - Match when platform has MSI-X +* @xe: Device structure +* @gt: GT structure +* @hwe: Engine instance +* +* Returns: true if platform has MSI-X interrupt support */ bool +xe_rtp_match_has_msix (const struct xe_device *xe, +const struct xe_gt *gt, +const struct xe_hw_engine *hwe); +#endif --2.53.0
RE: [PATCH 04/10] drm/xe: Move HWSTAM programming to RTP
In reply to Matt RoperQuoted 12 lines · Matt Roper
The write to
RING_HWSTAMto disable hardware status page writes on interrupt was unnecessarily open-coded inxe_hw_engine_enable_ring(); it's preferable to do such programming in the engine_entries[] RTP table since gets reflected/verified in debugfs, and will also automatically ensure that the register is properly saved/restored around engine resets.In this case the HWSTAM register wasn't explicitly added to the GuC ADS' save-restore list, so there was the potential for the value to be lost on engine resets. This doesn't seem to have happened in practice, so likely the GuC firmware is automatically saving/restoring this register on our behalf, but we shouldn't rely on this implicit behavior going forward.
Quoted 7 lines
One other slight change with this patch is that HWSTAM will now be programmed on the vestigial execlist (non-GuC) initialization path. Since the register's default value is
0x0and the documentation indicates that it's only legal to leave a single bit unmasked at a time, this likely would have been an illegal situation if the execlist code were actually usable.Signed-off-by Matt Roper <[email protected]>
LGTM.
Quoted 36 lines
--- drivers/gpu/drm/xe/xe_hw_engine.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/xe/xe_hw_engine.c +5
-1@@ -327,7 +327,6 @@ void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe) {u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -xe_hw_engine_mmio_write32 (hwe,RING_HWSTAM (0 ), ~0x0 );xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp));@@ -437,6 +436,11 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe) ring_cmd_cctl_val, XE_RTP_ACTION_FLAG(ENGINE_BASE))) }, + { XE_RTP_NAME("Disable HW status page updates for interrupts"), +XE_RTP_RULES (FUNC (xe_rtp_match_always )), + XE_RTP_ACTIONS(SET(RING_HWSTAM(0), ~0x0, + XE_RTP_ACTION_FLAG(ENGINE_BASE))) + },drivers/gpu/drm/xe/xe_hw_engine.c +0
-1/* * To allow the GSC engine to go idle on MTL we need to enable * idle messaging and set the hysteresis value (we use 0xA=5us -- 2.53.0
Re: [PATCH 01/10] drm/xe: Move CCS enablement to engine setup RTP
In reply to Matt RoperQuoted 76 lines · Matt Roper
Most register programming for engine setup happens via RTP tables in
hw_engine_setup_default_state(). Move the programming of RCU_MODE[0] which enables the platform's CCS engine(s) there. This both makes the code more consistent (otherRCU_MODEregister programming is already happening in this RTP table) and improves debuggability (since RTP contents and checks of their correct programming are exposed via debugfs). It also helps consolidate the regular driver initialization paths with the vestigial and currently unused execlist (i.e., non-GuC) initialization.With the original programming, the
RCU_MODEregister (which is a single global register, not a per-engine register) was getting re-programmed with the same value during the initialization of each CCS engine. When moved to the RTP table, we use thexe_rtp_match_first_render_or_computematch function so that it will just be programmed once, while doing the initialization for the first RCS/CCS engine, which avoids the redundant and unnecessary repetition.We can also safely drop the explicit addition of
RCU_MODEfrom the GuC ADS save-restore list now since all registers programmed via RTP tables are automatically added to the GuC's list.Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/xe/xe_execlist.c | 4 ---- drivers/gpu/drm/xe/xe_guc_ads.c | 1 - drivers/gpu/drm/xe/xe_hw_engine.c | 10 ++++------ 3 files changed, 4 insertions(+), 11 deletions(-)drivers/gpu/drm/xe/xe_execlist.c +0
-4@@ -59,10 +59,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc, lrc_desc |=FIELD_PREP (SW_CTX_ID , ctx_id); } -if (hwe->class ==XE_ENGINE_CLASS_COMPUTE ) -xe_mmio_write32 (mmio,RCU_MODE , -REG_MASKED_FIELD_ENABLE (RCU_MODE_CCS_ENABLE )); -xe_lrc_write_ctx_reg (lrc,CTX_RING_TAIL , lrc->ring.tail); lrc->ring.old_tail = lrc->ring.tail;drivers/gpu/drm/xe/xe_guc_ads.c +0
-1@@ -748,7 +748,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads, { .reg = RING_MODE(hwe->mmio_base), }, { .reg = RING_HWS_PGA(hwe->mmio_base), }, { .reg = RING_IMR(hwe->mmio_base), }, - { .reg = RCU_MODE, .skip = hwe != hwe_rcs_reset_domain }, { .reg = CCS_MODE, .skip = hwe != hwe_rcs_reset_domain || !xe_gt_ccs_mode_enabled(hwe->gt) }, };drivers/gpu/drm/xe/xe_hw_engine.c +0
-6@@ -325,14 +325,8 @@ u32 xe_hw_engine_mmio_read32(struct xe_hw_engine *hwe, struct xe_reg reg)void xe_hw_engine_enable_ring (struct xe_hw_engine *hwe) { -u32 ccs_mask = -xe_hw_engine_mask_per_class (hwe->gt,XE_ENGINE_CLASS_COMPUTE );u32 ring_mode =REG_MASKED_FIELD_ENABLE (GFX_DISABLE_LEGACY_MODE ); -if (hwe->class ==XE_ENGINE_CLASS_COMPUTE && ccs_mask) -xe_mmio_write32 (&hwe->gt->mmio,RCU_MODE , -REG_MASKED_FIELD_ENABLE (RCU_MODE_CCS_ENABLE )); -xe_hw_engine_mmio_write32 (hwe,RING_HWSTAM (0 ), ~0x0 );xe_hw_engine_mmio_write32 (hwe,RING_HWS_PGA (0 ),xe_bo_ggtt_addr (hwe->hwsp));
drivers/gpu/drm/xe/xe_hw_engine.c hw_engine_setup_default_state(struct xe_hw_engine *hwe) · line 463
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0@@ -465,6 +459,10 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)XE_RTP_ACTIONS (SET (CSFE_CHICKEN1 (0 ),CS_PRIORITY_MEM_READ ,XE_RTP_ACTION_FLAG (ENGINE_BASE ))) }, + { XE_RTP_NAME("Enable CCS Engine(s)"), + XE_RTP_RULES(FUNC(xe_rtp_match_first_render_or_compute)),
This should also have a test for graphics version >= 12.55 since we don't support the CCS engine on Xe_LP platforms; we should only enable the CCS engine(s) on the platforms where they're actually exposed to userspace.
This was the source of the CI failures; I'll fix this when I send v2.
Matt
Quoted 9 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+XE_RTP_ACTIONS (SET (RCU_MODE ,RCU_MODE_CCS_ENABLE )) + },/* Use Fixed slice CCS mode */ { XE_RTP_NAME("RCU_MODE_FIXED_SLICE_CCS_MODE"), XE_RTP_RULES(FUNC(xe_hw_engine_match_fixed_cslice_mode)),Signature · 2 lines
-- 2.53.0
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation