Skip to contentSkip to conversation

WIP: ASoC: codecs: pcm512x: only print info once on no sclk

PATCH Superseded Christian Hewitt 1 participant 1 message Jun 25

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 WIP: ASoC: codecs: pcm512x: only print info once on no sclk

If sclk is not provided the driver falls back to using bclk and prints an info message in the system log. Under normal operations the message is repeated many times:

[   17.929576] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.949172] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.953029] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.965059] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.592980] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.866293] pcm512x 0-004c: No SCLK, using BCLK: -2

Switch from dev_info to dev_info_once to reduce log noise.

---
This was observed on an Odroid Hifi-Sheild2 board used with Kodi which appears to reset the audio connection frequently resulting in 100+ repeats of the message over time.

 sound/soc/codecs/pcm512x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/pcm512x.c +1 -1
index fdef98ce52f1..fe3b5011fa16 100644
@@ -633,7 +633,7 @@ static int pcm512x_dai_startup_slave(struct snd_pcm_substream *substream,
 	struct regmap *regmap = pcm512x->regmap;
 
 	if (IS_ERR(pcm512x->sclk)) {
-		dev_info(dev, "No SCLK, using BCLK: %ld\n",
+		dev_info_once(dev, "No SCLK, using BCLK: %ld\n",
 			 PTR_ERR(pcm512x->sclk));
 
 		/* Disable reporting of missing SCLK as an error */
Signature · 1 line
2.43.0